| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:14e14d46-2795-e0b6-a265-9c2957f82cd9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E302:12A9AF:D03CA1:10C52D7:696B2B5F |
| html-safe-nonce | 19c7fc658ee758d1618f6361cf91e5fea8583d19810c2416a112541d996102cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzAyOjEyQTlBRjpEMDNDQTE6MTBDNTJENzo2OTZCMkI1RiIsInZpc2l0b3JfaWQiOiIyOTcwMTYwNTEzNTE4OTA3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1ddc9d2d850022aeaccc78d8c40c7e4ab99badae39454911ca086d0f890f9f16 |
| hovercard-subject-tag | pull_request:361770494 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31322/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/62c50927176c26d8842fa4d358f3c8ce3a4c847ce1844bdfc43dbc99225c68f0/nodejs/node/pull/31322 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/62c50927176c26d8842fa4d358f3c8ce3a4c847ce1844bdfc43dbc99225c68f0/nodejs/node/pull/31322 |
| og:image:alt | Remove unreachable code. As expected is converted to an Array the 'not ' check will be never executed.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message fol... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Flarna |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31322#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31322 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31322 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31322 |
| Reload | https://github.com/nodejs/node/pull/31322 |
| Reload | https://github.com/nodejs/node/pull/31322 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/31322#issue-comment-box |
| Flarna | https://github.com/Flarna |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dynatrace-oss-contrib:errors-remove-dead-code | https://github.com/dynatrace-oss-contrib/node/tree/errors-remove-dead-code |
|
errors: remove dead code in ERR_INVALID_ARG_TYPE
| https://github.com/nodejs/node/pull/31322#top |
| Flarna | https://github.com/Flarna |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dynatrace-oss-contrib:errors-remove-dead-code | https://github.com/dynatrace-oss-contrib/node/tree/errors-remove-dead-code |
|
Conversation
4
| https://github.com/nodejs/node/pull/31322 |
|
Commits
1
| https://github.com/nodejs/node/pull/31322/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/31322/checks |
|
Files changed
| https://github.com/nodejs/node/pull/31322/files |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| Jan 11, 2020 | https://github.com/nodejs/node/pull/31322#issue-548488208 |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Jan 11, 2020 | https://github.com/nodejs/node/pull/31322#event-2940876834 |
|
| https://github.com/Flarna |
| errors: remove dead code in ERR_INVALID_ARG_TYPE | https://github.com/nodejs/node/pull/31322/commits/91e2ce25479df7294ebf50e1683cb71282ba160a |
| 91e2ce2 | https://github.com/nodejs/node/pull/31322/commits/91e2ce25479df7294ebf50e1683cb71282ba160a |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| force-pushed | https://github.com/nodejs/node/compare/567229e633de6fa5a59dbcf5efb1c456b04a330a..91e2ce25479df7294ebf50e1683cb71282ba160a |
| 567229e | https://github.com/nodejs/node/commit/567229e633de6fa5a59dbcf5efb1c456b04a330a |
| 91e2ce2 | https://github.com/nodejs/node/commit/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
Compare
| https://github.com/nodejs/node/compare/567229e633de6fa5a59dbcf5efb1c456b04a330a..91e2ce25479df7294ebf50e1683cb71282ba160a |
| January 11, 2020 22:30 | https://github.com/nodejs/node/pull/31322#event-2940877799 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| Jan 11, 2020 | https://github.com/nodejs/node/pull/31322#event-2940877811 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 11, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341544091 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 11, 2020 | https://github.com/nodejs/node/pull/31322#event-2940878357 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 11, 2020 | https://github.com/nodejs/node/pull/31322#issuecomment-573360258 |
| https://ci.nodejs.org/job/node-test-pull-request/28370/ | https://ci.nodejs.org/job/node-test-pull-request/28370/ |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Jan 12, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341548111 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| mscdex | https://github.com/mscdex |
| Jan 12, 2020 | https://github.com/nodejs/node/pull/31322#discussion_r365550493 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| Flarna | https://github.com/Flarna |
| Jan 12, 2020 | https://github.com/nodejs/node/pull/31322#discussion_r365607277 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Jan 12, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341551383 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341578952 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 12, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341580493 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 13, 2020
| https://github.com/nodejs/node/pull/31322#pullrequestreview-341917136 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 14, 2020 | https://github.com/nodejs/node/pull/31322#issuecomment-574002707 |
| eb5e1dd | https://github.com/nodejs/node/commit/eb5e1ddd3146aa36180f44233a9465143a811afa |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 14, 2020 | https://github.com/nodejs/node/pull/31322#event-2945684760 |
| Trott | https://github.com/Trott |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/31322#ref-commit-eb5e1dd |
|
| https://github.com/Flarna |
|
| https://github.com/Trott |
| errors: remove dead code in ERR_INVALID_ARG_TYPE | https://github.com/nodejs/node/commit/eb5e1ddd3146aa36180f44233a9465143a811afa |
| eb5e1dd | https://github.com/nodejs/node/commit/eb5e1ddd3146aa36180f44233a9465143a811afa |
| #31322 | https://github.com/nodejs/node/pull/31322 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
| January 14, 2020 06:29 | https://github.com/nodejs/node/pull/31322#event-2945829231 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31322#ref-commit-4981f97 |
|
| https://github.com/Flarna |
|
| https://github.com/MylesBorins |
| errors: remove dead code in ERR_INVALID_ARG_TYPE | https://github.com/nodejs/node/commit/4981f9721a5428ae25aa075b567e26094d948c99 |
| 4981f97 | https://github.com/nodejs/node/commit/4981f9721a5428ae25aa075b567e26094d948c99 |
| #31322 | https://github.com/nodejs/node/pull/31322 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jan 16, 2020
| https://github.com/nodejs/node/pull/31322#ref-pullrequest-550944823 |
|
v13.7.0 proposal
#31382
| https://github.com/nodejs/node/pull/31382 |
| codebytere | https://github.com/codebytere |
|
Mar 14, 2020
| https://github.com/nodejs/node/pull/31322#ref-commit-8818694 |
|
| https://github.com/Flarna |
|
| https://github.com/codebytere |
| errors: remove dead code in ERR_INVALID_ARG_TYPE | https://github.com/nodejs/node/commit/881869416cf139389230b4d6158bf5b804bff2c6 |
| 8818694 | https://github.com/nodejs/node/commit/881869416cf139389230b4d6158bf5b804bff2c6 |
| #31322 | https://github.com/nodejs/node/pull/31322 |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31322#ref-commit-7231090 |
|
| https://github.com/Flarna |
|
| https://github.com/codebytere |
| errors: remove dead code in ERR_INVALID_ARG_TYPE | https://github.com/nodejs/node/commit/7231090a5dc44221d3c4f40300367cf709f90938 |
| 7231090 | https://github.com/nodejs/node/commit/7231090a5dc44221d3c4f40300367cf709f90938 |
| #31322 | https://github.com/nodejs/node/pull/31322 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Mar 17, 2020
| https://github.com/nodejs/node/pull/31322#ref-pullrequest-582721275 |
|
v12.16.2 proposal
#32313
| https://github.com/nodejs/node/pull/32313 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31322 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/31322/files/567229e633de6fa5a59dbcf5efb1c456b04a330a |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/31322/files/91e2ce25479df7294ebf50e1683cb71282ba160a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Please reload this page | https://github.com/nodejs/node/pull/31322 |
|
| https://github.com/Flarna |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/mscdex |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |