René's URL Explorer Experiment


Title: n-api: return napi_invalid_arg on napi_create_bigint_words by legendecas · Pull Request #31312 · nodejs/node · GitHub

Open Graph Title: n-api: return napi_invalid_arg on napi_create_bigint_words by legendecas · Pull Request #31312 · nodejs/node

X Title: n-api: return napi_invalid_arg on napi_create_bigint_words by legendecas · Pull Request #31312 · nodejs/node

Description: N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. Refs: #29849 These changes shall not be made on existing N-API. But BigInt related N-API is still an ...

Open Graph Description: N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. Refs: #29849 These changes shall not be made on existing N-API. But BigInt related N-API is still an ...

X Description: N-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. Refs: #29849 These changes shall not be made on existing N-API. But BigInt related N-API is still an ...

Opengraph URL: https://github.com/nodejs/node/pull/31312

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:084f1bab-30f9-88ec-ef5d-7d14b42b4861
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB3A:21279A:DBA98A:11B756C:696B2BA3
html-safe-nonce31fbed6e6a26ae0f6647398b9ab76ab0adea5f9690cb3acceae1cfd91fc68180
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjNBOjIxMjc5QTpEQkE5OEE6MTFCNzU2Qzo2OTZCMkJBMyIsInZpc2l0b3JfaWQiOiIyNDI3MzM4MjcyNzU3NDU5ODc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3eb2fe212fa64373aacb312f52166d41e3fa92d18b520941059595135e68aaad
hovercard-subject-tagpull_request:361700193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31312/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9a592a7dcb7e3dd8fa1c6d65b10de4eac23f1d8913b31e9adc390ecc4edda21c/nodejs/node/pull/31312
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a592a7dcb7e3dd8fa1c6d65b10de4eac23f1d8913b31e9adc390ecc4edda21c/nodejs/node/pull/31312
og:image:altN-API statuses shall be preferred over throwing JavaScript Errors on checks occurred in N-APIs. Refs: #29849 These changes shall not be made on existing N-API. But BigInt related N-API is still an ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31312#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31312
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31312
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31312
Reloadhttps://github.com/nodejs/node/pull/31312
Reloadhttps://github.com/nodejs/node/pull/31312
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31312
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31312
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31312#issue-comment-box
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node/tree/master
legendecas:napi_bigint_throwinghttps://github.com/legendecas/node/tree/napi_bigint_throwing
n-api: return napi_invalid_arg on napi_create_bigint_words https://github.com/nodejs/node/pull/31312#top
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node/tree/master
legendecas:napi_bigint_throwinghttps://github.com/legendecas/node/tree/napi_bigint_throwing
Conversation 6 https://github.com/nodejs/node/pull/31312
Commits 1 https://github.com/nodejs/node/pull/31312/commits
Checks 0 https://github.com/nodejs/node/pull/31312/checks
Files changed https://github.com/nodejs/node/pull/31312/files
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jan 11, 2020https://github.com/nodejs/node/pull/31312#issue-548388897
Please reload this pagehttps://github.com/nodejs/node/pull/31312
#29849https://github.com/nodejs/node/issues/29849
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 11, 2020https://github.com/nodejs/node/pull/31312#event-2940428512
https://github.com/legendecas
n-api: return napi_invalid_arg on napi_create_bigint_wordshttps://github.com/nodejs/node/pull/31312/commits/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
ccc6cd5https://github.com/nodejs/node/pull/31312/commits/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/326610c7402973dcbd2761f7da8114d92aec3742..ccc6cd58eb28dea97e9c9225121aade7b2a663f7
326610chttps://github.com/nodejs/node/commit/326610c7402973dcbd2761f7da8114d92aec3742
ccc6cd5https://github.com/nodejs/node/commit/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
Compare https://github.com/nodejs/node/compare/326610c7402973dcbd2761f7da8114d92aec3742..ccc6cd58eb28dea97e9c9225121aade7b2a663f7
January 11, 2020 06:23https://github.com/nodejs/node/pull/31312#event-2940428883
https://github.com/legendecas
legendecashttps://github.com/legendecas
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jan 11, 2020https://github.com/nodejs/node/pull/31312#event-2940429025
https://github.com/legendecas
legendecashttps://github.com/legendecas
January 11, 2020 06:24https://github.com/nodejs/node/pull/31312#event-2940429198
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 11, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341519733
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 11, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341523113
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 11, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341541213
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 11, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341545167
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 11, 2020https://github.com/nodejs/node/pull/31312#event-2940893135
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 11, 2020https://github.com/nodejs/node/pull/31312#issuecomment-573362643
https://ci.nodejs.org/job/node-test-pull-request/28376/https://ci.nodejs.org/job/node-test-pull-request/28376/
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 12, 2020https://github.com/nodejs/node/pull/31312#issuecomment-573375668
https://ci.nodejs.org/job/node-test-pull-request/28388/https://ci.nodejs.org/job/node-test-pull-request/28388/
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 13, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341613446
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 13, 2020 https://github.com/nodejs/node/pull/31312#pullrequestreview-341967737
View reviewed changes https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/31312#pullrequestreview-341967737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 13, 2020https://github.com/nodejs/node/pull/31312#issuecomment-573748184
https://ci.nodejs.org/job/node-test-pull-request/28434/https://ci.nodejs.org/job/node-test-pull-request/28434/
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2020https://github.com/nodejs/node/pull/31312#issuecomment-573748270
https://ci.nodejs.org/job/node-test-pull-request/28434/https://ci.nodejs.org/job/node-test-pull-request/28434/
Please reload this pagehttps://github.com/nodejs/node/pull/31312
Trotthttps://github.com/Trott
Jan 14, 2020 https://github.com/nodejs/node/pull/31312#ref-commit-689ab46
https://github.com/legendecas
https://github.com/Trott
n-api: return napi_invalid_arg on napi_create_bigint_wordshttps://github.com/nodejs/node/commit/689ab46c646bc8add5560a606ba73d3760f8f924
689ab46https://github.com/nodejs/node/commit/689ab46c646bc8add5560a606ba73d3760f8f924
#31312https://github.com/nodejs/node/pull/31312
#29849https://github.com/nodejs/node/issues/29849
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 14, 2020https://github.com/nodejs/node/pull/31312#issuecomment-574005775
689ab46https://github.com/nodejs/node/commit/689ab46c646bc8add5560a606ba73d3760f8f924
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 14, 2020https://github.com/nodejs/node/pull/31312#event-2945705190
MylesBorinshttps://github.com/MylesBorins
Jan 16, 2020 https://github.com/nodejs/node/pull/31312#ref-commit-c8aa08e
https://github.com/legendecas
https://github.com/MylesBorins
n-api: return napi_invalid_arg on napi_create_bigint_wordshttps://github.com/nodejs/node/commit/c8aa08ed2751b6af057c7ac6f04d2b0f3a63ab02
c8aa08ehttps://github.com/nodejs/node/commit/c8aa08ed2751b6af057c7ac6f04d2b0f3a63ab02
#31312https://github.com/nodejs/node/pull/31312
#29849https://github.com/nodejs/node/issues/29849
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jan 16, 2020 https://github.com/nodejs/node/pull/31312#ref-pullrequest-550944823
v13.7.0 proposal #31382 https://github.com/nodejs/node/pull/31382
https://github.com/legendecas
legendecashttps://github.com/legendecas
February 13, 2020 16:51https://github.com/nodejs/node/pull/31312#event-3035688771
codebyterehttps://github.com/codebytere
Mar 14, 2020 https://github.com/nodejs/node/pull/31312#ref-commit-ad081c5
https://github.com/legendecas
https://github.com/codebytere
n-api: return napi_invalid_arg on napi_create_bigint_wordshttps://github.com/nodejs/node/commit/ad081c50646f1598535f4ccd3d0cfb8fec818507
ad081c5https://github.com/nodejs/node/commit/ad081c50646f1598535f4ccd3d0cfb8fec818507
#31312https://github.com/nodejs/node/pull/31312
#29849https://github.com/nodejs/node/issues/29849
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31312#ref-commit-3a84634
https://github.com/legendecas
https://github.com/codebytere
n-api: return napi_invalid_arg on napi_create_bigint_wordshttps://github.com/nodejs/node/commit/3a84634cc1f5227bdd4e2779d64378a8449d4890
3a84634https://github.com/nodejs/node/commit/3a84634cc1f5227bdd4e2779d64378a8449d4890
#31312https://github.com/nodejs/node/pull/31312
#29849https://github.com/nodejs/node/issues/29849
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Mar 17, 2020 https://github.com/nodejs/node/pull/31312#ref-pullrequest-582721275
v12.16.2 proposal #32313 https://github.com/nodejs/node/pull/32313
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31312
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/31312/files/ccc6cd58eb28dea97e9c9225121aade7b2a663f7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/31312
https://github.com/legendecas
https://github.com/nodejs-github-bot
https://github.com/mhdawson
https://github.com/Trott
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.