René's URL Explorer Experiment


Title: Speed up promise introspection by bnoordhuis · Pull Request #3130 · nodejs/node · GitHub

Open Graph Title: Speed up promise introspection by bnoordhuis · Pull Request #3130 · nodejs/node

X Title: Speed up promise introspection by bnoordhuis · Pull Request #3130 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: R=@vkurchatkin | @thefourtheye | @targos? #3107 for background. I realized we don't have to wait for a V8 upgrade. CI: https://ci.nodejs.org/job/node-test-pull-request/399/

X Description: R=@vkurchatkin | @thefourtheye | @targos? #3107 for background. I realized we don't have to wait for a V8 upgrade. CI: https://ci.nodejs.org/job/node-test-pull-request/399/

Opengraph URL: https://github.com/nodejs/node/pull/3130

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7be37ef-329b-1333-2daa-1253bc15da0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C44:1BDCFF:1233692:1A97FF9:6A4E419C
html-safe-noncee72cd93a2aeeaa716c0517a57b0121aca47756eb9803f5c5a8fe2707b2fd6e1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQ0OjFCRENGRjoxMjMzNjkyOjFBOTdGRjk6NkE0RTQxOUMiLCJ2aXNpdG9yX2lkIjoiMzM3OTI3ODI0MzA1MTc0OTc4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac37af84919ffb8a8c03109f4f1d371735723dee238b7d5752e17aa4a9c96f41aa
hovercard-subject-tagpull_request:46381644
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3130/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a3206f5f6ee1c1e11dbbdeed8d0b298a356f4fb163e68f39501a3a4c68819ce/nodejs/node/pull/3130
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a3206f5f6ee1c1e11dbbdeed8d0b298a356f4fb163e68f39501a3a4c68819ce/nodejs/node/pull/3130
og:image:altR=@vkurchatkin | @thefourtheye | @targos? #3107 for background. I realized we don't have to wait for a V8 upgrade. CI: https://ci.nodejs.org/job/node-test-pull-request/399/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3130#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3130
Reloadhttps://github.com/nodejs/node/pull/3130
Reloadhttps://github.com/nodejs/node/pull/3130
Please reload this pagehttps://github.com/nodejs/node/pull/3130
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3130
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:speed-up-promise-introspectionhttps://github.com/bnoordhuis/io.js/tree/speed-up-promise-introspection
Conversationhttps://github.com/nodejs/node/pull/3130
Commits2 (2)https://github.com/nodejs/node/pull/3130/commits
Checkshttps://github.com/nodejs/node/pull/3130/checks
Files changedhttps://github.com/nodejs/node/pull/3130/files
Speed up promise introspectionhttps://github.com/nodejs/node/pull/3130#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:speed-up-promise-introspectionhttps://github.com/bnoordhuis/io.js/tree/speed-up-promise-introspection
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 30, 2015https://github.com/nodejs/node/pull/3130#issue-109053450
@vkurchatkinhttps://github.com/vkurchatkin
@thefourtheyehttps://github.com/thefourtheye
@targoshttps://github.com/targos
#3107https://github.com/nodejs/node/issues/3107
https://ci.nodejs.org/job/node-test-pull-request/399/https://ci.nodejs.org/job/node-test-pull-request/399/
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 30, 2015 https://github.com/nodejs/node/pull/3130#ref-issue-108738178
Map.keys() returns empty object (4.1.1) #3107 https://github.com/nodejs/node/issues/3107
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Sep 30, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144346097
Please reload this pagehttps://github.com/nodejs/node/pull/3130
targoshttps://github.com/targos
Sep 30, 2015 https://github.com/nodejs/node/pull/3130#discussion-diff-40783690
View reviewed changes https://github.com/nodejs/node/pull/3130/files#diff-3fb720f70ea34fb2975fd6c38ac4b6b6131373be2abfa4760dfaae8a25daaee2
lib/util.jshttps://github.com/nodejs/node/pull/3130/files#diff-3fb720f70ea34fb2975fd6c38ac4b6b6131373be2abfa4760dfaae8a25daaee2
targoshttps://github.com/targos
Sep 30, 2015https://github.com/nodejs/node/pull/3130#discussion_r40783690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3119https://github.com/nodejs/node/pull/3119
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Sep 30, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144469911
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/mscdex
mscdexhttps://github.com/mscdex
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Sep 30, 2015https://github.com/nodejs/node/pull/3130#event-423312289
bnoordhuishttps://github.com/bnoordhuis
September 30, 2015 23:43https://github.com/nodejs/node/pull/3130#commits-pushed-9a1bc4e
https://github.com/bnoordhuis
util: optimize promise introspectionhttps://github.com/nodejs/node/pull/3130/commits/9a1bc4ea7ecb15ecce643e56bb9015c790e391ea
9a1bc4ehttps://github.com/nodejs/node/pull/3130/commits/9a1bc4ea7ecb15ecce643e56bb9015c790e391ea
nodejs#3130https://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
deps: backporthttps://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24
f782159https://github.com/bnoordhuis/io.js/commit/f782159bfafabb7486803e78577fc305d272981b
from v8's upstreamhttps://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24
dbe4844https://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24
https://codereview.chromium.org/1367123003https://codereview.chromium.org/1367123003
nodejs#30966https://github.com/nodejs/node/pull/30966
nodejs#3130https://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/076dd530db06728dd14fba0522d216cbb59b362b..dbe48446b7981a60ac3e461056c7a888572b8e24
076dd53https://github.com/nodejs/node/commit/076dd530db06728dd14fba0522d216cbb59b362b
dbe4844https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24
Compare https://github.com/nodejs/node/compare/076dd530db06728dd14fba0522d216cbb59b362b..dbe48446b7981a60ac3e461056c7a888572b8e24
September 30, 2015 21:44https://github.com/nodejs/node/pull/3130#event-423611791
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 30, 2015https://github.com/nodejs/node/pull/3130#event-423611832
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
September 30, 2015 21:44https://github.com/nodejs/node/pull/3130#event-423611833
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
dbe4844https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24
Sep 30, 2015https://github.com/nodejs/node/pull/3130#event-423611995
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 30, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144551387
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 1, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144583723
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 1, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144707373
bnoordhuis/node@bdfee10https://github.com/bnoordhuis/node/commit/bdfee10
bnoordhuis/io.js@bdfee10https://github.com/bnoordhuis/io.js/commit/bdfee10
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 1, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144708009
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 1, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144710170
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 1, 2015https://github.com/nodejs/node/pull/3130#issuecomment-144714977
Please reload this pagehttps://github.com/nodejs/node/pull/3130
bnoordhuishttps://github.com/bnoordhuis
Oct 2, 2015 https://github.com/nodejs/node/pull/3130#ref-commit-d8ab4e1
https://github.com/bnoordhuis
https://github.com/rvagg
util: optimize promise introspectionhttps://github.com/nodejs/node/commit/d8ab4e185dc9f664084bb12a66c8e1d136676e9b
d8ab4e1https://github.com/nodejs/node/commit/d8ab4e185dc9f664084bb12a66c8e1d136676e9b
#3130https://github.com/nodejs/node/pull/3130
bnoordhuishttps://github.com/bnoordhuis
Oct 2, 2015 https://github.com/nodejs/node/pull/3130#ref-commit-925b29f
https://github.com/bnoordhuis
https://github.com/rvagg
deps: backporthttps://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285
f782159https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b
from v8's upstreamhttps://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285
925b29fhttps://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285
https://codereview.chromium.org/1367123003https://codereview.chromium.org/1367123003
#30966https://github.com/nodejs/node/pull/30966
#3130https://github.com/nodejs/node/pull/3130
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 3, 2015 https://github.com/nodejs/node/pull/3130#ref-pullrequest-109043108
Release proposal: v4.1.2 #3128 https://github.com/nodejs/node/pull/3128
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 5, 2015https://github.com/nodejs/node/pull/3130#issuecomment-145499236
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/targos
targoshttps://github.com/targos
Oct 5, 2015https://github.com/nodejs/node/pull/3130#issuecomment-145500021
@rvagghttps://github.com/rvagg
dbe4844https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 5, 2015https://github.com/nodejs/node/pull/3130#issuecomment-145500155
f782159https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b
Please reload this pagehttps://github.com/nodejs/node/pull/3130
rvagghttps://github.com/rvagg
Oct 5, 2015 https://github.com/nodejs/node/pull/3130#ref-commit-85df6ad
https://github.com/rvagg
2015-10-05, Version 4.1.2 (Stable) Releasehttps://github.com/nodejs/node/commit/85df6ada477715020dbd22e2fb5e687d84d663ff
85df6adhttps://github.com/nodejs/node/commit/85df6ada477715020dbd22e2fb5e687d84d663ff
CVE-2015-7384https://github.com/advisories/GHSA-gw56-f2ch-v6jj
#3128https://github.com/nodejs/node/pull/3128
#3128https://github.com/nodejs/node/pull/3128
#3010https://github.com/nodejs/node/pull/3010
#3117https://github.com/nodejs/node/pull/3117
f782159https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b
#3130https://github.com/nodejs/node/pull/3130
#3031https://github.com/nodejs/node/pull/3031
#3128https://github.com/nodejs/node/pull/3128
rvagghttps://github.com/rvagg
Oct 5, 2015 https://github.com/nodejs/node/pull/3130#ref-commit-820735d
https://github.com/rvagg
2015-10-05, Version 4.1.2 (Stable) Releasehttps://github.com/nodejs/node/commit/820735d96743717d4d037caa96e56ff5886c73df
820735dhttps://github.com/nodejs/node/commit/820735d96743717d4d037caa96e56ff5886c73df
CVE-2015-7384https://github.com/advisories/GHSA-gw56-f2ch-v6jj
#3128https://github.com/nodejs/node/pull/3128
#3128https://github.com/nodejs/node/pull/3128
#3010https://github.com/nodejs/node/pull/3010
#3117https://github.com/nodejs/node/pull/3117
f782159https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b
#3130https://github.com/nodejs/node/pull/3130
#3031https://github.com/nodejs/node/pull/3031
#3128https://github.com/nodejs/node/pull/3128
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Feb 16, 2016https://github.com/nodejs/node/pull/3130#event-551916998
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/3130
https://github.com/bnoordhuis
https://github.com/thefourtheye
https://github.com/evanlucas
https://github.com/rvagg
https://github.com/targos
https://github.com/mscdex
https://github.com/ChALkeR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.