| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d7be37ef-329b-1333-2daa-1253bc15da0e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C44:1BDCFF:1233692:1A97FF9:6A4E419C |
| html-safe-nonce | e72cd93a2aeeaa716c0517a57b0121aca47756eb9803f5c5a8fe2707b2fd6e1b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQ0OjFCRENGRjoxMjMzNjkyOjFBOTdGRjk6NkE0RTQxOUMiLCJ2aXNpdG9yX2lkIjoiMzM3OTI3ODI0MzA1MTc0OTc4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37af84919ffb8a8c03109f4f1d371735723dee238b7d5752e17aa4a9c96f41aa |
| hovercard-subject-tag | pull_request:46381644 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3130/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4a3206f5f6ee1c1e11dbbdeed8d0b298a356f4fb163e68f39501a3a4c68819ce/nodejs/node/pull/3130 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4a3206f5f6ee1c1e11dbbdeed8d0b298a356f4fb163e68f39501a3a4c68819ce/nodejs/node/pull/3130 |
| og:image:alt | R=@vkurchatkin | @thefourtheye | @targos?
#3107 for background. I realized we don't have to wait for a V8 upgrade.
CI: https://ci.nodejs.org/job/node-test-pull-request/399/ |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9fabff9b8b127e686a3ec86f91422e818056ca2c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/3130#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/3130 |
| Reload | https://github.com/nodejs/node/pull/3130 |
| Reload | https://github.com/nodejs/node/pull/3130 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:speed-up-promise-introspection | https://github.com/bnoordhuis/io.js/tree/speed-up-promise-introspection |
| Conversation | https://github.com/nodejs/node/pull/3130 |
| Commits2 (2) | https://github.com/nodejs/node/pull/3130/commits |
| Checks | https://github.com/nodejs/node/pull/3130/checks |
| Files changed | https://github.com/nodejs/node/pull/3130/files |
| Speed up promise introspection | https://github.com/nodejs/node/pull/3130#top |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:speed-up-promise-introspection | https://github.com/bnoordhuis/io.js/tree/speed-up-promise-introspection |
|
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#issue-109053450 |
| @vkurchatkin | https://github.com/vkurchatkin |
| @thefourtheye | https://github.com/thefourtheye |
| @targos | https://github.com/targos |
| #3107 | https://github.com/nodejs/node/issues/3107 |
| https://ci.nodejs.org/job/node-test-pull-request/399/ | https://ci.nodejs.org/job/node-test-pull-request/399/ |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 30, 2015
| https://github.com/nodejs/node/pull/3130#ref-issue-108738178 |
|
Map.keys() returns empty object (4.1.1)
#3107
| https://github.com/nodejs/node/issues/3107 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144346097 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| targos | https://github.com/targos |
|
Sep 30, 2015
| https://github.com/nodejs/node/pull/3130#discussion-diff-40783690 |
| View reviewed changes
| https://github.com/nodejs/node/pull/3130/files#diff-3fb720f70ea34fb2975fd6c38ac4b6b6131373be2abfa4760dfaae8a25daaee2 |
| lib/util.js | https://github.com/nodejs/node/pull/3130/files#diff-3fb720f70ea34fb2975fd6c38ac4b6b6131373be2abfa4760dfaae8a25daaee2 |
| targos | https://github.com/targos |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#discussion_r40783690 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3119 | https://github.com/nodejs/node/pull/3119 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144469911 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#event-423312289 |
| bnoordhuis | https://github.com/bnoordhuis |
| September 30, 2015 23:43 | https://github.com/nodejs/node/pull/3130#commits-pushed-9a1bc4e |
|
| https://github.com/bnoordhuis |
| util: optimize promise introspection | https://github.com/nodejs/node/pull/3130/commits/9a1bc4ea7ecb15ecce643e56bb9015c790e391ea |
| 9a1bc4e | https://github.com/nodejs/node/pull/3130/commits/9a1bc4ea7ecb15ecce643e56bb9015c790e391ea |
| nodejs#3130 | https://github.com/nodejs/node/pull/3130 |
|
| https://github.com/bnoordhuis |
| deps: backport | https://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24 |
| f782159 | https://github.com/bnoordhuis/io.js/commit/f782159bfafabb7486803e78577fc305d272981b |
| from v8's upstream | https://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24 |
| dbe4844 | https://github.com/nodejs/node/pull/3130/commits/dbe48446b7981a60ac3e461056c7a888572b8e24 |
| https://codereview.chromium.org/1367123003 | https://codereview.chromium.org/1367123003 |
| nodejs#30966 | https://github.com/nodejs/node/pull/30966 |
| nodejs#3130 | https://github.com/nodejs/node/pull/3130 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| force-pushed | https://github.com/nodejs/node/compare/076dd530db06728dd14fba0522d216cbb59b362b..dbe48446b7981a60ac3e461056c7a888572b8e24 |
| 076dd53 | https://github.com/nodejs/node/commit/076dd530db06728dd14fba0522d216cbb59b362b |
| dbe4844 | https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24 |
|
Compare
| https://github.com/nodejs/node/compare/076dd530db06728dd14fba0522d216cbb59b362b..dbe48446b7981a60ac3e461056c7a888572b8e24 |
| September 30, 2015 21:44 | https://github.com/nodejs/node/pull/3130#event-423611791 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#event-423611832 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| September 30, 2015 21:44 | https://github.com/nodejs/node/pull/3130#event-423611833 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| dbe4844 | https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24 |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#event-423611995 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 30, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144551387 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 1, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144583723 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 1, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144707373 |
| bnoordhuis/node@bdfee10 | https://github.com/bnoordhuis/node/commit/bdfee10 |
| bnoordhuis/io.js@bdfee10 | https://github.com/bnoordhuis/io.js/commit/bdfee10 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 1, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144708009 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 1, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144710170 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 1, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-144714977 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 2, 2015
| https://github.com/nodejs/node/pull/3130#ref-commit-d8ab4e1 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/rvagg |
| util: optimize promise introspection | https://github.com/nodejs/node/commit/d8ab4e185dc9f664084bb12a66c8e1d136676e9b |
| d8ab4e1 | https://github.com/nodejs/node/commit/d8ab4e185dc9f664084bb12a66c8e1d136676e9b |
| #3130 | https://github.com/nodejs/node/pull/3130 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 2, 2015
| https://github.com/nodejs/node/pull/3130#ref-commit-925b29f |
|
| https://github.com/bnoordhuis |
|
| https://github.com/rvagg |
| deps: backport | https://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285 |
| f782159 | https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b |
| from v8's upstream | https://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285 |
| 925b29f | https://github.com/nodejs/node/commit/925b29f95958cc66808a0e4bf26b341b79c6a285 |
| https://codereview.chromium.org/1367123003 | https://codereview.chromium.org/1367123003 |
| #30966 | https://github.com/nodejs/node/pull/30966 |
| #3130 | https://github.com/nodejs/node/pull/3130 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Oct 3, 2015
| https://github.com/nodejs/node/pull/3130#ref-pullrequest-109043108 |
|
Release proposal: v4.1.2
#3128
| https://github.com/nodejs/node/pull/3128 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Oct 5, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-145499236 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Oct 5, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-145500021 |
| @rvagg | https://github.com/rvagg |
| dbe4844 | https://github.com/nodejs/node/commit/dbe48446b7981a60ac3e461056c7a888572b8e24 |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Oct 5, 2015 | https://github.com/nodejs/node/pull/3130#issuecomment-145500155 |
| f782159 | https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
| rvagg | https://github.com/rvagg |
|
Oct 5, 2015
| https://github.com/nodejs/node/pull/3130#ref-commit-85df6ad |
|
| https://github.com/rvagg |
| 2015-10-05, Version 4.1.2 (Stable) Release | https://github.com/nodejs/node/commit/85df6ada477715020dbd22e2fb5e687d84d663ff |
| 85df6ad | https://github.com/nodejs/node/commit/85df6ada477715020dbd22e2fb5e687d84d663ff |
| CVE-2015-7384 | https://github.com/advisories/GHSA-gw56-f2ch-v6jj |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| #3010 | https://github.com/nodejs/node/pull/3010 |
| #3117 | https://github.com/nodejs/node/pull/3117 |
| f782159 | https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b |
| #3130 | https://github.com/nodejs/node/pull/3130 |
| #3031 | https://github.com/nodejs/node/pull/3031 |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| rvagg | https://github.com/rvagg |
|
Oct 5, 2015
| https://github.com/nodejs/node/pull/3130#ref-commit-820735d |
|
| https://github.com/rvagg |
| 2015-10-05, Version 4.1.2 (Stable) Release | https://github.com/nodejs/node/commit/820735d96743717d4d037caa96e56ff5886c73df |
| 820735d | https://github.com/nodejs/node/commit/820735d96743717d4d037caa96e56ff5886c73df |
| CVE-2015-7384 | https://github.com/advisories/GHSA-gw56-f2ch-v6jj |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| #3010 | https://github.com/nodejs/node/pull/3010 |
| #3117 | https://github.com/nodejs/node/pull/3117 |
| f782159 | https://github.com/nodejs/node/commit/f782159bfafabb7486803e78577fc305d272981b |
| #3130 | https://github.com/nodejs/node/pull/3130 |
| #3031 | https://github.com/nodejs/node/pull/3031 |
| #3128 | https://github.com/nodejs/node/pull/3128 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Feb 16, 2016 | https://github.com/nodejs/node/pull/3130#event-551916998 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3130 |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/3130 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/thefourtheye |
|
| https://github.com/evanlucas |
|
| https://github.com/rvagg |
|
| https://github.com/targos |
|
| https://github.com/mscdex |
|
| https://github.com/ChALkeR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |