René's URL Explorer Experiment


Title: Fix dispose without checking by jc-lab · Pull Request #31260 · nodejs/node · GitHub

Open Graph Title: Fix dispose without checking by jc-lab · Pull Request #31260 · nodejs/node

X Title: Fix dispose without checking by jc-lab · Pull Request #31260 · nodejs/node

Description: If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. node/src/env.cc ...

Open Graph Description: If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. node/src/env.cc ...

X Description: If created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. node/src/env.cc ...

Opengraph URL: https://github.com/nodejs/node/pull/31260

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b932e12c-b26a-f3b0-d11f-40c35ef737ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC24C:21FEDA:E29413:138F94C:696A9187
html-safe-nonce317cb74a7cad5504e8f29cda88613f4943d1a6b68e2062051fd3f85463da4354
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjRDOjIxRkVEQTpFMjk0MTM6MTM4Rjk0Qzo2OTZBOTE4NyIsInZpc2l0b3JfaWQiOiI0OTE0ODU2MDc4MDQ3MDMxMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9ca84c24480842b0aa2de5c4fe1adc41c58556108864b2c39f790987e37b1110
hovercard-subject-tagpull_request:360437333
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31260/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e8dd137447c25517ce05cb93f6b5ad91c0442c4d219aa90aa4ad0099bce3348/nodejs/node/pull/31260
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e8dd137447c25517ce05cb93f6b5ad91c0442c4d219aa90aa4ad0099bce3348/nodejs/node/pull/31260
og:image:altIf created platform with CreatePlatform, the crash occurs because it does not check if it was initialized to v8_platform when DisposePlatform was called. node/src/env.cc ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejc-lab
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31260#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31260
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31260
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31260
Reloadhttps://github.com/nodejs/node/pull/31260
Reloadhttps://github.com/nodejs/node/pull/31260
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31260
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31260
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31260#issue-comment-box
jc-labhttps://github.com/jc-lab
nodejs:masterhttps://github.com/nodejs/node/tree/master
jc-lab:fix-dispose-without-checkinghttps://github.com/jc-lab/node/tree/fix-dispose-without-checking
Fix dispose without checking https://github.com/nodejs/node/pull/31260#top
jc-labhttps://github.com/jc-lab
nodejs:masterhttps://github.com/nodejs/node/tree/master
jc-lab:fix-dispose-without-checkinghttps://github.com/jc-lab/node/tree/fix-dispose-without-checking
Conversation 13 https://github.com/nodejs/node/pull/31260
Commits 1 https://github.com/nodejs/node/pull/31260/commits
Checks 0 https://github.com/nodejs/node/pull/31260/checks
Files changed https://github.com/nodejs/node/pull/31260/files
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jc-lab
jc-labhttps://github.com/jc-lab
Jan 8, 2020https://github.com/nodejs/node/pull/31260#issue-546834821
node/src/env.cchttps://github.com/nodejs/node/blob/bd6d6512f02d6fa10a0484577c270bb44f1b750b/src/env.cc#L958
bd6d651https://github.com/nodejs/node/commit/bd6d6512f02d6fa10a0484577c270bb44f1b750b
node/src/node_v8_platform-inl.hhttps://github.com/nodejs/node/blob/bd6d6512f02d6fa10a0484577c270bb44f1b750b/src/node_v8_platform-inl.h#L176-L178
bd6d651https://github.com/nodejs/node/commit/bd6d6512f02d6fa10a0484577c270bb44f1b750b
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jan 8, 2020https://github.com/nodejs/node/pull/31260#event-2931001617
src: fix what a dispose without checkinghttps://github.com/nodejs/node/pull/31260/commits/4058d532f243b773573ea42b648b925625a1cb76
4058d53https://github.com/nodejs/node/pull/31260/commits/4058d532f243b773573ea42b648b925625a1cb76
https://github.com/jc-lab
jc-labhttps://github.com/jc-lab
force-pushedhttps://github.com/nodejs/node/compare/0641ee30d8a335e8a29e100388fda01f5465e364..4058d532f243b773573ea42b648b925625a1cb76
0641ee3https://github.com/nodejs/node/commit/0641ee30d8a335e8a29e100388fda01f5465e364
4058d53https://github.com/nodejs/node/commit/4058d532f243b773573ea42b648b925625a1cb76
Compare https://github.com/nodejs/node/compare/0641ee30d8a335e8a29e100388fda01f5465e364..4058d532f243b773573ea42b648b925625a1cb76
January 8, 2020 12:39https://github.com/nodejs/node/pull/31260#event-2931006532
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 8, 2020 https://github.com/nodejs/node/pull/31260#pullrequestreview-339891294
View reviewed changes https://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76
src/node_v8_platform-inl.hhttps://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76#diff-d1784ad702a5f00c64d10091f1fa9defa4f0426a2ad82939f20601fe3fc27db5
joyeecheunghttps://github.com/joyeecheung
Jan 8, 2020https://github.com/nodejs/node/pull/31260#discussion_r364252015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31260
jc-labhttps://github.com/jc-lab
Jan 8, 2020https://github.com/nodejs/node/pull/31260#discussion_r364276873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/src/env.cchttps://github.com/nodejs/node/blob/bd6d6512f02d6fa10a0484577c270bb44f1b750b/src/env.cc#L958
bd6d651https://github.com/nodejs/node/commit/bd6d6512f02d6fa10a0484577c270bb44f1b750b
Please reload this pagehttps://github.com/nodejs/node/pull/31260
joyeecheunghttps://github.com/joyeecheung
Jan 8, 2020https://github.com/nodejs/node/pull/31260#discussion_r364291294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31260
jc-labhttps://github.com/jc-lab
Jan 8, 2020https://github.com/nodejs/node/pull/31260#discussion_r364495725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 10, 2020https://github.com/nodejs/node/pull/31260#issuecomment-573239603
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2020https://github.com/nodejs/node/pull/31260#issuecomment-574393298
@Trotthttps://github.com/Trott
@jc-labhttps://github.com/jc-lab
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2020 https://github.com/nodejs/node/pull/31260#pullrequestreview-342866533
View reviewed changes https://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76
src/node_v8_platform-inl.hhttps://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76#diff-d1784ad702a5f00c64d10091f1fa9defa4f0426a2ad82939f20601fe3fc27db5
addaleaxhttps://github.com/addaleax
Jan 14, 2020https://github.com/nodejs/node/pull/31260#discussion_r366594317
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jc-labhttps://github.com/jc-lab
Please reload this pagehttps://github.com/nodejs/node/pull/31260
src/node_v8_platform-inl.hhttps://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76#diff-d1784ad702a5f00c64d10091f1fa9defa4f0426a2ad82939f20601fe3fc27db5
addaleaxhttps://github.com/addaleax
Jan 14, 2020https://github.com/nodejs/node/pull/31260#discussion_r366594432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jan 14, 2020https://github.com/nodejs/node/pull/31260#event-2948773633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 14, 2020https://github.com/nodejs/node/pull/31260#issuecomment-574394089
https://ci.nodejs.org/job/node-test-pull-request/28443/https://ci.nodejs.org/job/node-test-pull-request/28443/
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 14, 2020https://github.com/nodejs/node/pull/31260#issuecomment-574419552
@Trotthttps://github.com/Trott
https://github.com/nodejs/github-bot/blob/7026435015b0a9f4bceea21a78b18067dd595e0f/lib/node-labels.js#L26https://github.com/nodejs/github-bot/blob/7026435015b0a9f4bceea21a78b18067dd595e0f/lib/node-labels.js#L26
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 18, 2020https://github.com/nodejs/node/pull/31260#issuecomment-575845930
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 28, 2020 https://github.com/nodejs/node/pull/31260#ref-pullrequest-522317642
src: improve embedder API #30467 https://github.com/nodejs/node/pull/30467
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 28, 2020https://github.com/nodejs/node/pull/31260#issuecomment-592387650
#30467https://github.com/nodejs/node/pull/30467
Please reload this pagehttps://github.com/nodejs/node/pull/31260
addaleaxhttps://github.com/addaleax
Mar 12, 2020 https://github.com/nodejs/node/pull/31260#ref-commit-36ec54b
https://github.com/addaleax
src: fix what a dispose without checkinghttps://github.com/addaleax/node/commit/36ec54b8789069206e1fbdd594838fa3c7560642
36ec54bhttps://github.com/addaleax/node/commit/36ec54b8789069206e1fbdd594838fa3c7560642
nodejs#31260https://github.com/nodejs/node/pull/31260
addaleaxhttps://github.com/addaleax
Mar 21, 2020 https://github.com/nodejs/node/pull/31260#ref-commit-0e57674
https://github.com/addaleax
src: fix what a dispose without checkinghttps://github.com/nodejs/node/commit/0e576740dc9ef10203884fd631cef4456b0f3a7c
0e57674https://github.com/nodejs/node/commit/0e576740dc9ef10203884fd631cef4456b0f3a7c
#31260https://github.com/nodejs/node/pull/31260
#30467https://github.com/nodejs/node/pull/30467
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020https://github.com/nodejs/node/pull/31260#issuecomment-602027581
0e57674https://github.com/nodejs/node/commit/0e576740dc9ef10203884fd631cef4456b0f3a7c
#30467https://github.com/nodejs/node/pull/30467
@jc-labhttps://github.com/jc-lab
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 21, 2020https://github.com/nodejs/node/pull/31260#event-3151645949
addaleaxhttps://github.com/addaleax
Sep 23, 2020 https://github.com/nodejs/node/pull/31260#ref-commit-691a575
https://github.com/addaleax
src: fix what a dispose without checkinghttps://github.com/addaleax/node/commit/691a5755936d127c36ce7703a43b89e3c4662cfe
691a575https://github.com/addaleax/node/commit/691a5755936d127c36ce7703a43b89e3c4662cfe
nodejs#31260https://github.com/nodejs/node/pull/31260
nodejs#30467https://github.com/nodejs/node/pull/30467
addaleaxhttps://github.com/addaleax
Sep 23, 2020 https://github.com/nodejs/node/pull/31260#ref-commit-a28c990
https://github.com/addaleax
src: fix what a dispose without checkinghttps://github.com/nodejs/node/commit/a28c9900613f68f92f59ea3881b68c71d8e0010f
a28c990https://github.com/nodejs/node/commit/a28c9900613f68f92f59ea3881b68c71d8e0010f
#35241https://github.com/nodejs/node/pull/35241
#31260https://github.com/nodejs/node/pull/31260
#30467https://github.com/nodejs/node/pull/30467
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31260
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/31260/files/4058d532f243b773573ea42b648b925625a1cb76
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
Please reload this pagehttps://github.com/nodejs/node/pull/31260
https://github.com/jc-lab
https://github.com/Trott
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.