| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:177f2f3c-aee3-d11e-b3d3-1ae41d9f4529 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B86:446DE:866DF4:C201C4:6A4F87A7 |
| html-safe-nonce | cf90e7e7c0e6dfdd24f9ea5d40bcb1b2e2b5ef9efa14a1943cf6ae3928fef72b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qjg2OjQ0NkRFOjg2NkRGNDpDMjAxQzQ6NkE0Rjg3QTciLCJ2aXNpdG9yX2lkIjoiMzE1MjgyNzM2MjU1MzA1NjM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cdc730b85ac4d527d8e205da5691cd44d0497b32958874ed25a078507bd0a539 |
| hovercard-subject-tag | pull_request:360051204 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31248/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/77cb810d00610a39960c2635dbfffd7856ec2691ad6e6adc37188de2d7f6975d/nodejs/node/pull/31248 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/77cb810d00610a39960c2635dbfffd7856ec2691ad6e6adc37188de2d7f6975d/nodejs/node/pull/31248 |
| og:image:alt | (Previously #30796, I'd rather the branches match)
2020-01-07, Version 10.18.1 'Dubnium' (LTS), @BethGriggs
Notable changes
http2: fix session memory accounting after pausing (Michael ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BethGriggs |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31248#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31248 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31248 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31248 |
| Reload | https://github.com/nodejs/node/pull/31248 |
| Reload | https://github.com/nodejs/node/pull/31248 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BethGriggs | https://github.com/BethGriggs |
| v10.x | https://github.com/nodejs/node/tree/v10.x |
| v10.18.1-proposal | https://github.com/nodejs/node/tree/v10.18.1-proposal |
| Conversation | https://github.com/nodejs/node/pull/31248 |
| Commits16 (16) | https://github.com/nodejs/node/pull/31248/commits |
| Checks | https://github.com/nodejs/node/pull/31248/checks |
| Files changed | https://github.com/nodejs/node/pull/31248/files |
| v10.18.1 proposal | https://github.com/nodejs/node/pull/31248#top |
| BethGriggs | https://github.com/BethGriggs |
| v10.x | https://github.com/nodejs/node/tree/v10.x |
| v10.18.1-proposal | https://github.com/nodejs/node/tree/v10.18.1-proposal |
|
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issue-546358744 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| #30796 | https://github.com/nodejs/node/pull/30796 |
| @BethGriggs | https://github.com/BethGriggs |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| a80c59130e | https://github.com/nodejs/node/commit/a80c59130e |
| #28071 | https://github.com/nodejs/node/pull/28071 |
| 68b2b5cc51 | https://github.com/nodejs/node/commit/68b2b5cc51 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| 3e0709cf5e | https://github.com/nodejs/node/commit/3e0709cf5e |
| 25b8fbda35 | https://github.com/nodejs/node/commit/25b8fbda35 |
| #31086 | https://github.com/nodejs/node/pull/31086 |
| a1b095dd46 | https://github.com/nodejs/node/commit/a1b095dd46 |
| #31086 | https://github.com/nodejs/node/pull/31086 |
| 8f3b8ca515 | https://github.com/nodejs/node/commit/8f3b8ca515 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| 20f64a96de | https://github.com/nodejs/node/commit/20f64a96de |
| #29780 | https://github.com/nodejs/node/pull/29780 |
| 81c31005fd | https://github.com/nodejs/node/commit/81c31005fd |
| #24641 | https://github.com/nodejs/node/pull/24641 |
| 88e8b7cf83 | https://github.com/nodejs/node/commit/88e8b7cf83 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| 77e0318849 | https://github.com/nodejs/node/commit/77e0318849 |
| #29938 | https://github.com/nodejs/node/pull/29938 |
| 894aaa2040 | https://github.com/nodejs/node/commit/894aaa2040 |
| #30140 | https://github.com/nodejs/node/pull/30140 |
| 7e941eb17d | https://github.com/nodejs/node/commit/7e941eb17d |
| #25868 | https://github.com/nodejs/node/pull/25868 |
| 0f3ae77aaf | https://github.com/nodejs/node/commit/0f3ae77aaf |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| 4ae8d204cb | https://github.com/nodejs/node/commit/4ae8d204cb |
| #28458 | https://github.com/nodejs/node/pull/28458 |
| 4879b80d87 | https://github.com/nodejs/node/commit/4879b80d87 |
| #28458 | https://github.com/nodejs/node/pull/28458 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| saagarjha | https://github.com/saagarjha |
| December 17, 2019 17:08 | https://github.com/nodejs/node/pull/31248#commits-pushed-a80c591 |
|
| https://github.com/saagarjha |
|
| https://github.com/MylesBorins |
| build: fix configure script to work with Apple Clang 11 | https://github.com/nodejs/node/pull/31248/commits/a80c59130e92fa63cd61f782219448da33f3b6f9 |
| a80c591 | https://github.com/nodejs/node/pull/31248/commits/a80c59130e92fa63cd61f782219448da33f3b6f9 |
| #28071 | https://github.com/nodejs/node/pull/28071 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| tools: fix v8 testing with devtoolset on ppcle | https://github.com/nodejs/node/pull/31248/commits/4879b80d872205e21e2d609cbfd097e9f3b95f65 |
| 4879b80 | https://github.com/nodejs/node/pull/31248/commits/4879b80d872205e21e2d609cbfd097e9f3b95f65 |
| #28458 | https://github.com/nodejs/node/pull/28458 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| tools: move python code out of jenkins shell | https://github.com/nodejs/node/pull/31248/commits/4ae8d204cbb18829218e3987c8fd59803f4ccab0 |
| 4ae8d20 | https://github.com/nodejs/node/pull/31248/commits/4ae8d204cbb18829218e3987c8fd59803f4ccab0 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/configure | https://ci.nodejs.org/job/node-test-commit-v8-linux/configure |
| #28458 | https://github.com/nodejs/node/pull/28458 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| lib: fix comment nits in bootstrap\loaders.js | https://github.com/nodejs/node/pull/31248/commits/81c31005fdd779aadcd4585866162012db736762 |
| 81c3100 | https://github.com/nodejs/node/pull/31248/commits/81c31005fdd779aadcd4585866162012db736762 |
| #30338 | https://github.com/nodejs/node/pull/30338 |
| #24641 | https://github.com/nodejs/node/pull/24641 |
|
| https://github.com/MylesBorins |
| tools: update tzdata to 2019c | https://github.com/nodejs/node/pull/31248/commits/0f3ae77aaf01d0e5626668446bbcb1e66f408679 |
| 0f3ae77 | https://github.com/nodejs/node/pull/31248/commits/0f3ae77aaf01d0e5626668446bbcb1e66f408679 |
| #30211 | https://github.com/nodejs/node/issues/30211 |
| #30356 | https://github.com/nodejs/node/pull/30356 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
| deps: V8: backport fb63e5cf55e9 | https://github.com/nodejs/node/pull/31248/commits/3e0709cf5e7b6a44c9b84cb9144dd41ee54cb932 |
| 3e0709c | https://github.com/nodejs/node/pull/31248/commits/3e0709cf5e7b6a44c9b84cb9144dd41ee54cb932 |
| chromium:527926 | https://bugs.chromium.org/p/chromium/issues/detail?id=527926 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1529260 | https://chromium-review.googlesource.com/c/v8/v8/+/1529260 |
| #60379 | https://github.com/nodejs/node/pull/60379 |
| v8/v8@fb63e5c | https://github.com/v8/v8/commit/fb63e5cf55e93d7b4df51d3f382a6c84d25a5e86 |
| #30369 | https://github.com/nodejs/node/issues/30369 |
| #30372 | https://github.com/nodejs/node/pull/30372 |
|
| https://github.com/MylesBorins |
| n-api: correct bug in napi_get_last_error | https://github.com/nodejs/node/pull/31248/commits/88e8b7cf83353e575a1e1eb63f81a320002605a4 |
| 88e8b7c | https://github.com/nodejs/node/pull/31248/commits/88e8b7cf83353e575a1e1eb63f81a320002605a4 |
| #30532 | https://github.com/nodejs/node/pull/30532 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
|
| https://github.com/joaocgreis |
|
| https://github.com/MylesBorins |
| build,win: propagate error codes in vcbuild | https://github.com/nodejs/node/pull/31248/commits/68b2b5cc5110ada9876e33273b1801f1f8088cc5 |
| 68b2b5c | https://github.com/nodejs/node/pull/31248/commits/68b2b5cc5110ada9876e33273b1801f1f8088cc5 |
| #30726 | https://github.com/nodejs/node/pull/30726 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| nodejs/build#1996 | https://github.com/nodejs/build/issues/1996 |
|
| https://github.com/hashseed |
|
| https://github.com/MylesBorins |
| test: do not fail SLOW tests if they are not slow | https://github.com/nodejs/node/pull/31248/commits/7e941eb17db2f11c01062fbd09262c2a6a03ec80 |
| 7e941eb | https://github.com/nodejs/node/pull/31248/commits/7e941eb17db2f11c01062fbd09262c2a6a03ec80 |
| #25868 | https://github.com/nodejs/node/pull/25868 |
| #25867 | https://github.com/nodejs/node/issues/25867 |
|
| https://github.com/ZYSzys |
|
| https://github.com/MylesBorins |
| http2: use the latest settings | https://github.com/nodejs/node/pull/31248/commits/20f64a96de07bd588e81f8813440181d50097cbe |
| 20f64a9 | https://github.com/nodejs/node/pull/31248/commits/20f64a96de07bd588e81f8813440181d50097cbe |
| #29764 | https://github.com/nodejs/node/issues/29764 |
| #29780 | https://github.com/nodejs/node/pull/29780 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| stream: extract Readable.from in its own file | https://github.com/nodejs/node/pull/31248/commits/894aaa204011681676f5e6e021695a66c1588297 |
| 894aaa2 | https://github.com/nodejs/node/pull/31248/commits/894aaa204011681676f5e6e021695a66c1588297 |
| nodejs/readable-stream#420 | https://github.com/nodejs/readable-stream/pull/420 |
| #30140 | https://github.com/nodejs/node/pull/30140 |
|
| https://github.com/MylesBorins |
| http2: fix session memory accounting after pausing | https://github.com/nodejs/node/pull/31248/commits/8f3b8ca5156733a12ff3abbe8a277d42e02bceb2 |
| 8f3b8ca | https://github.com/nodejs/node/pull/31248/commits/8f3b8ca5156733a12ff3abbe8a277d42e02bceb2 |
| https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871 | https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871 |
| https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858 | https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858 |
| #29223 | https://github.com/nodejs/node/issues/29223 |
| 164ac5b | https://github.com/nodejs/node/commit/164ac5b241b96089e6bad5bb83ea416966b3245f |
| #30684 | https://github.com/nodejs/node/pull/30684 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
doc: allow in header elements | https://github.com/nodejs/node/pull/31248/commits/25b8fbda3512ce981ef53a7db298471c1fb646b6 |
| 25b8fbd | https://github.com/nodejs/node/pull/31248/commits/25b8fbda3512ce981ef53a7db298471c1fb646b6 |
| #31109 | https://github.com/nodejs/node/pull/31109 |
| #31086 | https://github.com/nodejs/node/pull/31086 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc,dns: use code markup/markdown in headers | https://github.com/nodejs/node/pull/31248/commits/a1b095dd46c69e548243e14ce32b19503eb79267 |
| a1b095d | https://github.com/nodejs/node/pull/31248/commits/a1b095dd46c69e548243e14ce32b19503eb79267 |
| #31109 | https://github.com/nodejs/node/pull/31109 |
| #31086 | https://github.com/nodejs/node/pull/31086 |
|
| https://github.com/ronag |
|
| https://github.com/BethGriggs |
| stream: increase MAX_HWM | https://github.com/nodejs/node/pull/31248/commits/77e0318849aa229b24bb5f30d3a919d8e133c226 |
| 77e0318 | https://github.com/nodejs/node/pull/31248/commits/77e0318849aa229b24bb5f30d3a919d8e133c226 |
| 9208c89 | https://github.com/nodejs/node/commit/9208c890582305218716a2bdadb7461ef24f5830 |
| #29933 | https://github.com/nodejs/node/issues/29933 |
| #29938 | https://github.com/nodejs/node/pull/29938 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#event-2928104346 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/31248#ref-pullrequest-532977448 |
|
v10.18.1 proposal
#30796
| https://github.com/nodejs/node/pull/30796 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-b189fd4 |
|
| https://github.com/BethGriggs |
| 2020-01-07, Version 10.18.1 'Dubnium' (LTS) | https://github.com/nodejs/node/commit/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
| b189fd4 | https://github.com/nodejs/node/commit/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #31248 | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/8dd60621159cf31261e654a36d78d07d42014b4f..b189fd429ec89bd8a5984a39061f4549b4efaf2e |
| 8dd6062 | https://github.com/nodejs/node/commit/8dd60621159cf31261e654a36d78d07d42014b4f |
| b189fd4 | https://github.com/nodejs/node/commit/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
|
Compare
| https://github.com/nodejs/node/compare/8dd60621159cf31261e654a36d78d07d42014b4f..b189fd429ec89bd8a5984a39061f4549b4efaf2e |
| January 7, 2020 15:52 | https://github.com/nodejs/node/pull/31248#event-2928116154 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/31248#pullrequestreview-339391180 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31248/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571690763 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571706554 |
| https://ci.nodejs.org/job/node-test-pull-request/28258/ | https://ci.nodejs.org/job/node-test-pull-request/28258/ |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571750742 |
| #28840 | https://github.com/nodejs/node/pull/28840 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571776515 |
| @BridgeAR | https://github.com/BridgeAR |
| #28840 | https://github.com/nodejs/node/pull/28840 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571801027 |
| https://ci.nodejs.org/job/node-test-pull-request/28272/ | https://ci.nodejs.org/job/node-test-pull-request/28272/ |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jan 7, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571820236 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2199/console | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2199/console |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2198/console | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2198/console |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 8, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-571921747 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| @BethGriggs | https://github.com/BethGriggs |
| #30537 | https://github.com/nodejs/node/pull/30537 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Jan 8, 2020
| https://github.com/nodejs/node/pull/31248#pullrequestreview-339717817 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31248/files |
| https://github.com/patilharshal16 |
| patilharshal16 | https://github.com/patilharshal16 |
|
Jan 8, 2020
| https://github.com/nodejs/node/pull/31248#pullrequestreview-339759685 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31248/files |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/b189fd429ec89bd8a5984a39061f4549b4efaf2e..56a206e53cd692e5b4556d0666d6d626d7990f0c |
| b189fd4 | https://github.com/nodejs/node/commit/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
| 56a206e | https://github.com/nodejs/node/commit/56a206e53cd692e5b4556d0666d6d626d7990f0c |
|
Compare
| https://github.com/nodejs/node/compare/b189fd429ec89bd8a5984a39061f4549b4efaf2e..56a206e53cd692e5b4556d0666d6d626d7990f0c |
| January 8, 2020 17:52 | https://github.com/nodejs/node/pull/31248#event-2932159637 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 8, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-572185211 |
| https://ci.nodejs.org/job/node-test-pull-request/28301/ | https://ci.nodejs.org/job/node-test-pull-request/28301/ |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| January 8, 2020 18:06 | https://github.com/nodejs/node/pull/31248#event-2932197417 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 8, 2020
| https://github.com/nodejs/node/pull/31248#pullrequestreview-340047216 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31248/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/31248#pullrequestreview-340047216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 8, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-76b7cb4 |
|
| https://github.com/BethGriggs |
| 2020-01-08, Version 10.18.1 'Dubnium' (LTS) | https://github.com/nodejs/node/commit/76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
| 76b7cb4 | https://github.com/nodejs/node/commit/76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #31248 | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/56a206e53cd692e5b4556d0666d6d626d7990f0c..76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
| 56a206e | https://github.com/nodejs/node/commit/56a206e53cd692e5b4556d0666d6d626d7990f0c |
| 76b7cb4 | https://github.com/nodejs/node/commit/76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
|
Compare
| https://github.com/nodejs/node/compare/56a206e53cd692e5b4556d0666d6d626d7990f0c..76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
| January 8, 2020 20:35 | https://github.com/nodejs/node/pull/31248#event-2932637260 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 8, 2020
| https://github.com/nodejs/node/pull/31248#ref-issue-547066219 |
|
Some platforms failing to run CITGM
nodejs/citgm#779
| https://github.com/nodejs/citgm/issues/779 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jan 8, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-572261696 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs/Release#504 | https://github.com/nodejs/Release/issues/504 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Jan 8, 2020 | https://github.com/nodejs/node/pull/31248#issuecomment-572311248 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
| nodejs/citgm#779 | https://github.com/nodejs/citgm/issues/779 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
|
| https://github.com/BethGriggs |
| 2020-01-09, Version 10.18.1 'Dubnium' (LTS) | https://github.com/nodejs/node/pull/31248/commits/8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
| 8d5e286 | https://github.com/nodejs/node/pull/31248/commits/8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #31248 | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/76b7cb48dd26428a154c45c9b78b2acc24cb77f7..8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
| 76b7cb4 | https://github.com/nodejs/node/commit/76b7cb48dd26428a154c45c9b78b2acc24cb77f7 |
| 8d5e286 | https://github.com/nodejs/node/commit/8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
|
Compare
| https://github.com/nodejs/node/compare/76b7cb48dd26428a154c45c9b78b2acc24cb77f7..8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
| January 9, 2020 11:07 | https://github.com/nodejs/node/pull/31248#event-2934540720 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| 8d5e286 | https://github.com/nodejs/node/commit/8d5e286872c8587dcafffcabce3edc64d2bdcfc5 |
| Jan 9, 2020 | https://github.com/nodejs/node/pull/31248#event-2936572625 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 9, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-84eec80 |
|
| https://github.com/BethGriggs |
| Working on v10.18.2 | https://github.com/nodejs/node/commit/84eec80f84e9752dd07e293c7aa3d852918f3350 |
| 84eec80 | https://github.com/nodejs/node/commit/84eec80f84e9752dd07e293c7aa3d852918f3350 |
| #31248 | https://github.com/nodejs/node/pull/31248 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 9, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-9d5d4f8 |
|
| https://github.com/BethGriggs |
| 2020-01-09, Version 10.18.1 'Dubnium' (LTS) | https://github.com/nodejs/node/commit/9d5d4f84e3a54fc585276fd5a74ff592783be6ff |
| 9d5d4f8 | https://github.com/nodejs/node/commit/9d5d4f84e3a54fc585276fd5a74ff592783be6ff |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #30684 | https://github.com/nodejs/node/pull/30684 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #28702 | https://github.com/nodejs/node/pull/28702 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #30479 | https://github.com/nodejs/node/pull/30479 |
| #31248 | https://github.com/nodejs/node/pull/31248 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 9, 2020
| https://github.com/nodejs/node/pull/31248#ref-pullrequest-547746792 |
|
Blog: v10.18.1 release post
nodejs/nodejs.org#2887
| https://github.com/nodejs/nodejs.org/pull/2887 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 9, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-56ac75d |
|
| https://github.com/BethGriggs |
| Blog: v10.18.1 release post | https://github.com/BethGriggs/nodejs.org/commit/56ac75d03a6aff3ea98f91657ea1113c3552b82d |
| 56ac75d | https://github.com/BethGriggs/nodejs.org/commit/56ac75d03a6aff3ea98f91657ea1113c3552b82d |
| nodejs/node#31248 | https://github.com/nodejs/node/pull/31248 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 9, 2020
| https://github.com/nodejs/node/pull/31248#ref-commit-2b34c33 |
|
| https://github.com/BethGriggs |
| Blog: v10.18.1 release post ( | https://github.com/nodejs/nodejs.org/commit/2b34c3333941897ba28363b1a00bb22eb96a6756 |
| #2887 | https://github.com/nodejs/nodejs.org/pull/2887 |
| ) | https://github.com/nodejs/nodejs.org/commit/2b34c3333941897ba28363b1a00bb22eb96a6756 |
| 2b34c33 | https://github.com/nodejs/nodejs.org/commit/2b34c3333941897ba28363b1a00bb22eb96a6756 |
| nodejs/node#31248 | https://github.com/nodejs/node/pull/31248 |
| https://github.com/targos |
| targos | https://github.com/targos |
| January 10, 2020 07:26 | https://github.com/nodejs/node/pull/31248#event-2937545367 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 27, 2020
| https://github.com/nodejs/node/pull/31248#ref-issue-521327317 |
|
toLocaleDateString() with option { hour: '2-digit' } returns single digit hour
#30369
| https://github.com/nodejs/node/issues/30369 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31248 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/31248/files/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/31248/files/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/31248/files/56a206e53cd692e5b4556d0666d6d626d7990f0c |
|
| https://github.com/patilharshal16 |
|
patilharshal16
| https://github.com/patilharshal16 |
|
| https://github.com/nodejs/node/pull/31248/files/b189fd429ec89bd8a5984a39061f4549b4efaf2e |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/31248 |
|
| https://github.com/BethGriggs |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BridgeAR |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/gengjiawen |
|
| https://github.com/patilharshal16 |
|
| https://github.com/saagarjha |
|
| https://github.com/sam-github |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
|
| https://github.com/targos |
|
| https://github.com/joaocgreis |
|
| https://github.com/hashseed |
|
| https://github.com/ZYSzys |
|
| https://github.com/mcollina |
|
| https://github.com/Trott |
|
| https://github.com/ronag |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |