René's URL Explorer Experiment


Title: [v12 backport] lib: no need to strip BOM or shebang for scripts by aduh95 · Pull Request #31228 · nodejs/node · GitHub

Open Graph Title: [v12 backport] lib: no need to strip BOM or shebang for scripts by aduh95 · Pull Request #31228 · nodejs/node

X Title: [v12 backport] lib: no need to strip BOM or shebang for scripts by aduh95 · Pull Request #31228 · nodejs/node

Description: Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade). EDIT: I get this part wrong... As of V8 7.4, V8 implements the Hashbang...

Open Graph Description: Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade). EDIT: I get this part wrong... As of V8 7.4, V8 implements the Hash...

X Description: Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade). EDIT: I get this part wrong... As of V8 7.4, V8 implements the ...

Opengraph URL: https://github.com/nodejs/node/pull/31228

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:111d0391-2be7-aa5a-73a7-146416e70c9a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE53C:134C26:483C77:623D07:696AA93B
html-safe-noncebbef37ae71a453e8dba1730aea3ebd4fb493dcc7f2489967e135f3cf1c8c9d99
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTNDOjEzNEMyNjo0ODNDNzc6NjIzRDA3OjY5NkFBOTNCIiwidmlzaXRvcl9pZCI6Ijc2MTk4OTM5NDc2NzY2NjYxNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac728b78137b7f822847ac29502b721582c1caa08289047008877b4c56e1793cae
hovercard-subject-tagpull_request:359691788
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31228/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce90bf5e87b6f928d14be2f3db6e04c6a09f2e8cc0f365101cc32dce0783352f/nodejs/node/pull/31228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce90bf5e87b6f928d14be2f3db6e04c6a09f2e8cc0f365101cc32dce0783352f/nodejs/node/pull/31228
og:image:altNode.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade). EDIT: I get this part wrong... As of V8 7.4, V8 implements the Hash...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/31228#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31228
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31228
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/31228
Reloadhttps://github.com/nodejs/node/pull/31228
Reloadhttps://github.com/nodejs/node/pull/31228
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/31228
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/31228
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/31228#issue-comment-box
aduh95https://github.com/aduh95
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
aduh95:backport-27768-to-erbiumhttps://github.com/aduh95/node/tree/backport-27768-to-erbium
[v12 backport] lib: no need to strip BOM or shebang for scripts https://github.com/nodejs/node/pull/31228#top
aduh95https://github.com/aduh95
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
aduh95:backport-27768-to-erbiumhttps://github.com/aduh95/node/tree/backport-27768-to-erbium
Conversation 7 https://github.com/nodejs/node/pull/31228
Commits 2 https://github.com/nodejs/node/pull/31228/commits
Checks 0 https://github.com/nodejs/node/pull/31228/checks
Files changed https://github.com/nodejs/node/pull/31228/files
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 6, 2020https://github.com/nodejs/node/pull/31228#issue-545912662
Please reload this pagehttps://github.com/nodejs/node/pull/31228
702331bhttps://github.com/nodejs/node/commit/702331be906fe58e0ef66c7b31c7d2aeb3af3421
Hashbang Grammarhttps://github.com/tc39/proposal-hashbang
702331bhttps://github.com/nodejs/node/commit/702331be906fe58e0ef66c7b31c7d2aeb3af3421
#27768https://github.com/nodejs/node/pull/27768
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
Jan 6, 2020https://github.com/nodejs/node/pull/31228#event-2925404503
https://github.com/devsnek
https://github.com/aduh95
lib: rework logic of stripping BOM+Shebang from commonjshttps://github.com/nodejs/node/pull/31228/commits/eb383650e481ff33b5f7d3b45913e44d60443ebc
eb38365https://github.com/nodejs/node/pull/31228/commits/eb383650e481ff33b5f7d3b45913e44d60443ebc
nodejs#27767https://github.com/nodejs/node/issues/27767
nodejs#27768https://github.com/nodejs/node/pull/27768
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/978378ff8fe28ad4bfa6ac36b22645ddc708d0be..6667b450617db0aa7666f2beef8df5355deac50d
978378fhttps://github.com/nodejs/node/commit/978378ff8fe28ad4bfa6ac36b22645ddc708d0be
6667b45https://github.com/nodejs/node/commit/6667b450617db0aa7666f2beef8df5355deac50d
Compare https://github.com/nodejs/node/compare/978378ff8fe28ad4bfa6ac36b22645ddc708d0be..6667b450617db0aa7666f2beef8df5355deac50d
January 6, 2020 22:31https://github.com/nodejs/node/pull/31228#event-2925798182
https://github.com/refack
https://github.com/aduh95
lib: no need to strip BOM or shebang for scriptshttps://github.com/nodejs/node/pull/31228/commits/7100e239fcdc3bd15adaf985923257fe42a60425
7100e23https://github.com/nodejs/node/pull/31228/commits/7100e239fcdc3bd15adaf985923257fe42a60425
nodejs#27375https://github.com/nodejs/node/pull/27375
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/6667b450617db0aa7666f2beef8df5355deac50d..7100e239fcdc3bd15adaf985923257fe42a60425
6667b45https://github.com/nodejs/node/commit/6667b450617db0aa7666f2beef8df5355deac50d
7100e23https://github.com/nodejs/node/commit/7100e239fcdc3bd15adaf985923257fe42a60425
Compare https://github.com/nodejs/node/compare/6667b450617db0aa7666f2beef8df5355deac50d..7100e239fcdc3bd15adaf985923257fe42a60425
January 6, 2020 23:27https://github.com/nodejs/node/pull/31228#event-2925912715
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 7, 2020 https://github.com/nodejs/node/pull/31228#ref-pullrequest-546226883
[v12 backport] vm: add Synthetic modules #31241 https://github.com/nodejs/node/pull/31241
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 7, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571723174
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 7, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571723240
https://ci.nodejs.org/job/node-test-pull-request/28259/https://ci.nodejs.org/job/node-test-pull-request/28259/
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/targos
targoshttps://github.com/targos
Jan 7, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571728283
#27768https://github.com/nodejs/node/pull/27768
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/targos
targoshttps://github.com/targos
Jan 7, 2020https://github.com/nodejs/node/pull/31228#event-2928737249
https://github.com/targos
targoshttps://github.com/targos
Jan 7, 2020https://github.com/nodejs/node/pull/31228#event-2928737438
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571854793
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571855167
@targoshttps://github.com/targos
#28005https://github.com/nodejs/node/pull/28005
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#ref-pullrequest-445778071
lib: rework logic of stripping BOM+Shebang from commonjs #27768 https://github.com/nodejs/node/pull/27768
https://github.com/targos
targoshttps://github.com/targos
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#pullrequestreview-339710056
View reviewed changes https://github.com/nodejs/node/pull/31228/files/7100e239fcdc3bd15adaf985923257fe42a60425
https://github.com/targos
targoshttps://github.com/targos
Jan 8, 2020https://github.com/nodejs/node/pull/31228#issuecomment-571945901
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/targos
targoshttps://github.com/targos
Jan 8, 2020https://github.com/nodejs/node/pull/31228#issuecomment-572079821
Please reload this pagehttps://github.com/nodejs/node/pull/31228
3645b1bhttps://github.com/nodejs/node/commit/3645b1b4ed44a71e6ab9e6852ce959be0e08ab5e
4c6bcdahttps://github.com/nodejs/node/commit/4c6bcdac8c7e5ffc9dd70c5afac2e818b9b3f794
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/targos
targoshttps://github.com/targos
Jan 8, 2020https://github.com/nodejs/node/pull/31228#event-2931376595
targoshttps://github.com/targos
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-3645b1b
https://github.com/devsnek
https://github.com/targos
lib: rework logic of stripping BOM+Shebang from commonjshttps://github.com/nodejs/node/commit/3645b1b4ed44a71e6ab9e6852ce959be0e08ab5e
3645b1bhttps://github.com/nodejs/node/commit/3645b1b4ed44a71e6ab9e6852ce959be0e08ab5e
#27767https://github.com/nodejs/node/issues/27767
#31228https://github.com/nodejs/node/pull/31228
#27768https://github.com/nodejs/node/pull/27768
targoshttps://github.com/targos
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-4c6bcda
https://github.com/refack
https://github.com/targos
lib: no need to strip BOM or shebang for scriptshttps://github.com/nodejs/node/commit/4c6bcdac8c7e5ffc9dd70c5afac2e818b9b3f794
4c6bcdahttps://github.com/nodejs/node/commit/4c6bcdac8c7e5ffc9dd70c5afac2e818b9b3f794
#31228https://github.com/nodejs/node/pull/31228
#27375https://github.com/nodejs/node/pull/27375
targoshttps://github.com/targos
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-6c34ad6
https://github.com/devsnek
https://github.com/targos
lib: rework logic of stripping BOM+Shebang from commonjshttps://github.com/nodejs/node/commit/6c34ad6c66a104d92d65537f1d70c2fb8a53422e
6c34ad6https://github.com/nodejs/node/commit/6c34ad6c66a104d92d65537f1d70c2fb8a53422e
#27767https://github.com/nodejs/node/issues/27767
#31228https://github.com/nodejs/node/pull/31228
#27768https://github.com/nodejs/node/pull/27768
targoshttps://github.com/targos
Jan 8, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-b743f2c
https://github.com/refack
https://github.com/targos
lib: no need to strip BOM or shebang for scriptshttps://github.com/nodejs/node/commit/b743f2c34343650f6807ffab33ad5b0646cfff35
b743f2chttps://github.com/nodejs/node/commit/b743f2c34343650f6807ffab33ad5b0646cfff35
#31228https://github.com/nodejs/node/pull/31228
#27375https://github.com/nodejs/node/pull/27375
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-1c50714
https://github.com/devsnek
https://github.com/BethGriggs
lib: rework logic of stripping BOM+Shebang from commonjshttps://github.com/nodejs/node/commit/1c50714729bef0db31a9ca814c0c5b600d360e4e
1c50714https://github.com/nodejs/node/commit/1c50714729bef0db31a9ca814c0c5b600d360e4e
#27767https://github.com/nodejs/node/issues/27767
#31228https://github.com/nodejs/node/pull/31228
#27768https://github.com/nodejs/node/pull/27768
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/31228#ref-commit-bcd27f7
https://github.com/refack
https://github.com/BethGriggs
lib: no need to strip BOM or shebang for scriptshttps://github.com/nodejs/node/commit/bcd27f730085ba4460990ed9aeaee5f389d58956
bcd27f7https://github.com/nodejs/node/commit/bcd27f730085ba4460990ed9aeaee5f389d58956
#31228https://github.com/nodejs/node/pull/31228
#27375https://github.com/nodejs/node/pull/27375
https://github.com/aduh95
aduh95https://github.com/aduh95
November 14, 2020 11:14https://github.com/nodejs/node/pull/31228#event-3996333347
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31228
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/31228/files/7100e239fcdc3bd15adaf985923257fe42a60425
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/31228
https://github.com/aduh95
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/devsnek
https://github.com/refack
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.