| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:26d139f5-7a6e-9afe-707e-be1ccd81d2ae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 975C:D9BB8:2D631E3:3CD8C16:6992F1AE |
| html-safe-nonce | 4857ee23fa24d752fa8f3301e2662253cc32628081ce6625cf7d22856bfa490d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzVDOkQ5QkI4OjJENjMxRTM6M0NEOEMxNjo2OTkyRjFBRSIsInZpc2l0b3JfaWQiOiI0NDgzNTU0NjY4ODc4OTUwODMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a7855c8aece78afae16be37e61867fd7d0c9305c06ef757f7592afc5e5593acd |
| hovercard-subject-tag | pull_request:356208316 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/31064/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2159cc6828e5852d00a1fea28f7bd6b984257cae4e3705c775ce447aec1e0cbc/nodejs/node/pull/31064 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2159cc6828e5852d00a1fea28f7bd6b984257cae4e3705c775ce447aec1e0cbc/nodejs/node/pull/31064 |
| og:image:alt | Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.
Fixes: #31019
Checklist
make -j4 test (UN... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dev-script |
| hostname | github.com |
| expected-hostname | github.com |
| None | 348cc0594c4976eb4050dc9547ecf65057ee89a2b7ed0652b983b9b539f57145 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ce72317238c729e85014e1d867fd30d09b7f94ba |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/31064#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31064 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31064 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/31064 |
| Reload | https://github.com/nodejs/node/pull/31064 |
| Reload | https://github.com/nodejs/node/pull/31064 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/31064 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| dev-script | https://github.com/dev-script |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/31064 |
| Commits1 (1) | https://github.com/nodejs/node/pull/31064/commits |
| Checks | https://github.com/nodejs/node/pull/31064/checks |
| Files changed | https://github.com/nodejs/node/pull/31064/files |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/pull/31064#top |
| dev-script | https://github.com/dev-script |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/dev-script |
| dev-script | https://github.com/dev-script |
| Dec 23, 2019 | https://github.com/nodejs/node/pull/31064#issue-541611012 |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/31064 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Dec 23, 2019 | https://github.com/nodejs/node/pull/31064#event-2903979490 |
|
| https://github.com/dev-script |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/pull/31064/commits/9e86e25fc065abd293e2399b773d578b83897a2f |
| 9e86e25 | https://github.com/nodejs/node/pull/31064/commits/9e86e25fc065abd293e2399b773d578b83897a2f |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/31064#pullrequestreview-335788110 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/31064#pullrequestreview-335875738 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/31064#pullrequestreview-335889389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Dec 23, 2019 | https://github.com/nodejs/node/pull/31064#issuecomment-568496848 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4113/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4113/ |
| Please reload this page | https://github.com/nodejs/node/pull/31064 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 23, 2019 | https://github.com/nodejs/node/pull/31064#event-2904965553 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 24, 2019
| https://github.com/nodejs/node/pull/31064#pullrequestreview-336233136 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 25, 2019
| https://github.com/nodejs/node/pull/31064#ref-commit-5661466 |
|
| https://github.com/dev-script |
|
| https://github.com/BridgeAR |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/commit/5661466921d18e04bcac766b9aea0c0f158c952e |
| 5661466 | https://github.com/nodejs/node/commit/5661466921d18e04bcac766b9aea0c0f158c952e |
| #31064 | https://github.com/nodejs/node/pull/31064 |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 25, 2019 | https://github.com/nodejs/node/pull/31064#issuecomment-568886463 |
| 5661466 | https://github.com/nodejs/node/commit/5661466921d18e04bcac766b9aea0c0f158c952e |
| Please reload this page | https://github.com/nodejs/node/pull/31064 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 25, 2019 | https://github.com/nodejs/node/pull/31064#event-2907898677 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 3, 2020
| https://github.com/nodejs/node/pull/31064#ref-commit-9141366 |
|
| https://github.com/dev-script |
|
| https://github.com/BridgeAR |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/commit/9141366e097cabbc89ac74b87e831eae8e08d597 |
| 9141366 | https://github.com/nodejs/node/commit/9141366e097cabbc89ac74b87e831eae8e08d597 |
| #31064 | https://github.com/nodejs/node/pull/31064 |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/31064#ref-pullrequest-546134970 |
|
v13.6.0 proposal
#31238
| https://github.com/nodejs/node/pull/31238 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/31064#ref-commit-1f0a1d5 |
|
| https://github.com/dev-script |
|
| https://github.com/targos |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/commit/1f0a1d5bbba7cef1c0729b304c78c9d81afb49a7 |
| 1f0a1d5 | https://github.com/nodejs/node/commit/1f0a1d5bbba7cef1c0729b304c78c9d81afb49a7 |
| #31064 | https://github.com/nodejs/node/pull/31064 |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/31064#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/31064#ref-commit-f099494 |
|
| https://github.com/dev-script |
|
| https://github.com/BethGriggs |
| doc: improve doc net:server.listen | https://github.com/nodejs/node/commit/f0994940f0cd3c4157ad2c6908203c903077bdf2 |
| f099494 | https://github.com/nodejs/node/commit/f0994940f0cd3c4157ad2c6908203c903077bdf2 |
| #31064 | https://github.com/nodejs/node/pull/31064 |
| #31019 | https://github.com/nodejs/node/issues/31019 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/31064#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F31064 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/31064/files/9e86e25fc065abd293e2399b773d578b83897a2f |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
Documentation is not clear enough regarding parameters in callback
| https://github.com/nodejs/node/issues/31019 |
| Please reload this page | https://github.com/nodejs/node/pull/31064 |
|
| https://github.com/dev-script |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |