| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fd08f4cf-f420-2991-c855-00f06fe47418 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B900:284E5C:10149B7:163F038:696A8C0D |
| html-safe-nonce | 6a3104b497c75062dddeec6ec21c8e6a1245afa2df56ed17aebdc9e242eead2b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTAwOjI4NEU1QzoxMDE0OUI3OjE2M0YwMzg6Njk2QThDMEQiLCJ2aXNpdG9yX2lkIjoiOTA0ODM4NTgwMjQ0NDkwMTM4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9bd85bf5dd89802b9bc3e06e3870eb7c0e4afc20146b3798e4a024463de656cf |
| hovercard-subject-tag | pull_request:353270983 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30977/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/452eb5ce70da98af0976f9165aac87506a1db0f98b89fe050ba8246ca3aa2cc1/nodejs/node/pull/30977 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/452eb5ce70da98af0976f9165aac87506a1db0f98b89fe050ba8246ca3aa2cc1/nodejs/node/pull/30977 |
| og:image:alt | Make manywrites benchmark a bit more realistic by taking backpressure into account. Otherwise memory usage would no correspond well with real world usage.
Checklist
make -j4 test (UNIX), or vcb... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30977#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30977 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30977 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30977 |
| Reload | https://github.com/nodejs/node/pull/30977 |
| Reload | https://github.com/nodejs/node/pull/30977 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/30977#issue-comment-box |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:manywrites-backpressuse | https://github.com/nxtedition/node/tree/manywrites-backpressuse |
|
benchmark: manywrites backpressure
| https://github.com/nodejs/node/pull/30977#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:manywrites-backpressuse | https://github.com/nxtedition/node/tree/manywrites-backpressuse |
|
Conversation
7
| https://github.com/nodejs/node/pull/30977 |
|
Commits
1
| https://github.com/nodejs/node/pull/30977/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/30977/checks |
|
Files changed
| https://github.com/nodejs/node/pull/30977/files |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#issue-538046269 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#event-2883957641 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#event-2883957982 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 15, 2019
| https://github.com/nodejs/node/pull/30977#pullrequestreview-332263612 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30977/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 15, 2019
| https://github.com/nodejs/node/pull/30977#pullrequestreview-332269691 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30977/files |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-565817999 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-565818249 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
|
| https://github.com/ronag |
| benchmark: manywrites back pressure | https://github.com/nodejs/node/pull/30977/commits/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| b06f8fe | https://github.com/nodejs/node/pull/30977/commits/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/45cfb45147be01e40c4e94180e54b66a2db13779..b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| 45cfb45 | https://github.com/nodejs/node/commit/45cfb45147be01e40c4e94180e54b66a2db13779 |
| b06f8fe | https://github.com/nodejs/node/commit/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
|
Compare
| https://github.com/nodejs/node/compare/45cfb45147be01e40c4e94180e54b66a2db13779..b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| December 15, 2019 15:14 | https://github.com/nodejs/node/pull/30977#event-2884037177 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Dec 15, 2019 | https://github.com/nodejs/node/pull/30977#event-2884133399 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 16, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-566214204 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 16, 2019
| https://github.com/nodejs/node/pull/30977#pullrequestreview-332821818 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30977/files/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30977#pullrequestreview-333043440 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30977/files/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-566567223 |
| https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10986/ | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10986/ |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 17, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-566567527 |
| https://ci.nodejs.org/job/node-test-pull-request/27764/ | https://ci.nodejs.org/job/node-test-pull-request/27764/ |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 17, 2019 | https://github.com/nodejs/node/pull/30977#event-2890080270 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 17, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-566684372 |
| https://ci.nodejs.org/job/node-test-pull-request/27770/ | https://ci.nodejs.org/job/node-test-pull-request/27770/ |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 18, 2019 | https://github.com/nodejs/node/pull/30977#issuecomment-566827151 |
| ea86f8c | https://github.com/nodejs/node/commit/ea86f8c902e13d8cff0e01007ed0d978f59fe132 |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 18, 2019 | https://github.com/nodejs/node/pull/30977#event-2891921836 |
| Trott | https://github.com/Trott |
|
Dec 18, 2019
| https://github.com/nodejs/node/pull/30977#ref-commit-ea86f8c |
|
| https://github.com/ronag |
|
| https://github.com/Trott |
| benchmark: update manywrites back pressure | https://github.com/nodejs/node/commit/ea86f8c902e13d8cff0e01007ed0d978f59fe132 |
| ea86f8c | https://github.com/nodejs/node/commit/ea86f8c902e13d8cff0e01007ed0d978f59fe132 |
| #30977 | https://github.com/nodejs/node/pull/30977 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 3, 2020
| https://github.com/nodejs/node/pull/30977#ref-commit-0e864a3 |
|
| https://github.com/ronag |
|
| https://github.com/BridgeAR |
| benchmark: update manywrites back pressure | https://github.com/nodejs/node/commit/0e864a383c80aa1da0937d165fcd33bdbf729dfb |
| 0e864a3 | https://github.com/nodejs/node/commit/0e864a383c80aa1da0937d165fcd33bdbf729dfb |
| #30977 | https://github.com/nodejs/node/pull/30977 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/30977#ref-pullrequest-546134970 |
|
v13.6.0 proposal
#31238
| https://github.com/nodejs/node/pull/31238 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/30977#ref-commit-1333798 |
|
| https://github.com/ronag |
|
| https://github.com/targos |
| benchmark: update manywrites back pressure | https://github.com/nodejs/node/commit/13337985f7eff823bcc7d0f48ddd23e0eaefd4b1 |
| 1333798 | https://github.com/nodejs/node/commit/13337985f7eff823bcc7d0f48ddd23e0eaefd4b1 |
| #30977 | https://github.com/nodejs/node/pull/30977 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/30977#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/30977#ref-commit-d5bebc3 |
|
| https://github.com/ronag |
|
| https://github.com/BethGriggs |
| benchmark: update manywrites back pressure | https://github.com/nodejs/node/commit/d5bebc3be884e537462ebe93884b7264cb2509ff |
| d5bebc3 | https://github.com/nodejs/node/commit/d5bebc3be884e537462ebe93884b7264cb2509ff |
| #30977 | https://github.com/nodejs/node/pull/30977 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/30977#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30977 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/30977/files/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/30977/files/45cfb45147be01e40c4e94180e54b66a2db13779 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30977/files/e21bb8d9e250639648cf4328200928052510580f |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/30977/files/b06f8fe0b96449f85d5ad50d77980a63c45865ca |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/30977 |
|
| https://github.com/ronag |
|
| https://github.com/lpinca |
|
| https://github.com/Fishrock123 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |