René's URL Explorer Experiment


Title: test: improve WASI start() coverage by cjihrig · Pull Request #30972 · nodejs/node · GitHub

Open Graph Title: test: improve WASI start() coverage by cjihrig · Pull Request #30972 · nodejs/node

X Title: test: improve WASI start() coverage by cjihrig · Pull Request #30972 · nodejs/node

Description: This PR should get the WASI start() JS test coverage to 100%. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...

Open Graph Description: This PR should get the WASI start() JS test coverage to 100%. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...

X Description: This PR should get the WASI start() JS test coverage to 100%. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...

Opengraph URL: https://github.com/nodejs/node/pull/30972

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1ce76e62-b59d-a53b-1b67-6da383035064
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8972:64491:10EAAB7:1767B5B:696A8C2F
html-safe-nonce053e50305a8a95d271c9b587c70027b827026ffedce1a58c19ff8f9523d10742
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTcyOjY0NDkxOjEwRUFBQjc6MTc2N0I1Qjo2OTZBOEMyRiIsInZpc2l0b3JfaWQiOiI0Mjg2MzUzOTk0MjU5NTMyODQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacff57a9e480bf5e3a695821f4214bafa95c20b90923046e43692944283502f0df
hovercard-subject-tagpull_request:353231185
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30972/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2bf62bf47d3b87cbfcf58c04a8fa62ec262d20f7fdec35e7f0e4cd6f1410f9b0/nodejs/node/pull/30972
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2bf62bf47d3b87cbfcf58c04a8fa62ec262d20f7fdec35e7f0e4cd6f1410f9b0/nodejs/node/pull/30972
og:image:altThis PR should get the WASI start() JS test coverage to 100%. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30972#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30972
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30972
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30972
Reloadhttps://github.com/nodejs/node/pull/30972
Reloadhttps://github.com/nodejs/node/pull/30972
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30972
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30972
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30972#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:wasi-start-covhttps://github.com/cjihrig/node/tree/wasi-start-cov
test: improve WASI start() coverage https://github.com/nodejs/node/pull/30972#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:wasi-start-covhttps://github.com/cjihrig/node/tree/wasi-start-cov
Conversation 2 https://github.com/nodejs/node/pull/30972
Commits 2 https://github.com/nodejs/node/pull/30972/commits
Checks 0 https://github.com/nodejs/node/pull/30972/checks
Files changed https://github.com/nodejs/node/pull/30972/files
Please reload this pagehttps://github.com/nodejs/node/pull/30972
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 15, 2019https://github.com/nodejs/node/pull/30972#issue-537991058
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30972
cjihrighttps://github.com/cjihrig
December 14, 2019 20:59https://github.com/nodejs/node/pull/30972#commits-pushed-047ed0a
https://github.com/cjihrig
test: improve WASI start() coveragehttps://github.com/nodejs/node/pull/30972/commits/047ed0a830ca6d22c17e803c8827e7863c7b1e6b
047ed0ahttps://github.com/nodejs/node/pull/30972/commits/047ed0a830ca6d22c17e803c8827e7863c7b1e6b
https://github.com/cjihrig
test: simplify test-wasi-start-validation.jshttps://github.com/nodejs/node/pull/30972/commits/f5540d594196ef9ff96ef13626e3c25fd61730c0
f5540d5https://github.com/nodejs/node/pull/30972/commits/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 15, 2019https://github.com/nodejs/node/pull/30972#event-2883719652
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
wasm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasm
Dec 15, 2019https://github.com/nodejs/node/pull/30972#event-2883776231
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Dec 15, 2019 https://github.com/nodejs/node/pull/30972#pullrequestreview-332243797
View reviewed changes https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Dec 15, 2019 https://github.com/nodejs/node/pull/30972#pullrequestreview-332243800
View reviewed changes https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 15, 2019https://github.com/nodejs/node/pull/30972#issuecomment-565779227
Please reload this pagehttps://github.com/nodejs/node/pull/30972
https://ci.nodejs.org/job/node-test-pull-request/27704/https://ci.nodejs.org/job/node-test-pull-request/27704/
Please reload this pagehttps://github.com/nodejs/node/pull/30972
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 15, 2019 https://github.com/nodejs/node/pull/30972#pullrequestreview-332243889
View reviewed changes https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 15, 2019https://github.com/nodejs/node/pull/30972#event-2884019441
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 15, 2019 https://github.com/nodejs/node/pull/30972#pullrequestreview-332285946
View reviewed changes https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 17, 2019https://github.com/nodejs/node/pull/30972#issuecomment-566393566
Please reload this pagehttps://github.com/nodejs/node/pull/30972
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 17, 2019https://github.com/nodejs/node/pull/30972#event-2888542385
Trotthttps://github.com/Trott
Dec 17, 2019 https://github.com/nodejs/node/pull/30972#ref-commit-bd91d6d
https://github.com/cjihrig
https://github.com/Trott
test: improve WASI start() coveragehttps://github.com/nodejs/node/commit/bd91d6dacdbea88f340008f2a4f1b36a0a1ccc54
bd91d6dhttps://github.com/nodejs/node/commit/bd91d6dacdbea88f340008f2a4f1b36a0a1ccc54
#30972https://github.com/nodejs/node/pull/30972
Trotthttps://github.com/Trott
Dec 17, 2019 https://github.com/nodejs/node/pull/30972#ref-commit-0a2355f
https://github.com/cjihrig
https://github.com/Trott
test: simplify test-wasi-start-validation.jshttps://github.com/nodejs/node/commit/0a2355ff5f38d424d435ec145ce497a938cc9c8b
0a2355fhttps://github.com/nodejs/node/commit/0a2355ff5f38d424d435ec145ce497a938cc9c8b
#30972https://github.com/nodejs/node/pull/30972
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
December 17, 2019 14:23https://github.com/nodejs/node/pull/30972#event-2890017496
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30972#ref-commit-c2d9552
https://github.com/cjihrig
https://github.com/MylesBorins
test: improve WASI start() coveragehttps://github.com/nodejs/node/commit/c2d95529f65346c5782be4553da2c35ffb335231
c2d9552https://github.com/nodejs/node/commit/c2d95529f65346c5782be4553da2c35ffb335231
#30972https://github.com/nodejs/node/pull/30972
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30972#ref-commit-5e268b8
https://github.com/cjihrig
https://github.com/MylesBorins
test: simplify test-wasi-start-validation.jshttps://github.com/nodejs/node/commit/5e268b8dbead4d71394353a2154ff5798880e1db
5e268b8https://github.com/nodejs/node/commit/5e268b8dbead4d71394353a2154ff5798880e1db
#30972https://github.com/nodejs/node/pull/30972
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30972#ref-pullrequest-539365694
v13.5.0 proposal #31010 https://github.com/nodejs/node/pull/31010
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30972#ref-commit-299d518
https://github.com/cjihrig
https://github.com/targos
test: improve WASI start() coveragehttps://github.com/nodejs/node/commit/299d518b48c6078a660ab03e5cc46a3c44171edb
299d518https://github.com/nodejs/node/commit/299d518b48c6078a660ab03e5cc46a3c44171edb
#30972https://github.com/nodejs/node/pull/30972
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30972#ref-commit-d676c6c
https://github.com/cjihrig
https://github.com/targos
test: simplify test-wasi-start-validation.jshttps://github.com/nodejs/node/commit/d676c6c5a9f11677a45a16547bc2a0e79f5067fe
d676c6chttps://github.com/nodejs/node/commit/d676c6c5a9f11677a45a16547bc2a0e79f5067fe
#30972https://github.com/nodejs/node/pull/30972
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30972#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30972#ref-commit-be3fd2e
https://github.com/cjihrig
https://github.com/BethGriggs
test: improve WASI start() coveragehttps://github.com/nodejs/node/commit/be3fd2e7147f40877274ce1c9dab7233606618ff
be3fd2ehttps://github.com/nodejs/node/commit/be3fd2e7147f40877274ce1c9dab7233606618ff
#30972https://github.com/nodejs/node/pull/30972
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30972#ref-commit-ceca549
https://github.com/cjihrig
https://github.com/BethGriggs
test: simplify test-wasi-start-validation.jshttps://github.com/nodejs/node/commit/ceca54940ba6034ae55036fcb3a14d439d4b0afb
ceca549https://github.com/nodejs/node/commit/ceca54940ba6034ae55036fcb3a14d439d4b0afb
#30972https://github.com/nodejs/node/pull/30972
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30972#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30972
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/30972/files/f5540d594196ef9ff96ef13626e3c25fd61730c0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
wasm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasm
Please reload this pagehttps://github.com/nodejs/node/pull/30972
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/gengjiawen
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.