René's URL Explorer Experiment


Title: src: unregister Isolate with platform before disposing by addaleax · Pull Request #30909 · nodejs/node · GitHub

Open Graph Title: src: unregister Isolate with platform before disposing by addaleax · Pull Request #30909 · nodejs/node

X Title: src: unregister Isolate with platform before disposing by addaleax · Pull Request #30909 · nodejs/node

Description: I previously thought the order of these calls was no longer relevant. I was wrong. This commit undoes the changes from 312c02d, adds a comment explaining why I was wrong, and flips the order of the...

Open Graph Description: I previously thought the order of these calls was no longer relevant. I was wrong. This commit undoes the changes from 312c02d, adds a comment explaining why I was wrong, and flips the order of the...

X Description: I previously thought the order of these calls was no longer relevant. I was wrong. This commit undoes the changes from 312c02d, adds a comment explaining why I was wrong, and flips the order of the...

Opengraph URL: https://github.com/nodejs/node/pull/30909

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ac1355a-3c29-0de5-5e0b-4145de7b5cfc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADB2:1E4FEF:1B195B:22A047:696AD87B
html-safe-noncebeaa104918cd0a2c8046d77723d076a579eb16349d479e400784946156a3770e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREIyOjFFNEZFRjoxQjE5NUI6MjJBMDQ3OjY5NkFEODdCIiwidmlzaXRvcl9pZCI6IjQyMjY0NTU1MDg0NzExNzUyOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf38cb6ae253a1a1ffe560a94a39a7a22f7ba6a2772a37c5e29427610a9e01cb0
hovercard-subject-tagpull_request:352210911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30909/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/334285fafdc2cff7403f3a1632ff8f43ad95b18ed4c1d32ff1cb811d6ee9e256/nodejs/node/pull/30909
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/334285fafdc2cff7403f3a1632ff8f43ad95b18ed4c1d32ff1cb811d6ee9e256/nodejs/node/pull/30909
og:image:altI previously thought the order of these calls was no longer relevant. I was wrong. This commit undoes the changes from 312c02d, adds a comment explaining why I was wrong, and flips the order of the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30909#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30909
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30909
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30909
Reloadhttps://github.com/nodejs/node/pull/30909
Reloadhttps://github.com/nodejs/node/pull/30909
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30909
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30909
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30909#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:revert-30181https://github.com/addaleax/node/tree/revert-30181
src: unregister Isolate with platform before disposing https://github.com/nodejs/node/pull/30909#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:revert-30181https://github.com/addaleax/node/tree/revert-30181
Conversation 6 https://github.com/nodejs/node/pull/30909
Commits 1 https://github.com/nodejs/node/pull/30909/commits
Checks 0 https://github.com/nodejs/node/pull/30909/checks
Files changed https://github.com/nodejs/node/pull/30909/files
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 12, 2019https://github.com/nodejs/node/pull/30909#issue-536731029
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
#30846https://github.com/nodejs/node/issues/30846
#30181https://github.com/nodejs/node/pull/30181
@codebyterehttps://github.com/codebytere
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/addaleax
src: unregister Isolate with platform before disposinghttps://github.com/nodejs/node/pull/30909/commits/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
27d48edhttps://github.com/nodejs/node/pull/30909/commits/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
312c02dhttps://github.com/addaleax/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/addaleax/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
nodejs#30846https://github.com/nodejs/node/issues/30846
nodejs#30181https://github.com/nodejs/node/pull/30181
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Dec 12, 2019https://github.com/nodejs/node/pull/30909#event-2876481802
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-330976286
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
codebyterehttps://github.com/codebytere
https://github.com/nodejs/node/pull/30909#pullrequestreview-330976286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-330977483
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-331050688
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-331075982
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-331113718
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-331178806
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Dec 12, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-331302884
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 13, 2019 https://github.com/nodejs/node/pull/30909#pullrequestreview-332007499
View reviewed changes https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 13, 2019https://github.com/nodejs/node/pull/30909#issuecomment-565529396
https://ci.nodejs.org/job/node-test-pull-request/27622/https://ci.nodejs.org/job/node-test-pull-request/27622/
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2019https://github.com/nodejs/node/pull/30909#issuecomment-565745683
https://ci.nodejs.org/job/node-test-pull-request/27687/https://ci.nodejs.org/job/node-test-pull-request/27687/
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019https://github.com/nodejs/node/pull/30909#issuecomment-565755187
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019https://github.com/nodejs/node/pull/30909#event-2883622043
Trotthttps://github.com/Trott
Dec 14, 2019 https://github.com/nodejs/node/pull/30909#ref-commit-25447d8
https://github.com/addaleax
https://github.com/Trott
src: unregister Isolate with platform before disposinghttps://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
#30846https://github.com/nodejs/node/issues/30846
#30181https://github.com/nodejs/node/pull/30181
#30909https://github.com/nodejs/node/pull/30909
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30909#ref-commit-d456aa0
https://github.com/addaleax
https://github.com/MylesBorins
src: unregister Isolate with platform before disposinghttps://github.com/nodejs/node/commit/d456aa0a579fc00a3b80c439af1e3668b617ded6
d456aa0https://github.com/nodejs/node/commit/d456aa0a579fc00a3b80c439af1e3668b617ded6
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
#30846https://github.com/nodejs/node/issues/30846
#30181https://github.com/nodejs/node/pull/30181
#30909https://github.com/nodejs/node/pull/30909
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30909#ref-pullrequest-539365694
v13.5.0 proposal #31010 https://github.com/nodejs/node/pull/31010
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-ace3e70
https://github.com/addaleax
https://github.com/targos
src: unregister Isolate with platform before disposinghttps://github.com/nodejs/node/commit/ace3e70ef115ffa562243d3da5ed4afd6ac32c44
ace3e70https://github.com/nodejs/node/commit/ace3e70ef115ffa562243d3da5ed4afd6ac32c44
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
#30846https://github.com/nodejs/node/issues/30846
#30181https://github.com/nodejs/node/pull/30181
#30909https://github.com/nodejs/node/pull/30909
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30909#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-65e5a8a
https://github.com/addaleax
https://github.com/BethGriggs
src: unregister Isolate with platform before disposinghttps://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a
65e5a8ahttps://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
312c02dhttps://github.com/nodejs/node/commit/312c02d25e90aac1ee087bf3386636e8c81e2a66
#30846https://github.com/nodejs/node/issues/30846
#30181https://github.com/nodejs/node/pull/30181
#30909https://github.com/nodejs/node/pull/30909
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30909#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Feb 13, 2020https://github.com/nodejs/node/pull/30909#event-3036895555
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 13, 2020https://github.com/nodejs/node/pull/30909#issuecomment-586021890
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
February 14, 2020 15:11https://github.com/nodejs/node/pull/30909#event-3039074133
addaleaxhttps://github.com/addaleax
Feb 14, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-3f7e078
https://github.com/addaleax
src: keep main-thread Isolate attached to platform during Disposehttps://github.com/addaleax/node/commit/3f7e0784369ca14f4e5291e9add04c6ace9d8946
3f7e078https://github.com/addaleax/node/commit/3f7e0784369ca14f4e5291e9add04c6ace9d8946
25447d8https://github.com/addaleax/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
25447d8https://github.com/addaleax/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
nodejs#30909https://github.com/nodejs/node/pull/30909
nodejs#31752https://github.com/nodejs/node/issues/31752
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 14, 2020 https://github.com/nodejs/node/pull/30909#ref-pullrequest-565399067
src: keep main-thread Isolate attached to platform during Dispose #31795 https://github.com/nodejs/node/pull/31795
addaleaxhttps://github.com/addaleax
Feb 14, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-e460f8c
https://github.com/addaleax
src: keep main-thread Isolate attached to platform during Disposehttps://github.com/nodejs/node/commit/e460f8cf43863a5a8d73273ce311135ad3245699
e460f8chttps://github.com/nodejs/node/commit/e460f8cf43863a5a8d73273ce311135ad3245699
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
#30909https://github.com/nodejs/node/pull/30909
#31752https://github.com/nodejs/node/issues/31752
#31795https://github.com/nodejs/node/pull/31795
addaleaxhttps://github.com/addaleax
Feb 14, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-43d02e2
https://github.com/addaleax
src: keep main-thread Isolate attached to platform during Disposehttps://github.com/nodejs/node/commit/43d02e20e0f37c3494cdf950fb9586f911df3d39
43d02e2https://github.com/nodejs/node/commit/43d02e20e0f37c3494cdf950fb9586f911df3d39
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
#30909https://github.com/nodejs/node/pull/30909
#31752https://github.com/nodejs/node/issues/31752
#31795https://github.com/nodejs/node/pull/31795
codebyterehttps://github.com/codebytere
Feb 17, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-a095ef0
https://github.com/addaleax
https://github.com/codebytere
src: keep main-thread Isolate attached to platform during Disposehttps://github.com/nodejs/node/commit/a095ef0d52a46c0504247a2038abcd2117855a47
a095ef0https://github.com/nodejs/node/commit/a095ef0d52a46c0504247a2038abcd2117855a47
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
25447d8https://github.com/nodejs/node/commit/25447d82d34afb8c7f0f7e8fea10942586ef2d7c
#30909https://github.com/nodejs/node/pull/30909
#31752https://github.com/nodejs/node/issues/31752
#31795https://github.com/nodejs/node/pull/31795
https://github.com/targos
targoshttps://github.com/targos
Feb 18, 2020https://github.com/nodejs/node/pull/30909#issuecomment-587312365
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Feb 18, 2020https://github.com/nodejs/node/pull/30909#event-3045915612
https://github.com/targos
targoshttps://github.com/targos
Feb 18, 2020 https://github.com/nodejs/node/pull/30909#ref-issue-566710187
v12.16.0 post-mortem nodejs/Release#536 https://github.com/nodejs/Release/issues/536
addaleaxhttps://github.com/addaleax
Feb 18, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-023ed84
https://github.com/addaleax
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/addaleax/node/commit/023ed84c64cbda7ccbb4f3fd8d570c00e223c3e2
023ed84https://github.com/addaleax/node/commit/023ed84c64cbda7ccbb4f3fd8d570c00e223c3e2
nodejs#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
nodejs#31795https://github.com/nodejs/node/pull/31795
nodejs#30909https://github.com/nodejs/node/pull/30909
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 18, 2020 https://github.com/nodejs/node/pull/30909#ref-pullrequest-567111900
src: discard tasks posted to platform TaskRunner during shutdown #31853 https://github.com/nodejs/node/pull/31853
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Feb 18, 2020https://github.com/nodejs/node/pull/30909#event-3048544036
addaleaxhttps://github.com/addaleax
Mar 11, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-8f61eef
https://github.com/addaleax
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/nodejs/node/commit/8f61eef562f2083f0cb9dd11758065d4c8ec0c35
8f61eefhttps://github.com/nodejs/node/commit/8f61eef562f2083f0cb9dd11758065d4c8ec0c35
#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
#31795https://github.com/nodejs/node/pull/31795
#30909https://github.com/nodejs/node/pull/30909
#31853https://github.com/nodejs/node/pull/31853
MylesBorinshttps://github.com/MylesBorins
Mar 11, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-625d8f7
https://github.com/addaleax
https://github.com/MylesBorins
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/nodejs/node/commit/625d8f7007f64e0df45c8f46763d6c896bb4b7c4
625d8f7https://github.com/nodejs/node/commit/625d8f7007f64e0df45c8f46763d6c896bb4b7c4
#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
#31795https://github.com/nodejs/node/pull/31795
#30909https://github.com/nodejs/node/pull/30909
#31853https://github.com/nodejs/node/pull/31853
codebyterehttps://github.com/codebytere
Mar 21, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-a01fb4a
https://github.com/addaleax
https://github.com/codebytere
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/nodejs/node/commit/a01fb4ac619df82f9d90fc0ec29f7cf89170f6a3
a01fb4ahttps://github.com/nodejs/node/commit/a01fb4ac619df82f9d90fc0ec29f7cf89170f6a3
#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
#31795https://github.com/nodejs/node/pull/31795
#30909https://github.com/nodejs/node/pull/30909
#31853https://github.com/nodejs/node/pull/31853
codebyterehttps://github.com/codebytere
Mar 23, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-9e83631
https://github.com/addaleax
https://github.com/codebytere
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/nodejs/node/commit/9e836315bd8fcec77f6f77f2391ea99d3e1d2f0c
9e83631https://github.com/nodejs/node/commit/9e836315bd8fcec77f6f77f2391ea99d3e1d2f0c
#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
#31795https://github.com/nodejs/node/pull/31795
#30909https://github.com/nodejs/node/pull/30909
#31853https://github.com/nodejs/node/pull/31853
codebyterehttps://github.com/codebytere
Mar 30, 2020 https://github.com/nodejs/node/pull/30909#ref-commit-908f634
https://github.com/addaleax
https://github.com/codebytere
src: discard tasks posted to platform TaskRunner during shutdownhttps://github.com/nodejs/node/commit/908f6341102fa001279476f76aa4dfa87a0630f4
908f634https://github.com/nodejs/node/commit/908f6341102fa001279476f76aa4dfa87a0630f4
#31752https://github.com/nodejs/node/issues/31752
https://bugs.chromium.org/p/v8/issues/detail?id=10104https://bugs.chromium.org/p/v8/issues/detail?id=10104
https://chromium-review.googlesource.com/c/v8/v8/+/2061548https://chromium-review.googlesource.com/c/v8/v8/+/2061548
#31795https://github.com/nodejs/node/pull/31795
#30909https://github.com/nodejs/node/pull/30909
#31853https://github.com/nodejs/node/pull/31853
https://github.com/targos
targoshttps://github.com/targos
Apr 9, 2025 https://github.com/nodejs/node/pull/30909#ref-pullrequest-2974069097
[help wanted] deps: update V8 to 13.6 #57753 https://github.com/nodejs/node/pull/57753
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30909
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/codebytere
codebytere https://github.com/codebytere
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/30909/files/27d48ed7ef78a8b5ef2d05b6d2dd503a24e63802
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Investigate flaky test parallel/test-worker-message-port-transfer-terminate https://github.com/nodejs/node/issues/30846
Please reload this pagehttps://github.com/nodejs/node/pull/30909
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/MylesBorins
https://github.com/targos
https://github.com/bnoordhuis
https://github.com/codebytere
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com/devnexen
https://github.com/richardlau
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.