| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:075b8949-d5b5-3840-ef57-45004e41828a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 851A:1E1D6F:24A3C9F:31B8D81:696AD27C |
| html-safe-nonce | b0a9c475c6d8187ecbd20bf5d33b8d6b7b10b22f28179308d04e8ad071733f40 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTFBOjFFMUQ2RjoyNEEzQzlGOjMxQjhEODE6Njk2QUQyN0MiLCJ2aXNpdG9yX2lkIjoiNDYwNDk0NTY1NzQzNTQ0MzgzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4f5552d303c52ceaa6320abcb55724dbdd63037ad075d0a06fa57cfe0a216c2f |
| hovercard-subject-tag | pull_request:350430252 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30856/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e738b843dc24d7ffd54ce9361ae0e206516362f75df751f913e95ff5878fad75/nodejs/node/pull/30856 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e738b843dc24d7ffd54ce9361ae0e206516362f75df751f913e95ff5878fad75/nodejs/node/pull/30856 |
| og:image:alt | Refactor the internal NativeModule class to a JS class and add
more documentation about its properties.
Tip: https://github.com/nodejs/node/pull/30856/files?w=1 is easier to review
Checklist
ma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30856#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30856 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30856 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30856 |
| Reload | https://github.com/nodejs/node/pull/30856 |
| Reload | https://github.com/nodejs/node/pull/30856 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/30856#issue-comment-box |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:class-module | https://github.com/joyeecheung/node/tree/class-module |
|
lib: refactor NativeModule
| https://github.com/nodejs/node/pull/30856#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:class-module | https://github.com/joyeecheung/node/tree/class-module |
|
Conversation
6
| https://github.com/nodejs/node/pull/30856 |
|
Commits
1
| https://github.com/nodejs/node/pull/30856/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/30856/checks |
|
Files changed
| https://github.com/nodejs/node/pull/30856/files |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Dec 8, 2019 | https://github.com/nodejs/node/pull/30856#issue-534566133 |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/nodejs/node/pull/30856/files?w=1 | https://github.com/nodejs/node/pull/30856/files?w=1 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
|
| https://github.com/joyeecheung |
| lib: refactor NativeModule | https://github.com/nodejs/node/pull/30856/commits/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| f2fe106 | https://github.com/nodejs/node/pull/30856/commits/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 8, 2019 | https://github.com/nodejs/node/pull/30856#issuecomment-562967015 |
| https://ci.nodejs.org/job/node-test-pull-request/27491/ | https://ci.nodejs.org/job/node-test-pull-request/27491/ |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Dec 8, 2019
| https://github.com/nodejs/node/pull/30856#pullrequestreview-328622893 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Dec 8, 2019
| https://github.com/nodejs/node/pull/30856#pullrequestreview-328632018 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| lib/internal/bootstrap/loaders.js | https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3#diff-b76c7c75bddd3058fb05bee3c05f0ba8d2e26668714aabccdff0158b6ab857e9 |
| aduh95 | https://github.com/aduh95 |
| Dec 8, 2019 | https://github.com/nodejs/node/pull/30856#discussion_r355214434 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| devsnek | https://github.com/devsnek |
| Dec 8, 2019 | https://github.com/nodejs/node/pull/30856#discussion_r355214751 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Dec 8, 2019
| https://github.com/nodejs/node/pull/30856#pullrequestreview-328632225 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 13, 2019 | https://github.com/nodejs/node/pull/30856#issuecomment-565563499 |
| https://ci.nodejs.org/job/node-test-pull-request/27628/ | https://ci.nodejs.org/job/node-test-pull-request/27628/ |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 13, 2019
| https://github.com/nodejs/node/pull/30856#pullrequestreview-332128476 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 13, 2019 | https://github.com/nodejs/node/pull/30856#issuecomment-565616573 |
| https://ci.nodejs.org/job/node-test-pull-request/27647/ | https://ci.nodejs.org/job/node-test-pull-request/27647/ |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 13, 2019 | https://github.com/nodejs/node/pull/30856#event-2882729057 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2019 | https://github.com/nodejs/node/pull/30856#issuecomment-565669802 |
| e4e5a83 | https://github.com/nodejs/node/commit/e4e5a835b8ced02ca6d08d7f44826e7617ec5e9e |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 14, 2019 | https://github.com/nodejs/node/pull/30856#event-2883088957 |
| Trott | https://github.com/Trott |
|
Dec 14, 2019
| https://github.com/nodejs/node/pull/30856#ref-commit-e4e5a83 |
|
| https://github.com/joyeecheung |
|
| https://github.com/Trott |
| lib: refactor NativeModule | https://github.com/nodejs/node/commit/e4e5a835b8ced02ca6d08d7f44826e7617ec5e9e |
| e4e5a83 | https://github.com/nodejs/node/commit/e4e5a835b8ced02ca6d08d7f44826e7617ec5e9e |
| #30856 | https://github.com/nodejs/node/pull/30856 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30856#ref-commit-30d3249 |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
| lib: refactor NativeModule | https://github.com/nodejs/node/commit/30d32492a0ec50eb51363506f38656d8a7673d54 |
| 30d3249 | https://github.com/nodejs/node/commit/30d32492a0ec50eb51363506f38656d8a7673d54 |
| #30856 | https://github.com/nodejs/node/pull/30856 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30856#ref-pullrequest-539365694 |
|
v13.5.0 proposal
#31010
| https://github.com/nodejs/node/pull/31010 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/30856#ref-commit-1c6e2ec |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| lib: refactor NativeModule | https://github.com/nodejs/node/commit/1c6e2ec74461358c315040a4abb616e02b003abc |
| 1c6e2ec | https://github.com/nodejs/node/commit/1c6e2ec74461358c315040a4abb616e02b003abc |
| #30856 | https://github.com/nodejs/node/pull/30856 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/30856#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/30856#ref-commit-84c9e4f |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
| lib: refactor NativeModule | https://github.com/nodejs/node/commit/84c9e4f1b51e06835816b27d2fab51844a95fc7a |
| 84c9e4f | https://github.com/nodejs/node/commit/84c9e4f1b51e06835816b27d2fab51844a95fc7a |
| #30856 | https://github.com/nodejs/node/pull/30856 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/30856#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30856 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/30856/files/f2fe106ebbce3114a12fde097b63ec81449747f3 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Please reload this page | https://github.com/nodejs/node/pull/30856 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/devsnek |
|
| https://github.com/lundibundi |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |