René's URL Explorer Experiment


Title: http2: fix graceful session close by lundibundi · Pull Request #30854 · nodejs/node · GitHub

Open Graph Title: http2: fix graceful session close by lundibundi · Pull Request #30854 · nodejs/node

X Title: http2: fix graceful session close by lundibundi · Pull Request #30854 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This is tied...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This is tied...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This is tied...

Opengraph URL: https://github.com/nodejs/node/pull/30854

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4cfe7066-cc8c-0eec-a6b5-61f15199e11e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9866:1860A8:18BD07:229B84:696A63BE
html-safe-noncee6eb9c55d0b2f8c79da0096b830a2eab1fdd83463cfaf3967d8d4f82579bf14e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODY2OjE4NjBBODoxOEJEMDc6MjI5Qjg0OjY5NkE2M0JFIiwidmlzaXRvcl9pZCI6IjMxNDgyMTYwMjc4MTU4NjM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc8754f10ed68cc51627cabb374c7684c7b267ec291306ceeff94c4bf40913e88
hovercard-subject-tagpull_request:350419106
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30854/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8874f52616898b59e2068b5cb21a57a59fe7b725df4c028db107cc9d145631de/nodejs/node/pull/30854
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8874f52616898b59e2068b5cb21a57a59fe7b725df4c028db107cc9d145631de/nodejs/node/pull/30854
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This is tied...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelundibundi
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30854#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30854
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30854
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30854
Reloadhttps://github.com/nodejs/node/pull/30854
Reloadhttps://github.com/nodejs/node/pull/30854
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30854
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30854
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30854#issue-comment-box
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:http2-graceful-session-closehttps://github.com/lundibundi/node/tree/http2-graceful-session-close
http2: fix graceful session close https://github.com/nodejs/node/pull/30854#top
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:http2-graceful-session-closehttps://github.com/lundibundi/node/tree/http2-graceful-session-close
Conversation 31 https://github.com/nodejs/node/pull/30854
Commits 2 https://github.com/nodejs/node/pull/30854/commits
Checks 0 https://github.com/nodejs/node/pull/30854/checks
Files changed https://github.com/nodejs/node/pull/30854/files
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 8, 2019https://github.com/nodejs/node/pull/30854#issue-534551041
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#20630https://github.com/nodejs/node/issues/20630
#19852https://github.com/nodejs/node/pull/19852
#20772https://github.com/nodejs/node/pull/20772
@addaleaxhttps://github.com/addaleax
@jasnellhttps://github.com/jasnell
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
addaleaxhttps://github.com/addaleax
apapirovskihttps://github.com/apapirovski
jasnellhttps://github.com/jasnell
December 8, 2019 14:40https://github.com/nodejs/node/pull/30854#event-2864225805
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Dec 8, 2019https://github.com/nodejs/node/pull/30854#event-2864225875
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Dec 8, 2019https://github.com/nodejs/node/pull/30854#event-2864226129
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30854
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328621073
View reviewed changes https://github.com/nodejs/node/pull/30854/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30854#pullrequestreview-328621073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 8, 2019https://github.com/nodejs/node/pull/30854#issuecomment-562972110
https://ci.nodejs.org/job/node-test-pull-request/27497/https://ci.nodejs.org/job/node-test-pull-request/27497/
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328621747
View reviewed changes https://github.com/nodejs/node/pull/30854/files
src/node_http2.cchttps://github.com/nodejs/node/pull/30854/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
lundibundihttps://github.com/lundibundi
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355201890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
addaleaxhttps://github.com/addaleax
Dec 9, 2019https://github.com/nodejs/node/pull/30854#discussion_r355471815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
lundibundihttps://github.com/lundibundi
Dec 9, 2019https://github.com/nodejs/node/pull/30854#discussion_r355666530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328622269
View reviewed changes https://github.com/nodejs/node/pull/30854/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/30854/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355202554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355205791
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328622371
View reviewed changes https://github.com/nodejs/node/pull/30854/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/30854/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355202697
Please reload this pagehttps://github.com/nodejs/node/pull/30854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
lundibundihttps://github.com/lundibundi
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355204907
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355205279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
lundibundihttps://github.com/lundibundi
Dec 16, 2019https://github.com/nodejs/node/pull/30854#discussion_r358315246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328622433
View reviewed changes https://github.com/nodejs/node/pull/30854/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/30854/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355202773
Please reload this pagehttps://github.com/nodejs/node/pull/30854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355202953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
lundibundihttps://github.com/lundibundi
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355204838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355205066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355205392
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30854#discussion_r355205500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29747https://github.com/nodejs/node/pull/29747
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 8, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328622605
View reviewed changes https://github.com/nodejs/node/pull/30854/files
ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/nodejs/node/pull/30854#pullrequestreview-328622605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 9, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-328947614
View reviewed changes https://github.com/nodejs/node/pull/30854/files
src/node_http2.cchttps://github.com/nodejs/node/pull/30854/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Dec 9, 2019https://github.com/nodejs/node/pull/30854#discussion_r355471815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Dec 10, 2019 https://github.com/nodejs/node/pull/30854#ref-pullrequest-504215455
test: fix flaky test-http2-client-upload #29889 https://github.com/nodejs/node/pull/29889
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 11, 2019https://github.com/nodejs/node/pull/30854#issuecomment-564640458
@lundibundihttps://github.com/lundibundi
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 11, 2019https://github.com/nodejs/node/pull/30854#issuecomment-564714148
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Dec 14, 2019https://github.com/nodejs/node/pull/30854#issuecomment-565730683
Please reload this pagehttps://github.com/nodejs/node/pull/30854
@lundibundihttps://github.com/lundibundi
Please reload this pagehttps://github.com/nodejs/node/pull/30854
lundibundihttps://github.com/lundibundi
December 16, 2019 19:31https://github.com/nodejs/node/pull/30854#commits-pushed-0995c29
https://github.com/lundibundi
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/pull/30854/commits/0995c2905279505a2f5e450b1eea82979d28fa45
0995c29https://github.com/nodejs/node/pull/30854/commits/0995c2905279505a2f5e450b1eea82979d28fa45
https://github.com/lundibundi
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/pull/30854/commits/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
082c0cbhttps://github.com/nodejs/node/pull/30854/commits/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
force-pushedhttps://github.com/nodejs/node/compare/ac665aecf0be75b995bd770bc1d5f2fc984788fb..082c0cb19377368f2c4fb7f0af3a366d6a6d273a
ac665aehttps://github.com/nodejs/node/commit/ac665aecf0be75b995bd770bc1d5f2fc984788fb
082c0cbhttps://github.com/nodejs/node/commit/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
Compare https://github.com/nodejs/node/compare/ac665aecf0be75b995bd770bc1d5f2fc984788fb..082c0cb19377368f2c4fb7f0af3a366d6a6d273a
December 16, 2019 17:44https://github.com/nodejs/node/pull/30854#event-2886875670
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 16, 2019https://github.com/nodejs/node/pull/30854#issuecomment-566186831
http2-graceful-session-close-properhttps://github.com/lundibundi/node/tree/http2-graceful-session-close-proper
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 16, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-332786640
View reviewed changes https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 18, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-333695131
View reviewed changes https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 20, 2019https://github.com/nodejs/node/pull/30854#issuecomment-568068576
@mcollinahttps://github.com/mcollina
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 21, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-335597613
View reviewed changes https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30854#pullrequestreview-335597613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 21, 2019https://github.com/nodejs/node/pull/30854#event-2902659467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 21, 2019https://github.com/nodejs/node/pull/30854#issuecomment-568177527
https://ci.nodejs.org/job/node-test-pull-request/27859/https://ci.nodejs.org/job/node-test-pull-request/27859/
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 22, 2019 https://github.com/nodejs/node/pull/30854#pullrequestreview-335630426
View reviewed changes https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 25, 2019https://github.com/nodejs/node/pull/30854#issuecomment-568879142
a8c2c66https://github.com/nodejs/node/commit/a8c2c667ce896f3b168e8622eefa878b355d7c9a
be3c7achttps://github.com/nodejs/node/commit/be3c7aceba58f0a58ee4813a9894681d9c8ba56e
Please reload this pagehttps://github.com/nodejs/node/pull/30854
BridgeARhttps://github.com/BridgeAR
Dec 25, 2019 https://github.com/nodejs/node/pull/30854#ref-commit-a8c2c66
https://github.com/lundibundi
https://github.com/BridgeAR
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/commit/a8c2c667ce896f3b168e8622eefa878b355d7c9a
a8c2c66https://github.com/nodejs/node/commit/a8c2c667ce896f3b168e8622eefa878b355d7c9a
#30854https://github.com/nodejs/node/pull/30854
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 25, 2019https://github.com/nodejs/node/pull/30854#event-2907848741
BridgeARhttps://github.com/BridgeAR
Dec 25, 2019 https://github.com/nodejs/node/pull/30854#ref-commit-be3c7ac
https://github.com/lundibundi
https://github.com/BridgeAR
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/commit/be3c7aceba58f0a58ee4813a9894681d9c8ba56e
be3c7achttps://github.com/nodejs/node/commit/be3c7aceba58f0a58ee4813a9894681d9c8ba56e
#30854https://github.com/nodejs/node/pull/30854
BridgeARhttps://github.com/BridgeAR
Jan 3, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-86f2e86
https://github.com/lundibundi
https://github.com/BridgeAR
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/commit/86f2e869dcc287d44185b64881a1b6e07a55a872
86f2e86https://github.com/nodejs/node/commit/86f2e869dcc287d44185b64881a1b6e07a55a872
#30854https://github.com/nodejs/node/pull/30854
BridgeARhttps://github.com/BridgeAR
Jan 3, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-ba0682e
https://github.com/lundibundi
https://github.com/BridgeAR
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/commit/ba0682e91cab2c8c147d1be70537f55fbf4b5d04
ba0682ehttps://github.com/nodejs/node/commit/ba0682e91cab2c8c147d1be70537f55fbf4b5d04
#30854https://github.com/nodejs/node/pull/30854
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 7, 2020 https://github.com/nodejs/node/pull/30854#ref-pullrequest-546134970
v13.6.0 proposal #31238 https://github.com/nodejs/node/pull/31238
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-7eadb1b
https://github.com/lundibundi
https://github.com/targos
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/commit/7eadb1b06c47ff18725e47383cee12fa43bc4ed5
7eadb1bhttps://github.com/nodejs/node/commit/7eadb1b06c47ff18725e47383cee12fa43bc4ed5
#30854https://github.com/nodejs/node/pull/30854
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-448888a
https://github.com/lundibundi
https://github.com/targos
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/commit/448888a78170e30326abb74f44632556017a65d0
448888ahttps://github.com/nodejs/node/commit/448888a78170e30326abb74f44632556017a65d0
#30854https://github.com/nodejs/node/pull/30854
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Jan 14, 2020https://github.com/nodejs/node/pull/30854#event-2947630060
https://github.com/targos
targoshttps://github.com/targos
Jan 14, 2020https://github.com/nodejs/node/pull/30854#issuecomment-574244046
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2020https://github.com/nodejs/node/pull/30854#issuecomment-574474064
#31107https://github.com/nodejs/node/issues/31107
Please reload this pagehttps://github.com/nodejs/node/pull/30854
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-759829c
https://github.com/lundibundi
https://github.com/targos
http2: wait for session to finish writing before destroyhttps://github.com/targos/node/commit/759829c46277f19a6b00918b00ca194281a03a3d
759829chttps://github.com/targos/node/commit/759829c46277f19a6b00918b00ca194281a03a3d
nodejs#30854https://github.com/nodejs/node/pull/30854
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-c9b2081
https://github.com/lundibundi
https://github.com/targos
http2: wait for session socket writable end on close/destroyhttps://github.com/targos/node/commit/c9b2081887f0f3884240d5e33b653731308d0574
c9b2081https://github.com/targos/node/commit/c9b2081887f0f3884240d5e33b653731308d0574
nodejs#30854https://github.com/nodejs/node/pull/30854
https://github.com/targos
targoshttps://github.com/targos
backport-open-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Apr 25, 2020https://github.com/nodejs/node/pull/30854#event-3271996423
https://github.com/targos
targoshttps://github.com/targos
Apr 25, 2020 https://github.com/nodejs/node/pull/30854#ref-pullrequest-606789439
[v12.x] Backport http2: fix graceful session close #33059 https://github.com/nodejs/node/pull/33059
clshortfusehttps://github.com/clshortfuse
Sep 22, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-4e4592b
https://github.com/lundibundi
https://github.com/clshortfuse
http2: wait for session to finish writing before destroyhttps://github.com/clshortfuse/node/commit/4e4592bf254d153b9fdf2235f8c6792f44de0e9c
4e4592bhttps://github.com/clshortfuse/node/commit/4e4592bf254d153b9fdf2235f8c6792f44de0e9c
nodejs#30854https://github.com/nodejs/node/pull/30854
clshortfusehttps://github.com/clshortfuse
Sep 22, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-0453ece
https://github.com/lundibundi
https://github.com/clshortfuse
http2: wait for session socket writable end on close/destroyhttps://github.com/clshortfuse/node/commit/0453ece0b997a741750d5d0a21a18ac3778c7c63
0453ecehttps://github.com/clshortfuse/node/commit/0453ece0b997a741750d5d0a21a18ac3778c7c63
nodejs#30854https://github.com/nodejs/node/pull/30854
MylesBorinshttps://github.com/MylesBorins
Oct 13, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-1cdf5d8
https://github.com/lundibundi
https://github.com/MylesBorins
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/commit/1cdf5d80d11edef64e626eb3c02c6285858962f8
1cdf5d8https://github.com/nodejs/node/commit/1cdf5d80d11edef64e626eb3c02c6285858962f8
#34845https://github.com/nodejs/node/pull/34845
#30854https://github.com/nodejs/node/pull/30854
MylesBorinshttps://github.com/MylesBorins
Oct 13, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-c950e76
https://github.com/lundibundi
https://github.com/MylesBorins
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/commit/c950e7676c0ca844efbc179d90cc7349148c17c5
c950e76https://github.com/nodejs/node/commit/c950e7676c0ca844efbc179d90cc7349148c17c5
#34845https://github.com/nodejs/node/pull/34845
#30854https://github.com/nodejs/node/pull/30854
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 3, 2020 https://github.com/nodejs/node/pull/30854#ref-pullrequest-735694919
v12.20.0 proposal #35950 https://github.com/nodejs/node/pull/35950
MylesBorinshttps://github.com/MylesBorins
Nov 16, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-2471197
https://github.com/lundibundi
https://github.com/MylesBorins
http2: wait for session to finish writing before destroyhttps://github.com/nodejs/node/commit/247119709916970885d0f718feae2a1bcb763e0f
2471197https://github.com/nodejs/node/commit/247119709916970885d0f718feae2a1bcb763e0f
#34845https://github.com/nodejs/node/pull/34845
#30854https://github.com/nodejs/node/pull/30854
MylesBorinshttps://github.com/MylesBorins
Nov 16, 2020 https://github.com/nodejs/node/pull/30854#ref-commit-e85ca7a
https://github.com/lundibundi
https://github.com/MylesBorins
http2: wait for session socket writable end on close/destroyhttps://github.com/nodejs/node/commit/e85ca7af4322a82b00ad3abb045281a90bed3ff8
e85ca7ahttps://github.com/nodejs/node/commit/e85ca7af4322a82b00ad3abb045281a90bed3ff8
#34845https://github.com/nodejs/node/pull/34845
#30854https://github.com/nodejs/node/pull/30854
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2021 https://github.com/nodejs/node/pull/30854#ref-issue-894579032
[Bug]: http2 can cause SIGPIPE on client close electron/electron#29206 https://github.com/electron/electron/issues/29206
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30854
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30854/files/082c0cb19377368f2c4fb7f0af3a366d6a6d273a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30854/files/ac665aecf0be75b995bd770bc1d5f2fc984788fb
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/30854
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/apapirovski
https://github.com/BridgeAR
https://github.com/targos
https://github.com/mcollina
https://github.com/jasnell
https://github.com/addaleax
https://github.com/ronag
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.