| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6e00e115-a65e-4409-33d0-07cd98eb8bbc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C940:9445B:165A661:1ECC3F2:696AA74B |
| html-safe-nonce | edcb6ffa65f1bb531294c03d9b84a2863329c4fee82ceff6142c17bf27767f4e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTQwOjk0NDVCOjE2NUE2NjE6MUVDQzNGMjo2OTZBQTc0QiIsInZpc2l0b3JfaWQiOiIyMDU0MjcxODkwMDk4OTIzMzM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6a4759e137e3cd195190678615909d7f6976905a8caa625d7de9ad21ab228160 |
| hovercard-subject-tag | pull_request:350319602 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a08f65c6624c1331effb58b2f7b9a12574cf338de617b1b5132df21acdf706e3/nodejs/node/pull/30838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a08f65c6624c1331effb58b2f7b9a12574cf338de617b1b5132df21acdf706e3/nodejs/node/pull/30838 |
| og:image:alt | Refs: #30786
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | richardlau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30838#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30838 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30838 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30838 |
| Reload | https://github.com/nodejs/node/pull/30838 |
| Reload | https://github.com/nodejs/node/pull/30838 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/30838#issue-comment-box |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:flaky | https://github.com/richardlau/node-1/tree/flaky |
|
test: mark addons/openssl-bindings/test flaky on arm
| https://github.com/nodejs/node/pull/30838#top |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:flaky | https://github.com/richardlau/node-1/tree/flaky |
|
Conversation
6
| https://github.com/nodejs/node/pull/30838 |
|
Commits
1
| https://github.com/nodejs/node/pull/30838/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/30838/checks |
|
Files changed
| https://github.com/nodejs/node/pull/30838/files |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issue-534414328 |
| #30786 | https://github.com/nodejs/node/issues/30786 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
|
| https://github.com/richardlau |
| test: mark addons/openssl-bindings/test flaky on arm | https://github.com/nodejs/node/pull/30838/commits/d7f762e01080a77ff3979e724213739fa5325862 |
| d7f762e | https://github.com/nodejs/node/pull/30838/commits/d7f762e01080a77ff3979e724213739fa5325862 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#event-2863584746 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
arm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aarm |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#event-2863584810 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562860139 |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://ci.nodejs.org/job/node-test-pull-request/27457/ | https://ci.nodejs.org/job/node-test-pull-request/27457/ |
| https://ci.nodejs.org/job/node-test-binary-arm-12+/3034/RUN_SUBSET=addons,label=pi2-docker/ | https://ci.nodejs.org/job/node-test-binary-arm-12+/3034/RUN_SUBSET=addons,label=pi2-docker/ |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30838#ref-issue-532452354 |
|
addons/openssl-binding/test very flaky on ARM
#30786
| https://github.com/nodejs/node/issues/30786 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30838#pullrequestreview-328561621 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#event-2863600585 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30838#pullrequestreview-328563128 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562863288 |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30838#pullrequestreview-328567826 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562876573 |
| https://ci.nodejs.org/job/node-test-pull-request/27462/ | https://ci.nodejs.org/job/node-test-pull-request/27462/ |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562882876 |
| https://ci.nodejs.org/job/node-test-pull-request/27463/ | https://ci.nodejs.org/job/node-test-pull-request/27463/ |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562886027 |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://ci.nodejs.org/job/node-test-pull-request/27464/ | https://ci.nodejs.org/job/node-test-pull-request/27464/ |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#event-2863780414 |
| richardlau | https://github.com/richardlau |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30838#ref-commit-d4e00ec |
|
| https://github.com/richardlau |
| test: mark addons/openssl-bindings/test flaky on arm | https://github.com/nodejs/node/commit/d4e00ec0aefd8d83ca48e75082c0f3ec2b260ba9 |
| d4e00ec | https://github.com/nodejs/node/commit/d4e00ec0aefd8d83ca48e75082c0f3ec2b260ba9 |
| #30838 | https://github.com/nodejs/node/pull/30838 |
| #30786 | https://github.com/nodejs/node/issues/30786 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#issuecomment-562886862 |
| d4e00ec | https://github.com/nodejs/node/commit/d4e00ec0aefd8d83ca48e75082c0f3ec2b260ba9 |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30838#event-2863782936 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| December 7, 2019 21:09 | https://github.com/nodejs/node/pull/30838#event-2863783060 |
| targos | https://github.com/targos |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30838#ref-commit-4dc9d8d |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
| test: mark addons/openssl-bindings/test flaky on arm | https://github.com/nodejs/node/commit/4dc9d8db134d6cd6d2178d24ddd013dd4f09831e |
| 4dc9d8d | https://github.com/nodejs/node/commit/4dc9d8db134d6cd6d2178d24ddd013dd4f09831e |
| #30838 | https://github.com/nodejs/node/pull/30838 |
| #30786 | https://github.com/nodejs/node/issues/30786 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 13, 2019
| https://github.com/nodejs/node/pull/30838#ref-pullrequest-537630771 |
|
v13.4.0 proposal
#30937
| https://github.com/nodejs/node/pull/30937 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/30838#ref-commit-39d770c |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
| test: mark addons/openssl-bindings/test flaky on arm | https://github.com/nodejs/node/commit/39d770cc6e3c6194369009178d3962ec63443493 |
| 39d770c | https://github.com/nodejs/node/commit/39d770cc6e3c6194369009178d3962ec63443493 |
| #30838 | https://github.com/nodejs/node/pull/30838 |
| #30786 | https://github.com/nodejs/node/issues/30786 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/30838#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/30838#ref-commit-fe3818e |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| test: mark addons/openssl-bindings/test flaky on arm | https://github.com/nodejs/node/commit/fe3818e0162a6613292272669b1bf10f23631201 |
| fe3818e | https://github.com/nodejs/node/commit/fe3818e0162a6613292272669b1bf10f23631201 |
| #30838 | https://github.com/nodejs/node/pull/30838 |
| #30786 | https://github.com/nodejs/node/issues/30786 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/30838#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30838 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/30838/files/d7f762e01080a77ff3979e724213739fa5325862 |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
arm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aarm |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/30838 |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/cjihrig |
|
| https://github.com/addaleax |
|
| https://github.com/ZYSzys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |