René's URL Explorer Experiment


Title: fs: synchronize close with other I/O for streams by addaleax · Pull Request #30837 · nodejs/node · GitHub

Open Graph Title: fs: synchronize close with other I/O for streams by addaleax · Pull Request #30837 · nodejs/node

X Title: fs: synchronize close with other I/O for streams by addaleax · Pull Request #30837 · nodejs/node

Description: Part of the flakiness in the parallel/test-readline-async-iterators-destroy test comes from fs streams starting _read() and _destroy() without waiting for the other to finish, which can lead to the...

Open Graph Description: Part of the flakiness in the parallel/test-readline-async-iterators-destroy test comes from fs streams starting _read() and _destroy() without waiting for the other to finish, which can lead to the...

X Description: Part of the flakiness in the parallel/test-readline-async-iterators-destroy test comes from fs streams starting _read() and _destroy() without waiting for the other to finish, which can lead to the...

Opengraph URL: https://github.com/nodejs/node/pull/30837

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bb045008-1d87-e75e-3a5b-6493055dbfed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC84:C8A64:BBBE7A:1031804:696A8B4E
html-safe-nonce705e99b12dbcc08e69636b9927173e4a57e77c6a60a99996c67165127b37ec79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzg0OkM4QTY0OkJCQkU3QToxMDMxODA0OjY5NkE4QjRFIiwidmlzaXRvcl9pZCI6IjQzNzY1MDc5NTYyNTc3ODY3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6fa1c050bbf3ea053b2d6c92afebe102a790e5fbe3084374dbd9171415557bf9
hovercard-subject-tagpull_request:350310806
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30837/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f89e1d8a28c1b139d094eca3efb5d2614a9b18b6d9e1b864729748bf9aa26eb8/nodejs/node/pull/30837
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f89e1d8a28c1b139d094eca3efb5d2614a9b18b6d9e1b864729748bf9aa26eb8/nodejs/node/pull/30837
og:image:altPart of the flakiness in the parallel/test-readline-async-iterators-destroy test comes from fs streams starting _read() and _destroy() without waiting for the other to finish, which can lead to the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30837#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30837
Reloadhttps://github.com/nodejs/node/pull/30837
Reloadhttps://github.com/nodejs/node/pull/30837
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30837#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fs-readline-testhttps://github.com/addaleax/node/tree/fs-readline-test
fs: synchronize close with other I/O for streams https://github.com/nodejs/node/pull/30837#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:fs-readline-testhttps://github.com/addaleax/node/tree/fs-readline-test
Conversation 64 https://github.com/nodejs/node/pull/30837
Commits 2 https://github.com/nodejs/node/pull/30837/commits
Checks 0 https://github.com/nodejs/node/pull/30837/checks
Files changed https://github.com/nodejs/node/pull/30837/files
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#issue-534402020
Please reload this pagehttps://github.com/nodejs/node/pull/30837
#30660https://github.com/nodejs/node/issues/30660
@ronaghttps://github.com/ronag
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Dec 7, 2019https://github.com/nodejs/node/pull/30837#event-2863520742
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328556790
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#ref-issue-528771101
investigate flaky parallel/test-readline-async-iterators-destroy in CI #30660 https://github.com/nodejs/node/issues/30660
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328557052
View reviewed changes https://github.com/nodejs/node/pull/30837/files
ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/nodejs/node/pull/30837#pullrequestreview-328557052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29656https://github.com/nodejs/node/pull/29656
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328557359
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328557485
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
Please reload this pagehttps://github.com/nodejs/node/pull/30837
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355122819
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29197https://github.com/nodejs/node/pull/29197
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
https://github.com/ronag
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562854477
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#event-2863551590
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/5eba8094abfa332928cb74b1ba7dc521e7511357..2a723ac6799d177782c651141db8dc91a29df5d3
5eba809https://github.com/nodejs/node/commit/5eba8094abfa332928cb74b1ba7dc521e7511357
2a723achttps://github.com/nodejs/node/commit/2a723ac6799d177782c651141db8dc91a29df5d3
Compare https://github.com/nodejs/node/compare/5eba8094abfa332928cb74b1ba7dc521e7511357..2a723ac6799d177782c651141db8dc91a29df5d3
December 7, 2019 14:25https://github.com/nodejs/node/pull/30837#event-2863551759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562855759
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328559420
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328559791
View reviewed changes https://github.com/nodejs/node/pull/30837/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328559944
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lpincahttps://github.com/lpinca
https://github.com/nodejs/node/pull/30837#pullrequestreview-328559944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562857591
https://ci.nodejs.org/job/node-test-pull-request/27454/https://ci.nodejs.org/job/node-test-pull-request/27454/
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328560228
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328560261
View reviewed changes https://github.com/nodejs/node/pull/30837/files
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/30837#pullrequestreview-328560261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562862932
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#ref-pullrequest-534418720
net: noop destroyed socket #30839 https://github.com/nodejs/node/pull/30839
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328563206
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355129239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355129789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355131129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/lib/_stream_writable.js#L821https://github.com/nodejs/node/blob/master/lib/_stream_writable.js#L821
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355132636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30837#discussion_r355132862
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355184157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355187483
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355187683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355188253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355188966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30837#ref-commit-1efb877
https://github.com/ronag
net: noop destroyed sockethttps://github.com/nxtedition/node/commit/1efb87774d72a1b4cee916daaf387c00e43933f3
1efb877https://github.com/nxtedition/node/commit/1efb87774d72a1b4cee916daaf387c00e43933f3
nodejs#30837https://github.com/nodejs/node/pull/30837
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328587386
View reviewed changes https://github.com/nodejs/node/pull/30837/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355159584
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30837/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019https://github.com/nodejs/node/pull/30837#discussion_r355159728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 8, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562947803
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 8, 2019https://github.com/nodejs/node/pull/30837#issuecomment-562948806
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-328611900
View reviewed changes https://github.com/nodejs/node/pull/30837/files
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 9, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563224596
Please reload this pagehttps://github.com/nodejs/node/pull/30837
@mcollinahttps://github.com/mcollina
#30864 (comment)https://github.com/nodejs/node/issues/30864#issuecomment-563216106
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 9, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563246435
https://ci.nodejs.org/job/node-test-pull-request/27521/https://ci.nodejs.org/job/node-test-pull-request/27521/
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/pull/30837/commits/b1f7bf01b870ce80c34a8b92505dcc0b0582066b
b1f7bf0https://github.com/nodejs/node/pull/30837/commits/b1f7bf01b870ce80c34a8b92505dcc0b0582066b
nodejs#30660https://github.com/nodejs/node/issues/30660
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/1c9c40facba0c07d4b8656bbbe868a7d4a3ee171..b1f7bf01b870ce80c34a8b92505dcc0b0582066b
1c9c40fhttps://github.com/nodejs/node/commit/1c9c40facba0c07d4b8656bbbe868a7d4a3ee171
b1f7bf0https://github.com/nodejs/node/commit/b1f7bf01b870ce80c34a8b92505dcc0b0582066b
Compare https://github.com/nodejs/node/compare/1c9c40facba0c07d4b8656bbbe868a7d4a3ee171..b1f7bf01b870ce80c34a8b92505dcc0b0582066b
December 9, 2019 13:50https://github.com/nodejs/node/pull/30837#event-2866389607
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 9, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563247201
https://ci.nodejs.org/job/node-test-pull-request/27522/https://ci.nodejs.org/job/node-test-pull-request/27522/
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 9, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563247289
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 9, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563323029
Please reload this pagehttps://github.com/nodejs/node/pull/30837
@ronaghttps://github.com/ronag
@mcollinahttps://github.com/mcollina
linked commenthttps://github.com/nodejs/node/issues/30864#issuecomment-563216106
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563524784
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
fixup! fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/pull/30837/commits/a1453c5c985ac93ccf80c44274ae7f7108365ef9
a1453c5https://github.com/nodejs/node/pull/30837/commits/a1453c5c985ac93ccf80c44274ae7f7108365ef9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563538957
https://ci.nodejs.org/job/node-test-pull-request/27544/https://ci.nodejs.org/job/node-test-pull-request/27544/
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563912336
Please reload this pagehttps://github.com/nodejs/node/pull/30837
@mcollinahttps://github.com/mcollina
@benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/blob/master/test/parallel/test-readline-async-iterators-destroy.jshttps://github.com/nodejs/node/blob/master/test/parallel/test-readline-async-iterators-destroy.js
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563955466
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 10, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-329708708
View reviewed changes https://github.com/nodejs/node/pull/30837/files/a1453c5c985ac93ccf80c44274ae7f7108365ef9
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30837#pullrequestreview-329708708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563971197
Please reload this pagehttps://github.com/nodejs/node/pull/30837
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-563980658
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 10, 2019 https://github.com/nodejs/node/pull/30837#pullrequestreview-329818215
View reviewed changes https://github.com/nodejs/node/pull/30837/files/a1453c5c985ac93ccf80c44274ae7f7108365ef9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-564041394
Please reload this pagehttps://github.com/nodejs/node/pull/30837
addaleaxhttps://github.com/addaleax
Dec 10, 2019 https://github.com/nodejs/node/pull/30837#ref-commit-8a5c7f6
https://github.com/addaleax
fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/commit/8a5c7f6abdfb4a8b09bd1de85c6e9819df66ca48
8a5c7f6https://github.com/nodejs/node/commit/8a5c7f6abdfb4a8b09bd1de85c6e9819df66ca48
#30660https://github.com/nodejs/node/issues/30660
#30837https://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30837#issuecomment-564074749
8a5c7f6https://github.com/nodejs/node/commit/8a5c7f6abdfb4a8b09bd1de85c6e9819df66ca48
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30837#event-2870856678
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 10, 2019 15:06https://github.com/nodejs/node/pull/30837#event-2870864690
targoshttps://github.com/targos
Dec 11, 2019 https://github.com/nodejs/node/pull/30837#ref-commit-6c07a72
https://github.com/addaleax
https://github.com/targos
fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/commit/6c07a7283344419994d73aa9fa8e5a802c0859e8
6c07a72https://github.com/nodejs/node/commit/6c07a7283344419994d73aa9fa8e5a802c0859e8
#30660https://github.com/nodejs/node/issues/30660
#30837https://github.com/nodejs/node/pull/30837
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 11, 2019 https://github.com/nodejs/node/pull/30837#ref-issue-536581363
stream: normalized destroy() #30906 https://github.com/nodejs/node/issues/30906
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 13, 2019 https://github.com/nodejs/node/pull/30837#ref-pullrequest-537630771
v13.4.0 proposal #30937 https://github.com/nodejs/node/pull/30937
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30837#ref-commit-c3daa3e
https://github.com/addaleax
https://github.com/targos
fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/commit/c3daa3e3f5a4e64c42589617a51b5d731a6de10c
c3daa3ehttps://github.com/nodejs/node/commit/c3daa3e3f5a4e64c42589617a51b5d731a6de10c
#30660https://github.com/nodejs/node/issues/30660
#30837https://github.com/nodejs/node/pull/30837
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30837#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
https://github.com/RafaelKr
RafaelKrhttps://github.com/RafaelKr
Jan 25, 2020 https://github.com/nodejs/node/pull/30837#ref-pullrequest-555073504
fix: close fds when returning due to different file size rook2pawn/node-filecompare#8 https://github.com/rook2pawn/node-filecompare/pull/8
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30837#ref-commit-578d12f
https://github.com/addaleax
https://github.com/BethGriggs
fs: synchronize close with other I/O for streamshttps://github.com/nodejs/node/commit/578d12fa10502cfe2c2fe370c5f0666ad35037b3
578d12fhttps://github.com/nodejs/node/commit/578d12fa10502cfe2c2fe370c5f0666ad35037b3
#30660https://github.com/nodejs/node/issues/30660
#30837https://github.com/nodejs/node/pull/30837
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30837#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30837
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30837/files/cfe14dd529cd2a792b14ce9100eca37011b98156
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/30837/files/44121f8b6d3833ad5e559b773a5bbd530b486aae
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/30837/files/a1453c5c985ac93ccf80c44274ae7f7108365ef9
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30837/files/44121f8b6d3833ad5e559b773a5bbd530b486aae
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30837/files/a1453c5c985ac93ccf80c44274ae7f7108365ef9
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/30837
https://github.com/addaleax
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/bnoordhuis
https://github.com/Trott
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.