René's URL Explorer Experiment


Title: test: wait for stream close before writing to file by addaleax · Pull Request #30836 · nodejs/node · GitHub

Open Graph Title: test: wait for stream close before writing to file by addaleax · Pull Request #30836 · nodejs/node

X Title: test: wait for stream close before writing to file by addaleax · Pull Request #30836 · nodejs/node

Description: Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. Fixes: #30660 Checklist make -j4 test (UNIX), o...

Open Graph Description: Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. Fixes: #30660 Checklist make -j4 test (UNIX), o...

X Description: Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. Fixes: #30660 Checklist make -j4 test (UNIX), o...

Opengraph URL: https://github.com/nodejs/node/pull/30836

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f69ae808-17af-863c-4123-b7526337f54d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BAC:3E22DA:104EF4B:1678E84:696A8B57
html-safe-nonce7ff465f6140694873563b5beb0a35b081dc98ad914acf944c6a7c3fc965d0729
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkFDOjNFMjJEQToxMDRFRjRCOjE2NzhFODQ6Njk2QThCNTciLCJ2aXNpdG9yX2lkIjoiODMwNTg4NTAyODk3NzExODAzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac184bd11098e78eb422b6ee8e32a0498e7c6ec67b11178489f90d809546519968
hovercard-subject-tagpull_request:350310764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30836/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be350866e38bee05f3fc97155401c9a7b5cab5cef05de60ccba42c0bb3c10b1e/nodejs/node/pull/30836
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be350866e38bee05f3fc97155401c9a7b5cab5cef05de60ccba42c0bb3c10b1e/nodejs/node/pull/30836
og:image:altWait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. Fixes: #30660 Checklist make -j4 test (UNIX), o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30836#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30836
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30836
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30836
Reloadhttps://github.com/nodejs/node/pull/30836
Reloadhttps://github.com/nodejs/node/pull/30836
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30836
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30836
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30836#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:readline-test-await-closehttps://github.com/addaleax/node/tree/readline-test-await-close
test: wait for stream close before writing to file https://github.com/nodejs/node/pull/30836#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:readline-test-await-closehttps://github.com/addaleax/node/tree/readline-test-await-close
Conversation 5 https://github.com/nodejs/node/pull/30836
Commits 1 https://github.com/nodejs/node/pull/30836/commits
Checks 0 https://github.com/nodejs/node/pull/30836/checks
Files changed https://github.com/nodejs/node/pull/30836/files
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30836#issue-534401968
Please reload this pagehttps://github.com/nodejs/node/pull/30836
#30660https://github.com/nodejs/node/issues/30660
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/addaleax
test: wait for stream close before writing to filehttps://github.com/nodejs/node/pull/30836/commits/a118f9bdd4216197330041b1a07799d7db63e317
a118f9bhttps://github.com/nodejs/node/pull/30836/commits/a118f9bdd4216197330041b1a07799d7db63e317
nodejs#30660https://github.com/nodejs/node/issues/30660
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 7, 2019https://github.com/nodejs/node/pull/30836#event-2863520421
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Dec 7, 2019https://github.com/nodejs/node/pull/30836#event-2863522815
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019 https://github.com/nodejs/node/pull/30836#ref-issue-528771101
investigate flaky parallel/test-readline-async-iterators-destroy in CI #30660 https://github.com/nodejs/node/issues/30660
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 7, 2019 https://github.com/nodejs/node/pull/30836#pullrequestreview-328559568
View reviewed changes https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 7, 2019 https://github.com/nodejs/node/pull/30836#pullrequestreview-328559682
View reviewed changes https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2019https://github.com/nodejs/node/pull/30836#issuecomment-562857775
https://ci.nodejs.org/job/node-test-pull-request/27455/https://ci.nodejs.org/job/node-test-pull-request/27455/
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 8, 2019 https://github.com/nodejs/node/pull/30836#pullrequestreview-328584507
View reviewed changes https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 8, 2019 https://github.com/nodejs/node/pull/30836#pullrequestreview-328587600
View reviewed changes https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2019https://github.com/nodejs/node/pull/30836#issuecomment-564043201
https://ci.nodejs.org/job/node-test-pull-request/27552/https://ci.nodejs.org/job/node-test-pull-request/27552/
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 10, 2019https://github.com/nodejs/node/pull/30836#event-2871712694
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2019https://github.com/nodejs/node/pull/30836#issuecomment-564183518
https://ci.nodejs.org/job/node-test-pull-request/27558/https://ci.nodejs.org/job/node-test-pull-request/27558/
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Dec 10, 2019 https://github.com/nodejs/node/pull/30836#ref-issue-535941695
Two tests consistently failing on ARM #30890 https://github.com/nodejs/node/issues/30890
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2019https://github.com/nodejs/node/pull/30836#issuecomment-564209644
https://ci.nodejs.org/job/node-test-pull-request/27560/https://ci.nodejs.org/job/node-test-pull-request/27560/
Please reload this pagehttps://github.com/nodejs/node/pull/30836
addaleaxhttps://github.com/addaleax
Dec 10, 2019 https://github.com/nodejs/node/pull/30836#ref-commit-b7d87e3
https://github.com/addaleax
test: wait for stream close before writing to filehttps://github.com/nodejs/node/commit/b7d87e31f5add8e7bc93f6bcb32f01bc947206c4
b7d87e3https://github.com/nodejs/node/commit/b7d87e31f5add8e7bc93f6bcb32f01bc947206c4
#30836https://github.com/nodejs/node/pull/30836
#30660https://github.com/nodejs/node/issues/30660
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30836#issuecomment-564252592
b7d87e3https://github.com/nodejs/node/commit/b7d87e31f5add8e7bc93f6bcb32f01bc947206c4
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 10, 2019https://github.com/nodejs/node/pull/30836#event-2872034537
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 10, 2019 20:52https://github.com/nodejs/node/pull/30836#event-2872035028
targoshttps://github.com/targos
Dec 11, 2019 https://github.com/nodejs/node/pull/30836#ref-commit-ce21fc7
https://github.com/addaleax
https://github.com/targos
test: wait for stream close before writing to filehttps://github.com/nodejs/node/commit/ce21fc715450641b926328f668c60cb6f768576d
ce21fc7https://github.com/nodejs/node/commit/ce21fc715450641b926328f668c60cb6f768576d
#30836https://github.com/nodejs/node/pull/30836
#30660https://github.com/nodejs/node/issues/30660
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 13, 2019 https://github.com/nodejs/node/pull/30836#ref-pullrequest-537630771
v13.4.0 proposal #30937 https://github.com/nodejs/node/pull/30937
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30836#ref-commit-bf9a824
https://github.com/addaleax
https://github.com/targos
test: wait for stream close before writing to filehttps://github.com/nodejs/node/commit/bf9a824c0a4d7a2c96cd89631f8422c359500b68
bf9a824https://github.com/nodejs/node/commit/bf9a824c0a4d7a2c96cd89631f8422c359500b68
#30836https://github.com/nodejs/node/pull/30836
#30660https://github.com/nodejs/node/issues/30660
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30836#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30836#ref-commit-5bffe11
https://github.com/addaleax
https://github.com/BethGriggs
test: wait for stream close before writing to filehttps://github.com/nodejs/node/commit/5bffe11cab76b39179a3d3fbc9adb74a512b6919
5bffe11https://github.com/nodejs/node/commit/5bffe11cab76b39179a3d3fbc9adb74a512b6919
#30836https://github.com/nodejs/node/pull/30836
#30660https://github.com/nodejs/node/issues/30660
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30836#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30836
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30836/files/a118f9bdd4216197330041b1a07799d7db63e317
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
investigate flaky parallel/test-readline-async-iterators-destroy in CI https://github.com/nodejs/node/issues/30660
Please reload this pagehttps://github.com/nodejs/node/pull/30836
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.