René's URL Explorer Experiment


Title: module: fix require in node repl by ZYSzys · Pull Request #30835 · nodejs/node · GitHub

Open Graph Title: module: fix require in node repl by ZYSzys · Pull Request #30835 · nodejs/node

X Title: module: fix require in node repl by ZYSzys · Pull Request #30835 · nodejs/node

Description: Fixes: #30808 In REPL, module.filename is null, and for relative path modules, we shouldn't look up relative modules from node_modules. > module.filename null > Checklist make -j4 test (UNIX), ...

Open Graph Description: Fixes: #30808 In REPL, module.filename is null, and for relative path modules, we shouldn't look up relative modules from node_modules. > module.filename null > Checklist make -j4 tes...

X Description: Fixes: #30808 In REPL, module.filename is null, and for relative path modules, we shouldn't look up relative modules from node_modules. > module.filename null > Checklist ...

Opengraph URL: https://github.com/nodejs/node/pull/30835

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4576a946-fcb7-fe37-df7b-374516eea2f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3DE:22EDB8:3F52A1:55C9F6:696AA82A
html-safe-nonced7b1338abc7d8f248a0b55d841b6f0824d06eb000683b82707f0509058181600
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0RFOjIyRURCODozRjUyQTE6NTVDOUY2OjY5NkFBODJBIiwidmlzaXRvcl9pZCI6IjUwODI1NTUwODMxMzE2Mjc1NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac509c2c7e1b5ec5f55b671b002bb790fbcacc09cfc1429f4340687e3f08ccc3ae
hovercard-subject-tagpull_request:350310405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30835/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/29982d5b0a5c6b85c0e84fce065469ac3cc5bd2904afec7faa7cc0f57001be44/nodejs/node/pull/30835
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/29982d5b0a5c6b85c0e84fce065469ac3cc5bd2904afec7faa7cc0f57001be44/nodejs/node/pull/30835
og:image:altFixes: #30808 In REPL, module.filename is null, and for relative path modules, we shouldn't look up relative modules from node_modules. > module.filename null > Checklist make -j4 tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30835#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30835
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30835
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30835
Reloadhttps://github.com/nodejs/node/pull/30835
Reloadhttps://github.com/nodejs/node/pull/30835
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30835
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/30835
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/30835#issue-comment-box
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
module: fix require in node repl https://github.com/nodejs/node/pull/30835#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 9 https://github.com/nodejs/node/pull/30835
Commits 2 https://github.com/nodejs/node/pull/30835/commits
Checks 0 https://github.com/nodejs/node/pull/30835/checks
Files changed https://github.com/nodejs/node/pull/30835/files
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 7, 2019https://github.com/nodejs/node/pull/30835#issue-534401473
Please reload this pagehttps://github.com/nodejs/node/pull/30835
#30808https://github.com/nodejs/node/issues/30808
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/ZYSzys
module: fix require in node replhttps://github.com/nodejs/node/pull/30835/commits/7815ee6e79f640323b21b2f4e9671285dc97f5fd
7815ee6https://github.com/nodejs/node/pull/30835/commits/7815ee6e79f640323b21b2f4e9671285dc97f5fd
#30808https://github.com/nodejs/node/issues/30808
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
bmeckhttps://github.com/bmeck
December 7, 2019 13:24https://github.com/nodejs/node/pull/30835#event-2863518700
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Dec 7, 2019https://github.com/nodejs/node/pull/30835#event-2863518827
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
bmeckhttps://github.com/bmeck
December 7, 2019 13:24https://github.com/nodejs/node/pull/30835#event-2863519018
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30835
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 7, 2019 https://github.com/nodejs/node/pull/30835#pullrequestreview-328557329
View reviewed changes https://github.com/nodejs/node/pull/30835/files/7815ee6e79f640323b21b2f4e9671285dc97f5fd
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/30835/files/7815ee6e79f640323b21b2f4e9671285dc97f5fd#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
ZYSzyshttps://github.com/ZYSzys
Dec 7, 2019https://github.com/nodejs/node/pull/30835#discussion_r355122557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30835
https://github.com/ZYSzys
fixup!https://github.com/nodejs/node/pull/30835/commits/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
ea05ebchttps://github.com/nodejs/node/pull/30835/commits/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2019https://github.com/nodejs/node/pull/30835#issuecomment-562857905
https://ci.nodejs.org/job/node-test-pull-request/27456/https://ci.nodejs.org/job/node-test-pull-request/27456/
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 7, 2019 https://github.com/nodejs/node/pull/30835#ref-issue-533388793
Surprising require('./file') behavior when ran from REPL #30808 https://github.com/nodejs/node/issues/30808
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 8, 2019 https://github.com/nodejs/node/pull/30835#pullrequestreview-328599702
View reviewed changes https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/30835#pullrequestreview-328599702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Dec 9, 2019 https://github.com/nodejs/node/pull/30835#pullrequestreview-328652408
View reviewed changes https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/nodejs/node/pull/30835#pullrequestreview-328652408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Dec 9, 2019 https://github.com/nodejs/node/pull/30835#pullrequestreview-328653043
View reviewed changes https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/30835#pullrequestreview-328653043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 9, 2019 https://github.com/nodejs/node/pull/30835#pullrequestreview-328686731
View reviewed changes https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 9, 2019https://github.com/nodejs/node/pull/30835#issuecomment-563062111
https://ci.nodejs.org/job/node-test-pull-request/27510/https://ci.nodejs.org/job/node-test-pull-request/27510/
Please reload this pagehttps://github.com/nodejs/node/pull/30835
ZYSzyshttps://github.com/ZYSzys
Dec 10, 2019 https://github.com/nodejs/node/pull/30835#ref-commit-7629fb2
https://github.com/ZYSzys
module: fix require in node replhttps://github.com/nodejs/node/commit/7629fb25f2c97de9926f71724072ad2b2af27c85
7629fb2https://github.com/nodejs/node/commit/7629fb25f2c97de9926f71724072ad2b2af27c85
#30808https://github.com/nodejs/node/issues/30808
#30835https://github.com/nodejs/node/pull/30835
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 10, 2019https://github.com/nodejs/node/pull/30835#issuecomment-563539938
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 10, 2019https://github.com/nodejs/node/pull/30835#event-2868480261
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
December 10, 2019 04:06https://github.com/nodejs/node/pull/30835#event-2868719613
targoshttps://github.com/targos
Dec 10, 2019 https://github.com/nodejs/node/pull/30835#ref-commit-8e16093
https://github.com/ZYSzys
https://github.com/targos
module: fix require in node replhttps://github.com/nodejs/node/commit/8e16093b646811c5b8f2624297e3667388f87352
8e16093https://github.com/nodejs/node/commit/8e16093b646811c5b8f2624297e3667388f87352
#30808https://github.com/nodejs/node/issues/30808
#30835https://github.com/nodejs/node/pull/30835
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 13, 2019 https://github.com/nodejs/node/pull/30835#ref-pullrequest-537630771
v13.4.0 proposal #30937 https://github.com/nodejs/node/pull/30937
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30835#ref-commit-ffc910f
https://github.com/ZYSzys
https://github.com/targos
module: fix require in node replhttps://github.com/nodejs/node/commit/ffc910f9f7e465c0d757c5c7c143e9a02b125c5b
ffc910fhttps://github.com/nodejs/node/commit/ffc910f9f7e465c0d757c5c7c143e9a02b125c5b
#30808https://github.com/nodejs/node/issues/30808
#30835https://github.com/nodejs/node/pull/30835
https://github.com/targos
targoshttps://github.com/targos
Jan 15, 2020 https://github.com/nodejs/node/pull/30835#ref-pullrequest-550126622
v12.15.0 release proposal #31368 https://github.com/nodejs/node/pull/31368
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30835#ref-commit-e5437ef
https://github.com/ZYSzys
https://github.com/BethGriggs
module: fix require in node replhttps://github.com/nodejs/node/commit/e5437ef355c6956df7eeb47cf0612867392376a7
e5437efhttps://github.com/nodejs/node/commit/e5437ef355c6956df7eeb47cf0612867392376a7
#30808https://github.com/nodejs/node/issues/30808
#30835https://github.com/nodejs/node/pull/30835
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 8, 2020 https://github.com/nodejs/node/pull/30835#ref-pullrequest-561953943
v12.16.0 proposal #31691 https://github.com/nodejs/node/pull/31691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30835
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/30835/files/ea05ebc41b0395bb6d225c21613c82be97cd8e3c
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Surprising require('./file') behavior when ran from REPL https://github.com/nodejs/node/issues/30808
Please reload this pagehttps://github.com/nodejs/node/pull/30835
https://github.com/ZYSzys
https://github.com/nodejs-github-bot
https://github.com/guybedford
https://github.com/Trott
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.