| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5707e2a-7959-54cf-3ba0-69091e26dd0e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDA0:2A0D62:C3DE31:10EDBC0:696A8B58 |
| html-safe-nonce | 786a499f965f18dc55a68118e51299429e52eebb467180f22316bc429fb32e2e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREEwOjJBMEQ2MjpDM0RFMzE6MTBFREJDMDo2OTZBOEI1OCIsInZpc2l0b3JfaWQiOiIyOTAwNDU3MzA0ODQ3NDQ1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ca661c314fb6ea37d9050d37f235d8aa47efcd31a46362b7ad4e7cb2d5cb4797 |
| hovercard-subject-tag | pull_request:350274906 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30830/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f1024c3457ba17037438d195f5f549aa476db757d3395fecf5bd04877a36f190/nodejs/node/pull/30830 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f1024c3457ba17037438d195f5f549aa476db757d3395fecf5bd04877a36f190/nodejs/node/pull/30830 |
| og:image:alt | Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.
Fixes: #30048
Refs: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | saitolume |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30830#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30830 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30830 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30830 |
| Reload | https://github.com/nodejs/node/pull/30830 |
| Reload | https://github.com/nodejs/node/pull/30830 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/30830#issue-comment-box |
| saitolume | https://github.com/saitolume |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| saitolume:fix-http-doc | https://github.com/saitolume/node/tree/fix-http-doc |
|
doc: update message.url example in http.IncomingMessage
| https://github.com/nodejs/node/pull/30830#top |
| saitolume | https://github.com/saitolume |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| saitolume:fix-http-doc | https://github.com/saitolume/node/tree/fix-http-doc |
|
Conversation
6
| https://github.com/nodejs/node/pull/30830 |
|
Commits
3
| https://github.com/nodejs/node/pull/30830/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/30830/checks |
|
Files changed
1
| https://github.com/nodejs/node/pull/30830/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/saitolume |
| saitolume | https://github.com/saitolume |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30830#issue-534351978 |
| #30048 | https://github.com/nodejs/node/issues/30048 |
| https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url | https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
|
| https://github.com/saitolume |
| doc: update message.url example in http.IncomingMessage | https://github.com/nodejs/node/pull/30830/commits/8f76b058fca97bf259ac78b2c253048b3c128963 |
| 8f76b05 | https://github.com/nodejs/node/pull/30830/commits/8f76b058fca97bf259ac78b2c253048b3c128963 |
| nodejs#30048 | https://github.com/nodejs/node/issues/30048 |
| https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url | https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30830#event-2863270398 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30830#pullrequestreview-328580314 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30830/files/8f76b058fca97bf259ac78b2c253048b3c128963 |
| doc/api/http.md | https://github.com/nodejs/node/pull/30830/files/8f76b058fca97bf259ac78b2c253048b3c128963#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 7, 2019
| https://github.com/nodejs/node/pull/30830#pullrequestreview-328580328 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30830/files/8f76b058fca97bf259ac78b2c253048b3c128963 |
| doc/api/http.md | https://github.com/nodejs/node/pull/30830/files/8f76b058fca97bf259ac78b2c253048b3c128963#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 7, 2019 | https://github.com/nodejs/node/pull/30830#issuecomment-562896535 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
|
| https://github.com/saitolume |
| doc: wrap message.url description at 80 characters | https://github.com/nodejs/node/pull/30830/commits/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
| 3efb569 | https://github.com/nodejs/node/pull/30830/commits/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
| nodejs#30048 | https://github.com/nodejs/node/issues/30048 |
| nodejs#30830 | https://github.com/nodejs/node/pull/30830 |
| https://github.com/saitolume |
| saitolume | https://github.com/saitolume |
| Trott | https://github.com/Trott |
| December 8, 2019 09:44 | https://github.com/nodejs/node/pull/30830#event-2864069613 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30830#pullrequestreview-333552153 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 18, 2019
| https://github.com/nodejs/node/pull/30830#pullrequestreview-333683359 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
| doc/api/http.md | https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 18, 2019
| https://github.com/nodejs/node/pull/30830#pullrequestreview-333683684 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
|
| https://github.com/saitolume |
|
| https://github.com/Trott |
| doc: replace specific strings with variables | https://github.com/nodejs/node/pull/30830/commits/ab5561e1155db813800f392d9b6a6ba0dec8bdd9 |
| ab5561e | https://github.com/nodejs/node/pull/30830/commits/ab5561e1155db813800f392d9b6a6ba0dec8bdd9 |
| Trott | https://github.com/Trott |
|
Dec 18, 2019
| https://github.com/nodejs/node/pull/30830#ref-commit-eaf5975 |
|
| https://github.com/saitolume |
|
| https://github.com/Trott |
| doc: update message.url example in http.IncomingMessage | https://github.com/Trott/io.js/commit/eaf59754be421498287a7bf2471b83e629da1911 |
| eaf5975 | https://github.com/Trott/io.js/commit/eaf59754be421498287a7bf2471b83e629da1911 |
| nodejs#30048 | https://github.com/nodejs/node/issues/30048 |
| nodejs#30830 | https://github.com/nodejs/node/pull/30830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 18, 2019 | https://github.com/nodejs/node/pull/30830#issuecomment-567030898 |
| eaf5975 | https://github.com/nodejs/node/commit/eaf59754be421498287a7bf2471b83e629da1911 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 18, 2019 | https://github.com/nodejs/node/pull/30830#event-2893538926 |
| https://github.com/saitolume |
| saitolume | https://github.com/saitolume |
| December 18, 2019 13:29 | https://github.com/nodejs/node/pull/30830#event-2893542374 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 3, 2020
| https://github.com/nodejs/node/pull/30830#ref-commit-7815d5f |
|
| https://github.com/saitolume |
|
| https://github.com/BridgeAR |
| doc: update message.url example in http.IncomingMessage | https://github.com/nodejs/node/commit/7815d5f2cb40b8ff29477ce27142e940aeeed30c |
| 7815d5f | https://github.com/nodejs/node/commit/7815d5f2cb40b8ff29477ce27142e940aeeed30c |
| #30048 | https://github.com/nodejs/node/issues/30048 |
| #30830 | https://github.com/nodejs/node/pull/30830 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 7, 2020
| https://github.com/nodejs/node/pull/30830#ref-pullrequest-546134970 |
|
v13.6.0 proposal
#31238
| https://github.com/nodejs/node/pull/31238 |
| targos | https://github.com/targos |
|
Jan 14, 2020
| https://github.com/nodejs/node/pull/30830#ref-commit-08186b2 |
|
| https://github.com/saitolume |
|
| https://github.com/targos |
| doc: update message.url example in http.IncomingMessage | https://github.com/nodejs/node/commit/08186b25f7e0b5b9d9ff16bec7de375d964ee16d |
| 08186b2 | https://github.com/nodejs/node/commit/08186b25f7e0b5b9d9ff16bec7de375d964ee16d |
| #30048 | https://github.com/nodejs/node/issues/30048 |
| #30830 | https://github.com/nodejs/node/pull/30830 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 15, 2020
| https://github.com/nodejs/node/pull/30830#ref-pullrequest-550126622 |
|
v12.15.0 release proposal
#31368
| https://github.com/nodejs/node/pull/31368 |
| BethGriggs | https://github.com/BethGriggs |
|
Feb 6, 2020
| https://github.com/nodejs/node/pull/30830#ref-commit-5536048 |
|
| https://github.com/saitolume |
|
| https://github.com/BethGriggs |
| doc: update message.url example in http.IncomingMessage | https://github.com/nodejs/node/commit/55360487b7407fc862311c554c77862b9f1cf81c |
| 5536048 | https://github.com/nodejs/node/commit/55360487b7407fc862311c554c77862b9f1cf81c |
| #30048 | https://github.com/nodejs/node/issues/30048 |
| #30830 | https://github.com/nodejs/node/pull/30830 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 8, 2020
| https://github.com/nodejs/node/pull/30830#ref-pullrequest-561953943 |
|
v12.16.0 proposal
#31691
| https://github.com/nodejs/node/pull/31691 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Oct 2, 2020
| https://github.com/nodejs/node/pull/30830#ref-issue-713458901 |
|
using Whatwg url to parse relative urls received via http may fail
#35458
| https://github.com/nodejs/node/issues/35458 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30830 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/30830/files/3efb569478650ef4e142ca2f6e620cad37b47ba7 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
Documentation for http.message.url suggests using deprecated url API
| https://github.com/nodejs/node/issues/30048 |
| Please reload this page | https://github.com/nodejs/node/pull/30830 |
|
| https://github.com/saitolume |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |