René's URL Explorer Experiment


Title: assert: handle (deep) equal(NaN, NaN) as being identical by BridgeAR · Pull Request #30766 · nodejs/node · GitHub

Open Graph Title: assert: handle (deep) equal(NaN, NaN) as being identical by BridgeAR · Pull Request #30766 · nodejs/node

X Title: assert: handle (deep) equal(NaN, NaN) as being identical by BridgeAR · Pull Request #30766 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This aligns the equal and deepEqual() implementation with the strict version by accepting NaN as being identical in case both sides are NaN. Refs: #30350 (comment) Checklist make -j4 test (UNIX...

X Description: This aligns the equal and deepEqual() implementation with the strict version by accepting NaN as being identical in case both sides are NaN. Refs: #30350 (comment) Checklist make -j4 test (UNIX...

Opengraph URL: https://github.com/nodejs/node/pull/30766

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d19dd871-a0a6-6fc8-3276-fdacf3557c08
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8A6:315724:75161:9A10D:6A4D91F7
html-safe-nonceac837a90c501451f1d00de3a8a1ef2622f74e65584465bd00ca6338d39d8a6c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEE2OjMxNTcyNDo3NTE2MTo5QTEwRDo2QTREOTFGNyIsInZpc2l0b3JfaWQiOiI4NjUwNzMxMDg4NTEzOTYyNDg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca1cce0c89f2866a72e1c398d207c9ac702db8a66c5b2ea1a2c3af163bc200c97
hovercard-subject-tagpull_request:347775170
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30766/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/afb2155a7bf5e58866202d517be45a8a8af2a9763b5767b65d5c0accdb620cf5/nodejs/node/pull/30766
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/afb2155a7bf5e58866202d517be45a8a8af2a9763b5767b65d5c0accdb620cf5/nodejs/node/pull/30766
og:image:altThis aligns the equal and deepEqual() implementation with the strict version by accepting NaN as being identical in case both sides are NaN. Refs: #30350 (comment) Checklist make -j4 test (UNIX...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release74e2a9c78f1e38588de4f25885878349d721eedf
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30766#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30766
Reloadhttps://github.com/nodejs/node/pull/30766
Reloadhttps://github.com/nodejs/node/pull/30766
Please reload this pagehttps://github.com/nodejs/node/pull/30766
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30766
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:align-deep-equal-nanhttps://github.com/BridgeAR/node/tree/align-deep-equal-nan
Conversationhttps://github.com/nodejs/node/pull/30766
Commits5 (5)https://github.com/nodejs/node/pull/30766/commits
Checkshttps://github.com/nodejs/node/pull/30766/checks
Files changedhttps://github.com/nodejs/node/pull/30766/files
assert: handle (deep) equal(NaN, NaN) as being identicalhttps://github.com/nodejs/node/pull/30766#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:align-deep-equal-nanhttps://github.com/BridgeAR/node/tree/align-deep-equal-nan
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 2, 2019https://github.com/nodejs/node/pull/30766#issue-531310093
#30350 (comment)https://github.com/nodejs/node/issues/30350#issuecomment-552191641
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
assert: handle (deep) equal(NaN, NaN) as being identicalhttps://github.com/nodejs/node/pull/30766/commits/d5cdde725ffc8bfa37a3c7fb384c49cfe3c2b692
d5cdde7https://github.com/nodejs/node/pull/30766/commits/d5cdde725ffc8bfa37a3c7fb384c49cfe3c2b692
nodejs#30350 (comment)https://github.com/nodejs/node/issues/30350#issuecomment-552191641
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
addaleaxhttps://github.com/addaleax
December 2, 2019 17:15https://github.com/nodejs/node/pull/30766#event-2846530616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Dec 2, 2019https://github.com/nodejs/node/pull/30766#event-2846530856
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Dec 2, 2019https://github.com/nodejs/node/pull/30766#event-2846531492
https://github.com/BridgeAR
fixup: add pr numberhttps://github.com/nodejs/node/pull/30766/commits/fa78dd80866cd394d6b059540ee0d5d5256bca9c
fa78dd8https://github.com/nodejs/node/pull/30766/commits/fa78dd80866cd394d6b059540ee0d5d5256bca9c
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
https://github.com/BridgeAR
fixup: add missing "changes"https://github.com/nodejs/node/pull/30766/commits/0076178e589b631e58a4eff65450d8f1f673444e
0076178https://github.com/nodejs/node/pull/30766/commits/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 2, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-325526910
View reviewed changes https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Dec 3, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-325943883
View reviewed changes https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
test/parallel/test-assert.jshttps://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 3, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-326039490
View reviewed changes https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Dec 3, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-326040488
View reviewed changes https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 3, 2019https://github.com/nodejs/node/pull/30766#issuecomment-561266348
https://ci.nodejs.org/job/node-test-pull-request/27307/https://ci.nodejs.org/job/node-test-pull-request/27307/
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 3, 2019https://github.com/nodejs/node/pull/30766#event-2850905604
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 5, 2019https://github.com/nodejs/node/pull/30766#issuecomment-561979478
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 5, 2019https://github.com/nodejs/node/pull/30766#issuecomment-561979840
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
fixup: update documentationhttps://github.com/nodejs/node/pull/30766/commits/d883bdf43a50df73bf9556314321f69364ba90f6
d883bdfhttps://github.com/nodejs/node/pull/30766/commits/d883bdf43a50df73bf9556314321f69364ba90f6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2019https://github.com/nodejs/node/pull/30766#issuecomment-562382598
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://ci.nodejs.org/job/node-test-pull-request/27376/https://ci.nodejs.org/job/node-test-pull-request/27376/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2111/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2111/
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2019https://github.com/nodejs/node/pull/30766#issuecomment-562382778
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 6, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-328342930
View reviewed changes https://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6
doc/api/assert.mdhttps://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 6, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-328343112
View reviewed changes https://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6
doc/api/assert.mdhttps://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 6, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-328343185
View reviewed changes https://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6
doc/api/assert.mdhttps://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 6, 2019 https://github.com/nodejs/node/pull/30766#pullrequestreview-328343265
View reviewed changes https://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6
https://github.com/BridgeAR
fixup: add backtickshttps://github.com/nodejs/node/pull/30766/commits/d698d7a374496d2e39014ce8e97980b65fb4bb66
d698d7ahttps://github.com/nodejs/node/pull/30766/commits/d698d7a374496d2e39014ce8e97980b65fb4bb66
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2019https://github.com/nodejs/node/pull/30766#issuecomment-562749423
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://ci.nodejs.org/job/node-test-pull-request/27419/https://ci.nodejs.org/job/node-test-pull-request/27419/
Please reload this pagehttps://github.com/nodejs/node/pull/30766
BridgeARhttps://github.com/BridgeAR
Dec 6, 2019 https://github.com/nodejs/node/pull/30766#ref-commit-5360dd1
https://github.com/BridgeAR
assert: handle (deep) equal(NaN, NaN) as being identicalhttps://github.com/nodejs/node/commit/5360dd151da9d8b1c97785a0e394cc731af31f69
5360dd1https://github.com/nodejs/node/commit/5360dd151da9d8b1c97785a0e394cc731af31f69
#30350 (comment)https://github.com/nodejs/node/issues/30350#issuecomment-552191641
#30766https://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2019https://github.com/nodejs/node/pull/30766#issuecomment-562784710
5360dd1https://github.com/nodejs/node/commit/5360dd151da9d8b1c97785a0e394cc731af31f69
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2019https://github.com/nodejs/node/pull/30766#event-2863072633
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 12:07https://github.com/nodejs/node/pull/30766#event-2962709872
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 10, 2020 https://github.com/nodejs/node/pull/30766#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30766
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30766/files/d883bdf43a50df73bf9556314321f69364ba90f6
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30766/files/0076178e589b631e58a4eff65450d8f1f673444e
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/30766
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/addaleax
https://github.com/devnexen
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.