René's URL Explorer Experiment


Title: stream: ensure finish is emitted in next tick by ronag · Pull Request #30733 · nodejs/node · GitHub

Open Graph Title: stream: ensure finish is emitted in next tick by ronag · Pull Request #30733 · nodejs/node

X Title: stream: ensure finish is emitted in next tick by ronag · Pull Request #30733 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When using end() it was possible for 'finish' to be emitted synchronously causing incorrect behaviour and subtle bugs. This is an edge case not usually encountered since a write() is usuall...

X Description: When using end() it was possible for 'finish' to be emitted synchronously causing incorrect behaviour and subtle bugs. This is an edge case not usually encountered since a write() i...

Opengraph URL: https://github.com/nodejs/node/pull/30733

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:65f1bab6-5aa1-37b1-4431-e59c4ab93ecf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA44E:1B9CED:1232232:18AE5A0:6A507DF0
html-safe-noncebe8046cb88ed88133ecce4908402cd9a8d6996212b85ac81ad31f063179c40c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDRFOjFCOUNFRDoxMjMyMjMyOjE4QUU1QTA6NkE1MDdERjAiLCJ2aXNpdG9yX2lkIjoiODg1MTcwMDM0MzUzMDA5NDA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac81c12e9a8a9d845f316c2b0c2bd3b643ebd41525d12a05cb9cd549fcb8636310
hovercard-subject-tagpull_request:347229726
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30733/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3061d2282c338e9de9226a1ceabaddb83c0c870ba77d67b471aa3557acfac711/nodejs/node/pull/30733
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3061d2282c338e9de9226a1ceabaddb83c0c870ba77d67b471aa3557acfac711/nodejs/node/pull/30733
og:image:altWhen using end() it was possible for 'finish' to be emitted synchronously causing incorrect behaviour and subtle bugs. This is an edge case not usually encountered since a write() is usuall...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30733#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30733
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30733
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30733
Reloadhttps://github.com/nodejs/node/pull/30733
Reloadhttps://github.com/nodejs/node/pull/30733
Please reload this pagehttps://github.com/nodejs/node/pull/30733
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30733
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-stream-finishhttps://github.com/nxtedition/node/tree/fix-stream-finish
Conversationhttps://github.com/nodejs/node/pull/30733
Commits1 (1)https://github.com/nodejs/node/pull/30733/commits
Checkshttps://github.com/nodejs/node/pull/30733/checks
Files changedhttps://github.com/nodejs/node/pull/30733/files
stream: ensure finish is emitted in next tickhttps://github.com/nodejs/node/pull/30733#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-stream-finishhttps://github.com/nxtedition/node/tree/fix-stream-finish
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 30, 2019https://github.com/nodejs/node/pull/30733#issue-530586908
Please reload this pagehttps://github.com/nodejs/node/pull/30733
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Nov 30, 2019https://github.com/nodejs/node/pull/30733#event-2842754875
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 30, 2019https://github.com/nodejs/node/pull/30733#issuecomment-559976827
Please reload this pagehttps://github.com/nodejs/node/pull/30733
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e1978319ca2668cb1e0cd5e1f1471189b906fc53..a9e54cc06f6232909ff60bad1ba97851d6b00d3a
e197831https://github.com/nodejs/node/commit/e1978319ca2668cb1e0cd5e1f1471189b906fc53
a9e54cchttps://github.com/nodejs/node/commit/a9e54cc06f6232909ff60bad1ba97851d6b00d3a
Compare https://github.com/nodejs/node/compare/e1978319ca2668cb1e0cd5e1f1471189b906fc53..a9e54cc06f6232909ff60bad1ba97851d6b00d3a
November 30, 2019 15:02https://github.com/nodejs/node/pull/30733#event-2842767399
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 30, 2019 https://github.com/nodejs/node/pull/30733#ref-pullrequest-530589985
stream: improve write performance #30736 https://github.com/nodejs/node/pull/30736
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 30, 2019https://github.com/nodejs/node/pull/30733#issuecomment-559986521
@Trotthttps://github.com/Trott
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/a9e54cc06f6232909ff60bad1ba97851d6b00d3a..7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89
a9e54cchttps://github.com/nodejs/node/commit/a9e54cc06f6232909ff60bad1ba97851d6b00d3a
7ee659fhttps://github.com/nodejs/node/commit/7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89
Compare https://github.com/nodejs/node/compare/a9e54cc06f6232909ff60bad1ba97851d6b00d3a..7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89
November 30, 2019 17:51https://github.com/nodejs/node/pull/30733#event-2842881857
https://github.com/ronag
stream: ensure finish is emitted in next tickhttps://github.com/nodejs/node/pull/30733/commits/cdc12a6774927900a54abcd7cf5c1bc781f56960
cdc12a6https://github.com/nodejs/node/pull/30733/commits/cdc12a6774927900a54abcd7cf5c1bc781f56960
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89..cdc12a6774927900a54abcd7cf5c1bc781f56960
7ee659fhttps://github.com/nodejs/node/commit/7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89
cdc12a6https://github.com/nodejs/node/commit/cdc12a6774927900a54abcd7cf5c1bc781f56960
Compare https://github.com/nodejs/node/compare/7ee659f1ae880804e9d4b2ca7c9b14ff0f8cff89..cdc12a6774927900a54abcd7cf5c1bc781f56960
November 30, 2019 17:57https://github.com/nodejs/node/pull/30733#event-2842885421
https://github.com/lpinca
lpincahttps://github.com/lpinca
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Dec 1, 2019https://github.com/nodejs/node/pull/30733#event-2843499210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 1, 2019https://github.com/nodejs/node/pull/30733#issuecomment-560117930
https://ci.nodejs.org/job/node-test-pull-request/27252/https://ci.nodejs.org/job/node-test-pull-request/27252/
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 1, 2019https://github.com/nodejs/node/pull/30733#issuecomment-560118127
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2100/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2100/
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019 https://github.com/nodejs/node/pull/30733#ref-pullrequest-527358420
stream: call _final synchronously #30597 https://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30733#issuecomment-562844082
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30733#issuecomment-562847495
Please reload this pagehttps://github.com/nodejs/node/pull/30733
#30832https://github.com/nodejs/node/issues/30832
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 7, 2019https://github.com/nodejs/node/pull/30733#issuecomment-562850122
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019 https://github.com/nodejs/node/pull/30733#pullrequestreview-328577296
View reviewed changes https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 7, 2019https://github.com/nodejs/node/pull/30733#issuecomment-562890388
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 8, 2019 https://github.com/nodejs/node/pull/30733#pullrequestreview-328600225
View reviewed changes https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30733#pullrequestreview-328600225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 12, 2019https://github.com/nodejs/node/pull/30733#issuecomment-565160748
Please reload this pagehttps://github.com/nodejs/node/pull/30733
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019https://github.com/nodejs/node/pull/30733#issuecomment-565753767
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 14, 2019https://github.com/nodejs/node/pull/30733#event-2883612989
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019 https://github.com/nodejs/node/pull/30733#pullrequestreview-332232457
View reviewed changes https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
Trotthttps://github.com/Trott
Dec 14, 2019 https://github.com/nodejs/node/pull/30733#ref-commit-e13a37e
https://github.com/ronag
https://github.com/Trott
stream: ensure finish is emitted in next tickhttps://github.com/nodejs/node/commit/e13a37e49d9f9f495cf96c825a64b5754766d348
e13a37ehttps://github.com/nodejs/node/commit/e13a37e49d9f9f495cf96c825a64b5754766d348
#30733https://github.com/nodejs/node/pull/30733
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019https://github.com/nodejs/node/pull/30733#issuecomment-565753850
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2019https://github.com/nodejs/node/pull/30733#event-2883613416
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 10, 2020 https://github.com/nodejs/node/pull/30733#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30733
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30733/files/cdc12a6774927900a54abcd7cf5c1bc781f56960
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/30733
https://github.com/ronag
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/benjamingr
https://github.com/addaleax
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.