| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e65a7b99-48c6-fcc0-93d9-3f850fe0645d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A782:188FE8:5FCC3C8:867DD9A:6A501FBE |
| html-safe-nonce | acda806ce57cc0baa39f1c0048ae9b7dcb4afa15cf96236cac6281e261554358 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzgyOjE4OEZFODo1RkNDM0M4Ojg2N0REOUE6NkE1MDFGQkUiLCJ2aXNpdG9yX2lkIjoiMTA5MzI1MTk4NTMwODY1NTU1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | af01bc90365370428ac7a3012370f2d07045de2b2d5d88cc45d04f4a5f082183 |
| hovercard-subject-tag | pull_request:347187208 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30726/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/166bf7463a773a874080aa4480b73f39f79f166130065a5f432bf1f4dc6ae0d9/nodejs/node/pull/30726 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/166bf7463a773a874080aa4480b73f39f79f166130065a5f432bf1f4dc6ae0d9/nodejs/node/pull/30726 |
| og:image:alt | This is a backport of #30724 to v12. The changes are adapted for v10.
@nodejs/backporters I will update this with any feedback from the original PR. This needs to land soon after to avoid issues ru... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joaocgreis |
| hostname | github.com |
| expected-hostname | github.com |
| None | a08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1b91b18e7330fc458dfd824c61eaed7daa830d6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30726#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30726 |
| Reload | https://github.com/nodejs/node/pull/30726 |
| Reload | https://github.com/nodejs/node/pull/30726 |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joaocgreis | https://github.com/joaocgreis |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| JaneaSystems:joaocgreis-JBR-vcbuild-CI-v10 | https://github.com/JaneaSystems/node/tree/joaocgreis-JBR-vcbuild-CI-v10 |
| Conversation | https://github.com/nodejs/node/pull/30726 |
| Commits2 (2) | https://github.com/nodejs/node/pull/30726/commits |
| Checks | https://github.com/nodejs/node/pull/30726/checks |
| Files changed | https://github.com/nodejs/node/pull/30726/files |
| [v10.x backport] Windows CI job update changes | https://github.com/nodejs/node/pull/30726#top |
| joaocgreis | https://github.com/joaocgreis |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| JaneaSystems:joaocgreis-JBR-vcbuild-CI-v10 | https://github.com/JaneaSystems/node/tree/joaocgreis-JBR-vcbuild-CI-v10 |
|
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/30726#issue-530525130 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| joaocgreis | https://github.com/joaocgreis |
| November 29, 2019 01:48 | https://github.com/nodejs/node/pull/30726#commits-pushed-f99ca87 |
|
| https://github.com/joaocgreis |
| build,win: add test-ci-native and test-ci-js | https://github.com/nodejs/node/pull/30726/commits/f99ca878b7b9fa4fa28ccba61cbee454262d0db0 |
| f99ca87 | https://github.com/nodejs/node/pull/30726/commits/f99ca878b7b9fa4fa28ccba61cbee454262d0db0 |
|
| https://github.com/joaocgreis |
| build,win: propagate error codes in vcbuild | https://github.com/nodejs/node/pull/30726/commits/40974316ff3c6d69ef72d00165b2092d2fec865e |
| 4097431 | https://github.com/nodejs/node/pull/30726/commits/40974316ff3c6d69ef72d00165b2092d2fec865e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/30726#event-2842438196 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 2, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-560473240 |
| @joaocgreis | https://github.com/joaocgreis |
| nodejs/build#2072 | https://github.com/nodejs/build/issues/2072 |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30726#pullrequestreview-326035009 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30726/files/40974316ff3c6d69ef72d00165b2092d2fec865e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-561104083 |
| https://ci.nodejs.org/job/node-test-pull-request/27303/ | https://ci.nodejs.org/job/node-test-pull-request/27303/ |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-561261745 |
| @BethGriggs | https://github.com/BethGriggs |
| #30725 | https://github.com/nodejs/node/pull/30725 |
| #30727 | https://github.com/nodejs/node/pull/30727 |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-561278158 |
| @joaocgreis | https://github.com/joaocgreis |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30726#ref-commit-c3e3862 |
|
| https://github.com/joaocgreis |
|
| https://github.com/BethGriggs |
| build,win: add test-ci-native and test-ci-js | https://github.com/nodejs/node/commit/c3e386284e4d34d99eecaa0e83bd11917db9a5de |
| c3e3862 | https://github.com/nodejs/node/commit/c3e386284e4d34d99eecaa0e83bd11917db9a5de |
| #30726 | https://github.com/nodejs/node/pull/30726 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| nodejs/build#1996 | https://github.com/nodejs/build/issues/1996 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30726#ref-commit-4d3ec1a |
|
| https://github.com/joaocgreis |
|
| https://github.com/BethGriggs |
| build,win: propagate error codes in vcbuild | https://github.com/nodejs/node/commit/4d3ec1a43eaabc258a639ea3dc83be39a74496e7 |
| 4d3ec1a | https://github.com/nodejs/node/commit/4d3ec1a43eaabc258a639ea3dc83be39a74496e7 |
| #30726 | https://github.com/nodejs/node/pull/30726 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| nodejs/build#1996 | https://github.com/nodejs/build/issues/1996 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-561293103 |
| 14e7a35...4d3ec1a | https://github.com/nodejs/node/compare/14e7a35e95b35beb5b9e42ed5813e9ccc4afa4e0...4d3ec1a43eaabc258a639ea3dc83be39a74496e7 |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#event-2851125604 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30726#issuecomment-561398865 |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 16, 2019
| https://github.com/nodejs/node/pull/30726#ref-commit-54a466a |
|
| https://github.com/joaocgreis |
|
| https://github.com/MylesBorins |
| build,win: add test-ci-native and test-ci-js | https://github.com/nodejs/node/commit/54a466a8655dce2151f937da0c0ac43954e09c01 |
| 54a466a | https://github.com/nodejs/node/commit/54a466a8655dce2151f937da0c0ac43954e09c01 |
| #30726 | https://github.com/nodejs/node/pull/30726 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| nodejs/build#1996 | https://github.com/nodejs/build/issues/1996 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30726#ref-commit-68b2b5c |
|
| https://github.com/joaocgreis |
|
| https://github.com/MylesBorins |
| build,win: propagate error codes in vcbuild | https://github.com/nodejs/node/commit/68b2b5cc5110ada9876e33273b1801f1f8088cc5 |
| 68b2b5c | https://github.com/nodejs/node/commit/68b2b5cc5110ada9876e33273b1801f1f8088cc5 |
| #30726 | https://github.com/nodejs/node/pull/30726 |
| #30724 | https://github.com/nodejs/node/pull/30724 |
| nodejs/build#1996 | https://github.com/nodejs/build/issues/1996 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30726 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/30726/files/40974316ff3c6d69ef72d00165b2092d2fec865e |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/30726 |
|
| https://github.com/joaocgreis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |