| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6d8ed94c-be01-a9f9-aaba-ec5313453fe0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBA4:31006B:1273EF9:18B538D:696AD873 |
| html-safe-nonce | 88e383c26ea3ff0b4572cf10b9fb3d4ca6452e41c4682ce800dc1137f8dc02dc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkE0OjMxMDA2QjoxMjczRUY5OjE4QjUzOEQ6Njk2QUQ4NzMiLCJ2aXNpdG9yX2lkIjoiNzExMDU1NzkwMzUwNzYwOTcxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a6f5bf350fbcdbbd07cf9c501022555a3578981566f2f213d595c320ed3d99b |
| hovercard-subject-tag | pull_request:346589005 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30699/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7581cac62b925e7a89990e5d198f075256164982199812dbc7f78025d6ef424d/nodejs/node/pull/30699 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7581cac62b925e7a89990e5d198f075256164982199812dbc7f78025d6ef424d/nodejs/node/pull/30699 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | juanarbol |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 524a93f2c1f36522a3b4be4c110467ee4172245d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30699#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30699 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30699 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30699 |
| Reload | https://github.com/nodejs/node/pull/30699 |
| Reload | https://github.com/nodejs/node/pull/30699 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/30699#issue-comment-box |
| juanarbol | https://github.com/juanarbol |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| juanarbol:esmod-as-cjmodule | https://github.com/juanarbol/node/tree/esmod-as-cjmodule |
|
WIP Make CJS suggestions when file ext is not provided
| https://github.com/nodejs/node/pull/30699#top |
| juanarbol | https://github.com/juanarbol |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| juanarbol:esmod-as-cjmodule | https://github.com/juanarbol/node/tree/esmod-as-cjmodule |
|
Conversation
19
| https://github.com/nodejs/node/pull/30699 |
|
Commits
2
| https://github.com/nodejs/node/pull/30699/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/30699/checks |
|
Files changed
| https://github.com/nodejs/node/pull/30699/files |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Nov 28, 2019 | https://github.com/nodejs/node/pull/30699#issue-529777113 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
|
| https://github.com/juanarbol |
| lib: remove extra espace on cjs loader | https://github.com/nodejs/node/pull/30699/commits/49dc5147d2ecd5bd40170b7bb22e028f062c96f0 |
| 49dc514 | https://github.com/nodejs/node/pull/30699/commits/49dc5147d2ecd5bd40170b7bb22e028f062c96f0 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Nov 28, 2019
| https://github.com/nodejs/node/pull/30699#ref-issue-527394798 |
|
Better not found errors for ESM
#30603
| https://github.com/nodejs/node/issues/30603 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Nov 28, 2019
| https://github.com/nodejs/node/pull/30699#pullrequestreview-324137905 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30699/files |
| lib/internal/modules/esm/default_resolve.js | https://github.com/nodejs/node/pull/30699/files#diff-a60f22852105e202a6de8237a500f28a3e901390b473f5084424530e4cf933bd |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| December 4, 2019 05:07 | https://github.com/nodejs/node/pull/30699#event-2852651425 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Dec 4, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-561479693 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Dec 4, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-561480379 |
| https://github.com/nodejs/node/blob/master/test/message/esm_loader_not_found.out | https://github.com/nodejs/node/blob/master/test/message/esm_loader_not_found.out |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Dec 4, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-561481201 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Dec 4, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-561481596 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Dec 4, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-561481894 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30699#pullrequestreview-329374183 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30699/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/30699#pullrequestreview-329374183 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Dec 11, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-564569587 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Dec 18, 2019
| https://github.com/nodejs/node/pull/30699#ref-pullrequest-528690629 |
|
doc: clarify extensionless esm
#30657
| https://github.com/nodejs/node/pull/30657 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 24, 2019 | https://github.com/nodejs/node/pull/30699#issuecomment-568781730 |
| @juanarbol | https://github.com/juanarbol |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Dec 24, 2019 | https://github.com/nodejs/node/pull/30699#event-2907177663 |
|
| https://github.com/juanarbol |
| lib,test: print CJS suggestions when ES not found | https://github.com/nodejs/node/pull/30699/commits/3e23195859e2ccafb7864f6a426380c4deeccdef |
| 3e23195 | https://github.com/nodejs/node/pull/30699/commits/3e23195859e2ccafb7864f6a426380c4deeccdef |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| force-pushed | https://github.com/nodejs/node/compare/f2eb75babbf56ba55938a4f0d043a243e4f58fd2..3e23195859e2ccafb7864f6a426380c4deeccdef |
| f2eb75b | https://github.com/nodejs/node/commit/f2eb75babbf56ba55938a4f0d043a243e4f58fd2 |
| 3e23195 | https://github.com/nodejs/node/commit/3e23195859e2ccafb7864f6a426380c4deeccdef |
|
Compare
| https://github.com/nodejs/node/compare/f2eb75babbf56ba55938a4f0d043a243e4f58fd2..3e23195859e2ccafb7864f6a426380c4deeccdef |
| December 26, 2019 18:34 | https://github.com/nodejs/node/pull/30699#event-2909503573 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Dec 26, 2019
| https://github.com/nodejs/node/pull/30699#pullrequestreview-336588504 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30699/files/3e23195859e2ccafb7864f6a426380c4deeccdef |
| test/es-module/test-esm-cjs-loader-suggestions.mjs | https://github.com/nodejs/node/pull/30699/files/3e23195859e2ccafb7864f6a426380c4deeccdef#diff-f3e1d544e6ea8086d5b69cbce20d6d0d17dd903cf3215f46e3dc021cdb9f9dc2 |
| juanarbol | https://github.com/juanarbol |
| Dec 26, 2019 | https://github.com/nodejs/node/pull/30699#discussion_r361510250 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| BridgeAR | https://github.com/BridgeAR |
| Jan 2, 2020 | https://github.com/nodejs/node/pull/30699#discussion_r362508776 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
| Jan 2, 2020 | https://github.com/nodejs/node/pull/30699#issuecomment-570239633 |
| #31021 | https://github.com/nodejs/node/pull/31021 |
| https://github.com/nodejs/node/blob/master/test/fixtures/es-modules/package-type-module/extension.unknown | https://github.com/nodejs/node/blob/master/test/fixtures/es-modules/package-type-module/extension.unknown |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 12, 2020 | https://github.com/nodejs/node/pull/30699#issuecomment-573369016 |
| @juanarbol | https://github.com/juanarbol |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jan 13, 2020 | https://github.com/nodejs/node/pull/30699#issuecomment-573477009 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Mar 2, 2020 | https://github.com/nodejs/node/pull/30699#issuecomment-593586629 |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Mar 2, 2020 | https://github.com/nodejs/node/pull/30699#event-3089420004 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| January 19, 2021 16:24 | https://github.com/nodejs/node/pull/30699#event-4223436700 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30699 |
|
| https://github.com/guybedford |
|
guybedford
| https://github.com/guybedford |
|
| https://github.com/nodejs/node/pull/30699/files/b5b2fca40acbf3e863213b9ef29194d19639b111 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30699/files/3e23195859e2ccafb7864f6a426380c4deeccdef |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/30699 |
|
| https://github.com/juanarbol |
|
| https://github.com/guybedford |
|
| https://github.com/BridgeAR |
|
| https://github.com/bmeck |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |