| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:ad33318c-fba7-6929-0367-63dd2c991b1f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 874E:69662:5768A13:7AC6624:6A4FB174 |
| html-safe-nonce | ab17309484e0e92e5a6a2b2f5ecfc78793b7b9753517120472d2a883bfb22edb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzRFOjY5NjYyOjU3NjhBMTM6N0FDNjYyNDo2QTRGQjE3NCIsInZpc2l0b3JfaWQiOiIzNDE4MTk0MTA0MjAyMjc3MjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3301004e72585f9164daaa292d6d41eda80906c76b7430c588cb3f4eecfec531 |
| hovercard-subject-tag | pull_request:346436301 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/30691 |
| twitter:image | https://opengraph.githubassets.com/484a48c1748ddcd87e035e2943f961fa1cd6205906fe42c32e41aae52f4484f8/nodejs/node/pull/30691 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/484a48c1748ddcd87e035e2943f961fa1cd6205906fe42c32e41aae52f4484f8/nodejs/node/pull/30691 |
| og:image:alt | Edit note in about onread option to socket.connect() for clarity.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows com... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30691#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30691 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30691 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30691 |
| Reload | https://github.com/nodejs/node/pull/30691 |
| Reload | https://github.com/nodejs/node/pull/30691 |
| Please reload this page | https://github.com/nodejs/node/pull/30691 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30691 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:net-note | https://github.com/Trott/io.js/tree/net-note |
| Conversation | https://github.com/nodejs/node/pull/30691 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30691/commits |
| Checks | https://github.com/nodejs/node/pull/30691/checks |
| Files changed | https://github.com/nodejs/node/pull/30691/files |
| doc: revise socket.connect() note | https://github.com/nodejs/node/pull/30691#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:net-note | https://github.com/Trott/io.js/tree/net-note |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 27, 2019 | https://github.com/nodejs/node/pull/30691#issue-529586039 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30691 |
|
| https://github.com/Trott |
| doc: revise socket.connect() note | https://github.com/nodejs/node/pull/30691/commits/647bfeea27b398683f62bae8fe620cea415c1a51 |
| 647bfee | https://github.com/nodejs/node/pull/30691/commits/647bfeea27b398683f62bae8fe620cea415c1a51 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Nov 27, 2019 | https://github.com/nodejs/node/pull/30691#event-2837091166 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 27, 2019
| https://github.com/nodejs/node/pull/30691#pullrequestreview-323961427 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30691/files/647bfeea27b398683f62bae8fe620cea415c1a51 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 28, 2019 | https://github.com/nodejs/node/pull/30691#event-2837455349 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30691#pullrequestreview-324870579 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30691/files/647bfeea27b398683f62bae8fe620cea415c1a51 |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30691#ref-commit-1b11039 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: revise socket.connect() note | https://github.com/nodejs/node/commit/1b110396e7d4e4495cafe53c03022083bc1f4d83 |
| 1b11039 | https://github.com/nodejs/node/commit/1b110396e7d4e4495cafe53c03022083bc1f4d83 |
| #30691 | https://github.com/nodejs/node/pull/30691 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/30691#issuecomment-559899627 |
| 1b11039 | https://github.com/nodejs/node/commit/1b110396e7d4e4495cafe53c03022083bc1f4d83 |
| Please reload this page | https://github.com/nodejs/node/pull/30691 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 30, 2019 | https://github.com/nodejs/node/pull/30691#event-2842385844 |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30691#ref-commit-87136c9 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: revise socket.connect() note | https://github.com/nodejs/node/commit/87136c9bde8ebff235b11f8f315ad30d4030d457 |
| 87136c9 | https://github.com/nodejs/node/commit/87136c9bde8ebff235b11f8f315ad30d4030d457 |
| #30691 | https://github.com/nodejs/node/pull/30691 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30691#ref-pullrequest-531889133 |
|
v13.3.0 proposal
#30774
| https://github.com/nodejs/node/pull/30774 |
| targos | https://github.com/targos |
|
Dec 5, 2019
| https://github.com/nodejs/node/pull/30691#ref-commit-44b474d |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: revise socket.connect() note | https://github.com/nodejs/node/commit/44b474dc854f71d8ac1db1ac336e238542ae1900 |
| 44b474d | https://github.com/nodejs/node/commit/44b474dc854f71d8ac1db1ac336e238542ae1900 |
| #30691 | https://github.com/nodejs/node/pull/30691 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30691#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30691#ref-commit-6fc562c |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: revise socket.connect() note | https://github.com/nodejs/node/commit/6fc562c97c123c96ed7d90de4055c3367a71a4fc |
| 6fc562c | https://github.com/nodejs/node/commit/6fc562c97c123c96ed7d90de4055c3367a71a4fc |
| #30691 | https://github.com/nodejs/node/pull/30691 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30691#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30691 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30691/files/647bfeea27b398683f62bae8fe620cea415c1a51 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30691/files/647bfeea27b398683f62bae8fe620cea415c1a51 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Please reload this page | https://github.com/nodejs/node/pull/30691 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |