René's URL Explorer Experiment


Title: dns: use length for building TXT string by addaleax · Pull Request #30690 · nodejs/node · GitHub

Open Graph Title: dns: use length for building TXT string by addaleax · Pull Request #30690 · nodejs/node

X Title: dns: use length for building TXT string by addaleax · Pull Request #30690 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Rely on the length reported by C-Ares rather than \0-termination for creating the JS string for a dns TXT response. Fixes: #30688 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

X Description: Rely on the length reported by C-Ares rather than \0-termination for creating the JS string for a dns TXT response. Fixes: #30688 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

Opengraph URL: https://github.com/nodejs/node/pull/30690

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6f42db59-fd31-170e-3a30-7a5179b3de55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1E0:162B2:44744D1:600FF68:6A4F7633
html-safe-nonce0984c13d6fe3e5b14c7e5c89fabbd1828c297afcda8ff0436b9ac1d9e2475881
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUUwOjE2MkIyOjQ0NzQ0RDE6NjAwRkY2ODo2QTRGNzYzMyIsInZpc2l0b3JfaWQiOiIzNjYyNDgwMDE1NjU4ODA4ODgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac580edcdbcc5995014f8f9bfb36ceb3c735ba095986e806814b1d49d9939abeb3
hovercard-subject-tagpull_request:346422102
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30690/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eb6781646e704afe2a4b8c2a5b04f49e30ffb54f5e12217f3714fb35b62e5f58/nodejs/node/pull/30690
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb6781646e704afe2a4b8c2a5b04f49e30ffb54f5e12217f3714fb35b62e5f58/nodejs/node/pull/30690
og:image:altRely on the length reported by C-Ares rather than \0-termination for creating the JS string for a dns TXT response. Fixes: #30688 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30690#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30690
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30690
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30690
Reloadhttps://github.com/nodejs/node/pull/30690
Reloadhttps://github.com/nodejs/node/pull/30690
Please reload this pagehttps://github.com/nodejs/node/pull/30690
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30690
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dns-txt-nullhttps://github.com/addaleax/node/tree/dns-txt-null
Conversationhttps://github.com/nodejs/node/pull/30690
Commits1 (1)https://github.com/nodejs/node/pull/30690/commits
Checkshttps://github.com/nodejs/node/pull/30690/checks
Files changedhttps://github.com/nodejs/node/pull/30690/files
dns: use length for building TXT stringhttps://github.com/nodejs/node/pull/30690#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dns-txt-nullhttps://github.com/addaleax/node/tree/dns-txt-null
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 27, 2019https://github.com/nodejs/node/pull/30690#issue-529568607
#30688https://github.com/nodejs/node/issues/30688
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30690
https://github.com/addaleax
dns: use length for building TXT stringhttps://github.com/nodejs/node/pull/30690/commits/d58b7c278700e3bbacc9300c9c5306b07c72c70a
d58b7c2https://github.com/nodejs/node/pull/30690/commits/d58b7c278700e3bbacc9300c9c5306b07c72c70a
nodejs#30688https://github.com/nodejs/node/issues/30688
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
Nov 27, 2019https://github.com/nodejs/node/pull/30690#event-2836987552
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 27, 2019https://github.com/nodejs/node/pull/30690#issuecomment-559247927
https://ci.nodejs.org/job/node-test-pull-request/27091/https://ci.nodejs.org/job/node-test-pull-request/27091/
Please reload this pagehttps://github.com/nodejs/node/pull/30690
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 27, 2019 https://github.com/nodejs/node/pull/30690#ref-issue-529564077
dns: invalid TXT response #30688 https://github.com/nodejs/node/issues/30688
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 27, 2019 https://github.com/nodejs/node/pull/30690#pullrequestreview-323942458
View reviewed changes https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Nov 28, 2019 https://github.com/nodejs/node/pull/30690#pullrequestreview-324115979
View reviewed changes https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 28, 2019 https://github.com/nodejs/node/pull/30690#pullrequestreview-324223793
View reviewed changes https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 29, 2019 https://github.com/nodejs/node/pull/30690#pullrequestreview-324824208
View reviewed changes https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 30, 2019https://github.com/nodejs/node/pull/30690#event-2842383827
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 30, 2019https://github.com/nodejs/node/pull/30690#issuecomment-559899349
https://ci.nodejs.org/job/node-test-pull-request/27185/https://ci.nodejs.org/job/node-test-pull-request/27185/
Please reload this pagehttps://github.com/nodejs/node/pull/30690
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2019https://github.com/nodejs/node/pull/30690#issuecomment-559901263
48cadcbhttps://github.com/nodejs/node/commit/48cadcb7aa902ee1af01357a2cf340ae5bc60f87
Please reload this pagehttps://github.com/nodejs/node/pull/30690
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30690#ref-commit-48cadcb
https://github.com/addaleax
dns: use length for building TXT stringhttps://github.com/nodejs/node/commit/48cadcb7aa902ee1af01357a2cf340ae5bc60f87
48cadcbhttps://github.com/nodejs/node/commit/48cadcb7aa902ee1af01357a2cf340ae5bc60f87
#30688https://github.com/nodejs/node/issues/30688
#30690https://github.com/nodejs/node/pull/30690
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 30, 2019https://github.com/nodejs/node/pull/30690#event-2842397357
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 30, 2019 01:04https://github.com/nodejs/node/pull/30690#event-2842397434
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30690#ref-commit-f37450f
https://github.com/addaleax
dns: use length for building TXT stringhttps://github.com/nodejs/node/commit/f37450f58075bcc2ec2c04fae40b874683eb418c
f37450fhttps://github.com/nodejs/node/commit/f37450f58075bcc2ec2c04fae40b874683eb418c
#30688https://github.com/nodejs/node/issues/30688
#30690https://github.com/nodejs/node/pull/30690
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30690#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
targoshttps://github.com/targos
Dec 5, 2019 https://github.com/nodejs/node/pull/30690#ref-commit-053c179
https://github.com/addaleax
https://github.com/targos
dns: use length for building TXT stringhttps://github.com/nodejs/node/commit/053c179571589cfdb96a24c0ac7f1de84ef708d5
053c179https://github.com/nodejs/node/commit/053c179571589cfdb96a24c0ac7f1de84ef708d5
#30688https://github.com/nodejs/node/issues/30688
#30690https://github.com/nodejs/node/pull/30690
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30690#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30690#ref-commit-ded0748
https://github.com/addaleax
https://github.com/MylesBorins
dns: use length for building TXT stringhttps://github.com/nodejs/node/commit/ded0748dea3933c231a9734be5dfb816ff55b61f
ded0748https://github.com/nodejs/node/commit/ded0748dea3933c231a9734be5dfb816ff55b61f
#30688https://github.com/nodejs/node/issues/30688
#30690https://github.com/nodejs/node/pull/30690
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30690#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30690
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30690/files/d58b7c278700e3bbacc9300c9c5306b07c72c70a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
dns: invalid TXT response https://github.com/nodejs/node/issues/30688
Please reload this pagehttps://github.com/nodejs/node/pull/30690
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/devnexen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.