| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6dbf29bb-c21b-e85e-17c1-3f2b7599e37a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D20A:CD887:3CA4A7C:5402184:6A4F4CF5 |
| html-safe-nonce | eb932afd3c343f454465671ba1f4afd49aff32f58c5bf2bc2684c276c33789d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjBBOkNEODg3OjNDQTRBN0M6NTQwMjE4NDo2QTRGNENGNSIsInZpc2l0b3JfaWQiOiIyNzk5MTMwMDcyMzQ2MjE3NzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 72a3f27eb11bac64cf7d370573103347f7f04462239b80686f2cb4c28d08117d |
| hovercard-subject-tag | pull_request:344750449 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30608/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f798364917ed9137d433b3656364d3a3ff395e710af7d8d428c803733cbe3933/nodejs/node/pull/30608 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f798364917ed9137d433b3656364d3a3ff395e710af7d8d428c803733cbe3933/nodejs/node/pull/30608 |
| og:image:alt | The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.
Refs: #30607
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | richardlau |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30608#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30608 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30608 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30608 |
| Reload | https://github.com/nodejs/node/pull/30608 |
| Reload | https://github.com/nodejs/node/pull/30608 |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
969
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:mininum-icu | https://github.com/richardlau/node-1/tree/mininum-icu |
| Conversation | https://github.com/nodejs/node/pull/30608 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30608/commits |
| Checks | https://github.com/nodejs/node/pull/30608/checks |
| Files changed | https://github.com/nodejs/node/pull/30608/files |
| test: test for minimum ICU version consistency | https://github.com/nodejs/node/pull/30608#top |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:mininum-icu | https://github.com/richardlau/node-1/tree/mininum-icu |
|
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#issue-527476664 |
| #30607 | https://github.com/nodejs/node/pull/30607 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#event-2824952694 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 23, 2019
| https://github.com/nodejs/node/pull/30608#ref-pullrequest-527459820 |
|
doc,deps: document how to maintain ICU in Node.js
#30607
| https://github.com/nodejs/node/pull/30607 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#event-2824956489 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#issuecomment-557742893 |
| https://ci.nodejs.org/job/node-test-pull-request/26867/ | https://ci.nodejs.org/job/node-test-pull-request/26867/ |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Nov 23, 2019
| https://github.com/nodejs/node/pull/30608#pullrequestreview-321882324 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30608/files |
| srl295 | https://github.com/srl295 |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/nodejs/node/pull/30608#pullrequestreview-321882324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 23, 2019
| https://github.com/nodejs/node/pull/30608#pullrequestreview-321882991 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30608/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#event-2825016411 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#issuecomment-557750880 |
| https://ci.nodejs.org/job/node-test-pull-request/26869/ | https://ci.nodejs.org/job/node-test-pull-request/26869/ |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Nov 23, 2019
| https://github.com/nodejs/node/pull/30608#pullrequestreview-321890631 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30608/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 23, 2019 | https://github.com/nodejs/node/pull/30608#issuecomment-557762675 |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://ci.nodejs.org/job/node-test-pull-request/26872/ | https://ci.nodejs.org/job/node-test-pull-request/26872/ |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 23, 2019
| https://github.com/nodejs/node/pull/30608#pullrequestreview-321913686 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30608/files |
|
| https://github.com/richardlau |
| test: test for minimum ICU version consistency | https://github.com/nodejs/node/pull/30608/commits/f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| f2060fa | https://github.com/nodejs/node/pull/30608/commits/f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| nodejs#30608 | https://github.com/nodejs/node/pull/30608 |
| nodejs#30607 | https://github.com/nodejs/node/pull/30607 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| force-pushed | https://github.com/nodejs/node/compare/3dab3f06df75454b3f9e5aeeb80423bb1aec917a..f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| 3dab3f0 | https://github.com/nodejs/node/commit/3dab3f06df75454b3f9e5aeeb80423bb1aec917a |
| f2060fa | https://github.com/nodejs/node/commit/f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
|
Compare
| https://github.com/nodejs/node/compare/3dab3f06df75454b3f9e5aeeb80423bb1aec917a..f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| November 26, 2019 00:41 | https://github.com/nodejs/node/pull/30608#event-2830120893 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 26, 2019 | https://github.com/nodejs/node/pull/30608#event-2830124253 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| f2060fa | https://github.com/nodejs/node/commit/f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| Nov 26, 2019 | https://github.com/nodejs/node/pull/30608#event-2830153410 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 26, 2019 | https://github.com/nodejs/node/pull/30608#issuecomment-558410841 |
| f2060fa | https://github.com/nodejs/node/commit/f2060fa9e6d7b179c3c49b2e630e3bc981a565de |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| November 26, 2019 01:01 | https://github.com/nodejs/node/pull/30608#event-2830154895 |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30608#ref-commit-d651c7d |
|
| https://github.com/richardlau |
|
| https://github.com/addaleax |
| test: test for minimum ICU version consistency | https://github.com/nodejs/node/commit/d651c7dd6b11b9681e014d2cfcce1a498214d225 |
| d651c7d | https://github.com/nodejs/node/commit/d651c7dd6b11b9681e014d2cfcce1a498214d225 |
| #30608 | https://github.com/nodejs/node/pull/30608 |
| #30607 | https://github.com/nodejs/node/pull/30607 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30608#ref-commit-c50e4f9 |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
| test: test for minimum ICU version consistency | https://github.com/nodejs/node/commit/c50e4f9dae755e7af58dc2268175b62f3dd900cc |
| c50e4f9 | https://github.com/nodejs/node/commit/c50e4f9dae755e7af58dc2268175b62f3dd900cc |
| #30608 | https://github.com/nodejs/node/pull/30608 |
| #30607 | https://github.com/nodejs/node/pull/30607 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30608#ref-pullrequest-531889133 |
|
v13.3.0 proposal
#30774
| https://github.com/nodejs/node/pull/30774 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30608#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30608#ref-commit-1c9ba2c |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| test: test for minimum ICU version consistency | https://github.com/nodejs/node/commit/1c9ba2cdc3634896b47ec218083a3561f8d923b4 |
| 1c9ba2c | https://github.com/nodejs/node/commit/1c9ba2cdc3634896b47ec218083a3561f8d923b4 |
| #30608 | https://github.com/nodejs/node/pull/30608 |
| #30607 | https://github.com/nodejs/node/pull/30607 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30608#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30608 |
|
| https://github.com/srl295 |
|
srl295
| https://github.com/srl295 |
|
| https://github.com/nodejs/node/pull/30608/files/3dab3f06df75454b3f9e5aeeb80423bb1aec917a |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30608/files/3dab3f06df75454b3f9e5aeeb80423bb1aec917a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30608/files/3dab3f06df75454b3f9e5aeeb80423bb1aec917a |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30608/files/3dab3f06df75454b3f9e5aeeb80423bb1aec917a |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/30608 |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/srl295 |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/gengjiawen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |