René's URL Explorer Experiment


Title: tools: update ESLint to 6.7.1 by cjihrig · Pull Request #30598 · nodejs/node · GitHub

Open Graph Title: tools: update ESLint to 6.7.1 by cjihrig · Pull Request #30598 · nodejs/node

X Title: tools: update ESLint to 6.7.1 by cjihrig · Pull Request #30598 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This also enables a handful of new ESLint rules that were added in 6.7.0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This also enables a handful of new ESLint rules that were added in 6.7.0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30598

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:01c18c27-af23-0f81-2b8c-5dea214a5160
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD7A:13C54:1D55686:284E497:6A4F2C52
html-safe-nonce54073b3ebb648d255ae44f39db95b8460b9c0e409a82ca908f9012718b661b8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDdBOjEzQzU0OjFENTU2ODY6Mjg0RTQ5Nzo2QTRGMkM1MiIsInZpc2l0b3JfaWQiOiIxMjU1Njg1OTc3NzAxMDM1MDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac94e65e7aeb34313a4dc120ef3dbd3f9bacfd7cfacbd28723e98bdc96f30ca4bf
hovercard-subject-tagpull_request:344664843
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30598/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9a78ebba4ba7d8fe24fb0987d3a2c3b01436d6ebd277db6feda6891dea4e180d/nodejs/node/pull/30598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a78ebba4ba7d8fe24fb0987d3a2c3b01436d6ebd277db6feda6891dea4e180d/nodejs/node/pull/30598
og:image:altThis also enables a handful of new ESLint rules that were added in 6.7.0. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30598#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30598
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30598
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30598
Reloadhttps://github.com/nodejs/node/pull/30598
Reloadhttps://github.com/nodejs/node/pull/30598
Please reload this pagehttps://github.com/nodejs/node/pull/30598
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30598
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:eslinthttps://github.com/cjihrig/node/tree/eslint
Conversationhttps://github.com/nodejs/node/pull/30598
Commits2 (2)https://github.com/nodejs/node/pull/30598/commits
Checkshttps://github.com/nodejs/node/pull/30598/checks
Files changedhttps://github.com/nodejs/node/pull/30598/files
tools: update ESLint to 6.7.1https://github.com/nodejs/node/pull/30598#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:eslinthttps://github.com/cjihrig/node/tree/eslint
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 22, 2019https://github.com/nodejs/node/pull/30598#issue-527373455
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Nov 22, 2019https://github.com/nodejs/node/pull/30598#event-2824330390
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 22, 2019 https://github.com/nodejs/node/pull/30598#pullrequestreview-321805995
View reviewed changes https://github.com/nodejs/node/pull/30598/files
https://github.com/targos
targoshttps://github.com/targos
Nov 22, 2019 https://github.com/nodejs/node/pull/30598#pullrequestreview-321827782
View reviewed changes https://github.com/nodejs/node/pull/30598/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 22, 2019 https://github.com/nodejs/node/pull/30598#pullrequestreview-321845698
View reviewed changes https://github.com/nodejs/node/pull/30598/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 22, 2019https://github.com/nodejs/node/pull/30598#event-2824801194
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/3fb31655ee1ea18065bf3e767f50e5b77c2fee44..e4cc7dced09685c40fe2377837b1c52cad0e110a
3fb3165https://github.com/nodejs/node/commit/3fb31655ee1ea18065bf3e767f50e5b77c2fee44
e4cc7dchttps://github.com/nodejs/node/commit/e4cc7dced09685c40fe2377837b1c52cad0e110a
Compare https://github.com/nodejs/node/compare/3fb31655ee1ea18065bf3e767f50e5b77c2fee44..e4cc7dced09685c40fe2377837b1c52cad0e110a
November 25, 2019 03:39https://github.com/nodejs/node/pull/30598#event-2826567551
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 25, 2019https://github.com/nodejs/node/pull/30598#event-2826567992
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-557991270
https://ci.nodejs.org/job/node-test-pull-request/26945/https://ci.nodejs.org/job/node-test-pull-request/26945/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558156081
https://ci.nodejs.org/job/node-test-pull-request/26952/https://ci.nodejs.org/job/node-test-pull-request/26952/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558196237
https://ci.nodejs.org/job/node-test-pull-request/26961/https://ci.nodejs.org/job/node-test-pull-request/26961/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558202233
https://ci.nodejs.org/job/node-test-pull-request/26963/https://ci.nodejs.org/job/node-test-pull-request/26963/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558228722
https://ci.nodejs.org/job/node-test-pull-request/26965/https://ci.nodejs.org/job/node-test-pull-request/26965/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558243079
https://ci.nodejs.org/job/node-test-commit-linux-containered/16163/https://ci.nodejs.org/job/node-test-commit-linux-containered/16163/
Please reload this pagehttps://github.com/nodejs/node/pull/30598
cjihrighttps://github.com/cjihrig
November 25, 2019 11:55https://github.com/nodejs/node/pull/30598#commits-pushed-90fb308
https://github.com/cjihrig
tools: update ESLint to 6.7.1https://github.com/nodejs/node/pull/30598/commits/90fb308de42575adeed82d864da57148049185b3
90fb308https://github.com/nodejs/node/pull/30598/commits/90fb308de42575adeed82d864da57148049185b3
nodejs#30598https://github.com/nodejs/node/pull/30598
https://github.com/cjihrig
tools: enable more eslint ruleshttps://github.com/nodejs/node/pull/30598/commits/a50cc2ed0eecf89713ea11c64b00dee416c88362
a50cc2ehttps://github.com/nodejs/node/pull/30598/commits/a50cc2ed0eecf89713ea11c64b00dee416c88362
nodejs#30598https://github.com/nodejs/node/pull/30598
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/e4cc7dced09685c40fe2377837b1c52cad0e110a..a50cc2ed0eecf89713ea11c64b00dee416c88362
e4cc7dchttps://github.com/nodejs/node/commit/e4cc7dced09685c40fe2377837b1c52cad0e110a
a50cc2ehttps://github.com/nodejs/node/commit/a50cc2ed0eecf89713ea11c64b00dee416c88362
Compare https://github.com/nodejs/node/compare/e4cc7dced09685c40fe2377837b1c52cad0e110a..a50cc2ed0eecf89713ea11c64b00dee416c88362
November 25, 2019 16:57https://github.com/nodejs/node/pull/30598#event-2828885327
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
a50cc2ehttps://github.com/nodejs/node/commit/a50cc2ed0eecf89713ea11c64b00dee416c88362
Nov 25, 2019https://github.com/nodejs/node/pull/30598#event-2828887708
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 25, 2019https://github.com/nodejs/node/pull/30598#issuecomment-558245977
02d4c74...a50cc2ehttps://github.com/nodejs/node/compare/02d4c742369975fd7499bb242be61bbb1f8fc1ab...a50cc2ed0eecf89713ea11c64b00dee416c88362
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
November 25, 2019 16:58https://github.com/nodejs/node/pull/30598#event-2828888057
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-5522467
https://github.com/cjihrig
https://github.com/addaleax
tools: update ESLint to 6.7.1https://github.com/nodejs/node/commit/5522467cf5c97addecd15bb6b0e3fcd5b48779a3
5522467https://github.com/nodejs/node/commit/5522467cf5c97addecd15bb6b0e3fcd5b48779a3
#30598https://github.com/nodejs/node/pull/30598
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-84f7b5c
https://github.com/cjihrig
https://github.com/addaleax
tools: enable more eslint ruleshttps://github.com/nodejs/node/commit/84f7b5c7528a7522fba37e06b1b43f491dad1230
84f7b5chttps://github.com/nodejs/node/commit/84f7b5c7528a7522fba37e06b1b43f491dad1230
#30598https://github.com/nodejs/node/pull/30598
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-701a1d5
https://github.com/cjihrig
https://github.com/targos
tools: update ESLint to 6.7.1https://github.com/nodejs/node/commit/701a1d5835445328dc79f9c685fd11ad9fe6f066
701a1d5https://github.com/nodejs/node/commit/701a1d5835445328dc79f9c685fd11ad9fe6f066
#30598https://github.com/nodejs/node/pull/30598
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-d9d6da4
https://github.com/cjihrig
https://github.com/targos
tools: enable more eslint ruleshttps://github.com/nodejs/node/commit/d9d6da4d537759f8db16082eddad213341ef861e
d9d6da4https://github.com/nodejs/node/commit/d9d6da4d537759f8db16082eddad213341ef861e
#30598https://github.com/nodejs/node/pull/30598
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30598#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30598#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-bce0880
https://github.com/cjihrig
https://github.com/MylesBorins
tools: update ESLint to 6.7.1https://github.com/nodejs/node/commit/bce08806c79a702f8e5bbcdc8a635112267f39da
bce0880https://github.com/nodejs/node/commit/bce08806c79a702f8e5bbcdc8a635112267f39da
#30598https://github.com/nodejs/node/pull/30598
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30598#ref-commit-df91d5f
https://github.com/cjihrig
https://github.com/MylesBorins
tools: enable more eslint ruleshttps://github.com/nodejs/node/commit/df91d5fd66618bf50cd5b77928fd2e1d9b954268
df91d5fhttps://github.com/nodejs/node/commit/df91d5fd66618bf50cd5b77928fd2e1d9b954268
#30598https://github.com/nodejs/node/pull/30598
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30598#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30598
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30598/files/3fb31655ee1ea18065bf3e767f50e5b77c2fee44
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/30598/files/3fb31655ee1ea18065bf3e767f50e5b77c2fee44
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30598/files/3fb31655ee1ea18065bf3e767f50e5b77c2fee44
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/30598
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/targos
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.