René's URL Explorer Experiment


Title: stream: call _final synchronously by ronag · Pull Request #30597 · nodejs/node · GitHub

Open Graph Title: stream: call _final synchronously by ronag · Pull Request #30597 · nodejs/node

X Title: stream: call _final synchronously by ronag · Pull Request #30597 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We don't actually have to call _final in a nextTick we just need to emit the event asynchronously. Try to call _final as soon as possible. With this change it's possible to remove some pref...

X Description: We don't actually have to call _final in a nextTick we just need to emit the event asynchronously. Try to call _final as soon as possible. With this change it's possible to remove s...

Opengraph URL: https://github.com/nodejs/node/pull/30597

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:39c535f7-85ce-4381-31a4-da32958e9054
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE2E:6F3CF:8157B1C:B5CACAA:6A50B762
html-safe-noncedd913f0822f127377dd0873b2843987d558a1a10a26bbadae2d403af19213b38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTJFOjZGM0NGOjgxNTdCMUM6QjVDQUNBQTo2QTUwQjc2MiIsInZpc2l0b3JfaWQiOiI0MTkwMzExMzkxNTk1Mzc4NTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf6678bee0bda530b02fd8b17c82ffc14550905c71fed377f1340fe6d29acd27d
hovercard-subject-tagpull_request:344652425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30597/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/65e70bf03f8b3a70fc09e4e4d078f8ced5fc04a8dbe2b0c2406dfef0d0d88605/nodejs/node/pull/30597
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/65e70bf03f8b3a70fc09e4e4d078f8ced5fc04a8dbe2b0c2406dfef0d0d88605/nodejs/node/pull/30597
og:image:altWe don't actually have to call _final in a nextTick we just need to emit the event asynchronously. Try to call _final as soon as possible. With this change it's possible to remove some pref...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None63772747707af4093f0d5fc7aa1bb3bb55f412a9865207c4f421aa34c64cc404
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseded53fe94e3ff1bb4dbf8cc77e285396c92580fb
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30597#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30597
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30597
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30597
Reloadhttps://github.com/nodejs/node/pull/30597
Reloadhttps://github.com/nodejs/node/pull/30597
Please reload this pagehttps://github.com/nodejs/node/pull/30597
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-fix-end-finishhttps://github.com/nxtedition/node/tree/stream-fix-end-finish
Conversationhttps://github.com/nodejs/node/pull/30597
Commits2 (2)https://github.com/nodejs/node/pull/30597/commits
Checkshttps://github.com/nodejs/node/pull/30597/checks
Files changedhttps://github.com/nodejs/node/pull/30597/files
stream: call _final synchronouslyhttps://github.com/nodejs/node/pull/30597#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-fix-end-finishhttps://github.com/nxtedition/node/tree/stream-fix-end-finish
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 22, 2019https://github.com/nodejs/node/pull/30597#issue-527358420
Please reload this pagehttps://github.com/nodejs/node/pull/30597
#29656https://github.com/nodejs/node/pull/29656
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Nov 22, 2019https://github.com/nodejs/node/pull/30597#event-2824231857
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 22, 2019https://github.com/nodejs/node/pull/30597#issuecomment-557693611
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/b6777af04f60dcff95d12a5b3c7f06bb058e93e4..9cb4bbb8d5e7120f8b6cdcf791393a9bb7faee6e
b6777afhttps://github.com/nodejs/node/commit/b6777af04f60dcff95d12a5b3c7f06bb058e93e4
9cb4bbbhttps://github.com/nodejs/node/commit/9cb4bbb8d5e7120f8b6cdcf791393a9bb7faee6e
Compare https://github.com/nodejs/node/compare/b6777af04f60dcff95d12a5b3c7f06bb058e93e4..9cb4bbb8d5e7120f8b6cdcf791393a9bb7faee6e
November 23, 2019 00:54https://github.com/nodejs/node/pull/30597#event-2824988098
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 23, 2019https://github.com/nodejs/node/pull/30597#issuecomment-557792002
@mcollinahttps://github.com/mcollina
@jasnellhttps://github.com/jasnell
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 23, 2019https://github.com/nodejs/node/pull/30597#issuecomment-557792528
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 23, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-321907774
View reviewed changes https://github.com/nodejs/node/pull/30597/files
test/parallel/test-internal-fs-syncwritestream.jshttps://github.com/nodejs/node/pull/30597/files#diff-ad76ace0655358bcc4c4f3c3f10fbf9e7aaf7f99980bb35faffa9e8164a26210
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 23, 2019 https://github.com/nodejs/node/pull/30597#ref-issue-527439754
stream: Transform questions #30605 https://github.com/nodejs/node/issues/30605
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 23, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-321932401
View reviewed changes https://github.com/nodejs/node/pull/30597/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/30597/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
addaleaxhttps://github.com/addaleax
Nov 23, 2019https://github.com/nodejs/node/pull/30597#discussion_r349893643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
ronaghttps://github.com/ronag
Nov 23, 2019https://github.com/nodejs/node/pull/30597#discussion_r349895307
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29656https://github.com/nodejs/node/pull/29656
Please reload this pagehttps://github.com/nodejs/node/pull/30597
ronaghttps://github.com/ronag
Nov 23, 2019https://github.com/nodejs/node/pull/30597#discussion_r349895335
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 24, 2019https://github.com/nodejs/node/pull/30597#issuecomment-557873517
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/lpinca
lpincahttps://github.com/lpinca
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Nov 24, 2019https://github.com/nodejs/node/pull/30597#event-2825900317
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30597#event-2863449039
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30597#issuecomment-562841313
#30733https://github.com/nodejs/node/pull/30733
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 7, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-328552504
View reviewed changes https://github.com/nodejs/node/pull/30597/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30597#pullrequestreview-328552504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#29656https://github.com/nodejs/node/pull/29656
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 7, 2019https://github.com/nodejs/node/pull/30597#issuecomment-562844306
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/nxtedition/node/blob/stream-transform-simplify/lib/_stream_transform.jshttps://github.com/nxtedition/node/blob/stream-transform-simplify/lib/_stream_transform.js
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/1672b251834257e4eb03ce379a3750704ca5ad0d..66e265436a164aaa07035a4eb74dc311348a3824
1672b25https://github.com/nodejs/node/commit/1672b251834257e4eb03ce379a3750704ca5ad0d
66e2654https://github.com/nodejs/node/commit/66e265436a164aaa07035a4eb74dc311348a3824
Compare https://github.com/nodejs/node/compare/1672b251834257e4eb03ce379a3750704ca5ad0d..66e265436a164aaa07035a4eb74dc311348a3824
December 14, 2019 22:36https://github.com/nodejs/node/pull/30597#event-2883648037
https://github.com/ronag
ronaghttps://github.com/ronag
addaleaxhttps://github.com/addaleax
mcollinahttps://github.com/mcollina
December 15, 2019 10:26https://github.com/nodejs/node/pull/30597#event-2883889309
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 15, 2019https://github.com/nodejs/node/pull/30597#issuecomment-565796403
@mcollinahttps://github.com/mcollina
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 15, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-332255436
View reviewed changes https://github.com/nodejs/node/pull/30597/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/30597/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
ronaghttps://github.com/ronag
Dec 15, 2019https://github.com/nodejs/node/pull/30597#discussion_r357968611
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/30597
addaleaxhttps://github.com/addaleax
Dec 16, 2019https://github.com/nodejs/node/pull/30597#discussion_r358450971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
ronaghttps://github.com/ronag
Dec 16, 2019https://github.com/nodejs/node/pull/30597#discussion_r358451789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
ronaghttps://github.com/ronag
Dec 16, 2019https://github.com/nodejs/node/pull/30597#discussion_r358451921
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 15, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-332255466
View reviewed changes https://github.com/nodejs/node/pull/30597/files
test/parallel/test-stream-transform-final-sync.jshttps://github.com/nodejs/node/pull/30597/files#diff-ccb3ff94896f7e3c3fa354fbb0ff292d2aa7ce790cf04e3f00f8b54f550aabb9
ronaghttps://github.com/ronag
Dec 15, 2019https://github.com/nodejs/node/pull/30597#discussion_r357968638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 15, 2019https://github.com/nodejs/node/pull/30597#issuecomment-565796508
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/866be2903c4a526b0abbad44e7a86a94d56a6a61..b6f2f1a2838075be89be530baf848afa81c7fa54
866be29https://github.com/nodejs/node/commit/866be2903c4a526b0abbad44e7a86a94d56a6a61
b6f2f1ahttps://github.com/nodejs/node/commit/b6f2f1a2838075be89be530baf848afa81c7fa54
Compare https://github.com/nodejs/node/compare/866be2903c4a526b0abbad44e7a86a94d56a6a61..b6f2f1a2838075be89be530baf848afa81c7fa54
December 15, 2019 15:17https://github.com/nodejs/node/pull/30597#event-2884038872
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Dec 15, 2019https://github.com/nodejs/node/pull/30597#event-2884240044
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Dec 25, 2019https://github.com/nodejs/node/pull/30597#event-2907808620
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569426401
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 28, 2019 https://github.com/nodejs/node/pull/30597#pullrequestreview-336924159
View reviewed changes https://github.com/nodejs/node/pull/30597/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30597#pullrequestreview-336924159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569441835
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/nxtedition/node/blob/stream-fix-end-finish/lib/_stream_transform.jshttps://github.com/nxtedition/node/blob/stream-fix-end-finish/lib/_stream_transform.js
https://github.com/nodejs/node/blob/master/lib/_stream_transform.jshttps://github.com/nodejs/node/blob/master/lib/_stream_transform.js
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569442162
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569442552
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#event-2912093893
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#event-2912106486
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/b6f2f1a2838075be89be530baf848afa81c7fa54..da175f00a2ef43a4fc2d0bf7557fa96fe5b780e7
b6f2f1ahttps://github.com/nodejs/node/commit/b6f2f1a2838075be89be530baf848afa81c7fa54
da175f0https://github.com/nodejs/node/commit/da175f00a2ef43a4fc2d0bf7557fa96fe5b780e7
Compare https://github.com/nodejs/node/compare/b6f2f1a2838075be89be530baf848afa81c7fa54..da175f00a2ef43a4fc2d0bf7557fa96fe5b780e7
December 28, 2019 20:10https://github.com/nodejs/node/pull/30597#event-2912110291
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 28, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569447581
Please reload this pagehttps://github.com/nodejs/node/pull/30597
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/91618f5308f5926255d4cffa5047b42ed4bde49e..5cf54fbcd0dc5dd7a1c65cffa430a12af2faf666
91618f5https://github.com/nodejs/node/commit/91618f5308f5926255d4cffa5047b42ed4bde49e
5cf54fbhttps://github.com/nodejs/node/commit/5cf54fbcd0dc5dd7a1c65cffa430a12af2faf666
Compare https://github.com/nodejs/node/compare/91618f5308f5926255d4cffa5047b42ed4bde49e..5cf54fbcd0dc5dd7a1c65cffa430a12af2faf666
December 28, 2019 20:18https://github.com/nodejs/node/pull/30597#event-2912113134
https://github.com/ronag
stream: call _final synchronouslyhttps://github.com/nodejs/node/pull/30597/commits/d17f23325a1145c4083b362ce2f5f36fbc303f23
d17f233https://github.com/nodejs/node/pull/30597/commits/d17f23325a1145c4083b362ce2f5f36fbc303f23
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/b43b23eff3c455030f25ea7d3cf3e692b6e57d3f..63380c28e7cec27d26ce181c89802d45a8d253b3
b43b23ehttps://github.com/nodejs/node/commit/b43b23eff3c455030f25ea7d3cf3e692b6e57d3f
63380c2https://github.com/nodejs/node/commit/63380c28e7cec27d26ce181c89802d45a8d253b3
Compare https://github.com/nodejs/node/compare/b43b23eff3c455030f25ea7d3cf3e692b6e57d3f..63380c28e7cec27d26ce181c89802d45a8d253b3
December 28, 2019 21:23https://github.com/nodejs/node/pull/30597#event-2912137384
https://github.com/ronag
stream: simplify Transformhttps://github.com/nodejs/node/pull/30597/commits/68c0d3be3ddc56f5b45af1fd468c27491e723d11
68c0d3bhttps://github.com/nodejs/node/pull/30597/commits/68c0d3be3ddc56f5b45af1fd468c27491e723d11
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/63380c28e7cec27d26ce181c89802d45a8d253b3..68c0d3be3ddc56f5b45af1fd468c27491e723d11
63380c2https://github.com/nodejs/node/commit/63380c28e7cec27d26ce181c89802d45a8d253b3
68c0d3bhttps://github.com/nodejs/node/commit/68c0d3be3ddc56f5b45af1fd468c27491e723d11
Compare https://github.com/nodejs/node/compare/63380c28e7cec27d26ce181c89802d45a8d253b3..68c0d3be3ddc56f5b45af1fd468c27491e723d11
December 29, 2019 15:26https://github.com/nodejs/node/pull/30597#event-2912580464
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 29, 2019https://github.com/nodejs/node/pull/30597#issuecomment-569526421
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 29, 2019https://github.com/nodejs/node/pull/30597#event-2912678282
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30597
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/30597/files/b6f2f1a2838075be89be530baf848afa81c7fa54
https://github.com/addaleax
addaleax https://github.com/addaleax
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/30597
https://github.com/ronag
https://github.com/mcollina
https://github.com/addaleax
https://github.com/Trott
https://github.com/lpinca
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.