René's URL Explorer Experiment


Title: test: add regression test for signal handler removal in exit by addaleax · Pull Request #30589 · nodejs/node · GitHub

Open Graph Title: test: add regression test for signal handler removal in exit by addaleax · Pull Request #30589 · nodejs/node

X Title: test: add regression test for signal handler removal in exit by addaleax · Pull Request #30589 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #30581 Refs: #30582 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Refs: #30581 Refs: #30582 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30589

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7a45d051-a2f6-bc5b-8315-466bf469a568
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA996:310BDB:4A3A155:68208E2:6A4F89AA
html-safe-nonce5ae868f6c30b01168a10a8ee6da73894f9842788419df45a1346d23a65bd22b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTk2OjMxMEJEQjo0QTNBMTU1OjY4MjA4RTI6NkE0Rjg5QUEiLCJ2aXNpdG9yX2lkIjoiNjE2OTcwMTA4Nzc2MDU4MzA4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace548a8eaec42ae30c01d1261cf48154265d183a552d624fa4861fe142dea3d01
hovercard-subject-tagpull_request:344541683
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30589/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a6e8122fb38c0a1c52d107612f89728e0b955fbae73b46db28247ab2ed0cf9e9/nodejs/node/pull/30589
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a6e8122fb38c0a1c52d107612f89728e0b955fbae73b46db28247ab2ed0cf9e9/nodejs/node/pull/30589
og:image:altRefs: #30581 Refs: #30582 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30589#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30589
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30589
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30589
Reloadhttps://github.com/nodejs/node/pull/30589
Reloadhttps://github.com/nodejs/node/pull/30589
Please reload this pagehttps://github.com/nodejs/node/pull/30589
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30589
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:signal-handler-exit-regression-testhttps://github.com/addaleax/node/tree/signal-handler-exit-regression-test
Conversationhttps://github.com/nodejs/node/pull/30589
Commits1 (1)https://github.com/nodejs/node/pull/30589/commits
Checkshttps://github.com/nodejs/node/pull/30589/checks
Files changedhttps://github.com/nodejs/node/pull/30589/files
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/pull/30589#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:signal-handler-exit-regression-testhttps://github.com/addaleax/node/tree/signal-handler-exit-regression-test
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 22, 2019https://github.com/nodejs/node/pull/30589#issue-527224905
#30581https://github.com/nodejs/node/issues/30581
#30582https://github.com/nodejs/node/pull/30582
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/addaleax
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/pull/30589/commits/d51233c23ba9aadeb02ac21af645bcb144ba16d0
d51233chttps://github.com/nodejs/node/pull/30589/commits/d51233c23ba9aadeb02ac21af645bcb144ba16d0
nodejs#30581https://github.com/nodejs/node/issues/30581
nodejs#30582https://github.com/nodejs/node/pull/30582
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Nov 22, 2019https://github.com/nodejs/node/pull/30589#event-2823395734
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 22, 2019https://github.com/nodejs/node/pull/30589#event-2823395970
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#ref-pullrequest-526970468
src: fix signal handler crash on close #30582 https://github.com/nodejs/node/pull/30582
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321576525
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321578991
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321579091
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321582208
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321586935
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/30589#pullrequestreview-321586935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Nov 22, 2019https://github.com/nodejs/node/pull/30589#event-2823531589
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 22, 2019https://github.com/nodejs/node/pull/30589#issuecomment-557564759
https://ci.nodejs.org/job/node-test-pull-request/26852/https://ci.nodejs.org/job/node-test-pull-request/26852/
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 22, 2019 https://github.com/nodejs/node/pull/30589#pullrequestreview-321795724
View reviewed changes https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 22, 2019https://github.com/nodejs/node/pull/30589#issuecomment-557685696
https://ci.nodejs.org/job/node-test-pull-request/26862/https://ci.nodejs.org/job/node-test-pull-request/26862/
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 27, 2019https://github.com/nodejs/node/pull/30589#issuecomment-559285951
https://ci.nodejs.org/job/node-test-pull-request/27111/https://ci.nodejs.org/job/node-test-pull-request/27111/
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 28, 2019https://github.com/nodejs/node/pull/30589#issuecomment-559300882
ea7a6f9https://github.com/nodejs/node/commit/ea7a6f9dbd05654fff3f8c474ac0f5126bc87376
Please reload this pagehttps://github.com/nodejs/node/pull/30589
addaleaxhttps://github.com/addaleax
Nov 28, 2019 https://github.com/nodejs/node/pull/30589#ref-commit-ea7a6f9
https://github.com/addaleax
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/commit/ea7a6f9dbd05654fff3f8c474ac0f5126bc87376
ea7a6f9https://github.com/nodejs/node/commit/ea7a6f9dbd05654fff3f8c474ac0f5126bc87376
#30581https://github.com/nodejs/node/issues/30581
#30582https://github.com/nodejs/node/pull/30582
#30589https://github.com/nodejs/node/pull/30589
#30581https://github.com/nodejs/node/issues/30581
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 28, 2019https://github.com/nodejs/node/pull/30589#event-2837383282
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 28, 2019 01:02https://github.com/nodejs/node/pull/30589#event-2837383391
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30589#ref-commit-0972fa3
https://github.com/addaleax
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/commit/0972fa3c16b3f8e41e5a549a2d44b2700c1e6d08
0972fa3https://github.com/nodejs/node/commit/0972fa3c16b3f8e41e5a549a2d44b2700c1e6d08
#30581https://github.com/nodejs/node/issues/30581
#30582https://github.com/nodejs/node/pull/30582
#30589https://github.com/nodejs/node/pull/30589
#30581https://github.com/nodejs/node/issues/30581
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30589#ref-commit-cac77dd
https://github.com/addaleax
https://github.com/targos
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/commit/cac77dd292649a29d3dfa6f28c583bc2cea4f4cb
cac77ddhttps://github.com/nodejs/node/commit/cac77dd292649a29d3dfa6f28c583bc2cea4f4cb
#30581https://github.com/nodejs/node/issues/30581
#30582https://github.com/nodejs/node/pull/30582
#30589https://github.com/nodejs/node/pull/30589
#30581https://github.com/nodejs/node/issues/30581
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30589#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30589#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30589#ref-commit-f5ac4ec
https://github.com/addaleax
https://github.com/MylesBorins
test: add regression test for signal handler removal in exithttps://github.com/nodejs/node/commit/f5ac4ec49ae9ba88873a08420d6c9f3585edab1c
f5ac4echttps://github.com/nodejs/node/commit/f5ac4ec49ae9ba88873a08420d6c9f3585edab1c
#30581https://github.com/nodejs/node/issues/30581
#30582https://github.com/nodejs/node/pull/30582
#30589https://github.com/nodejs/node/pull/30589
#30581https://github.com/nodejs/node/issues/30581
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30589#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30589
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/30589/files/d51233c23ba9aadeb02ac21af645bcb144ba16d0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/30589
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/gireeshpunathil
https://github.com/BethGriggs
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.