René's URL Explorer Experiment


Title: crypto: remove redundant validateUint32 argument by tniessen · Pull Request #30579 · nodejs/node · GitHub

Open Graph Title: crypto: remove redundant validateUint32 argument by tniessen · Pull Request #30579 · nodejs/node

X Title: crypto: remove redundant validateUint32 argument by tniessen · Pull Request #30579 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The third parameter should be a boolean indicating whether the number must be positive. Passing zero works, but is unnecessary, misleading and inconsistent with other uses of the same function. Ch...

X Description: The third parameter should be a boolean indicating whether the number must be positive. Passing zero works, but is unnecessary, misleading and inconsistent with other uses of the same function. Ch...

Opengraph URL: https://github.com/nodejs/node/pull/30579

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7d81896-6332-3623-7b45-700d5f15d28b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A82:188FE8:1E35696:293927F:6A4F2C40
html-safe-nonce5dcc9a6a19f71919137f24e764f70a56c5c7c2dc30346688793ce417bab32f6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTgyOjE4OEZFODoxRTM1Njk2OjI5MzkyN0Y6NkE0RjJDNDAiLCJ2aXNpdG9yX2lkIjoiMjQwMjA4OTMxOTY4MDM4ODE2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf08cb340a5f1d6980e3b4939115978393a617ba39f0bd849c0d2b30b7b4498e8
hovercard-subject-tagpull_request:344102658
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30579/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/477ecc0cf5288569bf12bd8ccc76fb6723877d75adbf3181d4414062387b2262/nodejs/node/pull/30579
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/477ecc0cf5288569bf12bd8ccc76fb6723877d75adbf3181d4414062387b2262/nodejs/node/pull/30579
og:image:altThe third parameter should be a boolean indicating whether the number must be positive. Passing zero works, but is unnecessary, misleading and inconsistent with other uses of the same function. Ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30579#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30579
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30579
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30579
Reloadhttps://github.com/nodejs/node/pull/30579
Reloadhttps://github.com/nodejs/node/pull/30579
Please reload this pagehttps://github.com/nodejs/node/pull/30579
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30579
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-remove-redundant-validateuint32-arghttps://github.com/tniessen/node/tree/crypto-remove-redundant-validateuint32-arg
Conversationhttps://github.com/nodejs/node/pull/30579
Commits1 (1)https://github.com/nodejs/node/pull/30579/commits
Checkshttps://github.com/nodejs/node/pull/30579/checks
Files changedhttps://github.com/nodejs/node/pull/30579/files
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/pull/30579#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-remove-redundant-validateuint32-arghttps://github.com/tniessen/node/tree/crypto-remove-redundant-validateuint32-arg
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/node/pull/30579#issue-526682079
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30579
https://github.com/tniessen
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/pull/30579/commits/267768145af7a901540b763b6009a79dcf636d23
2677681https://github.com/nodejs/node/pull/30579/commits/267768145af7a901540b763b6009a79dcf636d23
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Nov 21, 2019https://github.com/nodejs/node/pull/30579#event-2820179175
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/node/pull/30579#issuecomment-557147184
Please reload this pagehttps://github.com/nodejs/node/pull/30579
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 21, 2019 https://github.com/nodejs/node/pull/30579#pullrequestreview-320992602
View reviewed changes https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
https://github.com/tniessen
tniessenhttps://github.com/tniessen
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Nov 21, 2019https://github.com/nodejs/node/pull/30579#event-2820273533
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 21, 2019 https://github.com/nodejs/node/pull/30579#pullrequestreview-321061725
View reviewed changes https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/30579#pullrequestreview-321061725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30579
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 21, 2019 https://github.com/nodejs/node/pull/30579#pullrequestreview-321166518
View reviewed changes https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 21, 2019https://github.com/nodejs/node/pull/30579#issuecomment-557273848
https://ci.nodejs.org/job/node-test-pull-request/26826/https://ci.nodejs.org/job/node-test-pull-request/26826/
Please reload this pagehttps://github.com/nodejs/node/pull/30579
tniessenhttps://github.com/tniessen
Nov 22, 2019 https://github.com/nodejs/node/pull/30579#ref-commit-64ee64d
https://github.com/tniessen
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/commit/64ee64d3afc837350ee39058cef9179e92f3554c
64ee64dhttps://github.com/nodejs/node/commit/64ee64d3afc837350ee39058cef9179e92f3554c
#30579https://github.com/nodejs/node/pull/30579
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 22, 2019https://github.com/nodejs/node/pull/30579#issuecomment-557365040
64ee64dhttps://github.com/nodejs/node/commit/64ee64d3afc837350ee39058cef9179e92f3554c
Please reload this pagehttps://github.com/nodejs/node/pull/30579
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 22, 2019https://github.com/nodejs/node/pull/30579#event-2821855801
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30579#ref-commit-55c2ac7
https://github.com/tniessen
https://github.com/addaleax
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/commit/55c2ac70b7ff3c9ae0d97368ea27348a70031dbe
55c2ac7https://github.com/nodejs/node/commit/55c2ac70b7ff3c9ae0d97368ea27348a70031dbe
#30579https://github.com/nodejs/node/pull/30579
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30579#ref-commit-18db451
https://github.com/tniessen
https://github.com/targos
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/commit/18db45101c5049e8b3e46942a0b2efb594cedf64
18db451https://github.com/nodejs/node/commit/18db45101c5049e8b3e46942a0b2efb594cedf64
#30579https://github.com/nodejs/node/pull/30579
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30579#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30579#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30579#ref-commit-c1cb639
https://github.com/tniessen
https://github.com/MylesBorins
crypto: remove redundant validateUint32 argumenthttps://github.com/nodejs/node/commit/c1cb639e846199b3b233289672d5c8e1b634d37c
c1cb639https://github.com/nodejs/node/commit/c1cb639e846199b3b233289672d5c8e1b634d37c
#30579https://github.com/nodejs/node/pull/30579
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30579#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.com/tniessen
tniessenhttps://github.com/tniessen
January 23, 2020 03:48https://github.com/nodejs/node/pull/30579#event-2972365287
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30579
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/30579/files/267768145af7a901540b763b6009a79dcf636d23
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/30579
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.