René's URL Explorer Experiment


Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node · GitHub

Open Graph Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node

X Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node

Description: RFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but until that happens, Node.js should manually reject them. Refs: nodejs/webcrypto#29 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: RFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...

X Description: RFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...

Opengraph URL: https://github.com/nodejs/node/pull/30578

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b305adcb-2380-3722-fd4a-77bf231a3672
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD018:1A50E8:E2D6F:132DC9:6AED34C6
html-safe-nonce693530bbefc3debd84e30ddee62d623757043bbb82585a3bcddc16ece84bba31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDE4OjFBNTBFODpFMkQ2RjoxMzJEQzk6NkFFRDM0QzYiLCJ2aXNpdG9yX2lkIjoiODY2MzY4NTkwMzg5MDA2ODY3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfad6ca5bf72891603361c405e117583e3e3ee18bee48a0b342deba4c1a0660f0
hovercard-subject-tagpull_request:344078919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/30578/files
twitter:imagehttps://avatars.githubusercontent.com/u/3109072?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3109072?s=400&v=4
og:image:altRFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30578/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30578/files
Reloadhttps://github.com/nodejs/node/pull/30578/files
Reloadhttps://github.com/nodejs/node/pull/30578/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-forbid-iteration-count-zerohttps://github.com/tniessen/node/tree/crypto-forbid-iteration-count-zero
Conversation 12 https://github.com/nodejs/node/pull/30578
Commits 1 https://github.com/nodejs/node/pull/30578/commits
Checks 0 https://github.com/nodejs/node/pull/30578/checks
Files changed https://github.com/nodejs/node/pull/30578/files
Please reload this pagehttps://github.com/nodejs/node/pull/30578/files
crypto: forbid setting the PBKDF2 iter count to 0 https://github.com/nodejs/node/pull/30578/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/30578/files
a1ba429 crypto: forbid setting the PBKDF2 iter count to 0 tniessen Nov 21, 2019 https://github.com/nodejs/node/pull/30578/commits/a1ba429a2fe725abe5e664624fc441c3451005de
Clear filters https://github.com/nodejs/node/pull/30578/files
Please reload this pagehttps://github.com/nodejs/node/pull/30578/files
Please reload this pagehttps://github.com/nodejs/node/pull/30578/files
crypto.md https://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
pbkdf2.js https://github.com/nodejs/node/pull/30578/files#diff-dc4ff7692195e94fe4c1c2a7a462bfae70defed23a58c618b47989e0caef5095
test-crypto-pbkdf2.js https://github.com/nodejs/node/pull/30578/files#diff-226dffa4a509280042e7fbe3c8c6d177b0be38349fc426236d0f3368d2719b0f
doc/api/crypto.mdhttps://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
View file https://github.com/tniessen/node/blob/a1ba429a2fe725abe5e664624fc441c3451005de/doc/api/crypto.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/30578/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
https://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
https://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
https://github.com/nodejs/node/pull/30578/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
lib/internal/crypto/pbkdf2.jshttps://github.com/nodejs/node/pull/30578/files#diff-dc4ff7692195e94fe4c1c2a7a462bfae70defed23a58c618b47989e0caef5095
View file https://github.com/tniessen/node/blob/a1ba429a2fe725abe5e664624fc441c3451005de/lib/internal/crypto/pbkdf2.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/30578/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/30578/files#diff-dc4ff7692195e94fe4c1c2a7a462bfae70defed23a58c618b47989e0caef5095
https://github.com/nodejs/node/pull/30578/files#diff-dc4ff7692195e94fe4c1c2a7a462bfae70defed23a58c618b47989e0caef5095
test/parallel/test-crypto-pbkdf2.jshttps://github.com/nodejs/node/pull/30578/files#diff-226dffa4a509280042e7fbe3c8c6d177b0be38349fc426236d0f3368d2719b0f
View file https://github.com/tniessen/node/blob/a1ba429a2fe725abe5e664624fc441c3451005de/test/parallel/test-crypto-pbkdf2.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/30578/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/30578/files#diff-226dffa4a509280042e7fbe3c8c6d177b0be38349fc426236d0f3368d2719b0f
https://github.com/nodejs/node/pull/30578/files#diff-226dffa4a509280042e7fbe3c8c6d177b0be38349fc426236d0f3368d2719b0f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.