René's URL Explorer Experiment


Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node · GitHub

Open Graph Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node

X Title: crypto: forbid setting the PBKDF2 iter count to 0 by tniessen · Pull Request #30578 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: RFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...

X Description: RFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...

Opengraph URL: https://github.com/nodejs/node/pull/30578

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6d1e0618-c45d-5d29-1d16-0d0d6a8db790
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF0A:8FC12:7AED21:A69DEE:6AED2EA6
html-safe-noncef0f64b3eabfacd21fa1802a73c11030aa9f1b72408115260d6c55a26327210d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjBBOjhGQzEyOjdBRUQyMTpBNjlERUU6NkFFRDJFQTYiLCJ2aXNpdG9yX2lkIjoiNTI0MzA1ODQxMDQ0MDQzNzQxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceeefa43769340dd027225b218ea491ce0ceb84795c59ed0f0e0b331e5005b703
hovercard-subject-tagpull_request:344078919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30578/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ffd5712f95f7a52cfb88ffde6f211b0c1298f66e2441694aa688cb75076c13cf/nodejs/node/pull/30578
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ffd5712f95f7a52cfb88ffde6f211b0c1298f66e2441694aa688cb75076c13cf/nodejs/node/pull/30578
og:image:altRFC 2898 does not permit an iteration count of zero, and OpenSSL 1.1.1 will treat it as one iteration internally. Future OpenSSL versions will reject such inputs (already on master branch), but unt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30578#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30578
Reloadhttps://github.com/nodejs/node/pull/30578
Reloadhttps://github.com/nodejs/node/pull/30578
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-forbid-iteration-count-zerohttps://github.com/tniessen/node/tree/crypto-forbid-iteration-count-zero
Conversationhttps://github.com/nodejs/node/pull/30578
Commits1 (1)https://github.com/nodejs/node/pull/30578/commits
Checkshttps://github.com/nodejs/node/pull/30578/checks
Files changedhttps://github.com/nodejs/node/pull/30578/files
crypto: forbid setting the PBKDF2 iter count to 0https://github.com/nodejs/node/pull/30578#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-forbid-iteration-count-zerohttps://github.com/tniessen/node/tree/crypto-forbid-iteration-count-zero
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/node/pull/30578#issue-526653555
Please reload this pagehttps://github.com/nodejs/node/pull/30578
nodejs/webcrypto#29https://github.com/nodejs/webcrypto/pull/29
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Nov 21, 2019https://github.com/nodejs/node/pull/30578#event-2820002152
https://github.com/tniessen
tniessenhttps://github.com/tniessen
bnoordhuishttps://github.com/bnoordhuis
November 21, 2019 15:08https://github.com/nodejs/node/pull/30578#event-2820006634
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557127360
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 21, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557135276
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/tniessen
tniessenhttps://github.com/tniessen
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Nov 21, 2019https://github.com/nodejs/node/pull/30578#event-2820109694
https://github.com/tniessen
tniessenhttps://github.com/tniessen
November 21, 2019 15:37https://github.com/nodejs/node/pull/30578#event-2820116619
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557140695
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 21, 2019 https://github.com/nodejs/node/pull/30578#pullrequestreview-320981729
View reviewed changes https://github.com/nodejs/node/pull/30578/files
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Nov 21, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557148751
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 21, 2019 https://github.com/nodejs/node/pull/30578#pullrequestreview-321169478
View reviewed changes https://github.com/nodejs/node/pull/30578/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 22, 2019 https://github.com/nodejs/node/pull/30578#pullrequestreview-321303662
View reviewed changes https://github.com/nodejs/node/pull/30578/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30578#pullrequestreview-321303662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Nov 22, 2019 https://github.com/nodejs/node/pull/30578#pullrequestreview-321404135
View reviewed changes https://github.com/nodejs/node/pull/30578/files
https://github.com/tniessen
crypto: forbid setting the PBKDF2 iter count to 0https://github.com/nodejs/node/pull/30578/commits/a1ba429a2fe725abe5e664624fc441c3451005de
a1ba429https://github.com/nodejs/node/pull/30578/commits/a1ba429a2fe725abe5e664624fc441c3451005de
nodejs/webcrypto#29https://github.com/nodejs/webcrypto/pull/29
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/ad82adbe19af31578f79b3bb45364685e114b9d2..a1ba429a2fe725abe5e664624fc441c3451005de
ad82adbhttps://github.com/nodejs/node/commit/ad82adbe19af31578f79b3bb45364685e114b9d2
a1ba429https://github.com/nodejs/node/commit/a1ba429a2fe725abe5e664624fc441c3451005de
Compare https://github.com/nodejs/node/compare/ad82adbe19af31578f79b3bb45364685e114b9d2..a1ba429a2fe725abe5e664624fc441c3451005de
November 24, 2019 02:12https://github.com/nodejs/node/pull/30578#event-2825698346
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557860129
https://ci.nodejs.org/job/node-test-pull-request/26897/https://ci.nodejs.org/job/node-test-pull-request/26897/
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 24, 2019https://github.com/nodejs/node/pull/30578#issuecomment-557906809
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2097/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2097/
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 27, 2019 https://github.com/nodejs/node/pull/30578#pullrequestreview-323991646
View reviewed changes https://github.com/nodejs/node/pull/30578/files/a1ba429a2fe725abe5e664624fc441c3451005de
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 27, 2019https://github.com/nodejs/node/pull/30578#issuecomment-559286767
10f5fa7https://github.com/nodejs/node/commit/10f5fa75136b540487730b5c1852ea6ad795bb96
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 27, 2019https://github.com/nodejs/node/pull/30578#event-2837281683
addaleaxhttps://github.com/addaleax
Nov 27, 2019 https://github.com/nodejs/node/pull/30578#ref-commit-10f5fa7
https://github.com/tniessen
https://github.com/addaleax
crypto: forbid setting the PBKDF2 iter count to 0https://github.com/nodejs/node/commit/10f5fa75136b540487730b5c1852ea6ad795bb96
10f5fa7https://github.com/nodejs/node/commit/10f5fa75136b540487730b5c1852ea6ad795bb96
nodejs/webcrypto#29https://github.com/nodejs/webcrypto/pull/29
#30578https://github.com/nodejs/node/pull/30578
https://github.com/tniessen
tniessenhttps://github.com/tniessen
January 23, 2020 03:48https://github.com/nodejs/node/pull/30578#event-2972365433
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 10, 2020 https://github.com/nodejs/node/pull/30578#ref-pullrequest-578760228
2020-04-21, Version 14.0.0 (Current) #32181 https://github.com/nodejs/node/pull/32181
https://github.com/muctemi
muctemihttps://github.com/muctemi
Jul 30, 2021https://github.com/nodejs/node/pull/30578#issuecomment-890218681
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 31, 2021https://github.com/nodejs/node/pull/30578#issuecomment-890378700
@muctemihttps://github.com/muctemi
the codehttps://github.com/openssl/openssl/blob/ba4c89a9700ff07cecde90248707056292bf36d1/crypto/evp/p5_crpt2.c#L91
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30578
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/30578/files/87a30e55d7b2dced92c6beed0b4e1db13280f365
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30578/files/a1ba429a2fe725abe5e664624fc441c3451005de
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30578/files/87a30e55d7b2dced92c6beed0b4e1db13280f365
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30578/files/87a30e55d7b2dced92c6beed0b4e1db13280f365
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30578/files/87a30e55d7b2dced92c6beed0b4e1db13280f365
Please reload this pagehttps://github.com/nodejs/node/pull/30578
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/30578
https://github.com/tniessen
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/muctemi
https://github.com/bnoordhuis
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/devnexen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.