René's URL Explorer Experiment


Title: http: set socket.server unconditionally by addaleax · Pull Request #30571 · nodejs/node · GitHub

Open Graph Title: http: set socket.server unconditionally by addaleax · Pull Request #30571 · nodejs/node

X Title: http: set socket.server unconditionally by addaleax · Pull Request #30571 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is useful for situations in which the socket was not created for HTTP, e.g. when using arbitrary Duplex streams. (The added test fails because previously, socket.server.emit() would not work f...

X Description: This is useful for situations in which the socket was not created for HTTP, e.g. when using arbitrary Duplex streams. (The added test fails because previously, socket.server.emit() would not work f...

Opengraph URL: https://github.com/nodejs/node/pull/30571

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:58aea1a3-6f67-89c0-fe71-3bd8fb08ffc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA402:1ED8:49E43EA:68D0AE7:6A4FE2A6
html-safe-nonceac647936b6639084df6d09baa4d25e6e9340d226ee58d22147d603e56d9d258e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDAyOjFFRDg6NDlFNDNFQTo2OEQwQUU3OjZBNEZFMkE2IiwidmlzaXRvcl9pZCI6IjY0MTY0ODgxODUxNzk1OTMzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b7e87478dc148c518e10f2d58d0da8fdf9756fbbab3bac81d9706a7ad146617
hovercard-subject-tagpull_request:343769405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30571/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d2348e43839a01db32d4b0bec90cd73ce07639fc6975122afca0811e42c6e93/nodejs/node/pull/30571
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d2348e43839a01db32d4b0bec90cd73ce07639fc6975122afca0811e42c6e93/nodejs/node/pull/30571
og:image:altThis is useful for situations in which the socket was not created for HTTP, e.g. when using arbitrary Duplex streams. (The added test fails because previously, socket.server.emit() would not work f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30571#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30571
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30571
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30571
Reloadhttps://github.com/nodejs/node/pull/30571
Reloadhttps://github.com/nodejs/node/pull/30571
Please reload this pagehttps://github.com/nodejs/node/pull/30571
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30571
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 975 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http-generic-serverhttps://github.com/addaleax/node/tree/http-generic-server
Conversationhttps://github.com/nodejs/node/pull/30571
Commits1 (1)https://github.com/nodejs/node/pull/30571/commits
Checkshttps://github.com/nodejs/node/pull/30571/checks
Files changedhttps://github.com/nodejs/node/pull/30571/files
http: set socket.server unconditionallyhttps://github.com/nodejs/node/pull/30571#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http-generic-serverhttps://github.com/addaleax/node/tree/http-generic-server
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 20, 2019https://github.com/nodejs/node/pull/30571#issue-526271326
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30571
https://github.com/addaleax
http: set socket.server unconditionallyhttps://github.com/nodejs/node/pull/30571/commits/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
898a079https://github.com/nodejs/node/pull/30571/commits/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Nov 20, 2019https://github.com/nodejs/node/pull/30571#event-2817151854
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Nov 21, 2019 https://github.com/nodejs/node/pull/30571#pullrequestreview-320621321
View reviewed changes https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 21, 2019 https://github.com/nodejs/node/pull/30571#pullrequestreview-320662182
View reviewed changes https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 21, 2019 https://github.com/nodejs/node/pull/30571#pullrequestreview-320665522
View reviewed changes https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 21, 2019 https://github.com/nodejs/node/pull/30571#pullrequestreview-320933855
View reviewed changes https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 27, 2019https://github.com/nodejs/node/pull/30571#event-2837284057
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 27, 2019https://github.com/nodejs/node/pull/30571#issuecomment-559287204
https://ci.nodejs.org/job/node-test-pull-request/27114/https://ci.nodejs.org/job/node-test-pull-request/27114/
Please reload this pagehttps://github.com/nodejs/node/pull/30571
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 28, 2019https://github.com/nodejs/node/pull/30571#issuecomment-559472514
https://ci.nodejs.org/job/node-test-pull-request/27139/https://ci.nodejs.org/job/node-test-pull-request/27139/
Please reload this pagehttps://github.com/nodejs/node/pull/30571
addaleaxhttps://github.com/addaleax
Nov 29, 2019 https://github.com/nodejs/node/pull/30571#ref-commit-4871779
https://github.com/addaleax
http: set socket.server unconditionallyhttps://github.com/nodejs/node/commit/487177954201ee098ecbf5027473b238187cee22
4871779https://github.com/nodejs/node/commit/487177954201ee098ecbf5027473b238187cee22
#30571https://github.com/nodejs/node/pull/30571
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 29, 2019https://github.com/nodejs/node/pull/30571#issuecomment-559823628
4871779https://github.com/nodejs/node/commit/487177954201ee098ecbf5027473b238187cee22
Please reload this pagehttps://github.com/nodejs/node/pull/30571
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 29, 2019https://github.com/nodejs/node/pull/30571#event-2841752470
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
November 29, 2019 15:28https://github.com/nodejs/node/pull/30571#event-2841752695
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30571#ref-commit-1d1d136
https://github.com/addaleax
http: set socket.server unconditionallyhttps://github.com/nodejs/node/commit/1d1d1368068dca79bbb06430875c71aff0c1937c
1d1d136https://github.com/nodejs/node/commit/1d1d1368068dca79bbb06430875c71aff0c1937c
#30571https://github.com/nodejs/node/pull/30571
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30571#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
targoshttps://github.com/targos
Dec 5, 2019 https://github.com/nodejs/node/pull/30571#ref-commit-e2f8d23
https://github.com/addaleax
https://github.com/targos
http: set socket.server unconditionallyhttps://github.com/nodejs/node/commit/e2f8d23c1a5e9b824a5605a458ad4c7c21cac86d
e2f8d23https://github.com/nodejs/node/commit/e2f8d23c1a5e9b824a5605a458ad4c7c21cac86d
#30571https://github.com/nodejs/node/pull/30571
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30571#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30571#ref-commit-6b380cc
https://github.com/addaleax
https://github.com/MylesBorins
http: set socket.server unconditionallyhttps://github.com/nodejs/node/commit/6b380cc7913b0a4c87fc9bb966073820f05df449
6b380cchttps://github.com/nodejs/node/commit/6b380cc7913b0a4c87fc9bb966073820f05df449
#30571https://github.com/nodejs/node/pull/30571
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30571#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30571
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/30571/files/898a0793b3b55f8f1a7dd8cebc9aeb3bf22d8aa6
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/30571
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/trivikr
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.