| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:858c67a0-2461-2ef5-77cd-e9ad2b895f8e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BEB4:165D8F:18DC427:2265C14:6A500A99 |
| html-safe-nonce | d405121e41b8880d276dbc1d1cf34db50300002fa9da27ce23304f53328cf689 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUI0OjE2NUQ4RjoxOERDNDI3OjIyNjVDMTQ6NkE1MDBBOTkiLCJ2aXNpdG9yX2lkIjoiMzYzOTY4NzIwNDAzOTU1OTgzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 23f1682ece5e6851cd7f88686273e591bb533e21a5dc127658d43071c2492d03 |
| hovercard-subject-tag | pull_request:342720813 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30545/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/19acbfc78743ea97cae697b87ea4f8defa7a2debeffde8cc206595ca6cfec4a9/nodejs/node/pull/30545 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19acbfc78743ea97cae697b87ea4f8defa7a2debeffde8cc206595ca6cfec4a9/nodejs/node/pull/30545 |
| og:image:alt | When an error occurs unexpectedly, let the user know what the error is.
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is ob... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93a615b89b7dcbdb6b678f4772931ecc28ada82a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30545#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30545 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30545 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30545 |
| Reload | https://github.com/nodejs/node/pull/30545 |
| Reload | https://github.com/nodejs/node/pull/30545 |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:quelch | https://github.com/Trott/io.js/tree/quelch |
| Conversation | https://github.com/nodejs/node/pull/30545 |
| Commits0 (0) | https://github.com/nodejs/node/pull/30545/commits |
| Checks | https://github.com/nodejs/node/pull/30545/checks |
| Files changed | https://github.com/nodejs/node/pull/30545/files |
| test: improve test-dgram-send-cb-quelches-error | https://github.com/nodejs/node/pull/30545#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:quelch | https://github.com/Trott/io.js/tree/quelch |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30545#issue-525059305 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30545#event-2811721088 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30545#issuecomment-555543774 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30545#pullrequestreview-319096901 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30545/files |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30545 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30545#event-2811731435 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30545#pullrequestreview-319097988 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30545/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30545#issuecomment-555669751 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30545#pullrequestreview-319339184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30545/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2019 | https://github.com/nodejs/node/pull/30545#issuecomment-556017858 |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| https://ci.nodejs.org/job/node-test-pull-request/26780/ | https://ci.nodejs.org/job/node-test-pull-request/26780/ |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| Trott | https://github.com/Trott |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-f04f4ae |
|
| https://github.com/Trott |
| test: improve assertion message in internet dgram test | https://github.com/Trott/io.js/commit/f04f4aef1014e207356abc1f57c197732de118d2 |
| f04f4ae | https://github.com/Trott/io.js/commit/f04f4aef1014e207356abc1f57c197732de118d2 |
| nodejs#30545 | https://github.com/nodejs/node/pull/30545 |
| Trott | https://github.com/Trott |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-afa4f57 |
|
| https://github.com/Trott |
| test: use reserved .invalid TLD for invalid address in test | https://github.com/Trott/io.js/commit/afa4f579d36586117bf4773857215fe8a5b3557c |
| afa4f57 | https://github.com/Trott/io.js/commit/afa4f579d36586117bf4773857215fe8a5b3557c |
| nodejs#30545 | https://github.com/nodejs/node/pull/30545 |
| Trott | https://github.com/Trott |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-03b5c46 |
|
| https://github.com/Trott |
| test: move test not requiring internet from internet to parallel | https://github.com/Trott/io.js/commit/03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
| 03b5c46 | https://github.com/Trott/io.js/commit/03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
| nodejs#30545 | https://github.com/nodejs/node/pull/30545 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 21, 2019 | https://github.com/nodejs/node/pull/30545#event-2820702541 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/c8fa171ba30dd6ff700751db6ce10d2485cc17bc..03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
| c8fa171 | https://github.com/nodejs/node/commit/c8fa171ba30dd6ff700751db6ce10d2485cc17bc |
| 03b5c46 | https://github.com/nodejs/node/commit/03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
|
Compare
| https://github.com/nodejs/node/compare/c8fa171ba30dd6ff700751db6ce10d2485cc17bc..03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
| November 21, 2019 18:27 | https://github.com/nodejs/node/pull/30545#event-2820702543 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 21, 2019 | https://github.com/nodejs/node/pull/30545#issuecomment-557212747 |
| 9fbad51...03b5c46 | https://github.com/nodejs/node/compare/9fbad51c8a6afdaf7d24d57a1712319346efe28e...03b5c46bc41f8ffd8d30c7902247134e091dc8e9 |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| November 21, 2019 18:28 | https://github.com/nodejs/node/pull/30545#event-2820705623 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-92f766b |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: improve assertion message in internet dgram test | https://github.com/nodejs/node/commit/92f766bd8327f98185584e966714bf8831966ab7 |
| 92f766b | https://github.com/nodejs/node/commit/92f766bd8327f98185584e966714bf8831966ab7 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-902c670 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: use reserved .invalid TLD for invalid address in test | https://github.com/nodejs/node/commit/902c6702df69455170b7b8e3f40dc930389bd051 |
| 902c670 | https://github.com/nodejs/node/commit/902c6702df69455170b7b8e3f40dc930389bd051 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-cb9c64a |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: move test not requiring internet from internet to parallel | https://github.com/nodejs/node/commit/cb9c64a6e0ba2237c9c7b2fc60e9d887ee225edf |
| cb9c64a | https://github.com/nodejs/node/commit/cb9c64a6e0ba2237c9c7b2fc60e9d887ee225edf |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 21, 2019
| https://github.com/nodejs/node/pull/30545#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-36b6b05 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: improve assertion message in internet dgram test | https://github.com/nodejs/node/commit/36b6b052d3aeb124b33e65716f7ffa1c0896626a |
| 36b6b05 | https://github.com/nodejs/node/commit/36b6b052d3aeb124b33e65716f7ffa1c0896626a |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-7f3aec7 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: use reserved .invalid TLD for invalid address in test | https://github.com/nodejs/node/commit/7f3aec7e41bfd4af3d58e319463e59136abc37e2 |
| 7f3aec7 | https://github.com/nodejs/node/commit/7f3aec7e41bfd4af3d58e319463e59136abc37e2 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-aaee981 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: move test not requiring internet from internet to parallel | https://github.com/nodejs/node/commit/aaee981b8ea2bfc8605e27f4fe0e632374bf7656 |
| aaee981 | https://github.com/nodejs/node/commit/aaee981b8ea2bfc8605e27f4fe0e632374bf7656 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30545#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-d802393 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: improve assertion message in internet dgram test | https://github.com/nodejs/node/commit/d8023933360386c17764a40308bb4f379594d668 |
| d802393 | https://github.com/nodejs/node/commit/d8023933360386c17764a40308bb4f379594d668 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-9869aaa |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: use reserved .invalid TLD for invalid address in test | https://github.com/nodejs/node/commit/9869aaaee46e22a6de0f22904ee83087cd6c3771 |
| 9869aaa | https://github.com/nodejs/node/commit/9869aaaee46e22a6de0f22904ee83087cd6c3771 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30545#ref-commit-0d26263 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: move test not requiring internet from internet to parallel | https://github.com/nodejs/node/commit/0d26263b7e7a16e0651a93c116b695a8023f0114 |
| 0d26263 | https://github.com/nodejs/node/commit/0d26263b7e7a16e0651a93c116b695a8023f0114 |
| #30545 | https://github.com/nodejs/node/pull/30545 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30545#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30545 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30545/files/c8fa171ba30dd6ff700751db6ce10d2485cc17bc |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/30545/files/c8fa171ba30dd6ff700751db6ce10d2485cc17bc |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30545/files/c8fa171ba30dd6ff700751db6ce10d2485cc17bc |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/30545 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joyeecheung |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |