René's URL Explorer Experiment


Title: [v10.x] n-api: correct bug in napi_get_last_error by gabrielschulhof · Pull Request #30532 · nodejs/node · GitHub

Open Graph Title: [v10.x] n-api: correct bug in napi_get_last_error by gabrielschulhof · Pull Request #30532 · nodejs/node

X Title: [v10.x] n-api: correct bug in napi_get_last_error by gabrielschulhof · Pull Request #30532 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: napi_get_last_error returns incorrect napi_status. PR-URL: #28702 Reviewed-By: @jasnell Reviewed-By: @gabrielschulhof Reviewed-By: @cjihrig Reviewed-By: @mhdawson Re: #30487 Checklist make -j4 ...

X Description: napi_get_last_error returns incorrect napi_status. PR-URL: #28702 Reviewed-By: @jasnell Reviewed-By: @gabrielschulhof Reviewed-By: @cjihrig Reviewed-By: @mhdawson Re: #30487 Checklist make -j4 ...

Opengraph URL: https://github.com/nodejs/node/pull/30532

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a883b64-5b86-f7e1-3c22-8505b0d49982
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2CE:1A1F1B:6A52089:9587048:6A4FF4F2
html-safe-nonceecc4a3a67bea7a2b2ebf6a8a9f91d8c5ee8b5f77343eb818c6d02c98e234e4ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkNFOjFBMUYxQjo2QTUyMDg5Ojk1ODcwNDg6NkE0RkY0RjIiLCJ2aXNpdG9yX2lkIjoiMzEwMTc3OTM3OTU2MDExNzQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76b6b5dc36bc6900add1c20a4556bfb5a5d5665cacfd8836f7c1e35cf3387dbb
hovercard-subject-tagpull_request:342281820
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30532/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a2428370e434537e3c7f8daa619c3502356fe30f72951185b0b2c6da3149f37e/nodejs/node/pull/30532
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2428370e434537e3c7f8daa619c3502356fe30f72951185b0b2c6da3149f37e/nodejs/node/pull/30532
og:image:altnapi_get_last_error returns incorrect napi_status. PR-URL: #28702 Reviewed-By: @jasnell Reviewed-By: @gabrielschulhof Reviewed-By: @cjihrig Reviewed-By: @mhdawson Re: #30487 Checklist make -j4 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67a336083e4dcb40224dc2c01cd4c7ed413bdb09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30532#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30532
Reloadhttps://github.com/nodejs/node/pull/30532
Reloadhttps://github.com/nodejs/node/pull/30532
Please reload this pagehttps://github.com/nodejs/node/pull/30532
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30532
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:backport-28702-to-v10.xhttps://github.com/gabrielschulhof/node/tree/backport-28702-to-v10.x
Conversationhttps://github.com/nodejs/node/pull/30532
Commits1 (1)https://github.com/nodejs/node/pull/30532/commits
Checkshttps://github.com/nodejs/node/pull/30532/checks
Files changedhttps://github.com/nodejs/node/pull/30532/files
[v10.x] n-api: correct bug in napi_get_last_errorhttps://github.com/nodejs/node/pull/30532#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:backport-28702-to-v10.xhttps://github.com/gabrielschulhof/node/tree/backport-28702-to-v10.x
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 18, 2019https://github.com/nodejs/node/pull/30532#issue-524522913
#28702https://github.com/nodejs/node/pull/28702
@jasnellhttps://github.com/jasnell
@gabrielschulhofhttps://github.com/gabrielschulhof
@cjihrighttps://github.com/cjihrig
@mhdawsonhttps://github.com/mhdawson
#30487https://github.com/nodejs/node/issues/30487
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30532
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Nov 18, 2019https://github.com/nodejs/node/pull/30532#event-2808505804
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 19, 2019 https://github.com/nodejs/node/pull/30532#pullrequestreview-318738957
View reviewed changes https://github.com/nodejs/node/pull/30532/files
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Nov 19, 2019 https://github.com/nodejs/node/pull/30532#pullrequestreview-319194067
View reviewed changes https://github.com/nodejs/node/pull/30532/files
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 20, 2019 https://github.com/nodejs/node/pull/30532#pullrequestreview-320368824
View reviewed changes https://github.com/nodejs/node/pull/30532/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/30532#pullrequestreview-320368824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
n-api: correct bug in napi_get_last_errorhttps://github.com/nodejs/node/pull/30532/commits/d5a73ad775501a6111d9bbba37883d9779846b4d
d5a73adhttps://github.com/nodejs/node/pull/30532/commits/d5a73ad775501a6111d9bbba37883d9779846b4d
nodejs#28702https://github.com/nodejs/node/pull/28702
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac..d5a73ad775501a6111d9bbba37883d9779846b4d
01f2c3ahttps://github.com/nodejs/node/commit/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac
d5a73adhttps://github.com/nodejs/node/commit/d5a73ad775501a6111d9bbba37883d9779846b4d
Compare https://github.com/nodejs/node/compare/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac..d5a73ad775501a6111d9bbba37883d9779846b4d
November 25, 2019 15:15https://github.com/nodejs/node/pull/30532#event-2828491562
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 3, 2019https://github.com/nodejs/node/pull/30532#issuecomment-561103289
Please reload this pagehttps://github.com/nodejs/node/pull/30532
https://ci.nodejs.org/job/node-test-pull-request/27301/https://ci.nodejs.org/job/node-test-pull-request/27301/
Please reload this pagehttps://github.com/nodejs/node/pull/30532
BethGriggshttps://github.com/BethGriggs
Dec 3, 2019 https://github.com/nodejs/node/pull/30532#ref-commit-14e7a35
https://github.com/BethGriggs
n-api: correct bug in napi_get_last_errorhttps://github.com/nodejs/node/commit/14e7a35e95b35beb5b9e42ed5813e9ccc4afa4e0
14e7a35https://github.com/nodejs/node/commit/14e7a35e95b35beb5b9e42ed5813e9ccc4afa4e0
#30532https://github.com/nodejs/node/pull/30532
#28702https://github.com/nodejs/node/pull/28702
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 3, 2019https://github.com/nodejs/node/pull/30532#issuecomment-561269765
14e7a35https://github.com/nodejs/node/commit/14e7a35e95b35beb5b9e42ed5813e9ccc4afa4e0
Please reload this pagehttps://github.com/nodejs/node/pull/30532
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 3, 2019https://github.com/nodejs/node/pull/30532#event-2850930140
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30532#ref-commit-88e8b7c
https://github.com/MylesBorins
n-api: correct bug in napi_get_last_errorhttps://github.com/nodejs/node/commit/88e8b7cf83353e575a1e1eb63f81a320002605a4
88e8b7chttps://github.com/nodejs/node/commit/88e8b7cf83353e575a1e1eb63f81a320002605a4
#30532https://github.com/nodejs/node/pull/30532
#28702https://github.com/nodejs/node/pull/28702
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
March 13, 2020 06:47https://github.com/nodejs/node/pull/30532#event-3125582979
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30532
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/30532/files/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/30532/files/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/30532/files/01f2c3ac08f7669a674d1215d0c6fcb6c03e17ac
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/30532
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/legendecas
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.