René's URL Explorer Experiment


Title: test: clean up http-set-trailers by lundibundi · Pull Request #30522 · nodejs/node · GitHub

Open Graph Title: test: clean up http-set-trailers by lundibundi · Pull Request #30522 · nodejs/node

X Title: test: clean up http-set-trailers by lundibundi · Pull Request #30522 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: remove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was...

X Description: remove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was...

Opengraph URL: https://github.com/nodejs/node/pull/30522

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:91dc5c55-3bd2-a344-76b9-bb9661866732
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCFC:9D1CD:28434FE:37E0082:6A4F600C
html-safe-nonce22c09ea88462c26f9afbd2dafad401df6c0f489222d15de93c9f9675afb8ad93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0ZDOjlEMUNEOjI4NDM0RkU6MzdFMDA4Mjo2QTRGNjAwQyIsInZpc2l0b3JfaWQiOiI2MDc4MjM4NTM5NDIxNTQwMzY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd726b43d7eabc3c5e42bb07e67559d572e41e4e821ff22e0344b406b05e2b66c
hovercard-subject-tagpull_request:342086921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30522/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5caad22b6f6cc6ce5ca646046208c071f9bec95cfafac9ab686832ad5b141029/nodejs/node/pull/30522
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5caad22b6f6cc6ce5ca646046208c071f9bec95cfafac9ab686832ad5b141029/nodejs/node/pull/30522
og:image:altremove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelundibundi
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30522#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30522
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30522
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30522
Reloadhttps://github.com/nodejs/node/pull/30522
Reloadhttps://github.com/nodejs/node/pull/30522
Please reload this pagehttps://github.com/nodejs/node/pull/30522
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30522
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:improve-test-http-set-trailershttps://github.com/lundibundi/node/tree/improve-test-http-set-trailers
Conversationhttps://github.com/nodejs/node/pull/30522
Commits2 (2)https://github.com/nodejs/node/pull/30522/commits
Checkshttps://github.com/nodejs/node/pull/30522/checks
Files changedhttps://github.com/nodejs/node/pull/30522/files
test: clean up http-set-trailershttps://github.com/nodejs/node/pull/30522#top
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:improve-test-http-set-trailershttps://github.com/lundibundi/node/tree/improve-test-http-set-trailers
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Nov 18, 2019https://github.com/nodejs/node/pull/30522#issue-524285702
Please reload this pagehttps://github.com/nodejs/node/pull/30522
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/lundibundi
test: clean up http-set-trailershttps://github.com/nodejs/node/pull/30522/commits/88c5a602ad69b2dde01315bc8ea582c88280d081
88c5a60https://github.com/nodejs/node/pull/30522/commits/88c5a602ad69b2dde01315bc8ea582c88280d081
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 18, 2019https://github.com/nodejs/node/pull/30522#event-2807031339
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Nov 18, 2019https://github.com/nodejs/node/pull/30522#event-2807031730
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2019https://github.com/nodejs/node/pull/30522#issuecomment-554962079
https://ci.nodejs.org/job/node-test-pull-request/26693/https://ci.nodejs.org/job/node-test-pull-request/26693/
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 18, 2019 https://github.com/nodejs/node/pull/30522#pullrequestreview-318593268
View reviewed changes https://github.com/nodejs/node/pull/30522/files/88c5a602ad69b2dde01315bc8ea582c88280d081
test/parallel/test-http-set-trailers.jshttps://github.com/nodejs/node/pull/30522/files/88c5a602ad69b2dde01315bc8ea582c88280d081#diff-633a86f9bdb74c1d5d51af04d85ad8d224bc1336fd3902dabb27a5083229aa47
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 18, 2019 https://github.com/nodejs/node/pull/30522#pullrequestreview-318593921
View reviewed changes https://github.com/nodejs/node/pull/30522/files/88c5a602ad69b2dde01315bc8ea582c88280d081
test/parallel/test-http-set-trailers.jshttps://github.com/nodejs/node/pull/30522/files/88c5a602ad69b2dde01315bc8ea582c88280d081#diff-633a86f9bdb74c1d5d51af04d85ad8d224bc1336fd3902dabb27a5083229aa47
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/lundibundi
fixup! test: clean up http-set-trailershttps://github.com/nodejs/node/pull/30522/commits/eb734f3ed415aeff2145043b6dc34469b2aa580a
eb734f3https://github.com/nodejs/node/pull/30522/commits/eb734f3ed415aeff2145043b6dc34469b2aa580a
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 19, 2019 https://github.com/nodejs/node/pull/30522#pullrequestreview-318818763
View reviewed changes https://github.com/nodejs/node/pull/30522/files/eb734f3ed415aeff2145043b6dc34469b2aa580a
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 20, 2019https://github.com/nodejs/node/pull/30522#issuecomment-555857367
Please reload this pagehttps://github.com/nodejs/node/pull/30522
#30523https://github.com/nodejs/node/issues/30523
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 20, 2019https://github.com/nodejs/node/pull/30522#event-2814046660
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2019https://github.com/nodejs/node/pull/30522#issuecomment-555857844
https://ci.nodejs.org/job/node-test-pull-request/26770/https://ci.nodejs.org/job/node-test-pull-request/26770/
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Nov 20, 2019 https://github.com/nodejs/node/pull/30522#pullrequestreview-320039327
View reviewed changes https://github.com/nodejs/node/pull/30522/files/eb734f3ed415aeff2145043b6dc34469b2aa580a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2019https://github.com/nodejs/node/pull/30522#issuecomment-556086266
https://ci.nodejs.org/job/node-test-pull-request/26790/https://ci.nodejs.org/job/node-test-pull-request/26790/
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 20, 2019https://github.com/nodejs/node/pull/30522#issuecomment-556410567
a30a9f8https://github.com/nodejs/node/commit/a30a9f8193ddd61dfadc2d5d79784b682027b319
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 20, 2019https://github.com/nodejs/node/pull/30522#event-2816845143
Trotthttps://github.com/Trott
Nov 20, 2019 https://github.com/nodejs/node/pull/30522#ref-commit-a30a9f8
https://github.com/lundibundi
https://github.com/Trott
test: clean up http-set-trailershttps://github.com/nodejs/node/commit/a30a9f8193ddd61dfadc2d5d79784b682027b319
a30a9f8https://github.com/nodejs/node/commit/a30a9f8193ddd61dfadc2d5d79784b682027b319
#30522https://github.com/nodejs/node/pull/30522
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2019 https://github.com/nodejs/node/pull/30522#ref-commit-6be0398
https://github.com/lundibundi
https://github.com/MylesBorins
test: clean up http-set-trailershttps://github.com/nodejs/node/commit/6be03981b261939465672337d9790a18a2055b31
6be0398https://github.com/nodejs/node/commit/6be03981b261939465672337d9790a18a2055b31
#30522https://github.com/nodejs/node/pull/30522
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 21, 2019 https://github.com/nodejs/node/pull/30522#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30522#ref-commit-2bcd3a6
https://github.com/lundibundi
https://github.com/targos
test: clean up http-set-trailershttps://github.com/nodejs/node/commit/2bcd3a689fa8b68b7b82d1a135ef769927a077aa
2bcd3a6https://github.com/nodejs/node/commit/2bcd3a689fa8b68b7b82d1a135ef769927a077aa
#30522https://github.com/nodejs/node/pull/30522
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30522#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30522#ref-commit-3fb0f7e
https://github.com/lundibundi
https://github.com/MylesBorins
test: clean up http-set-trailershttps://github.com/nodejs/node/commit/3fb0f7ebd0a62d2d4cd1fb81b1613e500b2f8530
3fb0f7ehttps://github.com/nodejs/node/commit/3fb0f7ebd0a62d2d4cd1fb81b1613e500b2f8530
#30522https://github.com/nodejs/node/pull/30522
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30522#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30522
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/30522/files/eb734f3ed415aeff2145043b6dc34469b2aa580a
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/30522/files/eb734f3ed415aeff2145043b6dc34469b2aa580a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/30522
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.