René's URL Explorer Experiment


Title: src: remove unused sync result from ASYNC_CALL by skomski · Pull Request #3049 · nodejs/node · GitHub

Open Graph Title: src: remove unused sync result from ASYNC_CALL by skomski · Pull Request #3049 · nodejs/node

X Title: src: remove unused sync result from ASYNC_CALL by skomski · Pull Request #3049 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes use-after-free of req_wrap if uv returns early err

X Description: Fixes use-after-free of req_wrap if uv returns early err

Opengraph URL: https://github.com/nodejs/node/pull/3049

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd502da1-1c5e-047b-708a-d3e9ab225007
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFFE:35EA72:38A221:4CEA4B:6A4D9EC5
html-safe-noncebba12a2e224279614e8e26dfeefb9d2f69f0ab749726e93dd86fc8665411bd2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkZFOjM1RUE3MjozOEEyMjE6NENFQTRCOjZBNEQ5RUM1IiwidmlzaXRvcl9pZCI6Ijk1NTQ2NDUwMzEwNzI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca00277efb676a3ee7877b86bb609e986c91cd14a408877d7d3d984159eda2d71
hovercard-subject-tagpull_request:45878816
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3049/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98f5c92286d35d5420aea878fd0214632e41a50a81e397f716a32290c2a75b0d/nodejs/node/pull/3049
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98f5c92286d35d5420aea878fd0214632e41a50a81e397f716a32290c2a75b0d/nodejs/node/pull/3049
og:image:altFixes use-after-free of req_wrap if uv returns early err
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskomski
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3049#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3049
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3049
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3049
Reloadhttps://github.com/nodejs/node/pull/3049
Reloadhttps://github.com/nodejs/node/pull/3049
Please reload this pagehttps://github.com/nodejs/node/pull/3049
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3049
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
skomskihttps://github.com/skomski
nodejs:masterhttps://github.com/nodejs/node/tree/master
skomski:fix-ufe-req-wraphttps://github.com/skomski/node/tree/fix-ufe-req-wrap
Conversationhttps://github.com/nodejs/node/pull/3049
Commits1 (1)https://github.com/nodejs/node/pull/3049/commits
Checkshttps://github.com/nodejs/node/pull/3049/checks
Files changedhttps://github.com/nodejs/node/pull/3049/files
src: remove unused sync result from ASYNC_CALLhttps://github.com/nodejs/node/pull/3049#top
skomskihttps://github.com/skomski
nodejs:masterhttps://github.com/nodejs/node/tree/master
skomski:fix-ufe-req-wraphttps://github.com/skomski/node/tree/fix-ufe-req-wrap
https://github.com/skomski
skomskihttps://github.com/skomski
Sep 24, 2015https://github.com/nodejs/node/pull/3049#issue-108098216
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/mscdex
mscdexhttps://github.com/mscdex
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Sep 24, 2015https://github.com/nodejs/node/pull/3049#event-418150600
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 24, 2015https://github.com/nodejs/node/pull/3049#issuecomment-142948435
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/skomski
skomskihttps://github.com/skomski
force-pushedhttps://github.com/nodejs/node/compare/babbc51ae3038e6c4e35cf63ff538057949df9a4..e3dc2f617a16b907fd3334936dc2f684559d3339
babbc51https://github.com/nodejs/node/commit/babbc51ae3038e6c4e35cf63ff538057949df9a4
e3dc2f6https://github.com/nodejs/node/commit/e3dc2f617a16b907fd3334936dc2f684559d3339
Compare https://github.com/nodejs/node/compare/babbc51ae3038e6c4e35cf63ff538057949df9a4..e3dc2f617a16b907fd3334936dc2f684559d3339
September 26, 2015 20:38https://github.com/nodejs/node/pull/3049#event-419992332
https://github.com/skomski
skomskihttps://github.com/skomski
Sep 26, 2015https://github.com/nodejs/node/pull/3049#issuecomment-143495157
Please reload this pagehttps://github.com/nodejs/node/pull/3049
bnoordhuishttps://github.com/bnoordhuis
Sep 26, 2015 https://github.com/nodejs/node/pull/3049#discussion-diff-40498488
View reviewed changes https://github.com/nodejs/node/pull/3049/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
src/node_file.cchttps://github.com/nodejs/node/pull/3049/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
bnoordhuishttps://github.com/bnoordhuis
Sep 26, 2015https://github.com/nodejs/node/pull/3049#discussion_r40498488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/skomski
src: fix u-a-free if uv returns err in ASYNC_CALLhttps://github.com/nodejs/node/pull/3049/commits/95950253defa9052301b5b5a311ca85fdc377542
9595025https://github.com/nodejs/node/pull/3049/commits/95950253defa9052301b5b5a311ca85fdc377542
https://github.com/skomski
skomskihttps://github.com/skomski
force-pushedhttps://github.com/nodejs/node/compare/e3dc2f617a16b907fd3334936dc2f684559d3339..95950253defa9052301b5b5a311ca85fdc377542
e3dc2f6https://github.com/nodejs/node/commit/e3dc2f617a16b907fd3334936dc2f684559d3339
9595025https://github.com/nodejs/node/commit/95950253defa9052301b5b5a311ca85fdc377542
Compare https://github.com/nodejs/node/compare/e3dc2f617a16b907fd3334936dc2f684559d3339..95950253defa9052301b5b5a311ca85fdc377542
September 26, 2015 21:37https://github.com/nodejs/node/pull/3049#event-420004827
https://github.com/skomski
skomskihttps://github.com/skomski
Oct 7, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146120860
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 7, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146179942
https://ci.nodejs.org/job/node-test-pull-request/441/https://ci.nodejs.org/job/node-test-pull-request/441/
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/skomski
skomskihttps://github.com/skomski
Oct 8, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146629841
Please reload this pagehttps://github.com/nodejs/node/pull/3049
bnoordhuishttps://github.com/bnoordhuis
Oct 8, 2015 https://github.com/nodejs/node/pull/3049#ref-commit-ccaaae9
https://github.com/skomski
https://github.com/bnoordhuis
src: fix u-a-free if uv returns err in ASYNC_CALLhttps://github.com/bnoordhuis/io.js/commit/ccaaae9d0ca39ac83f54199102ce1469d5ac3a55
ccaaae9https://github.com/bnoordhuis/io.js/commit/ccaaae9d0ca39ac83f54199102ce1469d5ac3a55
nodejs#3049https://github.com/nodejs/node/pull/3049
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 8, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146631319
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 8, 2015https://github.com/nodejs/node/pull/3049#event-430585227
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 9, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146724948
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Oct 9, 2015https://github.com/nodejs/node/pull/3049#event-430946001
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 9, 2015https://github.com/nodejs/node/pull/3049#issuecomment-146726659
Please reload this pagehttps://github.com/nodejs/node/pull/3049
jasnellhttps://github.com/jasnell
Oct 9, 2015 https://github.com/nodejs/node/pull/3049#ref-commit-2314378
https://github.com/skomski
https://github.com/jasnell
src: fix u-a-free if uv returns err in ASYNC_CALLhttps://github.com/nodejs/node/commit/2314378f0689394e0b0ad7417dc2d54c875b997c
2314378https://github.com/nodejs/node/commit/2314378f0689394e0b0ad7417dc2d54c875b997c
#3049https://github.com/nodejs/node/pull/3049
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
Oct 9, 2015https://github.com/nodejs/node/pull/3049#event-431018563
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 10, 2015 https://github.com/nodejs/node/pull/3049#ref-pullrequest-110375513
Release proposal: v4.2.0 'Argon' (LTS) #3258 https://github.com/nodejs/node/pull/3258
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2015https://github.com/nodejs/node/pull/3049#issuecomment-157217779
2314378https://github.com/nodejs/node/commit/2314378f0689394e0b0ad7417dc2d54c875b997c
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Nov 17, 2015https://github.com/nodejs/node/pull/3049#event-466121104
[Snyk] Fix for 2 vulnerabilities baby636/node#28 https://github.com/baby636/node/pull/28
[Snyk] Fix for 2 vulnerabilities ron-a20/node#47 https://github.com/ron-a20/node/pull/47
[Snyk] Fix for 2 vulnerabilities Rednickle/node-1#34 https://github.com/Rednickle/node-1/pull/34
[Snyk] Fix for 2 vulnerabilities aliceUnhinged613/node#37 https://github.com/aliceUnhinged613/node/pull/37
[Snyk] Fix for 2 vulnerabilities meghasfdc/node#48 https://github.com/meghasfdc/node/pull/48
[Snyk] Fix for 2 vulnerabilities Dmarch28/node#38 https://github.com/Dmarch28/node/pull/38
[Snyk] Fix for 2 vulnerabilities wedataintelligence/node#16 https://github.com/wedataintelligence/node/pull/16
[Snyk] Fix for 2 vulnerabilities kissofire/node#49 https://github.com/kissofire/node/pull/49
[Snyk] Fix for 2 vulnerabilities 137717unity/node#40 https://github.com/137717unity/node/pull/40
[Snyk] Fix for 2 vulnerabilities sitedata/node#39 https://github.com/sitedata/node/pull/39
[Snyk] Fix for 2 vulnerabilities molllyn1/node#29 https://github.com/molllyn1/node/pull/29
[Snyk] Security upgrade prismjs from 1.21.0 to 1.25.0 turkdevops/node#340 https://github.com/turkdevops/node/pull/340
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3049
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/3049
https://github.com/skomski
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.