René's URL Explorer Experiment


Title: test: change from var to let by Sahtair · Pull Request #30431 · nodejs/node · GitHub

Open Graph Title: test: change from var to let by Sahtair · Pull Request #30431 · nodejs/node

X Title: test: change from var to let by Sahtair · Pull Request #30431 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30431

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a7c500cf-9a50-7c47-cac2-3ed5ae921e97
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD046:22B172:608661:8B153D:6A4FAC1A
html-safe-noncedc8aa795ddd11fcce849a5e44a36f2c27fa4facdc432a07c557b30814d446b68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDQ2OjIyQjE3Mjo2MDg2NjE6OEIxNTNEOjZBNEZBQzFBIiwidmlzaXRvcl9pZCI6IjM3NDU1NDIwNTg5Mzg0NDQ4MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8e5c6b95a06f383d562ef99a64628a88369e5ba8ec739509a8972f137c3a9e9f
hovercard-subject-tagpull_request:339983795
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30431/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/33da632f5948ab089b65bae2809425bb6912c9882c3474efd1384e38d6ef32e7/nodejs/node/pull/30431
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/33da632f5948ab089b65bae2809425bb6912c9882c3474efd1384e38d6ef32e7/nodejs/node/pull/30431
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSahtair
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30431#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30431
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30431
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30431
Reloadhttps://github.com/nodejs/node/pull/30431
Reloadhttps://github.com/nodejs/node/pull/30431
Please reload this pagehttps://github.com/nodejs/node/pull/30431
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30431
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sahtairhttps://github.com/Sahtair
nodejs:masterhttps://github.com/nodejs/node/tree/master
Sahtair:NodeConfEU103https://github.com/Sahtair/node/tree/NodeConfEU103
Conversationhttps://github.com/nodejs/node/pull/30431
Commits2 (2)https://github.com/nodejs/node/pull/30431/commits
Checkshttps://github.com/nodejs/node/pull/30431/checks
Files changedhttps://github.com/nodejs/node/pull/30431/files
test: change from var to lethttps://github.com/nodejs/node/pull/30431#top
Sahtairhttps://github.com/Sahtair
nodejs:masterhttps://github.com/nodejs/node/tree/master
Sahtair:NodeConfEU103https://github.com/Sahtair/node/tree/NodeConfEU103
https://github.com/Sahtair
Sahtairhttps://github.com/Sahtair
Nov 12, 2019https://github.com/nodejs/node/pull/30431#issue-521641640
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30431
test: Change from var to consthttps://github.com/nodejs/node/pull/30431/commits/17021e733e20fd8df4ff59c2e80beec73788c7e0
17021e7https://github.com/nodejs/node/pull/30431/commits/17021e733e20fd8df4ff59c2e80beec73788c7e0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 12, 2019https://github.com/nodejs/node/pull/30431#event-2792028511
https://github.com/Sahtair
Sahtairhttps://github.com/Sahtair
Nov 12, 2019https://github.com/nodejs/node/pull/30431#event-2792029113
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-315648156
View reviewed changes https://github.com/nodejs/node/pull/30431/files/17021e733e20fd8df4ff59c2e80beec73788c7e0
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-315651448
View reviewed changes https://github.com/nodejs/node/pull/30431/files/17021e733e20fd8df4ff59c2e80beec73788c7e0
targoshttps://github.com/targos
https://github.com/nodejs/node/pull/30431#pullrequestreview-315651448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30431
test: change from const to lethttps://github.com/nodejs/node/pull/30431/commits/833edc25a3868fea5ab88577c49fa43059b346c9
833edc2https://github.com/nodejs/node/pull/30431/commits/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/Sahtair
Sahtairhttps://github.com/Sahtair
targoshttps://github.com/targos
November 12, 2019 16:23https://github.com/nodejs/node/pull/30431#event-2792114793
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 12, 2019https://github.com/nodejs/node/pull/30431#event-2792117484
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-315665431
View reviewed changes https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019https://github.com/nodejs/node/pull/30431#event-2793717706
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-315972538
View reviewed changes https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 17, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-318018410
View reviewed changes https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/targos
targoshttps://github.com/targos
Nov 17, 2019 https://github.com/nodejs/node/pull/30431#pullrequestreview-318019486
View reviewed changes https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2019https://github.com/nodejs/node/pull/30431#issuecomment-554884487
https://ci.nodejs.org/job/node-test-pull-request/26676/https://ci.nodejs.org/job/node-test-pull-request/26676/
Please reload this pagehttps://github.com/nodejs/node/pull/30431
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 18, 2019 https://github.com/nodejs/node/pull/30431#ref-commit-0bc0abb
https://github.com/gireeshpunathil
test: Change from var to consthttps://github.com/nodejs/node/commit/0bc0abb941c0aeb58d057c033f217819f22bb105
0bc0abbhttps://github.com/nodejs/node/commit/0bc0abb941c0aeb58d057c033f217819f22bb105
#30431https://github.com/nodejs/node/pull/30431
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 18, 2019https://github.com/nodejs/node/pull/30431#issuecomment-554904044
0bc0abbhttps://github.com/nodejs/node/commit/0bc0abb941c0aeb58d057c033f217819f22bb105
Please reload this pagehttps://github.com/nodejs/node/pull/30431
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 18, 2019https://github.com/nodejs/node/pull/30431#event-2806541360
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30431#ref-commit-5ec550d
https://github.com/BridgeAR
test: Change from var to consthttps://github.com/nodejs/node/commit/5ec550de02e189f899712bee358f5571ed43aaeb
5ec550dhttps://github.com/nodejs/node/commit/5ec550de02e189f899712bee358f5571ed43aaeb
#30431https://github.com/nodejs/node/pull/30431
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30431#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30431#ref-commit-34b136b
https://github.com/targos
test: Change from var to consthttps://github.com/nodejs/node/commit/34b136bd765e793e1ac424564d19abd217825ea1
34b136bhttps://github.com/nodejs/node/commit/34b136bd765e793e1ac424564d19abd217825ea1
#30431https://github.com/nodejs/node/pull/30431
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30431#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30431#ref-commit-c0d9a54
https://github.com/MylesBorins
test: Change from var to consthttps://github.com/nodejs/node/commit/c0d9a545a3b3f83ea64f747da636f71cae9035fb
c0d9a54https://github.com/nodejs/node/commit/c0d9a545a3b3f83ea64f747da636f71cae9035fb
#30431https://github.com/nodejs/node/pull/30431
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30431#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30431
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30431/files/17021e733e20fd8df4ff59c2e80beec73788c7e0
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30431/files/833edc25a3868fea5ab88577c49fa43059b346c9
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/30431
https://github.com/Sahtair
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.