René's URL Explorer Experiment


Title: test: use spread instead of Object.assign by dnlup · Pull Request #30419 · nodejs/node · GitHub

Open Graph Title: test: use spread instead of Object.assign by dnlup · Pull Request #30419 · nodejs/node

X Title: test: use spread instead of Object.assign by dnlup · Pull Request #30419 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30419

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f9bec109-d925-d10d-8c04-1e83f1612b08
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB85E:3F60C6:5991BC0:7E9B898:6A500A70
html-safe-nonce5090a810f3d2962700eaf50e8d5ac1a4fc9a81277c0d72024422d693e83e79e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODVFOjNGNjBDNjo1OTkxQkMwOjdFOUI4OTg6NkE1MDBBNzAiLCJ2aXNpdG9yX2lkIjoiNDIyMjQ3NjE3ODMzNjc3ODg2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccb2466881bdf14d3549ecc995501ee2768872a534542c13d1cd6253855da5283
hovercard-subject-tagpull_request:339975497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30419/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8854c0732b6c527da563698c671f5d3290526843f61693092f0c1e3b433d9978/nodejs/node/pull/30419
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8854c0732b6c527da563698c671f5d3290526843f61693092f0c1e3b433d9978/nodejs/node/pull/30419
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamednlup
hostnamegithub.com
expected-hostnamegithub.com
None56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release93a615b89b7dcbdb6b678f4772931ecc28ada82a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30419#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30419
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30419
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30419
Reloadhttps://github.com/nodejs/node/pull/30419
Reloadhttps://github.com/nodejs/node/pull/30419
Please reload this pagehttps://github.com/nodejs/node/pull/30419
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30419
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
dnluphttps://github.com/dnlup
nodejs:masterhttps://github.com/nodejs/node/tree/master
dnlup:fix/testhttps://github.com/dnlup/node/tree/fix/test
Conversationhttps://github.com/nodejs/node/pull/30419
Commits1 (1)https://github.com/nodejs/node/pull/30419/commits
Checkshttps://github.com/nodejs/node/pull/30419/checks
Files changedhttps://github.com/nodejs/node/pull/30419/files
test: use spread instead of Object.assignhttps://github.com/nodejs/node/pull/30419#top
dnluphttps://github.com/dnlup
nodejs:masterhttps://github.com/nodejs/node/tree/master
dnlup:fix/testhttps://github.com/dnlup/node/tree/fix/test
https://github.com/dnlup
dnluphttps://github.com/dnlup
Nov 12, 2019https://github.com/nodejs/node/pull/30419#issue-521631402
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 12, 2019https://github.com/nodejs/node/pull/30419#event-2791966097
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 12, 2019https://github.com/nodejs/node/pull/30419#event-2791973777
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 12, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-315635965
View reviewed changes https://github.com/nodejs/node/pull/30419/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 12, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-315636011
View reviewed changes https://github.com/nodejs/node/pull/30419/files
test/benchmark/test-benchmark-dns.jshttps://github.com/nodejs/node/pull/30419/files#diff-d3838139915317bba7fbf7b8b710ed5b396d20eadf532665d5492a11d63b4219
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-315649796
View reviewed changes https://github.com/nodejs/node/pull/30419/files
https://github.com/dnlup
dnluphttps://github.com/dnlup
force-pushedhttps://github.com/nodejs/node/compare/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3..2c153f552ebdcfcf48ee2e0e6faebd9d0b969959
c237b08https://github.com/nodejs/node/commit/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3
2c153f5https://github.com/nodejs/node/commit/2c153f552ebdcfcf48ee2e0e6faebd9d0b969959
Compare https://github.com/nodejs/node/compare/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3..2c153f552ebdcfcf48ee2e0e6faebd9d0b969959
November 12, 2019 16:16https://github.com/nodejs/node/pull/30419#event-2792085302
https://github.com/dnlup
test: use spread instead of Object.assignhttps://github.com/nodejs/node/pull/30419/commits/db175d5c2be398821560d9bfc44e763779ffb6ca
db175d5https://github.com/nodejs/node/pull/30419/commits/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/dnlup
dnluphttps://github.com/dnlup
force-pushedhttps://github.com/nodejs/node/compare/2c153f552ebdcfcf48ee2e0e6faebd9d0b969959..db175d5c2be398821560d9bfc44e763779ffb6ca
2c153f5https://github.com/nodejs/node/commit/2c153f552ebdcfcf48ee2e0e6faebd9d0b969959
db175d5https://github.com/nodejs/node/commit/db175d5c2be398821560d9bfc44e763779ffb6ca
Compare https://github.com/nodejs/node/compare/2c153f552ebdcfcf48ee2e0e6faebd9d0b969959..db175d5c2be398821560d9bfc44e763779ffb6ca
November 12, 2019 16:16https://github.com/nodejs/node/pull/30419#event-2792087301
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-315974494
View reviewed changes https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 13, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-316408236
View reviewed changes https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 13, 2019https://github.com/nodejs/node/pull/30419#event-2796095475
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 13, 2019https://github.com/nodejs/node/pull/30419#issuecomment-553497655
https://ci.nodejs.org/job/node-test-pull-request/26554/https://ci.nodejs.org/job/node-test-pull-request/26554/
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 16, 2019 https://github.com/nodejs/node/pull/30419#pullrequestreview-317957091
View reviewed changes https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 16, 2019https://github.com/nodejs/node/pull/30419#issuecomment-554611689
https://ci.nodejs.org/job/node-test-pull-request/26625/https://ci.nodejs.org/job/node-test-pull-request/26625/
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 25, 2019https://github.com/nodejs/node/pull/30419#issuecomment-557956965
https://ci.nodejs.org/job/node-test-pull-request/26935/https://ci.nodejs.org/job/node-test-pull-request/26935/
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 25, 2019https://github.com/nodejs/node/pull/30419#issuecomment-557970830
#30498https://github.com/nodejs/node/issues/30498
Please reload this pagehttps://github.com/nodejs/node/pull/30419
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 25, 2019 https://github.com/nodejs/node/pull/30419#ref-commit-864608e
https://github.com/dnlup
https://github.com/gireeshpunathil
test: use spread instead of Object.assignhttps://github.com/nodejs/node/commit/864608ec6605e66f23905a3e51526bcdb067f6ec
864608ehttps://github.com/nodejs/node/commit/864608ec6605e66f23905a3e51526bcdb067f6ec
#30419https://github.com/nodejs/node/pull/30419
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 25, 2019https://github.com/nodejs/node/pull/30419#issuecomment-557971451
864608ehttps://github.com/nodejs/node/commit/864608ec6605e66f23905a3e51526bcdb067f6ec
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 25, 2019https://github.com/nodejs/node/pull/30419#event-2826558982
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 25, 2019https://github.com/nodejs/node/pull/30419#issuecomment-557971560
864608ehttps://github.com/nodejs/node/commit/864608ec6605e66f23905a3e51526bcdb067f6ec
Please reload this pagehttps://github.com/nodejs/node/pull/30419
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30419#ref-commit-2ecc735
https://github.com/dnlup
https://github.com/addaleax
test: use spread instead of Object.assignhttps://github.com/nodejs/node/commit/2ecc735c4808d7ff9ebf0e39dd5dda4432865925
2ecc735https://github.com/nodejs/node/commit/2ecc735c4808d7ff9ebf0e39dd5dda4432865925
#30419https://github.com/nodejs/node/pull/30419
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30419#ref-commit-eead424
https://github.com/dnlup
https://github.com/targos
test: use spread instead of Object.assignhttps://github.com/nodejs/node/commit/eead42470b3eb1be1066aa4027ae36fa60b7323f
eead424https://github.com/nodejs/node/commit/eead42470b3eb1be1066aa4027ae36fa60b7323f
#30419https://github.com/nodejs/node/pull/30419
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30419#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30419#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30419#ref-commit-d708887
https://github.com/dnlup
https://github.com/MylesBorins
test: use spread instead of Object.assignhttps://github.com/nodejs/node/commit/d708887c0bc42d2a244a35422ae6f2cfd809eba8
d708887https://github.com/nodejs/node/commit/d708887c0bc42d2a244a35422ae6f2cfd809eba8
#30419https://github.com/nodejs/node/pull/30419
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30419#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.com/dnlup
dnluphttps://github.com/dnlup
January 10, 2020 13:40https://github.com/nodejs/node/pull/30419#event-2938547015
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30419
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30419/files/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30419/files/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/30419/files/c237b08c2ec1c48ed2f180e086b6edbb6658d8a3
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30419/files/db175d5c2be398821560d9bfc44e763779ffb6ca
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/30419
https://github.com/dnlup
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.