| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fed647b0-254a-ec05-baef-fd1052cf5311 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B20E:16C3D3:31B5E13:45E8E94:6A4F7636 |
| html-safe-nonce | 199679cc05cc0ba4b772b75a89a7f10fa6e2838eb877b441a061693fb425a226 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjBFOjE2QzNEMzozMUI1RTEzOjQ1RThFOTQ6NkE0Rjc2MzYiLCJ2aXNpdG9yX2lkIjoiMjcyOTg1MjA0Nzk5ODI4NTM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | feb2b1dd35402e25cae7761d84ec2df61a40c9c8262a98add4eb443170498fef |
| hovercard-subject-tag | pull_request:339970986 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30414/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a071650485667d7bd0488782e75f9f50ba1c94d308446e72e176a359dd048fa6/nodejs/node/pull/30414 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a071650485667d7bd0488782e75f9f50ba1c94d308446e72e176a359dd048fa6/nodejs/node/pull/30414 |
| og:image:alt | replaced var to let in lib/internal/child_process.js
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows [commit guidelines] |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lcamargof |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30414#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30414 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30414 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30414 |
| Reload | https://github.com/nodejs/node/pull/30414 |
| Reload | https://github.com/nodejs/node/pull/30414 |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lcamargof | https://github.com/lcamargof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lcamargof:nconf19 | https://github.com/lcamargof/node/tree/nconf19 |
| Conversation | https://github.com/nodejs/node/pull/30414 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30414/commits |
| Checks | https://github.com/nodejs/node/pull/30414/checks |
| Files changed | https://github.com/nodejs/node/pull/30414/files |
| child_process: replaced var to let in lib/internal/child_process.js | https://github.com/nodejs/node/pull/30414#top |
| lcamargof | https://github.com/lcamargof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lcamargof:nconf19 | https://github.com/lcamargof/node/tree/nconf19 |
|
| https://github.com/lcamargof |
| lcamargof | https://github.com/lcamargof |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30414#issue-521625877 |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30414#event-2791930789 |
|
| https://github.com/lcamargof |
| child_process: replaced var to let in lib/internal/child_process.js | https://github.com/nodejs/node/pull/30414/commits/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| 2cf7033 | https://github.com/nodejs/node/pull/30414/commits/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| https://github.com/lcamargof |
| lcamargof | https://github.com/lcamargof |
| force-pushed | https://github.com/nodejs/node/compare/900185f11a4038d734735e3541ad07883a80be63..2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| 900185f | https://github.com/nodejs/node/commit/900185f11a4038d734735e3541ad07883a80be63 |
| 2cf7033 | https://github.com/nodejs/node/commit/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
|
Compare
| https://github.com/nodejs/node/compare/900185f11a4038d734735e3541ad07883a80be63..2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| November 12, 2019 15:49 | https://github.com/nodejs/node/pull/30414#event-2791980321 |
| https://github.com/lcamargof |
| lcamargof | https://github.com/lcamargof |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30414#event-2791981180 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30414#pullrequestreview-315637460 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30414#event-2792258285 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 13, 2019
| https://github.com/nodejs/node/pull/30414#pullrequestreview-315973551 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 13, 2019
| https://github.com/nodejs/node/pull/30414#pullrequestreview-316406345 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30414#issuecomment-553496384 |
| https://ci.nodejs.org/job/node-test-pull-request/26552/ | https://ci.nodejs.org/job/node-test-pull-request/26552/ |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30414#event-2796496200 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 16, 2019
| https://github.com/nodejs/node/pull/30414#pullrequestreview-317957234 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2019 | https://github.com/nodejs/node/pull/30414#issuecomment-556035641 |
| https://ci.nodejs.org/job/node-test-pull-request/26784/ | https://ci.nodejs.org/job/node-test-pull-request/26784/ |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30414#issuecomment-557890703 |
| https://ci.nodejs.org/job/node-test-pull-request/26921/ | https://ci.nodejs.org/job/node-test-pull-request/26921/ |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30414#issuecomment-557902472 |
| https://ci.nodejs.org/job/node-test-pull-request/26928/ | https://ci.nodejs.org/job/node-test-pull-request/26928/ |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| Trott | https://github.com/Trott |
|
Nov 24, 2019
| https://github.com/nodejs/node/pull/30414#ref-commit-8709b90 |
|
| https://github.com/lcamargof |
|
| https://github.com/Trott |
| child_process: replace var with const/let in internal/child_process.js | https://github.com/nodejs/node/commit/8709b905833d2078eaeec65a5e6dbce16096ae00 |
| 8709b90 | https://github.com/nodejs/node/commit/8709b905833d2078eaeec65a5e6dbce16096ae00 |
| #30414 | https://github.com/nodejs/node/pull/30414 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30414#issuecomment-557908567 |
| 8709b90 | https://github.com/nodejs/node/commit/8709b905833d2078eaeec65a5e6dbce16096ae00 |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30414#event-2826098865 |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30414#ref-commit-4b13bca |
|
| https://github.com/lcamargof |
|
| https://github.com/addaleax |
| child_process: replace var with const/let in internal/child_process.js | https://github.com/nodejs/node/commit/4b13bca31aca5e0886ac86fa2ed9aa1454ead40a |
| 4b13bca | https://github.com/nodejs/node/commit/4b13bca31aca5e0886ac86fa2ed9aa1454ead40a |
| #30414 | https://github.com/nodejs/node/pull/30414 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30414#ref-commit-938b894 |
|
| https://github.com/lcamargof |
|
| https://github.com/targos |
| child_process: replace var with const/let in internal/child_process.js | https://github.com/nodejs/node/commit/938b894423db1483f4daaa28cb797e96d533d85b |
| 938b894 | https://github.com/nodejs/node/commit/938b894423db1483f4daaa28cb797e96d533d85b |
| #30414 | https://github.com/nodejs/node/pull/30414 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30414#ref-pullrequest-531889133 |
|
v13.3.0 proposal
#30774
| https://github.com/nodejs/node/pull/30774 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30414#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30414#ref-commit-6974f26 |
|
| https://github.com/lcamargof |
|
| https://github.com/MylesBorins |
| child_process: replace var with const/let in internal/child_process.js | https://github.com/nodejs/node/commit/6974f26e26513ba0e9af95391e2bc6b501baafb1 |
| 6974f26 | https://github.com/nodejs/node/commit/6974f26e26513ba0e9af95391e2bc6b501baafb1 |
| #30414 | https://github.com/nodejs/node/pull/30414 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30414#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30414 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30414/files/2cf7033fc03f747eba88d4db9e8088a7344099c2 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Please reload this page | https://github.com/nodejs/node/pull/30414 |
|
| https://github.com/lcamargof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |