| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:638f9a74-8983-9b41-2a73-91d64ee78e60 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CEC:4FAAE:12A50CE:1AF8418:6A4FAC47 |
| html-safe-nonce | d7e9baa05da38506792c685303b3d3ebb5bed0a73068c80af0a95e656967eb29 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0VDOjRGQUFFOjEyQTUwQ0U6MUFGODQxODo2QTRGQUM0NyIsInZpc2l0b3JfaWQiOiIyMDIyOTUxNjMxMzgxODM0ODIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7498241c9e03d1d736d56d8a10dc0b21c8a7d976c01294e392666342083871a7 |
| hovercard-subject-tag | pull_request:339968636 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30407/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f0a064e73cc7bb3875a3f7c734c697fbf48cd147bd8fb8e4a182bed1157b95a6/nodejs/node/pull/30407 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f0a064e73cc7bb3875a3f7c734c697fbf48cd147bd8fb8e4a182bed1157b95a6/nodejs/node/pull/30407 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alvarp |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30407#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30407 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30407 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30407 |
| Reload | https://github.com/nodejs/node/pull/30407 |
| Reload | https://github.com/nodejs/node/pull/30407 |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| alvarp | https://github.com/alvarp |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| alvarp:nceu19 | https://github.com/alvarp/node/tree/nceu19 |
| Conversation | https://github.com/nodejs/node/pull/30407 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30407/commits |
| Checks | https://github.com/nodejs/node/pull/30407/checks |
| Files changed | https://github.com/nodejs/node/pull/30407/files |
| fs: change var to let in fs/streams.js | https://github.com/nodejs/node/pull/30407#top |
| alvarp | https://github.com/alvarp |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| alvarp:nceu19 | https://github.com/alvarp/node/tree/nceu19 |
|
| https://github.com/alvarp |
| alvarp | https://github.com/alvarp |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30407#issue-521623043 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
|
| https://github.com/alvarp |
| fs: change var to let | https://github.com/nodejs/node/pull/30407/commits/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| fff42b0 | https://github.com/nodejs/node/pull/30407/commits/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30407#event-2791912657 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-315624357 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-315632611 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30407#event-2791957879 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 13, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-315977524 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 13, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-316472751 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30407#event-2796418490 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-553546563 |
| https://ci.nodejs.org/job/node-test-pull-request/26568/ | https://ci.nodejs.org/job/node-test-pull-request/26568/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 16, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-317957361 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 18, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-554905211 |
| https://ci.nodejs.org/job/node-test-pull-request/26680/ | https://ci.nodejs.org/job/node-test-pull-request/26680/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Nov 18, 2019
| https://github.com/nodejs/node/pull/30407#pullrequestreview-318170918 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 18, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-554987120 |
| https://ci.nodejs.org/job/node-test-pull-request/26695/ | https://ci.nodejs.org/job/node-test-pull-request/26695/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 22, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-557421594 |
| https://ci.nodejs.org/job/node-test-pull-request/26832/ | https://ci.nodejs.org/job/node-test-pull-request/26832/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 22, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-557454855 |
| https://ci.nodejs.org/job/node-test-pull-request/26842/ | https://ci.nodejs.org/job/node-test-pull-request/26842/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-557867053 |
| https://ci.nodejs.org/job/node-test-pull-request/26903/ | https://ci.nodejs.org/job/node-test-pull-request/26903/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-557875035 |
| https://ci.nodejs.org/job/node-test-pull-request/26906/ | https://ci.nodejs.org/job/node-test-pull-request/26906/ |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 24, 2019
| https://github.com/nodejs/node/pull/30407#ref-commit-de20c53 |
|
| https://github.com/alvarp |
|
| https://github.com/gireeshpunathil |
| fs: change var to let | https://github.com/nodejs/node/commit/de20c530d4e5ff2106c0da1a7a1359c5a689da7a |
| de20c53 | https://github.com/nodejs/node/commit/de20c530d4e5ff2106c0da1a7a1359c5a689da7a |
| #30407 | https://github.com/nodejs/node/pull/30407 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30407#issuecomment-557877934 |
| de20c53 | https://github.com/nodejs/node/commit/de20c530d4e5ff2106c0da1a7a1359c5a689da7a |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 24, 2019 | https://github.com/nodejs/node/pull/30407#event-2825893698 |
| addaleax | https://github.com/addaleax |
|
Nov 30, 2019
| https://github.com/nodejs/node/pull/30407#ref-commit-8ee27ff |
|
| https://github.com/alvarp |
|
| https://github.com/addaleax |
| fs: change var to let | https://github.com/nodejs/node/commit/8ee27ffe77ae533a70e7142443ed0d6ae3268cf4 |
| 8ee27ff | https://github.com/nodejs/node/commit/8ee27ffe77ae533a70e7142443ed0d6ae3268cf4 |
| #30407 | https://github.com/nodejs/node/pull/30407 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30407#ref-commit-0000859 |
|
| https://github.com/alvarp |
|
| https://github.com/targos |
| fs: change var to let | https://github.com/nodejs/node/commit/00008590cac38fbaac289bc341e561d9781975ab |
| 0000859 | https://github.com/nodejs/node/commit/00008590cac38fbaac289bc341e561d9781975ab |
| #30407 | https://github.com/nodejs/node/pull/30407 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30407#ref-pullrequest-531889133 |
|
v13.3.0 proposal
#30774
| https://github.com/nodejs/node/pull/30774 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30407#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30407#ref-commit-1a83c65 |
|
| https://github.com/alvarp |
|
| https://github.com/MylesBorins |
| fs: change var to let | https://github.com/nodejs/node/commit/1a83c654f9c1d385d1c5bd3f296eb88993c3b978 |
| 1a83c65 | https://github.com/nodejs/node/commit/1a83c654f9c1d385d1c5bd3f296eb88993c3b978 |
| #30407 | https://github.com/nodejs/node/pull/30407 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30407#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30407 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30407/files/fff42b0592158b74c53c41975aa9d8705bc6a4b7 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Please reload this page | https://github.com/nodejs/node/pull/30407 |
|
| https://github.com/alvarp |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/ChALkeR |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |