René's URL Explorer Experiment


Title: http2: core.js replace var with let by DanielSchuech · Pull Request #30403 · nodejs/node · GitHub

Open Graph Title: http2: core.js replace var with let by DanielSchuech · Pull Request #30403 · nodejs/node

X Title: http2: core.js replace var with let by DanielSchuech · Pull Request #30403 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: const has to be used in for in loop (https://medium.com/@mautayro/es6-variable-declaration-for-loops-why-const-works-in-a-for-in-loop-but-not-in-a-normal-a200cc5467c2) Checklist make -j4 test (...

X Description: const has to be used in for in loop (https://medium.com/@mautayro/es6-variable-declaration-for-loops-why-const-works-in-a-for-in-loop-but-not-in-a-normal-a200cc5467c2) Checklist make -j4 test (...

Opengraph URL: https://github.com/nodejs/node/pull/30403

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5be2f508-1c1c-cc2a-eb0c-e20d14a289af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89B2:69662:2FE888C:41D889D:6A4F1B86
html-safe-nonce4c5c3d13a20c395e70c3578d18a031dab7c604600dd0018c22771696ed7f0880
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUIyOjY5NjYyOjJGRTg4OEM6NDFEODg5RDo2QTRGMUI4NiIsInZpc2l0b3JfaWQiOiI1MTQ1MjgxMTkwNzE5MDY5MDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1b580212472290a52baa7ecaa5376ae8dc579fa0e29acc2d66ad4058da7b33bb
hovercard-subject-tagpull_request:339966838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30403/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be4f0b844ba721ce690e7da0d94c763e0b3b977eb1ce07ab5e6acc0aca30129b/nodejs/node/pull/30403
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be4f0b844ba721ce690e7da0d94c763e0b3b977eb1ce07ab5e6acc0aca30129b/nodejs/node/pull/30403
og:image:altconst has to be used in for in loop (https://medium.com/@mautayro/es6-variable-declaration-for-loops-why-const-works-in-a-for-in-loop-but-not-in-a-normal-a200cc5467c2) Checklist make -j4 test (...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielSchuech
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30403#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30403
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30403
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30403
Reloadhttps://github.com/nodejs/node/pull/30403
Reloadhttps://github.com/nodejs/node/pull/30403
Please reload this pagehttps://github.com/nodejs/node/pull/30403
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30403
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 968 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
DanielSchuechhttps://github.com/DanielSchuech
nodejs:masterhttps://github.com/nodejs/node/tree/master
DanielSchuech:refactor/interal-http-corehttps://github.com/DanielSchuech/node/tree/refactor/interal-http-core
Conversationhttps://github.com/nodejs/node/pull/30403
Commits1 (1)https://github.com/nodejs/node/pull/30403/commits
Checkshttps://github.com/nodejs/node/pull/30403/checks
Files changedhttps://github.com/nodejs/node/pull/30403/files
http2: core.js replace var with lethttps://github.com/nodejs/node/pull/30403#top
DanielSchuechhttps://github.com/DanielSchuech
nodejs:masterhttps://github.com/nodejs/node/tree/master
DanielSchuech:refactor/interal-http-corehttps://github.com/DanielSchuech/node/tree/refactor/interal-http-core
https://github.com/DanielSchuech
DanielSchuechhttps://github.com/DanielSchuech
Nov 12, 2019https://github.com/nodejs/node/pull/30403#issue-521620867
https://medium.com/@mautayro/es6-variable-declaration-for-loops-why-const-works-in-a-for-in-loop-but-not-in-a-normal-a200cc5467c2https://medium.com/@mautayro/es6-variable-declaration-for-loops-why-const-works-in-a-for-in-loop-but-not-in-a-normal-a200cc5467c2
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/DanielSchuech
http2: core.js replace var with lethttps://github.com/nodejs/node/pull/30403/commits/bc086ba83e7271cd94ce9079782bd85092d0d85a
bc086bahttps://github.com/nodejs/node/pull/30403/commits/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Nov 12, 2019https://github.com/nodejs/node/pull/30403#event-2791898611
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Nov 12, 2019 https://github.com/nodejs/node/pull/30403#pullrequestreview-315622184
View reviewed changes https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 12, 2019https://github.com/nodejs/node/pull/30403#event-2791919063
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2019 https://github.com/nodejs/node/pull/30403#pullrequestreview-315624719
View reviewed changes https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30403#pullrequestreview-315976570
View reviewed changes https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 13, 2019 https://github.com/nodejs/node/pull/30403#pullrequestreview-316487464
View reviewed changes https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 13, 2019https://github.com/nodejs/node/pull/30403#issuecomment-553555216
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4060/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4060/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 13, 2019https://github.com/nodejs/node/pull/30403#event-2796485369
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 16, 2019 https://github.com/nodejs/node/pull/30403#pullrequestreview-317946995
View reviewed changes https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 16, 2019https://github.com/nodejs/node/pull/30403#issuecomment-554594759
https://ci.nodejs.org/job/node-test-pull-request/26620/https://ci.nodejs.org/job/node-test-pull-request/26620/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2019https://github.com/nodejs/node/pull/30403#issuecomment-554905854
https://ci.nodejs.org/job/node-test-pull-request/26684/https://ci.nodejs.org/job/node-test-pull-request/26684/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2019https://github.com/nodejs/node/pull/30403#issuecomment-557861646
https://ci.nodejs.org/job/node-test-pull-request/26899/https://ci.nodejs.org/job/node-test-pull-request/26899/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2019https://github.com/nodejs/node/pull/30403#issuecomment-557875078
https://ci.nodejs.org/job/node-test-pull-request/26907/https://ci.nodejs.org/job/node-test-pull-request/26907/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 24, 2019https://github.com/nodejs/node/pull/30403#issuecomment-557878225
https://ci.nodejs.org/job/node-test-pull-request/26911/https://ci.nodejs.org/job/node-test-pull-request/26911/
Please reload this pagehttps://github.com/nodejs/node/pull/30403
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 24, 2019 https://github.com/nodejs/node/pull/30403#ref-commit-7c43da3
https://github.com/DanielSchuech
https://github.com/gireeshpunathil
http2: core.js replace var with lethttps://github.com/nodejs/node/commit/7c43da3178ac7fb720a46698294aa486a42598ef
7c43da3https://github.com/nodejs/node/commit/7c43da3178ac7fb720a46698294aa486a42598ef
#30403https://github.com/nodejs/node/pull/30403
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 24, 2019https://github.com/nodejs/node/pull/30403#issuecomment-557881098
7c43da3https://github.com/nodejs/node/commit/7c43da3178ac7fb720a46698294aa486a42598ef
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 24, 2019https://github.com/nodejs/node/pull/30403#event-2825914657
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30403#ref-commit-1a2ed4a
https://github.com/DanielSchuech
https://github.com/addaleax
http2: core.js replace var with lethttps://github.com/nodejs/node/commit/1a2ed4a5f4ec0f88f95294436246742fbf4c83b0
1a2ed4ahttps://github.com/nodejs/node/commit/1a2ed4a5f4ec0f88f95294436246742fbf4c83b0
#30403https://github.com/nodejs/node/pull/30403
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30403#ref-commit-f1569f3
https://github.com/DanielSchuech
https://github.com/targos
http2: core.js replace var with lethttps://github.com/nodejs/node/commit/f1569f314dd5fc7cead7f75d09a1d2d0927ef18b
f1569f3https://github.com/nodejs/node/commit/f1569f314dd5fc7cead7f75d09a1d2d0927ef18b
#30403https://github.com/nodejs/node/pull/30403
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30403#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30403#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30403#ref-commit-68f3dde
https://github.com/DanielSchuech
https://github.com/MylesBorins
http2: core.js replace var with lethttps://github.com/nodejs/node/commit/68f3dde04bc707ff69d8e726d9a57c4d65192ab9
68f3ddehttps://github.com/nodejs/node/commit/68f3dde04bc707ff69d8e726d9a57c4d65192ab9
#30403https://github.com/nodejs/node/pull/30403
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30403#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30403
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/30403/files/bc086ba83e7271cd94ce9079782bd85092d0d85a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/30403
https://github.com/DanielSchuech
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/devnexen
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.