René's URL Explorer Experiment


Title: doc: add explanation why keep var with for loop in async_hooks by lrecknagel · Pull Request #30380 · nodejs/node · GitHub

Open Graph Title: doc: add explanation why keep var with for loop in async_hooks by lrecknagel · Pull Request #30380 · nodejs/node

X Title: doc: add explanation why keep var with for loop in async_hooks by lrecknagel · Pull Request #30380 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: nceu19-async_hooks This comment will help contributors to understand why keeping var in some for loop instead changing at to let, as discussed with @mcollina Checklist make -j4 test (UNIX...

X Description: Refs: nceu19-async_hooks This comment will help contributors to understand why keeping var in some for loop instead changing at to let, as discussed with @mcollina Checklist make -j4 test (UNIX...

Opengraph URL: https://github.com/nodejs/node/pull/30380

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:df5e77d8-31f9-4f78-1aea-e8509009edf1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91B2:34D244:1811B7D:20CB6B7:6A4F2BCA
html-safe-nonced8a41dfc1e22aa2d844585e857c8378a03d3a4eba3613caeacce84eb82512ba4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUIyOjM0RDI0NDoxODExQjdEOjIwQ0I2Qjc6NkE0RjJCQ0EiLCJ2aXNpdG9yX2lkIjoiODg5NDM5NzUyODI0NzU3NzU0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ac9f90173719e8329935d3e6cf86f7319e84e733dcb18fdc0cb83cf986fe5f7
hovercard-subject-tagpull_request:339953946
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30380/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a67096bd67fd8179c53b1185e73ea1e69d0d272c6bb8ecb05628d3836038c456/nodejs/node/pull/30380
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a67096bd67fd8179c53b1185e73ea1e69d0d272c6bb8ecb05628d3836038c456/nodejs/node/pull/30380
og:image:altRefs: nceu19-async_hooks This comment will help contributors to understand why keeping var in some for loop instead changing at to let, as discussed with @mcollina Checklist make -j4 test (UNIX...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelrecknagel
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30380#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30380
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30380
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30380
Reloadhttps://github.com/nodejs/node/pull/30380
Reloadhttps://github.com/nodejs/node/pull/30380
Please reload this pagehttps://github.com/nodejs/node/pull/30380
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30380
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lrecknagelhttps://github.com/lrecknagel
nodejs:masterhttps://github.com/nodejs/node/tree/master
lrecknagel:doc/asyncHooksKeepVarhttps://github.com/lrecknagel/node/tree/doc/asyncHooksKeepVar
Conversationhttps://github.com/nodejs/node/pull/30380
Commits1 (1)https://github.com/nodejs/node/pull/30380/commits
Checkshttps://github.com/nodejs/node/pull/30380/checks
Files changedhttps://github.com/nodejs/node/pull/30380/files
doc: add explanation why keep var with for loop in async_hookshttps://github.com/nodejs/node/pull/30380#top
lrecknagelhttps://github.com/lrecknagel
nodejs:masterhttps://github.com/nodejs/node/tree/master
lrecknagel:doc/asyncHooksKeepVarhttps://github.com/lrecknagel/node/tree/doc/asyncHooksKeepVar
https://github.com/lrecknagel
lrecknagelhttps://github.com/lrecknagel
Nov 12, 2019https://github.com/nodejs/node/pull/30380#issue-521605443
Please reload this pagehttps://github.com/nodejs/node/pull/30380
@mcollinahttps://github.com/mcollina
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/lrecknagel
doc: add explanation why keep var with for loophttps://github.com/nodejs/node/pull/30380/commits/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
0e1a18chttps://github.com/nodejs/node/pull/30380/commits/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Nov 12, 2019https://github.com/nodejs/node/pull/30380#event-2791796403
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2019https://github.com/nodejs/node/pull/30380#issuecomment-552936713
@lrecknagelhttps://github.com/lrecknagel
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 12, 2019https://github.com/nodejs/node/pull/30380#issuecomment-552948364
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 12, 2019 https://github.com/nodejs/node/pull/30380#pullrequestreview-315629619
View reviewed changes https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/30380#pullrequestreview-315629619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 12, 2019https://github.com/nodejs/node/pull/30380#event-2792006802
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2019 https://github.com/nodejs/node/pull/30380#pullrequestreview-315643074
View reviewed changes https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2019https://github.com/nodejs/node/pull/30380#issuecomment-553031747
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2019 https://github.com/nodejs/node/pull/30380#pullrequestreview-315747144
View reviewed changes https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
lib/internal/async_hooks.jshttps://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716#diff-708abd8609bdfbfcb8abf61f945a9fb86b0e35f5a891f607ae1118ce8677f0e1
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2019 https://github.com/nodejs/node/pull/30380#pullrequestreview-315747378
View reviewed changes https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
lib/internal/async_hooks.jshttps://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716#diff-708abd8609bdfbfcb8abf61f945a9fb86b0e35f5a891f607ae1118ce8677f0e1
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2019https://github.com/nodejs/node/pull/30380#issuecomment-553037270
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 13, 2019 https://github.com/nodejs/node/pull/30380#ref-pullrequest-521626012
lib: adding optemisation notes, leaving var in place in js_stream_socket.js #30415 https://github.com/nodejs/node/pull/30415
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 14, 2019 https://github.com/nodejs/node/pull/30380#pullrequestreview-317139147
View reviewed changes https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2019https://github.com/nodejs/node/pull/30380#issuecomment-553998374
https://ci.nodejs.org/job/node-test-pull-request/26587/https://ci.nodejs.org/job/node-test-pull-request/26587/
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 26, 2019https://github.com/nodejs/node/pull/30380#issuecomment-558630697
https://ci.nodejs.org/job/node-test-pull-request/27032/https://ci.nodejs.org/job/node-test-pull-request/27032/
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 26, 2019https://github.com/nodejs/node/pull/30380#issuecomment-558663216
#30519https://github.com/nodejs/node/issues/30519
#30619https://github.com/nodejs/node/issues/30619
#30660https://github.com/nodejs/node/issues/30660
Please reload this pagehttps://github.com/nodejs/node/pull/30380
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 26, 2019 https://github.com/nodejs/node/pull/30380#ref-commit-4506991
https://github.com/lrecknagel
https://github.com/gireeshpunathil
doc: add explanation why keep var with for loophttps://github.com/nodejs/node/commit/4506991aafa59f311024a7290b5195cf030cee7c
4506991https://github.com/nodejs/node/commit/4506991aafa59f311024a7290b5195cf030cee7c
#30380https://github.com/nodejs/node/pull/30380
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 26, 2019https://github.com/nodejs/node/pull/30380#issuecomment-558665397
4506991https://github.com/nodejs/node/commit/4506991aafa59f311024a7290b5195cf030cee7c
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 26, 2019https://github.com/nodejs/node/pull/30380#event-2832232448
addaleaxhttps://github.com/addaleax
Nov 30, 2019 https://github.com/nodejs/node/pull/30380#ref-commit-329a821
https://github.com/lrecknagel
https://github.com/addaleax
doc: add explanation why keep var with for loophttps://github.com/nodejs/node/commit/329a821d253abe6f9dacf426ed6d103d9b777620
329a821https://github.com/nodejs/node/commit/329a821d253abe6f9dacf426ed6d103d9b777620
#30380https://github.com/nodejs/node/pull/30380
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30380#ref-commit-5be20b4
https://github.com/lrecknagel
https://github.com/targos
doc: add explanation why keep var with for loophttps://github.com/nodejs/node/commit/5be20b49480cd51a92d970c901b60b09b8f2676a
5be20b4https://github.com/nodejs/node/commit/5be20b49480cd51a92d970c901b60b09b8f2676a
#30380https://github.com/nodejs/node/pull/30380
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2019 https://github.com/nodejs/node/pull/30380#ref-pullrequest-531889133
v13.3.0 proposal #30774 https://github.com/nodejs/node/pull/30774
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30380#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30380#ref-commit-c705a8e
https://github.com/lrecknagel
https://github.com/MylesBorins
doc: add explanation why keep var with for loophttps://github.com/nodejs/node/commit/c705a8e816877be8ee93d78e4617d6b63d83cf93
c705a8ehttps://github.com/nodejs/node/commit/c705a8e816877be8ee93d78e4617d6b63d83cf93
#30380https://github.com/nodejs/node/pull/30380
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30380#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.com/Fdawgs
Fdawgshttps://github.com/Fdawgs
Mar 1, 2021 https://github.com/nodejs/node/pull/30380#ref-pullrequest-806386927
chore: update docs and ci fastify/fastify-auth#82 https://github.com/fastify/fastify-auth/pull/82
https://github.com/Aschen
Aschenhttps://github.com/Aschen
Jul 18, 2022https://github.com/nodejs/node/pull/30380#issuecomment-1187787916
https://user-images.githubusercontent.com/4447392/179565429-53005884-898a-4630-80a3-fb77d6086b8b.png
Sourcehttps://gist.github.com/Aschen/7fc5a1c219be2e05cacbe6c1eb33b5ac
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 24, 2024 https://github.com/nodejs/node/pull/30380#ref-pullrequest-2262279643
Adding VersionStream for nodejs-22 wolfi-dev/os#17646 https://github.com/wolfi-dev/os/pull/17646
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30380
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30380/files/0e1a18c0d31dcd749b415d8fdc7fc79f1b352716
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Please reload this pagehttps://github.com/nodejs/node/pull/30380
https://github.com/lrecknagel
https://github.com/Trott
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/Aschen
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.