René's URL Explorer Experiment


Title: lib: replace var with let and const in readline.js by VinceOPS · Pull Request #30377 · nodejs/node · GitHub

Open Graph Title: lib: replace var with let and const in readline.js by VinceOPS · Pull Request #30377 · nodejs/node

X Title: lib: replace var with let and const in readline.js by VinceOPS · Pull Request #30377 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30377

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:100ebc28-e7a3-1301-c620-c1d8a86c08a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE1A:3B16A6:3EF8C57:580BCFD:6A4F58D6
html-safe-nonceeaf29dba5e243e0427be8597fe934be7013aa0e8f2f4d9f2342c5a2f1b1ecafe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTFBOjNCMTZBNjozRUY4QzU3OjU4MEJDRkQ6NkE0RjU4RDYiLCJ2aXNpdG9yX2lkIjoiODI5NTg2MjMzMTk2NDg3MjkxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac200a31af9eeeb1cb6a63afda0960a0c2caa2d5b7cf0c4a1a32c1f8cf7efdc073
hovercard-subject-tagpull_request:339951675
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30377/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c1b3e8f6b2aa76a55ef5204d689464ab32fd7182cc39cf7ccd1b2fb4c7103369/nodejs/node/pull/30377
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c1b3e8f6b2aa76a55ef5204d689464ab32fd7182cc39cf7ccd1b2fb4c7103369/nodejs/node/pull/30377
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameVinceOPS
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb14b8c6d72fdb96ca48aba85dec94fe96ce5adbe
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30377#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30377
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30377
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30377
Reloadhttps://github.com/nodejs/node/pull/30377
Reloadhttps://github.com/nodejs/node/pull/30377
Please reload this pagehttps://github.com/nodejs/node/pull/30377
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30377
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
VinceOPShttps://github.com/VinceOPS
nodejs:masterhttps://github.com/nodejs/node/tree/master
VinceOPS:readline-var-replacement-nodeconfeuhttps://github.com/VinceOPS/node/tree/readline-var-replacement-nodeconfeu
Conversationhttps://github.com/nodejs/node/pull/30377
Commits1 (1)https://github.com/nodejs/node/pull/30377/commits
Checkshttps://github.com/nodejs/node/pull/30377/checks
Files changedhttps://github.com/nodejs/node/pull/30377/files
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/pull/30377#top
VinceOPShttps://github.com/VinceOPS
nodejs:masterhttps://github.com/nodejs/node/tree/master
VinceOPS:readline-var-replacement-nodeconfeuhttps://github.com/VinceOPS/node/tree/readline-var-replacement-nodeconfeu
https://github.com/VinceOPS
VinceOPShttps://github.com/VinceOPS
Nov 12, 2019https://github.com/nodejs/node/pull/30377#issue-521602699
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Nov 12, 2019https://github.com/nodejs/node/pull/30377#event-2791779515
https://github.com/VinceOPS
VinceOPShttps://github.com/VinceOPS
force-pushedhttps://github.com/nodejs/node/compare/26e552b3324cbfc09fa150e29782a3ea34508ead..ca6d8912730cd16d040abbba586a1b1d299efe85
26e552bhttps://github.com/nodejs/node/commit/26e552b3324cbfc09fa150e29782a3ea34508ead
ca6d891https://github.com/nodejs/node/commit/ca6d8912730cd16d040abbba586a1b1d299efe85
Compare https://github.com/nodejs/node/compare/26e552b3324cbfc09fa150e29782a3ea34508ead..ca6d8912730cd16d040abbba586a1b1d299efe85
November 12, 2019 15:00https://github.com/nodejs/node/pull/30377#event-2791786881
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 12, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-315622625
View reviewed changes https://github.com/nodejs/node/pull/30377/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 12, 2019https://github.com/nodejs/node/pull/30377#event-2791915680
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-315624234
View reviewed changes https://github.com/nodejs/node/pull/30377/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-315993854
View reviewed changes https://github.com/nodejs/node/pull/30377/files
trivikrhttps://github.com/trivikr
https://github.com/nodejs/node/pull/30377#pullrequestreview-315993854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30377
lib/readline.jshttps://github.com/nodejs/node/pull/30377/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Please reload this pagehttps://github.com/nodejs/node/pull/30377
lib/readline.jshttps://github.com/nodejs/node/pull/30377/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/VinceOPS
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/pull/30377/commits/8df84c00f3f7bae7410f6fd80fb139397c4b609e
8df84c0https://github.com/nodejs/node/pull/30377/commits/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/VinceOPS
VinceOPShttps://github.com/VinceOPS
force-pushedhttps://github.com/nodejs/node/compare/ca6d8912730cd16d040abbba586a1b1d299efe85..8df84c00f3f7bae7410f6fd80fb139397c4b609e
ca6d891https://github.com/nodejs/node/commit/ca6d8912730cd16d040abbba586a1b1d299efe85
8df84c0https://github.com/nodejs/node/commit/8df84c00f3f7bae7410f6fd80fb139397c4b609e
Compare https://github.com/nodejs/node/compare/ca6d8912730cd16d040abbba586a1b1d299efe85..8df84c00f3f7bae7410f6fd80fb139397c4b609e
November 13, 2019 10:20https://github.com/nodejs/node/pull/30377#event-2794684925
https://github.com/VinceOPS
VinceOPShttps://github.com/VinceOPS
Nov 13, 2019https://github.com/nodejs/node/pull/30377#issuecomment-553339065
@trivikrhttps://github.com/trivikr
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-316382839
View reviewed changes https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 13, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-316617075
View reviewed changes https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 13, 2019https://github.com/nodejs/node/pull/30377#issuecomment-553644280
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4070/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4070/
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 13, 2019https://github.com/nodejs/node/pull/30377#event-2797128270
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 14, 2019 https://github.com/nodejs/node/pull/30377#pullrequestreview-317137308
View reviewed changes https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2019https://github.com/nodejs/node/pull/30377#issuecomment-553997031
https://ci.nodejs.org/job/node-test-pull-request/26585/https://ci.nodejs.org/job/node-test-pull-request/26585/
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2019https://github.com/nodejs/node/pull/30377#issuecomment-554757543
https://ci.nodejs.org/job/node-test-pull-request/26661/https://ci.nodejs.org/job/node-test-pull-request/26661/
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2019https://github.com/nodejs/node/pull/30377#issuecomment-555877674
https://ci.nodejs.org/job/node-test-pull-request/26773/https://ci.nodejs.org/job/node-test-pull-request/26773/
Please reload this pagehttps://github.com/nodejs/node/pull/30377
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 20, 2019 https://github.com/nodejs/node/pull/30377#ref-commit-205046a
https://github.com/VinceOPS
https://github.com/gireeshpunathil
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/commit/205046af7eb6be0b4a7a785082962586ed6f1dec
205046ahttps://github.com/nodejs/node/commit/205046af7eb6be0b4a7a785082962586ed6f1dec
#30377https://github.com/nodejs/node/pull/30377
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 20, 2019https://github.com/nodejs/node/pull/30377#issuecomment-556008605
205046ahttps://github.com/nodejs/node/commit/205046af7eb6be0b4a7a785082962586ed6f1dec
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 20, 2019https://github.com/nodejs/node/pull/30377#event-2815297741
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2019 https://github.com/nodejs/node/pull/30377#ref-commit-31a63ab
https://github.com/VinceOPS
https://github.com/MylesBorins
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/commit/31a63ab1ece912ac684bcba7aa160ba21e9eabb5
31a63abhttps://github.com/nodejs/node/commit/31a63ab1ece912ac684bcba7aa160ba21e9eabb5
#30377https://github.com/nodejs/node/pull/30377
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 21, 2019 https://github.com/nodejs/node/pull/30377#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30377#ref-commit-7aa999b
https://github.com/VinceOPS
https://github.com/targos
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/commit/7aa999b8ba58897dcb90810141dcf83c6b721c4b
7aa999bhttps://github.com/nodejs/node/commit/7aa999b8ba58897dcb90810141dcf83c6b721c4b
#30377https://github.com/nodejs/node/pull/30377
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30377#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30377#ref-commit-614949d
https://github.com/VinceOPS
https://github.com/MylesBorins
lib: replace var with let and const in readline.jshttps://github.com/nodejs/node/commit/614949d25dbee324b183eb06c79802940c22051c
614949dhttps://github.com/nodejs/node/commit/614949d25dbee324b183eb06c79802940c22051c
#30377https://github.com/nodejs/node/pull/30377
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30377#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30377
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/30377/files/ca6d8912730cd16d040abbba586a1b1d299efe85
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/30377/files/ca6d8912730cd16d040abbba586a1b1d299efe85
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30377/files/8df84c00f3f7bae7410f6fd80fb139397c4b609e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Please reload this pagehttps://github.com/nodejs/node/pull/30377
https://github.com/VinceOPS
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/jasnell
https://github.com/addaleax
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.