| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1f69df62-61ec-30d8-a392-b2397a3f0c24 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B58:C8AE2:550FE00:77F7A19:6A4FAB57 |
| html-safe-nonce | cdd0960f4bd9d6a36bd1a418e90025edb2a18fb094c5305398958cc4a8b3834a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjU4OkM4QUUyOjU1MEZFMDA6NzdGN0ExOTo2QTRGQUI1NyIsInZpc2l0b3JfaWQiOiIxNTc5MTY1MjYyMTIwMjAxMDQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8f8f9be0e45ca42493bbae594d40bdd45f144a4b18aa0866380f2bc26dccd5c8 |
| hovercard-subject-tag | pull_request:339868680 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30372/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f0fbc1e3dd23d6538ac6413ccc4eb5a901d7b6e1261f1f08ed46fa21949aa9dc/nodejs/node/pull/30372 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f0fbc1e3dd23d6538ac6413ccc4eb5a901d7b6e1261f1f08ed46fa21949aa9dc/nodejs/node/pull/30372 |
| og:image:alt | Original commit message:
[Intl] Fix output of hour:'2-digit', hour12: true
Bug: chromium:527926
Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
Reviewed-on: https://chromium-review.go... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30372#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30372 |
| Reload | https://github.com/nodejs/node/pull/30372 |
| Reload | https://github.com/nodejs/node/pull/30372 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| targos | https://github.com/targos |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| targos:fix-30369 | https://github.com/targos/node/tree/fix-30369 |
| Conversation | https://github.com/nodejs/node/pull/30372 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30372/commits |
| Checks | https://github.com/nodejs/node/pull/30372/checks |
| Files changed | https://github.com/nodejs/node/pull/30372/files |
| [v10.x] deps: V8: backport fb63e5cf55e9 | https://github.com/nodejs/node/pull/30372#top |
| targos | https://github.com/targos |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| targos:fix-30369 | https://github.com/targos/node/tree/fix-30369 |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30372#issue-521501977 |
| v8/v8@fb63e5c | https://github.com/v8/v8/commit/fb63e5cf55e93d7b4df51d3f382a6c84d25a5e86 |
| #30369 | https://github.com/nodejs/node/issues/30369 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
|
| https://github.com/targos |
| deps: V8: backport fb63e5cf55e9 | https://github.com/nodejs/node/pull/30372/commits/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| ded973a | https://github.com/nodejs/node/pull/30372/commits/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1529260 | https://chromium-review.googlesource.com/c/v8/v8/+/1529260 |
| nodejs#60379 | https://github.com/nodejs/node/pull/60379 |
| v8/v8@fb63e5c | https://github.com/v8/v8/commit/fb63e5cf55e93d7b4df51d3f382a6c84d25a5e86 |
| nodejs#30369 | https://github.com/nodejs/node/issues/30369 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30372#event-2791166836 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30372#event-2791167084 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30372#ref-issue-521327317 |
|
toLocaleDateString() with option { hour: '2-digit' } returns single digit hour
#30369
| https://github.com/nodejs/node/issues/30369 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30372#pullrequestreview-315480877 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30372#pullrequestreview-315486370 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30372#pullrequestreview-315567361 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30372#pullrequestreview-315587928 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30372#issuecomment-552980455 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/2624/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/2624/ |
| centos7-ppcle failure | https://ci.nodejs.org/job/node-test-commit-v8-linux/2624/nodes=centos7-ppcle,v8test=v8test/ |
| #28458 | https://github.com/nodejs/node/pull/28458 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Nov 19, 2019 | https://github.com/nodejs/node/pull/30372#issuecomment-555682302 |
| #28458 | https://github.com/nodejs/node/pull/28458 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/2642 | https://ci.nodejs.org/job/node-test-commit-v8-linux/2642 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 2, 2019 | https://github.com/nodejs/node/pull/30372#issuecomment-560660965 |
| https://ci.nodejs.org/job/node-test-pull-request/27289/ | https://ci.nodejs.org/job/node-test-pull-request/27289/ |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30372#issuecomment-561100763 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| https://ci.nodejs.org/job/node-test-pull-request/27298/ | https://ci.nodejs.org/job/node-test-pull-request/27298/ |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 3, 2019
| https://github.com/nodejs/node/pull/30372#ref-commit-0a7f6fa |
|
| https://github.com/targos |
|
| https://github.com/BethGriggs |
| deps: V8: backport fb63e5cf55e9 | https://github.com/nodejs/node/commit/0a7f6fa6b87de270f062d74efae1ebee1d7ee585 |
| 0a7f6fa | https://github.com/nodejs/node/commit/0a7f6fa6b87de270f062d74efae1ebee1d7ee585 |
| chromium:527926 | https://bugs.chromium.org/p/chromium/issues/detail?id=527926 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1529260 | https://chromium-review.googlesource.com/c/v8/v8/+/1529260 |
| #60379 | https://github.com/nodejs/node/pull/60379 |
| v8/v8@fb63e5c | https://github.com/v8/v8/commit/fb63e5cf55e93d7b4df51d3f382a6c84d25a5e86 |
| #30369 | https://github.com/nodejs/node/issues/30369 |
| #30372 | https://github.com/nodejs/node/pull/30372 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30372#issuecomment-561247135 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Dec 3, 2019 | https://github.com/nodejs/node/pull/30372#event-2850733888 |
| https://github.com/targos |
| targos | https://github.com/targos |
| December 3, 2019 17:02 | https://github.com/nodejs/node/pull/30372#event-2850861322 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30372#ref-commit-3e0709c |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
| deps: V8: backport fb63e5cf55e9 | https://github.com/nodejs/node/commit/3e0709cf5e7b6a44c9b84cb9144dd41ee54cb932 |
| 3e0709c | https://github.com/nodejs/node/commit/3e0709cf5e7b6a44c9b84cb9144dd41ee54cb932 |
| chromium:527926 | https://bugs.chromium.org/p/chromium/issues/detail?id=527926 |
| https://chromium-review.googlesource.com/c/v8/v8/+/1529260 | https://chromium-review.googlesource.com/c/v8/v8/+/1529260 |
| #60379 | https://github.com/nodejs/node/pull/60379 |
| v8/v8@fb63e5c | https://github.com/v8/v8/commit/fb63e5cf55e93d7b4df51d3f382a6c84d25a5e86 |
| #30369 | https://github.com/nodejs/node/issues/30369 |
| #30372 | https://github.com/nodejs/node/pull/30372 |
| francois2metz | https://github.com/francois2metz |
|
Jan 31, 2020
| https://github.com/nodejs/node/pull/30372#ref-commit-0add237 |
|
| https://github.com/francois2metz |
| Update the test with 2-digit formating since the nodejs bug is fixed. | https://github.com/osmontrouge/osmontrouge/commit/0add2377c038fbb566765f7ac9bdac931316c515 |
| 0add237 | https://github.com/osmontrouge/osmontrouge/commit/0add2377c038fbb566765f7ac9bdac931316c515 |
| nodejs/node#30372 | https://github.com/nodejs/node/pull/30372 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30372 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/30372/files/ded973a1d29a498d48cd8e02e7308e07da9f8353 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/30372 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
|
| https://github.com/bnoordhuis |
|
| https://github.com/cjihrig |
|
| https://github.com/lundibundi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |