| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:81d450f0-a491-2132-30dd-cd2f6a924459 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8784:1691AA:28175D3:3761FC7:6A4F51A7 |
| html-safe-nonce | 3cb470d1fd42c2111a0a87e9f419d7acb07ce4bf7d43a3ae8f4850656643b0ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzg0OjE2OTFBQToyODE3NUQzOjM3NjFGQzc6NkE0RjUxQTciLCJ2aXNpdG9yX2lkIjoiNjkyMTAyNDY2MDM1NzIwNjQ0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a0a75a92908f6bdc01e0a7f11134854c8226d811dc88f9dbccc8485a34c8728 |
| hovercard-subject-tag | pull_request:339501150 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30360/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/517999abf1fe1b06e7eb121a914cebae1eafc7feb545f5072b50c64c6caa6260/nodejs/node/pull/30360 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/517999abf1fe1b06e7eb121a914cebae1eafc7feb545f5072b50c64c6caa6260/nodejs/node/pull/30360 |
| og:image:alt | On some platforms the 'end' event might not be emitted because the
socket could be destroyed by the other peer while the client is still
sending the data triggering an error. Use the 'c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30360#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30360 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30360 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30360 |
| Reload | https://github.com/nodejs/node/pull/30360 |
| Reload | https://github.com/nodejs/node/pull/30360 |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:deflake/test-http-dump-req-when-res-ends | https://github.com/lpinca/node/tree/deflake/test-http-dump-req-when-res-ends |
| Conversation | https://github.com/nodejs/node/pull/30360 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30360/commits |
| Checks | https://github.com/nodejs/node/pull/30360/checks |
| Files changed | https://github.com/nodejs/node/pull/30360/files |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/pull/30360#top |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:deflake/test-http-dump-req-when-res-ends | https://github.com/lpinca/node/tree/deflake/test-http-dump-req-when-res-ends |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/30360#issue-521043962 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/30360#event-2788431869 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-314990926 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/30360#issuecomment-552503281 |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
|
| https://github.com/lpinca |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/pull/30360/commits/bd774d9039828db4792f8fb452f69b104360ad6a |
| bd774d9 | https://github.com/nodejs/node/pull/30360/commits/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| force-pushed | https://github.com/nodejs/node/compare/7fa136da6d535d9cb655f37b41eebb1b3716359b..bd774d9039828db4792f8fb452f69b104360ad6a |
| 7fa136d | https://github.com/nodejs/node/commit/7fa136da6d535d9cb655f37b41eebb1b3716359b |
| bd774d9 | https://github.com/nodejs/node/commit/bd774d9039828db4792f8fb452f69b104360ad6a |
|
Compare
| https://github.com/nodejs/node/compare/7fa136da6d535d9cb655f37b41eebb1b3716359b..bd774d9039828db4792f8fb452f69b104360ad6a |
| November 11, 2019 16:04 | https://github.com/nodejs/node/pull/30360#event-2788457385 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315013103 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315027742 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315056039 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315161299 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315249055 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-315392477 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 13, 2019
| https://github.com/nodejs/node/pull/30360#pullrequestreview-316495061 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30360#event-2796520691 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 13, 2019 | https://github.com/nodejs/node/pull/30360#issuecomment-553560272 |
| https://ci.nodejs.org/job/node-test-pull-request/26572/ | https://ci.nodejs.org/job/node-test-pull-request/26572/ |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 14, 2019 | https://github.com/nodejs/node/pull/30360#issuecomment-554024519 |
| https://ci.nodejs.org/job/node-test-pull-request/26596/ | https://ci.nodejs.org/job/node-test-pull-request/26596/ |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 15, 2019 | https://github.com/nodejs/node/pull/30360#issuecomment-554382401 |
| https://ci.nodejs.org/job/node-test-pull-request/26597/ | https://ci.nodejs.org/job/node-test-pull-request/26597/ |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
| lpinca | https://github.com/lpinca |
|
Nov 15, 2019
| https://github.com/nodejs/node/pull/30360#ref-commit-a4a089a |
|
| https://github.com/lpinca |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/commit/a4a089a5687c99f42c37d4d80d73f79e4c8d8da8 |
| a4a089a | https://github.com/nodejs/node/commit/a4a089a5687c99f42c37d4d80d73f79e4c8d8da8 |
| #30360 | https://github.com/nodejs/node/pull/30360 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 15, 2019 | https://github.com/nodejs/node/pull/30360#issuecomment-554402991 |
| a4a089a | https://github.com/nodejs/node/commit/a4a089a5687c99f42c37d4d80d73f79e4c8d8da8 |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 15, 2019 | https://github.com/nodejs/node/pull/30360#event-2803028713 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| November 15, 2019 15:26 | https://github.com/nodejs/node/pull/30360#event-2803028923 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30360#ref-commit-109da52 |
|
| https://github.com/lpinca |
|
| https://github.com/MylesBorins |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/commit/109da52141aec2f76c2defadfb5afe2541e194dc |
| 109da52 | https://github.com/nodejs/node/commit/109da52141aec2f76c2defadfb5afe2541e194dc |
| #30360 | https://github.com/nodejs/node/pull/30360 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30360#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 20, 2019
| https://github.com/nodejs/node/pull/30360#ref-issue-508600803 |
|
flaky test: test-http-dump-req-when-res-ends on windows
#30011
| https://github.com/nodejs/node/issues/30011 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30360#ref-commit-b685d7d |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/commit/b685d7ded29fe954c78f2f079c9257fb07d7fe8d |
| b685d7d | https://github.com/nodejs/node/commit/b685d7ded29fe954c78f2f079c9257fb07d7fe8d |
| #30360 | https://github.com/nodejs/node/pull/30360 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30360#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30360#ref-commit-b49e63d |
|
| https://github.com/lpinca |
|
| https://github.com/MylesBorins |
| test: deflake test-http-dump-req-when-res-ends.js | https://github.com/nodejs/node/commit/b49e63d51cedcab32c60cc00aa6d6cd33797a3db |
| b49e63d | https://github.com/nodejs/node/commit/b49e63d51cedcab32c60cc00aa6d6cd33797a3db |
| #30360 | https://github.com/nodejs/node/pull/30360 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30360#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30360 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30360/files/7fa136da6d535d9cb655f37b41eebb1b3716359b |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/30360/files/bd774d9039828db4792f8fb452f69b104360ad6a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/30360 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/antsmartian |
|
| https://github.com/benjamingr |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |