| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:852db5d1-b3dd-56cf-f4af-936a5a03e336 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 94A4:13C54:4898A92:670CB1C:6A4FD2D1 |
| html-safe-nonce | d30f16c21ac7b83fcad6da62a157b48bae2af4fdc3c7b456e9099d62b3baa45f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEE0OjEzQzU0OjQ4OThBOTI6NjcwQ0IxQzo2QTRGRDJEMSIsInZpc2l0b3JfaWQiOiI0NDk2MTM0MzQ3ODAxMTE1NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 19a38ab064a7500b9681281de6bffa78f26fc87e5203c9a39ad39fa7fcd57b6f |
| hovercard-subject-tag | pull_request:338850248 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30340/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d81b4deaa5648851213b073d051ec86d36ed9893aefcc7cc9fc5a35e6f89a696/nodejs/node/pull/30340 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d81b4deaa5648851213b073d051ec86d36ed9893aefcc7cc9fc5a35e6f89a696/nodejs/node/pull/30340 |
| og:image:alt | Co-authored-by: @patrickhousley
Fixes to Python tests to ensure that the following all pass:
python2 -m pytest ./test ./tools # 30 tests pass
python3 -m pytest ./test ./tools # 30 tests pass
pyt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30340#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30340 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30340 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30340 |
| Reload | https://github.com/nodejs/node/pull/30340 |
| Reload | https://github.com/nodejs/node/pull/30340 |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:Python-tests | https://github.com/cclauss/node/tree/Python-tests |
| Conversation | https://github.com/nodejs/node/pull/30340 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30340/commits |
| Checks | https://github.com/nodejs/node/pull/30340/checks |
| Files changed | https://github.com/nodejs/node/pull/30340/files |
| test: Fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/pull/30340#top |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:Python-tests | https://github.com/cclauss/node/tree/Python-tests |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 8, 2019 | https://github.com/nodejs/node/pull/30340#issue-520223793 |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
| @patrickhousley | https://github.com/patrickhousley |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Nov 8, 2019 | https://github.com/nodejs/node/pull/30340#event-2784484178 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30340#pullrequestreview-314448732 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30340/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/30340#pullrequestreview-314448732 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/8a182dcd0576bdf5f2789d8535dd01adb8f1487c..37c650103ad0b103674c07a540fe0db34639c107 |
| 8a182dc | https://github.com/nodejs/node/commit/8a182dcd0576bdf5f2789d8535dd01adb8f1487c |
| 37c6501 | https://github.com/nodejs/node/commit/37c650103ad0b103674c07a540fe0db34639c107 |
|
Compare
| https://github.com/nodejs/node/compare/8a182dcd0576bdf5f2789d8535dd01adb8f1487c..37c650103ad0b103674c07a540fe0db34639c107 |
| November 8, 2019 20:53 | https://github.com/nodejs/node/pull/30340#event-2784515752 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Nov 9, 2019
| https://github.com/nodejs/node/pull/30340#pullrequestreview-314533818 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30340/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 9, 2019
| https://github.com/nodejs/node/pull/30340#pullrequestreview-314535977 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30340/files |
|
| https://github.com/cclauss |
| test: fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/pull/30340/commits/3e8d965acf468089ed4e95303819130ff5ab9c38 |
| 3e8d965 | https://github.com/nodejs/node/pull/30340/commits/3e8d965acf468089ed4e95303819130ff5ab9c38 |
| @patrickhousley | https://github.com/patrickhousley |
| nodejs#30033 | https://github.com/nodejs/node/pull/30033 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/37c650103ad0b103674c07a540fe0db34639c107..3e8d965acf468089ed4e95303819130ff5ab9c38 |
| 37c6501 | https://github.com/nodejs/node/commit/37c650103ad0b103674c07a540fe0db34639c107 |
| 3e8d965 | https://github.com/nodejs/node/commit/3e8d965acf468089ed4e95303819130ff5ab9c38 |
|
Compare
| https://github.com/nodejs/node/compare/37c650103ad0b103674c07a540fe0db34639c107..3e8d965acf468089ed4e95303819130ff5ab9c38 |
| November 9, 2019 06:59 | https://github.com/nodejs/node/pull/30340#event-2785123698 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 9, 2019 | https://github.com/nodejs/node/pull/30340#issuecomment-552075721 |
| https://ci.nodejs.org/job/node-test-pull-request/26490/ | https://ci.nodejs.org/job/node-test-pull-request/26490/ |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Nov 9, 2019
| https://github.com/nodejs/node/pull/30340#pullrequestreview-314560677 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30340/files/3e8d965acf468089ed4e95303819130ff5ab9c38 |
| cclauss | https://github.com/cclauss |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30340#ref-commit-e6a58a8 |
|
| https://github.com/cclauss |
| test: fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/commit/e6a58a89cb01aaac668aabf4cab737c6503a27a1 |
| e6a58a8 | https://github.com/nodejs/node/commit/e6a58a89cb01aaac668aabf4cab737c6503a27a1 |
| @patrickhousley | https://github.com/patrickhousley |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| #30340 | https://github.com/nodejs/node/pull/30340 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/30340#issuecomment-552372273 |
| e6a58a8 | https://github.com/nodejs/node/commit/e6a58a89cb01aaac668aabf4cab737c6503a27a1 |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Nov 11, 2019 | https://github.com/nodejs/node/pull/30340#event-2787320757 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Nov 11, 2019
| https://github.com/nodejs/node/pull/30340#ref-issue-404288651 |
|
build: ongoing list of actions for Python 3 compatibility
#25789
| https://github.com/nodejs/node/issues/25789 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30340#ref-commit-aec695e |
|
| https://github.com/cclauss |
|
| https://github.com/MylesBorins |
| test: fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/commit/aec695eb6c5352afdce6c8521d4be26ffa1124a9 |
| aec695e | https://github.com/nodejs/node/commit/aec695eb6c5352afdce6c8521d4be26ffa1124a9 |
| @patrickhousley | https://github.com/patrickhousley |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| #30340 | https://github.com/nodejs/node/pull/30340 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30340#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30340#ref-commit-deb1824 |
|
| https://github.com/cclauss |
|
| https://github.com/targos |
| test: fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/commit/deb1824ccf5614f0d7ec506465c697a97ecd50bc |
| deb1824 | https://github.com/nodejs/node/commit/deb1824ccf5614f0d7ec506465c697a97ecd50bc |
| @patrickhousley | https://github.com/patrickhousley |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| #30340 | https://github.com/nodejs/node/pull/30340 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30340#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30340#ref-commit-d148330 |
|
| https://github.com/cclauss |
|
| https://github.com/MylesBorins |
| test: fix Python unittests in ./test and ./tools | https://github.com/nodejs/node/commit/d1483305aefeb24523a445d3a1296ded3cb64f4f |
| d148330 | https://github.com/nodejs/node/commit/d1483305aefeb24523a445d3a1296ded3cb64f4f |
| @patrickhousley | https://github.com/patrickhousley |
| #30033 | https://github.com/nodejs/node/pull/30033 |
| #30340 | https://github.com/nodejs/node/pull/30340 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30340#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30340 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30340/files/8a182dcd0576bdf5f2789d8535dd01adb8f1487c |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30340/files/37c650103ad0b103674c07a540fe0db34639c107 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/30340/files/37c650103ad0b103674c07a540fe0db34639c107 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/30340/files/3e8d965acf468089ed4e95303819130ff5ab9c38 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/30340 |
|
| https://github.com/cclauss |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/gengjiawen |
|
| https://github.com/devnexen |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |