| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:907ecef9-419a-5266-5254-145345dfe18c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B5CE:102756:176B527:1FFECF1:6A4F2C3D |
| html-safe-nonce | b8fd9f6f095c25a8974643557f7f4be32c247a08221a4037a0983976dde6e721 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUNFOjEwMjc1NjoxNzZCNTI3OjFGRkVDRjE6NkE0RjJDM0QiLCJ2aXNpdG9yX2lkIjoiNDY3NTI3MTU4OTM5NDA2NjQ5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 285722403d470d5428843c32e2c6d8fd719a6de40ecbb819f5d154c4d5a97a17 |
| hovercard-subject-tag | pull_request:337406026 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30314/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b96807d364b6c15d62f62fa2ae65dcd10775963b55a3ed446d96211d01499867/nodejs/node/pull/30314 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b96807d364b6c15d62f62fa2ae65dcd10775963b55a3ed446d96211d01499867/nodejs/node/pull/30314 |
| og:image:alt | src: lib/internal/timers.js change var to let/const
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nikolaykrashnikov |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30314#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30314 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30314 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30314 |
| Reload | https://github.com/nodejs/node/pull/30314 |
| Reload | https://github.com/nodejs/node/pull/30314 |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| nikolaykrashnikov | https://github.com/nikolaykrashnikov |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/30314 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30314/commits |
| Checks | https://github.com/nodejs/node/pull/30314/checks |
| Files changed | https://github.com/nodejs/node/pull/30314/files |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/pull/30314#top |
| nikolaykrashnikov | https://github.com/nikolaykrashnikov |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/nikolaykrashnikov |
| nikolaykrashnikov | https://github.com/nikolaykrashnikov |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30314#issue-518527591 |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30314#event-2775647566 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30314#event-2775726660 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-312581263 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files |
| lib/internal/timers.js | https://github.com/nodejs/node/pull/30314/files#diff-41813f5e6561d74a1162a1a326c914dd05d298c44c90653726d3997bdc1f9df1 |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
|
| https://github.com/nikolaykrashnikov |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/pull/30314/commits/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| 05d18cf | https://github.com/nodejs/node/pull/30314/commits/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-312762592 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-312785507 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-312808417 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Nov 7, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-313049104 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 7, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-313198561 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 7, 2019 | https://github.com/nodejs/node/pull/30314#issuecomment-550992902 |
| https://ci.nodejs.org/job/node-test-pull-request/26433/ | https://ci.nodejs.org/job/node-test-pull-request/26433/ |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Nov 7, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-313385638 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30314#pullrequestreview-315398842 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30314#issuecomment-552822304 |
| https://ci.nodejs.org/job/node-test-pull-request/26511/ | https://ci.nodejs.org/job/node-test-pull-request/26511/ |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30314#ref-commit-9bda2bb |
|
| https://github.com/nikolaykrashnikov |
|
| https://github.com/gireeshpunathil |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/commit/9bda2bb5b8cc2c87492203571179ae187c5840ce |
| 9bda2bb | https://github.com/nodejs/node/commit/9bda2bb5b8cc2c87492203571179ae187c5840ce |
| #30314 | https://github.com/nodejs/node/pull/30314 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 17, 2019 | https://github.com/nodejs/node/pull/30314#issuecomment-554757883 |
| 9bda2bb | https://github.com/nodejs/node/commit/9bda2bb5b8cc2c87492203571179ae187c5840ce |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 17, 2019 | https://github.com/nodejs/node/pull/30314#event-2805488470 |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30314#ref-commit-d648c93 |
|
| https://github.com/nikolaykrashnikov |
|
| https://github.com/BridgeAR |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/commit/d648c933b58683fdcda560d53589e0a4bf6ba9fc |
| d648c93 | https://github.com/nodejs/node/commit/d648c933b58683fdcda560d53589e0a4bf6ba9fc |
| #30314 | https://github.com/nodejs/node/pull/30314 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30314#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30314#ref-commit-56b3205 |
|
| https://github.com/nikolaykrashnikov |
|
| https://github.com/targos |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/commit/56b32053647d853334fb501fb57adde423a79160 |
| 56b3205 | https://github.com/nodejs/node/commit/56b32053647d853334fb501fb57adde423a79160 |
| #30314 | https://github.com/nodejs/node/pull/30314 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30314#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30314#ref-commit-3d7882e |
|
| https://github.com/nikolaykrashnikov |
|
| https://github.com/MylesBorins |
| src: lib/internal/timers.js var -> let/const | https://github.com/nodejs/node/commit/3d7882e0d11c0041a1e8bb0e28c9fe73a047a705 |
| 3d7882e | https://github.com/nodejs/node/commit/3d7882e0d11c0041a1e8bb0e28c9fe73a047a705 |
| #30314 | https://github.com/nodejs/node/pull/30314 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30314#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30314 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/30314/files/05d18cf02713e807c9d26a2a19c7bdef913a8208 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/30314 |
|
| https://github.com/nikolaykrashnikov |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/ChALkeR |
|
| https://github.com/jasnell |
|
| https://github.com/gengjiawen |
|
| https://github.com/devnexen |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |