| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fe792683-6ab8-33f0-6b7a-d4e04b7a8b3c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9C4:1EE1:24579F5:332CB43:6A4F731A |
| html-safe-nonce | 873a686c9e13b89264a37bbb5bc0053fa07939ddae24b07d72b6ffb9d8584a51 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUM0OjFFRTE6MjQ1NzlGNTozMzJDQjQzOjZBNEY3MzFBIiwidmlzaXRvcl9pZCI6IjI1NTAzOTI5Njg0NTMyNTU5NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3cd9137b9dd0002aad8a08f278326f786529c0fa3ef8c5334dd42c17cb7d52a2 |
| hovercard-subject-tag | pull_request:337384465 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30308/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3c8138bbed86f2acd1cd38adbe20ddbe5b4e01865b0076f59d9753b3dcb16f69/nodejs/node/pull/30308 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c8138bbed86f2acd1cd38adbe20ddbe5b4e01865b0076f59d9753b3dcb16f69/nodejs/node/pull/30308 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dividead |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30308#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30308 |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30308 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30308 |
| Reload | https://github.com/nodejs/node/pull/30308 |
| Reload | https://github.com/nodejs/node/pull/30308 |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| dividead | https://github.com/dividead |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dividead:code-and-learn | https://github.com/dividead/node/tree/code-and-learn |
| Conversation | https://github.com/nodejs/node/pull/30308 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30308/commits |
| Checks | https://github.com/nodejs/node/pull/30308/checks |
| Files changed | https://github.com/nodejs/node/pull/30308/files |
| tls: replace var with let | https://github.com/nodejs/node/pull/30308#top |
| dividead | https://github.com/dividead |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dividead:code-and-learn | https://github.com/dividead/node/tree/code-and-learn |
|
| https://github.com/dividead |
| dividead | https://github.com/dividead |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30308#issue-518501375 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
|
| https://github.com/dividead |
| tls: replace var with let | https://github.com/nodejs/node/pull/30308/commits/f1ff55d881d1650597af5fd021212229db86cb45 |
| f1ff55d | https://github.com/nodejs/node/pull/30308/commits/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30308#event-2775484021 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2019 | https://github.com/nodejs/node/pull/30308#event-2775555348 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-312481385 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-312482138 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-312587517 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| lib/_tls_wrap.js | https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8 |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 6, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-312748143 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 7, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-313365709 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 7, 2019 | https://github.com/nodejs/node/pull/30308#issuecomment-551096380 |
| https://ci.nodejs.org/job/node-test-pull-request/26439/ | https://ci.nodejs.org/job/node-test-pull-request/26439/ |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-314216624 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Nov 8, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-314223462 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30308#pullrequestreview-315397804 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30308#event-2790818612 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 12, 2019
| https://github.com/nodejs/node/pull/30308#ref-commit-cc6f99d |
|
| https://github.com/dividead |
|
| https://github.com/gireeshpunathil |
| tls: replace var with let | https://github.com/nodejs/node/commit/cc6f99de449beb0993db3647de4ef979bead804d |
| cc6f99d | https://github.com/nodejs/node/commit/cc6f99de449beb0993db3647de4ef979bead804d |
| #30308 | https://github.com/nodejs/node/pull/30308 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30308#issuecomment-552821658 |
| cc6f99d | https://github.com/nodejs/node/commit/cc6f99de449beb0993db3647de4ef979bead804d |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 12, 2019 | https://github.com/nodejs/node/pull/30308#event-2790833449 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30308#ref-commit-26a9bdf |
|
| https://github.com/dividead |
|
| https://github.com/MylesBorins |
| tls: replace var with let | https://github.com/nodejs/node/commit/26a9bdfca334644718212722afb908ce813544c7 |
| 26a9bdf | https://github.com/nodejs/node/commit/26a9bdfca334644718212722afb908ce813544c7 |
| #30308 | https://github.com/nodejs/node/pull/30308 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30308#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30308#ref-commit-67e9985 |
|
| https://github.com/dividead |
|
| https://github.com/targos |
| tls: replace var with let | https://github.com/nodejs/node/commit/67e9985c16151dce75da07ae047042a37ae37800 |
| 67e9985 | https://github.com/nodejs/node/commit/67e9985c16151dce75da07ae047042a37ae37800 |
| #30308 | https://github.com/nodejs/node/pull/30308 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30308#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30308#ref-commit-6fe2c7a |
|
| https://github.com/dividead |
|
| https://github.com/MylesBorins |
| tls: replace var with let | https://github.com/nodejs/node/commit/6fe2c7a1064a661a481ecb109de2b8d78037e421 |
| 6fe2c7a | https://github.com/nodejs/node/commit/6fe2c7a1064a661a481ecb109de2b8d78037e421 |
| #30308 | https://github.com/nodejs/node/pull/30308 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30308#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30308 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/30308/files/f1ff55d881d1650597af5fd021212229db86cb45 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/30308 |
|
| https://github.com/dividead |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/gengjiawen |
|
| https://github.com/devnexen |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com/ChALkeR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |