René's URL Explorer Experiment


Title: url: replace var with let in lib/url.js by xefimx · Pull Request #30281 · nodejs/node · GitHub

Open Graph Title: url: replace var with let in lib/url.js by xefimx · Pull Request #30281 · nodejs/node

X Title: url: replace var with let in lib/url.js by xefimx · Pull Request #30281 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: url: replace var with let and const in lib/url.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: url: replace var with let and const in lib/url.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/30281

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8b504ab-419a-ab23-eb9b-15a2e350e6e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3BE:1F16:C82629:1247C33:6A4F73A7
html-safe-nonce44d36d95a7ce47429858458de256a2048ba9eff95fb64bb936819e3435851a94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0JFOjFGMTY6QzgyNjI5OjEyNDdDMzM6NkE0RjczQTciLCJ2aXNpdG9yX2lkIjoiNTkyMDM4NTgwMzk2MDE1Mjk5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac88e7a38d2f3bc2caf2604fc27d0b174944b8617f930cca9e305d252ee95b8c7e
hovercard-subject-tagpull_request:337288511
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30281/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9039587f361fab9b757e5bf0c23add8029c189bedfb02ef3893e6cf21b776b2/nodejs/node/pull/30281
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9039587f361fab9b757e5bf0c23add8029c189bedfb02ef3893e6cf21b776b2/nodejs/node/pull/30281
og:image:alturl: replace var with let and const in lib/url.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamexefimx
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30281#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30281
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30281
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30281
Reloadhttps://github.com/nodejs/node/pull/30281
Reloadhttps://github.com/nodejs/node/pull/30281
Please reload this pagehttps://github.com/nodejs/node/pull/30281
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30281
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
xefimxhttps://github.com/xefimx
nodejs:masterhttps://github.com/nodejs/node/tree/master
xefimx:url-var-fixhttps://github.com/xefimx/node/tree/url-var-fix
Conversationhttps://github.com/nodejs/node/pull/30281
Commits1 (1)https://github.com/nodejs/node/pull/30281/commits
Checkshttps://github.com/nodejs/node/pull/30281/checks
Files changedhttps://github.com/nodejs/node/pull/30281/files
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/pull/30281#top
xefimxhttps://github.com/xefimx
nodejs:masterhttps://github.com/nodejs/node/tree/master
xefimx:url-var-fixhttps://github.com/xefimx/node/tree/url-var-fix
https://github.com/xefimx
xefimxhttps://github.com/xefimx
Nov 6, 2019https://github.com/nodejs/node/pull/30281#issue-518384515
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/xefimx
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/pull/30281/commits/3469484ade1034de2d09ce9951d549faa512f013
3469484https://github.com/nodejs/node/pull/30281/commits/3469484ade1034de2d09ce9951d549faa512f013
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Nov 6, 2019https://github.com/nodejs/node/pull/30281#event-2774791725
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 6, 2019https://github.com/nodejs/node/pull/30281#event-2774915070
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 6, 2019 https://github.com/nodejs/node/pull/30281#pullrequestreview-312758105
View reviewed changes https://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 6, 2019 https://github.com/nodejs/node/pull/30281#pullrequestreview-312819251
View reviewed changes https://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013
lib/url.jshttps://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013#diff-3755baff71802c66753e9be67b9b7c0e219dd0b61fda072a0009f807a3ea2095
trivikrhttps://github.com/trivikr
Nov 6, 2019https://github.com/nodejs/node/pull/30281#discussion_r343380565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30281
lib/url.jshttps://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013#diff-3755baff71802c66753e9be67b9b7c0e219dd0b61fda072a0009f807a3ea2095
trivikrhttps://github.com/trivikr
Nov 6, 2019https://github.com/nodejs/node/pull/30281#discussion_r343382054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 12, 2019https://github.com/nodejs/node/pull/30281#issuecomment-552824178
@trivikrhttps://github.com/trivikr
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2019https://github.com/nodejs/node/pull/30281#issuecomment-552824598
https://ci.nodejs.org/job/node-test-pull-request/26515/https://ci.nodejs.org/job/node-test-pull-request/26515/
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 12, 2019https://github.com/nodejs/node/pull/30281#issuecomment-553070052
@trivikrhttps://github.com/trivikr
@gireeshpunathilhttps://github.com/gireeshpunathil
@xefimxhttps://github.com/xefimx
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 13, 2019 https://github.com/nodejs/node/pull/30281#ref-pullrequest-521665425
Change var declarations to let and const #30445 https://github.com/nodejs/node/pull/30445
Trotthttps://github.com/Trott
Nov 17, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-87cef76
https://github.com/xefimx
https://github.com/Trott
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/commit/87cef760006aa29a6ce372ada26bcbae477c55da
87cef76https://github.com/nodejs/node/commit/87cef760006aa29a6ce372ada26bcbae477c55da
#30281https://github.com/nodejs/node/pull/30281
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 17, 2019https://github.com/nodejs/node/pull/30281#issuecomment-554690690
87cef76https://github.com/nodejs/node/commit/87cef760006aa29a6ce372ada26bcbae477c55da
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 17, 2019https://github.com/nodejs/node/pull/30281#event-2805106232
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 17, 2019https://github.com/nodejs/node/pull/30281#issuecomment-554690699
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Nov 17, 2019 https://github.com/nodejs/node/pull/30281#ref-pullrequest-523927392
url: declare iterator inside loop #30509 https://github.com/nodejs/node/pull/30509
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-3b45f8f
https://github.com/xefimx
https://github.com/MylesBorins
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/commit/3b45f8fd9c2b7e8d8162fbb5cf7c978d9843f573
3b45f8fhttps://github.com/nodejs/node/commit/3b45f8fd9c2b7e8d8162fbb5cf7c978d9843f573
#30281https://github.com/nodejs/node/pull/30281
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30281#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-1413377
https://github.com/xefimx
https://github.com/targos
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/commit/1413377bd3bd1e8de1362748638726bced219403
1413377https://github.com/nodejs/node/commit/1413377bd3bd1e8de1362748638726bced219403
#30281https://github.com/nodejs/node/pull/30281
trivikrhttps://github.com/trivikr
Dec 7, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-92ee25c
https://github.com/trivikr
url: declare iterator inside loophttps://github.com/trivikr/node/commit/92ee25c11d63f8c3849a1fda7e80b39e35439ff1
92ee25chttps://github.com/trivikr/node/commit/92ee25c11d63f8c3849a1fda7e80b39e35439ff1
nodejs#30281 (comment)https://github.com/nodejs/node/pull/30281#discussion_r343380565
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30281#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
bmeckhttps://github.com/bmeck
Dec 11, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-9c32b24
https://github.com/trivikr
https://github.com/bfarias-godaddy
url: declare iterator inside loophttps://github.com/nodejs/node/commit/9c32b24b652725af6e5a65994e2e6ec57d999fa0
9c32b24https://github.com/nodejs/node/commit/9c32b24b652725af6e5a65994e2e6ec57d999fa0
#30281 (comment)https://github.com/nodejs/node/pull/30281#discussion_r343380565
#30509https://github.com/nodejs/node/pull/30509
MylesBorinshttps://github.com/MylesBorins
Dec 13, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-5ab3ca4
https://github.com/trivikr
https://github.com/MylesBorins
url: declare iterator inside loophttps://github.com/nodejs/node/commit/5ab3ca4f96ae43802e972b661bad4f47a1c4e9e4
5ab3ca4https://github.com/nodejs/node/commit/5ab3ca4f96ae43802e972b661bad4f47a1c4e9e4
#30281 (comment)https://github.com/nodejs/node/pull/30281#discussion_r343380565
#30509https://github.com/nodejs/node/pull/30509
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30281#ref-commit-f2f4529
https://github.com/xefimx
https://github.com/MylesBorins
url: replace var with let in lib/url.jshttps://github.com/nodejs/node/commit/f2f45297a084b77fab6d7eb32a8b99ddf1b9b171
f2f4529https://github.com/nodejs/node/commit/f2f45297a084b77fab6d7eb32a8b99ddf1b9b171
#30281https://github.com/nodejs/node/pull/30281
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30281#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
targoshttps://github.com/targos
Jan 14, 2020 https://github.com/nodejs/node/pull/30281#ref-commit-70dc7a2
https://github.com/trivikr
https://github.com/targos
url: declare iterator inside loophttps://github.com/nodejs/node/commit/70dc7a2672b2feee8ff8c740d64276f0da13c6b1
70dc7a2https://github.com/nodejs/node/commit/70dc7a2672b2feee8ff8c740d64276f0da13c6b1
#30281 (comment)https://github.com/nodejs/node/pull/30281#discussion_r343380565
#30509https://github.com/nodejs/node/pull/30509
BethGriggshttps://github.com/BethGriggs
Feb 6, 2020 https://github.com/nodejs/node/pull/30281#ref-commit-6d674d4
https://github.com/trivikr
https://github.com/BethGriggs
url: declare iterator inside loophttps://github.com/nodejs/node/commit/6d674d476e19dce6441cf794391c7a2d078c3047
6d674d4https://github.com/nodejs/node/commit/6d674d476e19dce6441cf794391c7a2d078c3047
#30281 (comment)https://github.com/nodejs/node/pull/30281#discussion_r343380565
#30509https://github.com/nodejs/node/pull/30509
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30281
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/30281/files/3469484ade1034de2d09ce9951d549faa512f013
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Please reload this pagehttps://github.com/nodejs/node/pull/30281
https://github.com/xefimx
https://github.com/gireeshpunathil
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com/Trott
https://github.com/BridgeAR
https://github.com/ChALkeR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.