René's URL Explorer Experiment


Title: module: empty object fix in InternalModuleReadJSON for #30245 by guybedford · Pull Request #30256 · nodejs/node · GitHub

Open Graph Title: module: empty object fix in InternalModuleReadJSON for #30245 by guybedford · Pull Request #30256 · nodejs/node

X Title: module: empty object fix in InternalModuleReadJSON for #30245 by guybedford · Pull Request #30256 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes the bug posted in #30245, where having a package.json with no "type" field would not apply the CommonJS default. The issue turned out to be that InternalModuleReadJSON applies ...

X Description: This fixes the bug posted in #30245, where having a package.json with no "type" field would not apply the CommonJS default. The issue turned out to be that InternalModuleReadJSON ...

Opengraph URL: https://github.com/nodejs/node/pull/30256

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb9bef47-3299-6c9a-2f42-464f9a923cb3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB334:20853D:4A826CC:66FCC7E:6A4F601C
html-safe-nonce9f4c0be62cf27fe86da4a08a158e3a39452021cc447b5884f55b1f7f94685cab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzM0OjIwODUzRDo0QTgyNkNDOjY2RkNDN0U6NkE0RjYwMUMiLCJ2aXNpdG9yX2lkIjoiOTA2MTAzNDMzMDgyMjc2MjUyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73da666f46dc1ced7fb5cb1a442225d1d9101ecd9a19481716b48fa35a51f066
hovercard-subject-tagpull_request:336548437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30256/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c9e1dcbddfdb8695d6a53fc2740de201bb56695674484ac9f56e26d5aeaedc48/nodejs/node/pull/30256
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c9e1dcbddfdb8695d6a53fc2740de201bb56695674484ac9f56e26d5aeaedc48/nodejs/node/pull/30256
og:image:altThis fixes the bug posted in #30245, where having a package.json with no "type" field would not apply the CommonJS default. The issue turned out to be that InternalModuleReadJSON applies ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/30256#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30256
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30256
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/30256
Reloadhttps://github.com/nodejs/node/pull/30256
Reloadhttps://github.com/nodejs/node/pull/30256
Please reload this pagehttps://github.com/nodejs/node/pull/30256
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/30256
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:pjson-filter-empty-type-bughttps://github.com/guybedford/node/tree/pjson-filter-empty-type-bug
Conversationhttps://github.com/nodejs/node/pull/30256
Commits5 (5)https://github.com/nodejs/node/pull/30256/commits
Checkshttps://github.com/nodejs/node/pull/30256/checks
Files changedhttps://github.com/nodejs/node/pull/30256/files
module: empty object fix in InternalModuleReadJSON for #30245https://github.com/nodejs/node/pull/30256#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:pjson-filter-empty-type-bughttps://github.com/guybedford/node/tree/pjson-filter-empty-type-bug
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issue-517487663
#30245https://github.com/nodejs/node/issues/30245
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
module: empty object fix in InternalModuleReadJSON forhttps://github.com/nodejs/node/pull/30256/commits/528cbb5ccd169abf8b206ea7695ed024d93fa3cd
nodejs#30245https://github.com/nodejs/node/issues/30245
528cbb5https://github.com/nodejs/node/pull/30256/commits/528cbb5ccd169abf8b206ea7695ed024d93fa3cd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 5, 2019https://github.com/nodejs/node/pull/30256#event-2769729384
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 5, 2019 https://github.com/nodejs/node/pull/30256#ref-issue-516972785
A package.json lacking a "type" field is not treated as if it contained "type": "commonjs" #30245 https://github.com/nodejs/node/issues/30245
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549616035
Please reload this pagehttps://github.com/nodejs/node/pull/30256
guybedfordhttps://github.com/guybedford
November 4, 2019 21:37https://github.com/nodejs/node/pull/30256#commits-pushed-67e1a5d
https://github.com/guybedford
fixup module binding testhttps://github.com/nodejs/node/pull/30256/commits/67e1a5d9345dd1b457a4e29e76c7d460b8261bbf
67e1a5dhttps://github.com/nodejs/node/pull/30256/commits/67e1a5d9345dd1b457a4e29e76c7d460b8261bbf
https://github.com/guybedford
fixup assertionhttps://github.com/nodejs/node/pull/30256/commits/cd1a6d4e28e88f3916901ee1f8f7ad4e76fac95e
cd1a6d4https://github.com/nodejs/node/pull/30256/commits/cd1a6d4e28e88f3916901ee1f8f7ad4e76fac95e
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549646347
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549647646
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
fixup empty object comparisonhttps://github.com/nodejs/node/pull/30256/commits/d334de0d022aa9a097ff1605b97d8be5e39a6351
d334de0https://github.com/nodejs/node/pull/30256/commits/d334de0d022aa9a097ff1605b97d8be5e39a6351
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549649543
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549649973
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 5, 2019https://github.com/nodejs/node/pull/30256#issuecomment-549650696
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
moar fixupshttps://github.com/nodejs/node/pull/30256/commits/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
7ec3143https://github.com/nodejs/node/pull/30256/commits/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 6, 2019 https://github.com/nodejs/node/pull/30256#pullrequestreview-312712885
View reviewed changes https://github.com/nodejs/node/pull/30256/files/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/30256#pullrequestreview-312712885
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 6, 2019https://github.com/nodejs/node/pull/30256#issuecomment-550511254
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 7, 2019https://github.com/nodejs/node/pull/30256#issuecomment-550557519
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/hybrist
hybristhttps://github.com/hybrist
Nov 7, 2019 https://github.com/nodejs/node/pull/30256#pullrequestreview-313481566
View reviewed changes https://github.com/nodejs/node/pull/30256/files/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 7, 2019https://github.com/nodejs/node/pull/30256#issuecomment-551210542
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://ci.nodejs.org/job/node-test-pull-request/26459/https://ci.nodejs.org/job/node-test-pull-request/26459/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/31070/https://ci.nodejs.org/job/node-test-commit-windows-fanned/31070/
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 7, 2019https://github.com/nodejs/node/pull/30256#event-2780857175
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 8, 2019https://github.com/nodejs/node/pull/30256#issuecomment-551384127
https://ci.nodejs.org/job/node-test-pull-request/26464/https://ci.nodejs.org/job/node-test-pull-request/26464/
Please reload this pagehttps://github.com/nodejs/node/pull/30256
Trotthttps://github.com/Trott
Nov 8, 2019 https://github.com/nodejs/node/pull/30256#ref-commit-1eee0b8
https://github.com/guybedford
https://github.com/Trott
module: fix for empty object in InternalModuleReadJSONhttps://github.com/nodejs/node/commit/1eee0b8bf8bba39b600fb16a9223e545e3bac2bc
1eee0b8https://github.com/nodejs/node/commit/1eee0b8bf8bba39b600fb16a9223e545e3bac2bc
#30245https://github.com/nodejs/node/issues/30245
#30256https://github.com/nodejs/node/pull/30256
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2019https://github.com/nodejs/node/pull/30256#issuecomment-551741288
1eee0b8https://github.com/nodejs/node/commit/1eee0b8bf8bba39b600fb16a9223e545e3bac2bc
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2019https://github.com/nodejs/node/pull/30256#event-2782789437
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2019 https://github.com/nodejs/node/pull/30256#ref-commit-caedcd9
https://github.com/guybedford
https://github.com/MylesBorins
module: fix for empty object in InternalModuleReadJSONhttps://github.com/nodejs/node/commit/caedcd9ef945a6b0e31cbd7489bb22c0f7b3a10b
caedcd9https://github.com/nodejs/node/commit/caedcd9ef945a6b0e31cbd7489bb22c0f7b3a10b
#30245https://github.com/nodejs/node/issues/30245
#30256https://github.com/nodejs/node/pull/30256
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 19, 2019 https://github.com/nodejs/node/pull/30256#ref-pullrequest-525166118
v13.2.0 proposal #30547 https://github.com/nodejs/node/pull/30547
targoshttps://github.com/targos
Dec 1, 2019 https://github.com/nodejs/node/pull/30256#ref-commit-ec227c9
https://github.com/guybedford
https://github.com/targos
module: fix for empty object in InternalModuleReadJSONhttps://github.com/nodejs/node/commit/ec227c99fcab8fb7842b13783ecded504fef6133
ec227c9https://github.com/nodejs/node/commit/ec227c99fcab8fb7842b13783ecded504fef6133
#30245https://github.com/nodejs/node/issues/30245
#30256https://github.com/nodejs/node/pull/30256
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 9, 2019 https://github.com/nodejs/node/pull/30256#ref-pullrequest-534888029
v12.13.2 proposal #30865 https://github.com/nodejs/node/pull/30865
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/30256#ref-commit-b141556
https://github.com/guybedford
https://github.com/MylesBorins
module: fix for empty object in InternalModuleReadJSONhttps://github.com/nodejs/node/commit/b1415564ea9d4006ab9b78ec23f7d23345dd306d
b141556https://github.com/nodejs/node/commit/b1415564ea9d4006ab9b78ec23f7d23345dd306d
#30245https://github.com/nodejs/node/issues/30245
#30256https://github.com/nodejs/node/pull/30256
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 23, 2019 https://github.com/nodejs/node/pull/30256#ref-pullrequest-541795773
v12.14.1 proposal #31069 https://github.com/nodejs/node/pull/31069
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30256
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/30256/files/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/30256/files/7ec31437297a6ab17ea8bfde66e7698bb93ad36e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/30256
https://github.com/guybedford
https://github.com/devsnek
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/MylesBorins
https://github.com/hybrist
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.