| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:85a5c855-a242-1fb1-ee3c-6e876ffae146 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBC4:A6D52:3EFF898:59422DC:6A4FAC42 |
| html-safe-nonce | 6a1c2bc97cb77b19db96a21f170db17da42fade5b2cdfb0168671ba1e080b7f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkM0OkE2RDUyOjNFRkY4OTg6NTk0MjJEQzo2QTRGQUM0MiIsInZpc2l0b3JfaWQiOiIxNjgxNDcwNzkwNDA1NDM0NDM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 554af9e3f1b247930ffd465d680f778acd5dfbc420e883a27ca49414a7f793ab |
| hovercard-subject-tag | pull_request:336139548 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/30246/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a723cb4186bb313bd34be90d3cb392c20e6b2c5b4f63c884a2858a5e1d7dceec/nodejs/node/pull/30246 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a723cb4186bb313bd34be90d3cb392c20e6b2c5b4f63c884a2858a5e1d7dceec/nodejs/node/pull/30246 |
| og:image:alt | Refs: nodejs/code-and-learn#97
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | peze |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/30246#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30246 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30246 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/30246 |
| Reload | https://github.com/nodejs/node/pull/30246 |
| Reload | https://github.com/nodejs/node/pull/30246 |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| peze | https://github.com/peze |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| peze:cluster-primordials | https://github.com/peze/node-1/tree/cluster-primordials |
| Conversation | https://github.com/nodejs/node/pull/30246 |
| Commits1 (1) | https://github.com/nodejs/node/pull/30246/commits |
| Checks | https://github.com/nodejs/node/pull/30246/checks |
| Files changed | https://github.com/nodejs/node/pull/30246/files |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/pull/30246#top |
| peze | https://github.com/peze |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| peze:cluster-primordials | https://github.com/peze/node-1/tree/cluster-primordials |
|
| https://github.com/peze |
| peze | https://github.com/peze |
| Nov 4, 2019 | https://github.com/nodejs/node/pull/30246#issue-516981103 |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
|
| https://github.com/peze |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/pull/30246/commits/b331d0f7bdb99a57949fb16568f301c225925e1b |
| b331d0f | https://github.com/nodejs/node/pull/30246/commits/b331d0f7bdb99a57949fb16568f301c225925e1b |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
cluster
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster |
| Nov 4, 2019 | https://github.com/nodejs/node/pull/30246#event-2766679218 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-310902168 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 4, 2019 | https://github.com/nodejs/node/pull/30246#event-2766724192 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 4, 2019 | https://github.com/nodejs/node/pull/30246#issuecomment-549244378 |
| https://ci.nodejs.org/job/node-test-pull-request/26308/ | https://ci.nodejs.org/job/node-test-pull-request/26308/ |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311031502 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| XadillaX | https://github.com/XadillaX |
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311031502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311041406 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 4, 2019 | https://github.com/nodejs/node/pull/30246#issuecomment-549335421 |
| https://ci.nodejs.org/job/node-test-pull-request/26321/ | https://ci.nodejs.org/job/node-test-pull-request/26321/ |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311043481 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311046878 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 4, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311114048 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 5, 2019
| https://github.com/nodejs/node/pull/30246#pullrequestreview-311558372 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
| ZYSzys | https://github.com/ZYSzys |
|
Nov 9, 2019
| https://github.com/nodejs/node/pull/30246#ref-commit-0356746 |
|
| https://github.com/peze |
|
| https://github.com/ZYSzys |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/commit/0356746f50189368172d389ea1b69d8876cf329b |
| 0356746 | https://github.com/nodejs/node/commit/0356746f50189368172d389ea1b69d8876cf329b |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| #30246 | https://github.com/nodejs/node/pull/30246 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Nov 9, 2019 | https://github.com/nodejs/node/pull/30246#issuecomment-552072203 |
| 0356746 | https://github.com/nodejs/node/commit/0356746f50189368172d389ea1b69d8876cf329b |
| https://www.nodetodo.org/next-steps/ | https://www.nodetodo.org/next-steps/ |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
| https://github.com/ZYSzys |
| ZYSzys | https://github.com/ZYSzys |
| Nov 9, 2019 | https://github.com/nodejs/node/pull/30246#event-2785117627 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2019
| https://github.com/nodejs/node/pull/30246#ref-commit-6bf0e40 |
|
| https://github.com/peze |
|
| https://github.com/MylesBorins |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/commit/6bf0e40badb802a82e99f4da36e4aec739691309 |
| 6bf0e40 | https://github.com/nodejs/node/commit/6bf0e40badb802a82e99f4da36e4aec739691309 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| #30246 | https://github.com/nodejs/node/pull/30246 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 19, 2019
| https://github.com/nodejs/node/pull/30246#ref-pullrequest-525166118 |
|
v13.2.0 proposal
#30547
| https://github.com/nodejs/node/pull/30547 |
| targos | https://github.com/targos |
|
Dec 1, 2019
| https://github.com/nodejs/node/pull/30246#ref-commit-5c72cc3 |
|
| https://github.com/peze |
|
| https://github.com/targos |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/commit/5c72cc30a82d59368b672cf754e431320cf204d6 |
| 5c72cc3 | https://github.com/nodejs/node/commit/5c72cc30a82d59368b672cf754e431320cf204d6 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| #30246 | https://github.com/nodejs/node/pull/30246 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2019
| https://github.com/nodejs/node/pull/30246#ref-pullrequest-534888029 |
|
v12.13.2 proposal
#30865
| https://github.com/nodejs/node/pull/30865 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 17, 2019
| https://github.com/nodejs/node/pull/30246#ref-commit-2938fe3 |
|
| https://github.com/peze |
|
| https://github.com/MylesBorins |
| cluster: destruct primordials in lib/internal/cluster/worker.js | https://github.com/nodejs/node/commit/2938fe31aee3a618e67fde1e022f8f7d8425c5d7 |
| 2938fe3 | https://github.com/nodejs/node/commit/2938fe31aee3a618e67fde1e022f8f7d8425c5d7 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| #30246 | https://github.com/nodejs/node/pull/30246 |
| nodejs/code-and-learn#97 | https://github.com/nodejs/code-and-learn/issues/97 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 23, 2019
| https://github.com/nodejs/node/pull/30246#ref-pullrequest-541795773 |
|
v12.14.1 proposal
#31069
| https://github.com/nodejs/node/pull/31069 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F30246 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/ZYSzys |
|
ZYSzys
| https://github.com/ZYSzys |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
| https://github.com/XadillaX |
|
XadillaX
| https://github.com/XadillaX |
|
| https://github.com/nodejs/node/pull/30246/files/b331d0f7bdb99a57949fb16568f301c225925e1b |
|
cluster
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Please reload this page | https://github.com/nodejs/node/pull/30246 |
|
| https://github.com/peze |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ZYSzys |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/XadillaX |
|
| https://github.com/gengjiawen |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |